Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/spec/src/ui/component-record-blocks.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const messagesOf = (result: { success: boolean; error?: { issues: { message: str
return result.error!.issues.map((i) => i.message).join('\n');
};

describe('ComponentPropsMap rows exist and are the exported schemas (#8744)', () => {
describe('ComponentPropsMap rows exist and are the exported schemas', () => {
it('dispatches all four previously-skipped types', () => {
expect(ComponentPropsMap['record:alert']).toBe(RecordAlertProps);
expect(ComponentPropsMap['record:quick_actions']).toBe(RecordQuickActionsProps);
Expand All @@ -56,7 +56,7 @@ describe('ComponentPropsMap rows exist and are the exported schemas (#8744)', ()
});
});

describe('ComponentPropsMap["record:alert"] (#8744)', () => {
describe('ComponentPropsMap["record:alert"]', () => {
// The card's own headline defect: a typo'd `severty` shipped as a silent
// no-op. With the row it is a prescriptive refusal that names the rename.
it('refuses the card\'s planted `severty` with the rename suggestion', () => {
Expand Down Expand Up @@ -164,7 +164,7 @@ describe('ComponentPropsMap["record:alert"] (#8744)', () => {
});
});

describe('ComponentPropsMap["record:quick_actions"] (#8744)', () => {
describe('ComponentPropsMap["record:quick_actions"]', () => {
it('accepts the showcase and sys_user bars byte-identically', () => {
for (const authored of [
// examples/app-showcase/src/ui/pages/task-detail.page.ts
Expand Down Expand Up @@ -247,7 +247,7 @@ describe('ComponentPropsMap["record:quick_actions"] (#8744)', () => {
});
});

describe('ComponentPropsMap["record:history"] (#8744)', () => {
describe('ComponentPropsMap["record:history"]', () => {
it('accepts the registration\'s three presentation keys byte-identically', () => {
const authored = { limit: 20, emptyText: 'No changes yet', unknownUserText: 'System' };
expect(RecordHistoryProps.parse(authored)).toEqual(authored);
Expand Down Expand Up @@ -352,7 +352,7 @@ describe('ComponentPropsMap["record:activity"] — the host feed slot is named,
});
});

describe('the `record:discussion` / `record:chatter` pair (#8744)', () => {
describe('the `record:discussion` / `record:chatter` pair — one shared row', () => {
it('judges both names with one accept face', () => {
const authored = { position: 'bottom', collapsible: false } as const;
const viaChatter = ComponentPropsMap['record:chatter'].safeParse(authored);
Expand All @@ -367,7 +367,7 @@ describe('the `record:discussion` / `record:chatter` pair (#8744)', () => {
expect(message).toContain('`dock`');
});

it("both names accept the renderer's position vocabulary and refuse a retired spelling with ONE prescription (#8762)", () => {
it("both names accept the renderer's position vocabulary and refuse a retired spelling with ONE prescription", () => {
for (const type of ['record:chatter', 'record:discussion'] as const) {
for (const position of ['bottom', 'right', 'left'] as const) {
expect(ComponentPropsMap[type].safeParse({ position }).success).toBe(true);
Expand Down
4 changes: 2 additions & 2 deletions packages/spec/src/ui/component-reference-rail.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ const messagesOf = (result: { success: boolean; error?: { issues: { message: str
return result.error!.issues.map((i) => i.message).join('\n');
};

describe('ComponentPropsMap["record:reference_rail"] (#8691)', () => {
it('exists, and is the exported schema (the row is what the #5068 gate dispatches on)', () => {
describe('ComponentPropsMap["record:reference_rail"]', () => {
it('exists, and is the exported schema (the row is what the props gate dispatches on)', () => {
expect(ComponentPropsMap['record:reference_rail']).toBe(RecordReferenceRailProps);
});

Expand Down
6 changes: 3 additions & 3 deletions packages/spec/src/ui/component-type-vocabulary.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe('KNOWN_COMPONENT_TYPES covers every declared face', () => {
* deliberate and has its own note in `component.zod.ts`, so a sweep that took
* it in by accident is caught here rather than in a rendered page.
*/
it('the three #18305 blocks are known through their rows; object-chart still is not', () => {
it('object-map / object-gantt / object-tree are known through their rows; object-chart still is not', () => {
for (const type of ['object-map', 'object-gantt', 'object-tree']) {
expect(Object.keys(ComponentPropsMap), type).toContain(type);
expect(isKnownComponentType(type), type).toBe(true);
Expand Down Expand Up @@ -121,7 +121,7 @@ describe('KNOWN_COMPONENT_TYPES covers every declared face', () => {
* refuses it is the schema door (`PageComponentSchema.type`), not this
* vocabulary — pinned in `component.test.ts`.
*/
it('user:profile is known through its kept row and refused by name at the parse (#14159)', () => {
it('user:profile is known through its kept row and refused by name at the parse', () => {
expect(PageComponentType.options).not.toContain('user:profile');
expect(hasReservedComponentNamespace('user:profile')).toBe(false);
expect(isKnownComponentType('user:profile')).toBe(true);
Expand All @@ -135,7 +135,7 @@ describe('KNOWN_COMPONENT_TYPES covers every declared face', () => {
* populates `ai:` — so the namespace list above is unchanged and the
* `component-type-unknown` rule keeps claiming `ai:`.
*/
it('ai:chat_window is known through its kept row, not a candidate, and `ai:` stays reserved (#21504)', () => {
it('ai:chat_window is known through its kept row, not a candidate, and `ai:` stays reserved', () => {
expect(PageComponentType.options).not.toContain('ai:chat_window');
expect(isKnownComponentType('ai:chat_window')).toBe(true);
expect(KNOWN_COMPONENT_TYPE_CANDIDATES).not.toContain('ai:chat_window');
Expand Down
Loading
Loading