Skip to content

docs(adr-0029): the OS_METADATA_WRITABLE anchor names the file that holds the one reader - #22442

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-22411-adr-0029-anchor
Oct 9, 2026
Merged

os-zhuang merged 1 commit into
mainfrom
claude/issue-22411-adr-0029-anchor

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Refs #22411

What

This is a path-only symbol-anchor correction in docs/adr/0029-kernel-object-ownership-and-platform-objects-decomposition.md (D9.6). Exactly one anchor changes:

  • from packages/metadata-protocol/src/protocol.ts#OS_METADATA_WRITABLE
  • to packages/metadata-protocol/src/sys-metadata-repository.ts#OS_METADATA_WRITABLE

The sentence and the rest of the ADR are unchanged.

Why

PR #22440 gives OS_METADATA_WRITABLE one reader. The protocol's envWritableTypes() now delegates to the repository's envWritableMetadataTypes(), so protocol.ts no longer spells the variable. On that PR's head the anchor stopped being found: Lint & Repo Gates, step "ADR symbol anchors resolve", reports [unresolved-symbol] docs/adr/0029-…md:605. The anchor now names the file that holds the reader. That file already carries the literal on main (readEnvWithDeprecation('OS_METADATA_WRITABLE', [])), so the anchor holds on main today and after PR #22440 lands. It is a separate PR because docs/adr/** is Tier H. PR #22440 and its branch are untouched.

Verification

Acceptance notes

  • The sentence this anchor sits in (D9.6) says the operator hatch "is the same one door as before, and it now has to stay open for the life of the customization". Since ADR-0131 D6, the hatch no longer opens an overlay write to an item a managed package ships. So the sentence may have become untrue, and that is not a pointer problem. Following the anchor gate's own rule ("Do not repair prose to clear this gate"), it is left as written and reported to the seat on the card. Who takes it up: nobody yet.

维护者速读(草稿)

改了什么:ADR-0029 里有一处指向代码的“锚点”,原来指向 protocol.ts,现在改为指向 sys-metadata-repository.ts。只改这一个文件路径,ADR 的正文论述一个字没动。

为什么改:PR #22440 把 OS_METADATA_WRITABLE 这个运维开关统一成只由一个地方读取(仓储层)。protocol.ts 里不再出现这个变量名,ADR 的锚点因此失效,门禁变红。锚点改为指向现在真正读取这个开关的文件。

风险与代价(含回滚):不影响任何运行时行为,也不发布任何包。回滚就是撤销这一行改动。注意:锚点只有在 PR #22440 合入后才必须改;在 main 上,新旧两个路径现在都能通过门禁。

席位意见:

你要做的:这是 Tier H 文件(docs/adr/**),需要您批准或亲手合入。建议与 PR #22440 同时或先于它合入,否则 PR #22440 的 Lint & Repo Gates 会一直红。另请留意上方 Acceptance notes:D9.6 那句关于运维开关的描述,在 ADR-0131 D6 之后可能已经不再成立,是否修订正文需要您另行决定。


Generated by Claude Code

…olds the one reader

The reader ADR-0029 D9.6 points at moved: the protocol's copy now delegates
to the repository's envWritableMetadataTypes(), so protocol.ts no longer
spells the variable and the symbol anchor stopped resolving. Path-only
correction; the sentence is unchanged.

Claude-Session: https://claude.ai/code/session_01Bw3y2DWhT9RPnrmDsNqEVG
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

维护者速读

domain:engine#2 · session_01Bw3y2DWhT9RPnrmDsNqEVG · 2026-10-09T08:34Z · 复核记录在 #22411 的 6077407029。

改了什么:ADR-0029 里有一处指向代码的锚点,改了它指向的文件路径。原来指向 protocol.ts,现在指向 sys-metadata-repository.ts。只改这一行,ADR 的正文论述一个字没动。

为什么改:PR #22440(#22411)把运维开关 OS_METADATA_WRITABLE 统一成只在一个地方读取,就是仓储层。11.0 已发布的移除记录里写明旧拼写 OBJECTSTACK_METADATA_WRITABLE 已移除,但当时漏改了协议层那一份读取,导致类型列表显示「可写」,保存却被拒。合并成一处读取之后,protocol.ts 里不再出现这个变量名,ADR 的锚点就找不到它,Lint & Repo Gates 因此变红。锚点改为指向现在真正读取这个开关的文件。

风险与代价(含回滚):不改任何运行时行为,也不发布任何包。新路径在 main 上现在就能解析,在 PR #22440 合入之后也能解析,开发 agent 两种情况都实测通过。回滚就是撤销这一行。

席位意见:建议批准。这是一处只改路径的锚点更正,不改变 ADR 的任何决定。它必须先于 PR #22440 合入,否则 #22440 的门禁会一直红,而 #22440 本身已经复核通过。另外,ADR-0029 D9.6 那句「运维开关要在定制的整个生命周期内保持打开」在 ADR-0131 D6 封印托管内容之后已经不成立。这一点不在本 PR 里修,已由 #15206 的 S7 承接(S7 本来就带着 ADR-0029 D9.6 与 ADR-0086 D1 的注记),到时同样要你批。

你要做的:用 os-zhuang 或 hotlong 对本 PR 提交一次 Approve(或亲手合入);批准之后由本席落地,再接着落地 #22440。

@os-zhuang
os-zhuang marked this pull request as ready for review October 9, 2026 08:40
@os-zhuang
os-zhuang enabled auto-merge October 9, 2026 08:40
@os-zhuang
os-zhuang added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit da159f7 Oct 9, 2026
44 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-22411-adr-0029-anchor branch October 9, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants