Repository navigation
docs(adr-0029): the OS_METADATA_WRITABLE anchor names the file that holds the one reader - #22442
Conversation
…olds the one reader The reader ADR-0029 D9.6 points at moved: the protocol's copy now delegates to the repository's envWritableMetadataTypes(), so protocol.ts no longer spells the variable and the symbol anchor stopped resolving. Path-only correction; the sentence is unchanged. Claude-Session: https://claude.ai/code/session_01Bw3y2DWhT9RPnrmDsNqEVG Co-authored-by: Claude <noreply@anthropic.com>
维护者速读
改了什么:ADR-0029 里有一处指向代码的锚点,改了它指向的文件路径。原来指向 为什么改:PR #22440(#22411)把运维开关 风险与代价(含回滚):不改任何运行时行为,也不发布任何包。新路径在 席位意见:建议批准。这是一处只改路径的锚点更正,不改变 ADR 的任何决定。它必须先于 PR #22440 合入,否则 #22440 的门禁会一直红,而 #22440 本身已经复核通过。另外,ADR-0029 D9.6 那句「运维开关要在定制的整个生命周期内保持打开」在 ADR-0131 D6 封印托管内容之后已经不成立。这一点不在本 PR 里修,已由 #15206 的 S7 承接(S7 本来就带着 ADR-0029 D9.6 与 ADR-0086 D1 的注记),到时同样要你批。 你要做的:用 |
Refs #22411
What
This is a path-only symbol-anchor correction in
docs/adr/0029-kernel-object-ownership-and-platform-objects-decomposition.md(D9.6). Exactly one anchor changes:packages/metadata-protocol/src/protocol.ts#OS_METADATA_WRITABLEpackages/metadata-protocol/src/sys-metadata-repository.ts#OS_METADATA_WRITABLEThe sentence and the rest of the ADR are unchanged.
Why
PR #22440 gives
OS_METADATA_WRITABLEone reader. The protocol'senvWritableTypes()now delegates to the repository'senvWritableMetadataTypes(), soprotocol.tsno longer spells the variable. On that PR's head the anchor stopped being found:Lint & Repo Gates, step "ADR symbol anchors resolve", reports[unresolved-symbol] docs/adr/0029-…md:605. The anchor now names the file that holds the reader. That file already carries the literal onmain(readEnvWithDeprecation('OS_METADATA_WRITABLE', [])), so the anchor holds onmaintoday and after PR #22440 lands. It is a separate PR becausedocs/adr/**is Tier H. PR #22440 and its branch are untouched.Verification
main081e6a0) gives exit 0 on all three of:node scripts/check-adr-symbol-anchors.mjs: 2232 anchors across 141 records;pnpm check:adr-anchors;pnpm check:nul-bytes.adbb0a550(git merge --no-commit --no-ff, aborted afterwards, never pushed).node scripts/check-adr-symbol-anchors.mjsexits 0 there.[unresolved-symbol] … protocol.ts#OS_METADATA_WRITABLEline, so the probe is able to fail.node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commandsderives 19 commands, and all 19 exit 0.check:doc-formula-expressionsfirst answered PREREQUISITE NOT MET (exit 3) and exits 0 after building@objectstack/formulaand@objectstack/lint.--ranreports 19 derived, 19 run, 0 NOT-MEASURED, 0 UNRUN.docs/adr/**publishes nothing.Acceptance notes
维护者速读(草稿)
改了什么:ADR-0029 里有一处指向代码的“锚点”,原来指向
protocol.ts,现在改为指向sys-metadata-repository.ts。只改这一个文件路径,ADR 的正文论述一个字没动。为什么改:PR #22440 把
OS_METADATA_WRITABLE这个运维开关统一成只由一个地方读取(仓储层)。protocol.ts里不再出现这个变量名,ADR 的锚点因此失效,门禁变红。锚点改为指向现在真正读取这个开关的文件。风险与代价(含回滚):不影响任何运行时行为,也不发布任何包。回滚就是撤销这一行改动。注意:锚点只有在 PR #22440 合入后才必须改;在
main上,新旧两个路径现在都能通过门禁。席位意见:
你要做的:这是 Tier H 文件(
docs/adr/**),需要您批准或亲手合入。建议与 PR #22440 同时或先于它合入,否则 PR #22440 的Lint & Repo Gates会一直红。另请留意上方 Acceptance notes:D9.6 那句关于运维开关的描述,在 ADR-0131 D6 之后可能已经不再成立,是否修订正文需要您另行决定。Generated by Claude Code