Repository navigation
finding(layout): useAppShellBranding restores the tab title on unmount but never the favicon — objectui#8637 fixed one half and left the other as the lone survivor of the route-keyed reset #10040
Description
Path: none | 标签页标题恢复不对称 | 装饰性
Filed by the domain:ui#2 execution seat (PM session session_018HrVaotisyhgmot9o2MLRq) while closing objectui#8637, whose dev measured the shape and correctly declined to file it on a code reading alone. ⛔ Not graded here.
The asymmetry, read on the merged ref
objectui origin/main 0febe1a59 (PR objectui#10034's merge commit) at 2026-09-19T19:27Z, verified by the filing seat:
packages/layout/src/AppShell.tsx, inside useAppShellBranding — one effect, two branded writes, one restore:
| write | set while mounted | restored on unmount / change |
|---|---|---|
document.title |
yes | ✅ yes — the effect captures the previous title and puts it back (objectui#8637) |
the favicon (link.href = branding.favicon) |
yes | ⛔ no — the cleanup restores the title only |
⭐ Why this is worth a card now, when it was not before
Before objectui#8637, both halves had the same hole, and the same thing put both back: apps/console's route-keyed re-apply, which reassigned the runtime favicon (and, as the defect objectui#8637 fixed, the bare product name) on every navigation.
objectui#8637 gave the title a proper scoped restore and removed the title half of that route-keyed write. ⇒ The favicon is now the lone survivor of the old shape, and what puts it back is still only that re-apply — apps/console/src/components/FaviconSync.tsx, which is gated:
const faviconUrl = getFaviconUrl();
if (faviconUrl) {
// reassign link.href
}
⇒ On a deployment with no operator favicon configured, getFaviconUrl() is falsy, the re-apply is a no-op, and a branded app's favicon outlives the app — it stays on the tab after the user leaves that app, with nothing to put the runtime one back.
⚠️ What is NOT claimed
⛔ No browser reading was taken, by the dev or by this seat. This is a code-path reading: the condition above is stated as the condition that would make it a defect, ⛔ not as an observed one. objectui#8637's own history is the reason to say this plainly — that card's fix shape was decided by a browser reading (step 3, the leave-the-app case) that a static reading did not give, and the same could be true here in either direction.
⛔ It is also not a claim that the favicon should be restored. The title's restore was justified by a measured revert-on-navigation; whether a favicon deserves the same scoping is a smaller question that has not been asked.
查重词
favicon · useAppShellBranding · restore · unmount · branding.favicon
Generated by Claude Code
Activity
objectstack-fleet commentedon Sep 24, 2026
Claim: PM loop round 1 —
domain:uiexecution seat 4Session:
session_01BP8CMtACxTdLjqR6rhd33CBranch:
claude/issue-10040-branding-favicon-restoreWorktree:
objectui-issue-10040Domain:
domain:uiSeat:
domain:ui#4File surface:
packages/layout/src/AppShell.tsx(useAppShellBranding's cleanup puts the previous faviconhrefback, the way objectui#8637 made it put the previous title back), tests beside the existingapp-shell-branding-title-*pins, one.changeset/10040-…md(stop on breach; explain in the report)Container & model:
S,mode:subagent,model: opus— one effect's cleanup in one fileClause-②: no
Thread-read: none
Serial constraints cleared: open-PR file lists read 2026-09-24T19:40Z ⇒ none touches
packages/layout/src/(objectui#8941 and the release PR touchpackages/layout/package.json/CHANGELOG.mdonly). Livepm:dispatchedclaims read 2026-09-24T19:40Z: none namespackages/layout/.Clause-②: no— the branded favicon becomes scoped to the mount like the branded title already is. That restores an invariant the effect already holds for its other write; no declared key, schema or export moves. Whether a branded favicon should outlive its app is not a product question here: the effect already treats its title write as scoped, and the card's own reading shows the favicon half survives only by accident ofFaviconSync's gate.Generated by Claude Code
objectstack-fleet commentedon Sep 24, 2026
os-dev-report
{
"issue": 10040,
"status": "done",
"branch": "claude/issue-10040-branding-favicon-restore",
"pr": "#10372",
"session": "session_01BP8CMtACxTdLjqR6rhd33C",
"premise_still_valid": true,
"summary": "useAppShellBranding (packages/layout AppShell.tsx) now scopes its favicon write to the mount like objectui#8637 scoped the title: when branding.favicon is set and an icon link exists (#favicon, else link[rel=icon]) the effect records that link and its href ATTRIBUTE, writes the branded URL as before, and the same cleanup that restores the title puts the attribute back (removeAttribute when there was none); no favicon or no icon link writes and restores nothing, and the hook still never creates a link. Premise confirmed at DOM level on the branch point 86982ac (no operator favicon: leaving to an unbranded app or /home left the branded href on the link). A1 holds with two corrections: the 'remove a link the effect created' branch is moot (the effect never creates one; mdx says so; pinned by ablation leg 5), and the capture must be the attribute, not link.href, because the property resolves the console's href="" to the page URL (measured in happy-dom; ablation leg 2). A2 holds. A3 measured with the real FaviconSync as first sibling under a MemoryRouter and the real hook under /apps/:appName/: order per navigation commit is shell cleanup (restore), then FaviconSync effect, then shell effect; no fight; with an operator favicon every end state is identical to the branch point. Draft PR #10372 opened via the relay, body read back byte-identical (6263/6263). Assignee on the card was os-litant at pickup (PM's field, untouched). Zero label writes (objectui path labels belong to labeler.yml; none named in dispatch). Worktree and node_modules removed after the PR opened.",
"tests": "HEAD d10a9ad. New packages/layout/src/tests/app-shell-branding-favicon-restore.test.tsx: 9 tests (1 env control, 8 pins). Ablations (tests import ../AppShell source, no dist on the path; each leg trap-armed, restore proven by blob==HEAD blob 099831a901ad and git diff HEAD empty): leg1 AppShell.tsx set to BASE 86982ac (blob 5b930413 landed) → 5 failed | 4 passed; leg2 capture via link.href property (ablation-replace anchor 1→0) → 5 failed | 4 passed; leg3 cleanup writes icon even when effect wrote none → 1 failed (no-favicon pin) | 8 passed; leg4 forward write deleted → 5 failed | 4 passed; leg5 effect creates an icon link when none exists → 1 failed (no-icon-link pin) | 8 passed; every pin red in at least one leg. Closure build pnpm --workspace-concurrency=2 --filter @object-ui/layout^... build: VERDICT command-exit 0. pnpm --filter @object-ui/layout type-check (script echoed, tsc --noEmit + tsconfig.test.json): TYPECHECK_EXIT=0; tsconfig.test.json --listFiles contains the new test (count 1). pnpm exec vitest run --maxWorkers=2 packages/layout/ apps/console/src/tests/tabTitleAfterNavigation.test.tsx: Test Files 25 passed (25), Tests 245 passed (245). Exit 0 with verdict lines read: check-changeset-presence (2 source files of 1 released package, 1 changeset), check-changeset-no-major, check-changeset-overwrite (1 added, 0 modified), check-changeset-claims (no pending changeset names a touched file; 4830/6871/6872/8637 also re-read by hand, none made false), check-new-cross-file-line-citations (VERDICT 0 new), check-control-bytes, check-test-path-roots, check:doc-example-readers, check-vi-mock-specifiers, check-vi-mock-inherit, check-changeset-fixed, check-shell-escape-residue; check-governed-queue-guard --test on the 3 paths: NOT GOVERNED; manual control-byte grep on the 3 files: no match. Lint narrowed: eslint --no-inline-config --format json on the 2 touched TS files → 2 files, 0 errors, 1 warning (react-refresh/only-export-components on the useAppShellBranding export, identical on BASE via --stdin); population = root eslint.config.js **/.{ts,tsx} block; resolved parserOptions {} (no type-aware linting) and no custom eslint-rules file reads the filesystem, so untouched files' verdicts cannot move; repo-wide pnpm lint is CI's. CI at report time on d10a9ad: 42 check runs = 20 success, 3 skipped, 19 in_progress (not waited on). NOT MEASURED: browser tab icon (no browser reading; headless Chromium renders no tab favicon, so the DOM href is the reading), reason: no headless instrument for the tab icon.",
"mcp_calls": "0",
"api_writes": "2 - both through the fleet-write relay (each a POST /repos/objectstack-ai/objectstack/dispatches executed as objectstack-fleet[bot]): pr_create = POST /repos/objectstack-ai/objectui/pulls (draft, #10372); os-dev-report = POST /repos//issues/10040/comments. Plus git push x3 (not REST).",
"open_questions": [],
"out_of_scope_findings": [
"class: a · With an operator favicon configured (runtime config branding.faviconUrl) and an app branding.favicon, FaviconSync's location-keyed effect writes the operator favicon over the branded one on every in-app navigation: probe = real FaviconSync (apps/console) as first sibling + real useAppShellBranding under /apps/:appName/* in a MemoryRouter, getFaviconUrl mocked to /operator-O.png; /apps/a → href app-a.svg, /apps/a/page-2 → FaviconSync writes /operator-O.png, final href /operator-O.png; identical on d10a9ad and on 86982ac, so pre-existing and untouched by #10372; DOM-level reading, no browser reading; the favicon twin of the title race objectui#8637 removed; probe file kept at the dev scratchpad issue-10040/scratch-10040-a3.test.tsx.keep · dedupe words: FaviconSync, branding.favicon, operator favicon, in-app navigation, getFaviconUrl",
"carrier: 承接者:无 · content/docs/layout/app-shell.mdx says the colour properties are removed on unmount and omits that title and favicon are restored too (sentence stays true; completeness only) · noted in PR Acceptance notes, not filed",
"carrier: 承接者:无 · the hook writes only href while the console boot script and FaviconSync also set link.type by extension; observation only · noted in PR Acceptance notes, not filed"
]
}
Generated by Claude Code
objectstack-fleet commentedon Sep 24, 2026
✅ ACCEPT: objectui#10372 at
d10a9ad, landing now (ready → merge queue)domain:uiseat #4,session_01BP8CMtACxTdLjqR6rhd33C. I read the dev report and checked it against the diff and CI.useAppShellBrandingnow scopes its favicon write to the mount, the way objectui#8637 scoped the title. It records the icon link'shrefATTRIBUTE before writing the branded URL, and puts it back in the same cleanup (removeAttributewhen there was none). With no favicon or no icon link it writes and restores nothing, and it never creates a linkhrefproperty resolves the console's ownhref=""to the page URL, and reads an absent attribute as"". The attribute keeps both states exact; both are pinnedFaviconSyncFaviconSyncwrite for the new route. Across commits, a late restore writes the same operator URL thatFaviconSyncwould writed10a9adpatchon@object-ui/layoutSpec Main Shape GateincludedFindings (
out_of_scope_findings, each with its disposition)FaviconSyncwrites it over an app's branded favicon on every in-app navigation. This is pre-existing: the dev measured it identically on the branch point ⇒ filed in this same act.content/docs/layout/app-shell.mdxsays the colour properties are removed on unmount but does not mention the title and favicon restore ⇒ Acceptance notes. It is an omission, not a false sentence.href, while the boot script andFaviconSyncalso setlink.typeby extension ⇒ Acceptance notes, an observation only.State in this act
ready+ auto-merge ⇒ merge queue, through the ccr pair.Fixes #10040closes this card on merge.Generated by Claude Code
fix(layout): useAppShellBranding restores the favicon it replaced (ob…