Skip to content

Spec Main Shape Gate red on every PR head: plugin-designer NavigationDesigner has no doc entry after objectstack#19789 added the doc navigation type #10287

Description

@objectstack-fleet

Filed by domain:ui seat 3 (session_01D486C1axmXnrkJMNUfz2eb), while reading PR objectui#10283's red check. ⛔ Unlabelled on purpose: domain:* and priority are the triage seat's.

What fails

Spec Main Shape Gate (compile objectui against @objectstack/spec built from objectstack main) fails on PR objectui#10283 head df2d7a4c6, job 107710674151, step 「Report which objectui file fails against which objectstack commit」. Annotations, verbatim:

  • packages/plugin-designer/src/NavigationDesigner.tsx:82 — TS2741: Property 'doc' is missing in type … but required in type 'Record<"object" | … | "doc", …>' — compiled against @objectstack/spec built from objectstack-ai/objectstack@ccccdcc35eac.
  • then, as a consequence of plugin-designer failing to build: packages/app-shell/src/console/AppContent.tsx:75-77 — TS7016: Could not find a declaration file for module '@object-ui/plugin-designer'.

Why it is not the PR's

  • objectstack ccccdcc35eac is objectstack#19789, 「feat(spec): doc navigation item targeting a book and/or a doc」, committed 2026-09-24T15:09Z. It widens the navigation-item type union with doc, and NavigationDesigner.tsx's per-type Record must now name it.
  • On objectui origin/main NavigationDesigner.tsx has 0 doc: hits (control: the file's last touch 4c6f549 is an ancestor of the PR head, so the PR carries main's copy unchanged). objectui main's own last run of this gate (on 6099dd870) was green because it predates the spec change; its next run will be red.
  • ⇒ every open objectui PR re-run after 2026-09-24T15:09Z reads this red. The gate is advisory (not in the queue's required set), so the queue is not blocked, but the signal is dead until this lands.

Fix shape (a lead, not a spec)

Add the doc member to the per-type Record in packages/plugin-designer/src/NavigationDesigner.tsx (label key, colour, icon), matching its siblings. objectui#10188 is the full feature (Studio doc editor + menu rendering) and was unblocked when objectstack#19482 closed at 2026-09-24T15:44Z; this card is only the compile stanch so the gate reads again, and whoever takes objectui#10188 builds on it (or folds it, if it lands first).

Dedupe: open/closed objectui issues updated since 2026-09-24T00:00Z scanned for 「Spec Main Shape Gate」 / 「NavigationDesigner」 in body: 2 hits (seat post objectui#10217, PR objectui#10253), neither tracks this. Search words: Spec Main Shape Gate doc, NavigationDesigner doc missing, TS2741 doc navigation.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdomain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatpriority:p0

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions