Repository navigation
finding(plugin-view): an authored event-name onChange on filter-ui / sort-ui (and onViewChange on view-switcher) crashes with "onChange is not a function" through SchemaRenderer #10616
Description
Activity
Path: business objects, records and views | records-forms.adhoc-filter-sort-builder | P2
Triage: first grade —
bug·priority:p2·domain:ui·area:records·pm:queue(findingremoved — graded)Triage: lands in
packages/plugin-view(FilterUI.notifyChange,SortUI,ViewSwitcher:onChange?.()/onViewChange?.()is called on the authored string thatSchemaRendererspreads into the same-named callback prop) ⇒domain:ui; rationale: the declared, documented authoring form (objectui#6124: an event NAME) throwsTypeErroron interaction on three components, and the window event never fires. The pending changeset6124-view-handler-keys-are-event-names.mdpublishes it as a working example. A documented form that crashes, with a release deadline ⇒ p2.Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) ·
session_01CRZSc7dU8oDStbTbSwhuZe· 2026-09-25T13:42Z. ⛔ Not a claim, ⛔ not a dispatch. Read: this card and its full thread, and objectuiorigin/main.Execution note: fix at the boundary where the string meets the callback slot (call the prop only when it is a function; dispatch the named event when it is a string), and keep the host function channel working. Pin through the real
SchemaRenderer: the objectui#6124 pins mock it, which is why they stay green. Land before the next release, or scope the pending changeset's example in the same PR.Claim: PM loop round 6 —
domain:uiexecution seat 2
Session:session_014mXUNuFomfj24w7s1pZzhN
Branch:claude/issue-10616-view-handler-event-names
Worktree:objectui-issue-10616
Domain:domain:ui
Seat:domain:ui#2
File surface:packages/plugin-view/src/FilterUI.tsx,SortUI.tsx,ViewSwitcher.tsx(the boundary where the authored event-name string meets the callback prop), tests through the realSchemaRenderer, the pending.changeset/6124-view-handler-keys-are-event-names.mdonly if its example must be scoped, and one changeset ('@object-ui/plugin-view': patch). Stop on breach and explain it in the report
Container & model:S,mode:subagent,model: opus—dispatch-gates --tier: 「no path-derived mandate … floor sonnet · default opus · ceiling fable」; executes triage5833415851(bug · p2: fix at the boundary where the string meets the callback slot, calling the prop only when it is a function and dispatching the named event when it is a string, keeping the host function channel working; pin through the realSchemaRenderer; land before the next release, or scope the pending changeset's example in the same PR)
Clause-②: no
Thread-read: 5833415851
Serial constraints cleared: open-PR file lists read 2026-09-25T13:48Z. No open PR touches the three components. The only open PR naming6124-view-handler-keys-are-event-names.mdis the release PR objectui#5400, which consumes pending changesets at release.check-governed-queue-guard.mjs --test: NOT GOVERNED.Clause-②: no— three components begin honouring the declared event-name contract (objectui#6124) through the renderer; no export, schema or accept set moves.
Generated by Claude Code
os-dev-report
{
"issue": 10616,
"status": "done",
"branch": "claude/issue-10616-view-handler-event-names",
"pr": "#10646",
"session": "session_014mXUNuFomfj24w7s1pZzhN (mode:subagent, so this is the dispatching seat's id; the container's CLAUDE_CODE_REMOTE_SESSION_ID is cse_014mXUNuFomfj24w7s1pZzhN)",
"premise_still_valid": true,
"summary": "H1 confirmed: through the real SchemaRenderer and registry with no host prop, the authored string reached the same-named callback prop, and each control threwTypeError: onChange is not a function(onViewChangefor view-switcher). The window event never fired because the throw came first. The host-function control passed. Fix (H2): a new plugin-view helpernotifyViewHandlerChannels(packages/plugin-view/src/viewHandlerChannels.ts), called by thenotifyChangeof FilterUI, SortUI and ViewSwitcher. It calls the prop only whentypeofsays function. It then dispatchesnew CustomEvent(schema.KEY, { detail }), reading the name fromschema, never from the prop. The SchemaRenderer spread and the public types are unchanged. Order is the same as before: the host function first, then the window event. With both present, both are delivered: the host function holds the prop slot because SchemaRenderer spreads the host's props last, and the authored name stays onschema. H3: no other hit in plugin-view or views.zod.ts. H5: every sentence of the pending objectui#6124 changeset is true at this change, so it is unchanged (md5 ccd92197c632d2b200478176ac6d1a95 at BASE and HEAD). The docs rowsonChange?: stringandonViewChange?: stringare true, and the README names neither key. Draft PR #10646 is open withFixes #10616andClause-②: no. The PR-assignee write was refused by the permission classifier (see deviations), so the PR has no assignee yet. The card assigneeos-elon-muskwas not touched.",
"tests": "Everything below ran at HEAD 528b56d, which is the PR head; BASE eca2760. (1) One run under os-verify-lock,VERDICT command-exit 0 · held the lock 295s, script issue-10616/verify-10616.sh. HEAD:pnpm exec vitest runon the new pin handlerEventNameThroughRenderer-10616.test.tsx plus the objectui#6124 pin ⇒Tests 14 passed (14). BASE (the three components checked out at BASE, pins from HEAD) ⇒Tests 3 failed | 11 passed (14): each authored-string leg fails with reportedTypeError: onChange is not a function(filter-ui, sort-ui) andTypeError: onViewChange is not a function(view-switcher); the 3 host-function controls and all 8 objectui#6124 tests pass. Per-component ablation (one file at BASE) ⇒ FilterUI1 failed | 5 passed (6), filter authored leg only; SortUI1 failed | 5 passed (6), sort authored leg only; ViewSwitcher1 failed | 5 passed (6), view authored leg only. Every mutation was proven on disk before its run (notifyViewHandlerChannelscount 0 and bareonChange?.(/onViewChange?.(count 1, per file). Every restore ran from anEXIT INT TERMtrap and was proven withRESTORE OK: 3 blobs equal HEAD, git diff HEAD empty. No build sits between mutation and run: the tests resolve source through the vitest aliases in vitest.config.mts. (2)pnpm exec vitest run packages/plugin-view/⇒Test Files 50 passed (50),Tests 483 passed (483). (3)turbo run build --filter='@object-ui/plugin-view^...' --concurrency=2⇒Tasks: 15 successful, 15 total, thenpnpm --filter @object-ui/plugin-view type-check(tsc --noEmit && tsc -p tsconfig.test.json) ⇒ exit 0.tsc -p tsconfig.test.json --listFilesOnlylists the new pin, the objectui#6124 pin and viewHandlerChannels.ts (45 files under plugin-view src/tests). (4) ESLint, narrowed and declared:eslint --no-inline-config --format jsonon the 6 touched TS files ⇒ 6 files, 0 errors, 11 warnings, all on lines this diff does not touch; lint sets no --max-warnings. Population: the eslint.config.jsfiles: ['**/*.{ts,tsx}']block, none of the 6 ignored. Invariance: 0parserOptions/projectServicein eslint.config.js, so linting is not type-aware, and 0 filesystem reads (readFileSync/existsSync/readdirSync/statSync) in eslint-rules/*.js; control: 9 of 9 rule files matchcreate. The repo-widepnpm lintis left to CI. (5) Unlocked source gates, all exit 0: check-changeset-presence (6 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)); check:new-line-citations (VERDICT new-cross-file-line-citations: 0 new citation(s)); check:control-bytes (OK (scanned 8752 tracked text file(s)); check-changeset-no-major; check-changeset-overwrite (1 changeset(s) added, 0 modified, 0 deleted); check-changeset-fixed; check-changeset-claims (report-only; it flags the objectui#6124 changeset's last paragraph because it names the 6124 test file this diff edits. Read: only the header comment changed and the pin still holds both halves, so the paragraph stays true); check:handler-key-reads (49 judged ... every judged read is a declared member); check:unreferenced-sources; check:esm-specifiers; check:phantom-deps; check:self-import; check-vi-mock-override-shape; check-vi-mock-specifiers; check-vi-mock-inherit; check-test-path-roots. No doc or readme gate is reached, because no content/ or README file changed. check-governed-queue-guard --test on the 7 paths ⇒NOT GOVERNED.git merge-tree --write-tree HEAD origin/mainat f99f9cd ⇒ exit 0; main has not changed plugin-view or the 6124 changeset since BASE, so no merge was needed. CI: not waited on; in_progress.",
"mcp_calls": "0 — no MCP GitHub tool called",
"api_writes": "2 — (1) POST /repos/objectstack-ai/objectstack/dispatches, the fleet-write relay carrying one pr_create op; the executor ran POST /repos/objectstack-ai/objectui/pulls (draft) ⇒ #10646; request fw-20260925T141742Z-155f21, run 36146519810 conclusion success. (2) This os-dev-report comment, POST /repos//issues/10616/comments, through post-stamped.mjs. label-write --assign was refused by the classifier before any request, so it made 0 writes. git push is not counted: 2 pushes (the empty-branch probe, then 528b56d).",
"open_questions": [],
"deviations": [
"PR assignee NOT set.node scripts/pm/label-write.mjs --repo objectstack-ai/objectui --issue 10646 --assign os-elon-muskwas refused by the Claude Code auto-mode permission classifier:Permission for this action was denied by the Claude Code auto mode classifier. Reason: [External System Writes]. Per the order it was not retried and not routed another way, so the seat needs to set the PR #10646 assignee to os-elon-musk.",
"The verify lock's first acquisition returnedVERDICT queue-timeout (exit 99) · never acquired · waited 540s. The place was kept under slot issue-10616, and the second acquisition ran the whole script. A third locked call (tsc --listFiles) sat at queue position 5/5, so I stopped it by its own PID (2301). I replaced it with the unlockedtsc -p tsconfig.test.json --listFilesOnly, which does module resolution only and no type-check. The type-check itself had already run under the lock.",
"The objectui#6124 pin file changed in its header comment only. Its three cross-file line addresses pointed at lines this diff moves, so they are now symbol citations (AGENTS.md #11), and the header gains a note that the file mocks SchemaRenderer plus a pointer to the new pin. No assertion changed.",
"Commit trailers are model-free (Co-Authored-By: Claude, plusClaude-Session), following the role file. The harness attribution reminder named a model; the role file takes precedence."
],
"files_changed": [
"packages/plugin-view/src/viewHandlerChannels.ts (new)",
"packages/plugin-view/src/FilterUI.tsx",
"packages/plugin-view/src/SortUI.tsx",
"packages/plugin-view/src/ViewSwitcher.tsx",
"packages/plugin-view/src/tests/handlerEventNameThroughRenderer-10616.test.tsx (new)",
"packages/plugin-view/src/tests/handlerEventNameLiveness.6124.test.tsx (header comment only)",
".changeset/10616-view-handler-event-names-through-renderer.md (new, '@object-ui/plugin-view': patch)"
],
"out_of_scope_findings": [
"carrier: 承接者:无 · noted in PR #10646## Acceptance notes, not filed · In theViewSwitcherSchematable of content/docs/api/schema-reference.md, theonViewChangerow reads 'Expression or callback invoked on view change.' That contradicts the declared contract in views.zod.ts (ViewSwitcherSchema.onViewChangedescribe: 'Event name dispatched on window when the view changes (detail: { view }) — an event NAME, not a callback or a handler expression'). The row was false at BASE and at HEAD. It is outside the claimed file surface. It is a candidate for class b (Seam: spec:ViewSwitcherSchema.onViewChange → renderer:ViewSwitcher), but reach was not measured at a public door (docs prose only), so it is not submitted for filing · dedupe words:Expression or callback invoked on view change· schema-reference ViewSwitcherSchema onViewChange · event name docs row 6124"
]
}
Generated by Claude Code
✅ ACCEPT: objectui#10646 at
19efdc4; ready and auto-merge follow this ACCEPTdomain:uiseat #2,session_014mXUNuFomfj24w7s1pZzhN. I checked this against the diff and CI, not against the report's own account. Claim5833485343. It executes triage5833415851.Implemented-by: claude/issue-10616-view-handler-event-names Reviewed-by: session_014mXUNuFomfj24w7s1pZzhNitem reading the change filter-ui,sort-uiandview-switcherread their event-name key (onChange,onViewChange) through one plugin-view helper. The helper calls the prop only when it is a function, then dispatchesnew CustomEvent(schema.KEY, { detail })onwindow, with the name taken fromschema. The authored string no longer reaches a call, so the first interaction no longer throwsTypeError: onChange is not a functionboth channels SchemaRendererspreads the host's props last, so a host function keeps the prop slot while the authored name stays onschema. Host first, then event, as on basepins handlerEventNameThroughRenderer-10616.test.tsxruns through the realSchemaRendererand registry with no mock. The round-1 reviewer re-ran it: head 14/14; base 3 failed (the threeTypeErrors); a per-component ablation turns exactly its own authored leg red. The objectui#6124 pin changes in comments onlyClause-②: no/ semverpatchon@object-ui/plugin-view. The helper is not exported from the package entry; no export, schema or accept set movespublished text round 1 found one overstated changeset sentence ("passes every node key", while SchemaRendererstrips a metadata set). Round 2 changed that one sentence to "passes these keys through". The frontmatter md5 is4d3ab4fd127d2f0feaabd7840d888656at both heads. The pending objectui#6124 changeset (md5ccd92197c632d2b200478176ac6d1a95, unchanged) is now true through the rendererreviews round 1 PASS at 528b56dand round 2 PASS at19efdc4, both atCONTRACT_REVIEW_TIER; the round-2 record is posted with this landing. The seat read both transcripts: every turn ran at tierserial git merge-treeagainst mainf99f9cde7: clean. No open PR touches these seven filesgoverned NOT GOVERNED CI round-1 head: 40 success, 3 skipped, none red, Test (shard 2/8)green. Round-2 head: in progress with nothing red at the reviewer's last poll; auto-merge waits for itclosing keywords Fixes #10616onlyFindings, each with its disposition
- Dev and round-1 reviewer:
content/docs/api/schema-reference.md'sViewSwitcherSchema.onViewChangerow reads "Expression or callback invoked on view change", which contradicts the declared event-name contract. It predates this card (an objectui#6124 leftover) ⇒ card owed; the seat files it, folded with the next item. - Round-1 reviewer: the
packages/types/src/views.tsJSDoc for all three keys cites "new CustomEvent(schema.KEY, …)read atplugin-view/src/ViewSwitcher.tsx(FilterUI, SortUI)". After this change that expression lives only inviewHandlerChannels.ts⇒ folded into the same docs card.
Deviations recorded
- PR assignee not set. The dev's
label-write --assignwas refused by the permission classifier. The seat does not re-issue a refused write; it is surfaced to the maintainer.
State
In one stroke:
readyand auto-merge (squash), through the relay opspr_ready+automerge_enable. The PR body stands as the dev wrote it: it says "every non-metadata node key", which is true.
Generated by Claude Code
- Dev and round-1 reviewer:
- added a commit that references this issue
on Sep 28, 2026
Filing-gate category: ① a product defect with a named site and a reproduction (class a). reach: a public entry measured once with a wrong result. The documented example (
.changeset/6124-view-handler-keys-are-event-names.md, pending, andfilter-ui.mdx'sonChange?: string) throws through the realSchemaRenderer. Reader: triage first (route and grade), then thedomain:uiexecution seat that claims it.Filed by the
domain:uiexecution seat (seat 1, sessionsession_01BA3nKVUwKQJf8DBxrSVtNC) from theos-dev-reportof objectui#9616 (a side reading of its runtime probe). ⛔ Not graded and not routed.The declared contract
objectui#6124 declared the three view handler keys as EVENT NAMES:
FilterUISchema.onChange,SortUISchema.onChangeandViewSwitcherSchema.onViewChangearez.string(), 「Event name dispatched on window when the filters change (detail: { values }) — an event NAME, not a callback or a handler expression」 (packages/types/src/zod/views.zod.ts). The pending changeset6124-view-handler-keys-are-event-names.mdpublishes the example{ "type": "sort-ui", "fields": [{ "field": "name" }], "onChange": "myapp:sort-changed" }.What happens
SchemaRendererspreads every non-metadata key of the node as a React prop, so the authored STRING lands in the component's same-named React callback prop.FilterUI.notifyChange(packages/plugin-view/src/FilterUI.tsx) callsonChange?.(nextValues)first.?.does not guard a string, so it throwsTypeError: onChange is not a function, and the windowCustomEventafter it is never dispatched.sort-ui(onChange) andview-switcher(onViewChange) have the same shape.Reproduction (the dev's throwaway probe, deleted, ⛔ not re-run by the seat)
Real
SchemaRendererand registry, no host prop:filter-ui⇒ errors['TypeError: onChange is not a function'], window events[];sort-ui⇒ the same;view-switcher⇒['TypeError: onViewChange is not a function'], events[].Control: with a host FUNCTION prop passed to
SchemaRenderer, both channels fire. The objectui#6124 pins (packages/plugin-view/src/__tests__/handlerEventNameLiveness.6124.test.tsx) render the components directly and mockSchemaRenderer, so they stay green over the defect.Grade notes (for triage, not a grade)
Dedupe
REST page walk over the 1000 most recently updated objectui items (oldest
updated_at2026-09-18, open and closed).onChange is not a function⇒ 0,handlerEventNameLiveness⇒ 0,event.name.{0,80}(CustomEvent|SchemaRenderer)⇒ 0,onViewChange⇒ 3 (objectui#8235 / PR objectui#10515, which annotate doc rows the zod twin refuses, and objectui#9944, unrelated). Must-hit control6124⇒ 10. No card carries this.Dedupe words:
onChange is not a function·event name CustomEvent SchemaRenderer spread·onViewChange·handlerEventNameLiveness 6124Generated by Claude Code