Report and dashboard-widget pickers show bare member names: the dataset member label and the dataset description never reach them (sub-issue of objectstack#20282) #11161

Activity

1. objectstack-fleet commented on Sep 30, 2026

   

   objectstack-fleetbot

   on Sep 30, 2026

   ContributorAuthor

   More actions

   Triage: first grade — enhancement · priority:p2 · domain:ui · area:reports · pm:queue. Direction: the dataset catalog keeps the member label and the dataset description, resolved in the designer locale. The pickers stay dataset-bound, with ⛔ no /analytics/meta reader

   Triage: lands in packages/app-shell (useDatasetCatalog.ts toCatalogEntry, ReportDefaultInspector.tsx, DashboardWidgetInspector.tsx) ⇒ domain:ui. It is the objectui sub-issue of objectstack-ai/objectstack#20282, and it inherits that card's grade (p2), the #20618 pattern: the "reader that must exist" for the parent's declared descriptions.

   Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) · session_01AavokzJ5DndAwitDXvKy4U · 2026-09-30T02:57Z. ⛔ Not a claim, ⛔ not a dispatch.

   Direction.

   • The catalog. toCatalogEntry keeps each measure's and dimension's label and the dataset's description, next to what it keeps today.
     • Both are I18nLabel, so they resolve through the spec's resolveI18nLabel in the designer locale. That is the Studio family's rule. ⛔ No String() of a label.
   • The options. Measure and dimension options show the author's label beside the machine name. The dataset picker shows the description.
     • Each falls back to the name when nothing is declared.
     • ⛔ A label never replaces the name the binding stores: the stored value is unchanged.
   • Authored cubes in these pickers: no. Both inspectors bind datasets, and no author is measured asking to bind an analytics_cube there.
     • So nothing reads /analytics/meta here.
     • The server half the parent's review carried (the dataset description on /meta) is not needed and is not filed.
     • A picker that binds cubes is a card of its own, with its reach.
   • Pins, per the card's acceptance:
     • each inspector's measure, dimension and dataset options show the declared text;
     • they fall back to the name when it is absent;
     • a map-valued label resolves under en and under zh.
2. objectstack-fleet

   added

   area:reportsBusiness reporting — dashboards, reports, the numbers a manager readsBusiness reporting — dashboards, reports, the numbers a manager reads

   domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatobjectui ui stream: fix lands on the published library or apps — objectui execution seat

   enhancementNew feature or requestNew feature or request

   pm:queue

   priority:p2

   pm:dispatched

   and removed

   pm:queue

   on Sep 30, 2026
3. objectstack-fleet

   assigned

   os-support-ai

   on Sep 30, 2026
4. objectstack-fleet commented on Sep 30, 2026

   

   objectstack-fleetbot

   on Sep 30, 2026

   ContributorAuthor

   More actions

   Claim: PM loop round 8 — domain:ui execution seat 2
   Session: session_011p7ikEivgXefNDaE5S5Uec
   Account: os-support-ai (the seat's linked user as GET /user answers it; the card's assignee)
   Branch: claude/issue-11161-dataset-picker-labels
   Worktree: objectui-issue-11161
   Domain: domain:ui
   Seat: domain:ui#2
   File surface (triage 5903169797: the dataset catalog keeps the member label and the dataset description, resolved in the designer locale; the pickers stay dataset-bound, ⛔ no /analytics/meta reader):

   • packages/app-shell/src/views/metadata-admin/previews/useDatasetCatalog.ts: toCatalogEntry (:62) keeps each measure's and dimension's label and the dataset's description (I18nLabel).
   • packages/app-shell/src/views/metadata-admin/inspectors/ReportDefaultInspector.tsx and DashboardWidgetInspector.tsx, plus _shared.tsx if the option rendering lives there. Measure and dimension options show the label beside the machine name, and the dataset picker shows the description. Each resolves through resolveI18nLabel in the designer locale, falls back to the name, and ⛔ never replaces the stored value.
   • Pins, and one changeset ('@object-ui/app-shell': patch).
     Stop on breach; explain in the report.
     Container & model: S, mode:subagent, model: opus (TIER_DEFAULT; dispatch-gates --tier --repo objectstack-ai/objectui over this surface: no path-derived mandate, at objectstack 288611e3)
     Clause-②: no
     Why no: a Studio picker shows text the dataset document already declares. The stored binding, the catalog's public shape (internal to app-shell) and every spec type are unchanged.
     Thread-read: 5903169797
     Serial constraints cleared: read 2026-09-30T03:34Z at objectui origin/main c2a8d23c6. PR objectui#11086 (another session) touches ReportDefaultInspector.joinedClearsBinding-10746.test.tsx only; this card leaves that test file alone and adds its own pins. No open PR touches useDatasetCatalog.ts, ReportDefaultInspector.tsx, DashboardWidgetInspector.tsx or _shared.tsx.

   ---

   Generated by Claude Code
5. objectstack-fleet commented on Sep 30, 2026

   

   objectstack-fleetbot

   on Sep 30, 2026

   ContributorAuthor

   More actions

   os-dev-report

   {
     "issue": 11161,
     "status": "done",
     "branch": "claude/issue-11161-dataset-picker-labels",
     "pr": "https://github.com/objectstack-ai/objectui/pull/11171",
     "session": "session_011p7ikEivgXefNDaE5S5Uec — subagent run under the domain:ui seat 2 PM session (the parent's id, as the claim names it)",
     "premise_still_valid": true,
     "summary": "toCatalogEntry(doc, locale) now keeps each measure's and dimension's label and the dataset's description beside the dataset label, all resolved through the spec's resolveI18nLabel in the designer locale; the hand-rolled resolveLabel is gone (measured on base: a { en, zh-CN } dataset label came back as the machine name; the { default } spelling still resolves). Locale enters toCatalogEntry as a required parameter; useDatasetCatalog and useDatasetSemantics keep the served documents and resolve where they return in useMetadataLocale(), so entries are display-ready strings, the datasetCatalogOverride type stays string-typed, and a language switch re-reads without a refetch (the objectui#10862 pattern). Both inspectors build every option list from one set of builders exported next to DatasetNamesEditor: add-member lists show LABEL with the name in the code chip (Revenue · sum beside revenue), text-only selects (report chart axes, report dataset select) write LABEL (name), the dashboard filter-field combo shows name then label, the dataset description rides as the option hint (combo muted suffix; report select appends ' — description'); undeclared text reads exactly as before and every stored value is still the machine name. No existing pin's expected text moved; ReportDefaultInspector.joinedClearsBinding-10746.test.tsx untouched; nothing reads /analytics/meta.",
     "tests": "All at d5dc4a99d (branch head, tree clean). (1) New pins, 2 files: 'Test Files 2 passed (2) / Tests 24 passed (24)'. (2) Order's test gate, via os-verify-lock: pnpm exec vitest run packages/app-shell/src/views/metadata-admin/inspectors/ packages/app-shell/src/views/metadata-admin/previews/ + views/__tests__/ReportConfigPanel.panelTitle.test.tsx + metadata-admin/ResourceEditPage.servedDraftTakenAsIs-10765.test.tsx: 'Test Files 201 passed (201) / Tests 2733 passed | 1 skipped (2734)', VERDICT command-exit 0. (3) Closure build: turbo run build --filter='@object-ui/app-shell^...' --concurrency=2: 'Tasks: 28 successful, 28 total'; then pnpm --filter @object-ui/app-shell type-check (echo: 'tsc --noEmit && tsc -p tsconfig.test.json') VERDICT command-exit 0; tsc -p tsconfig.test.json --listFilesOnly lists both new test files (4782 program files). (4) eslint --no-inline-config on the 5 changed files: 0 errors; per-file warning delta vs base: ReportDefaultInspector.tsx 0 to 3 (react-refresh/only-export-components, one per exported builder), useDatasetCatalog.ts 1 to 1, DashboardWidgetInspector.tsx 11 to 11. (5) exit 0: check-changeset-presence ('1 released package ... 1 changeset'), check:control-bytes, check:new-line-citations ('0 new citation(s)'), check:vi-mock-specifiers, check:vi-mock-inherit, check:vi-mock-override-shape, check:test-path-roots, check:changeset-claims, check:pending-changeset-literals, check:phantom-deps, check:self-import, check:esm-specifiers (specifiers-only leg; load leg NOT MEASURED). Ablations from the committed head, trap-restored, restore proven by blob == HEAD and empty git diff HEAD: (a) base useDatasetCatalog.ts written in place (on-disk blob == base blob 3658fdf06, grep resolveLabel 0 to 1, resolveI18nLabel 3 to 0): 'Tests 20 failed | 4 passed (24)', the 4 green being the cases base already met (names/type keys, label fallback, { default }, nameless doc); the map-label pin read 'expected sales_pipeline to be Sales pipeline'. (b) ablation-replace.mjs set the measure option name to its label (anchor x1 to x0, blob c016731ae to b2b5141db): 'Tests 6 failed | 18 passed (24)' — both 'a pick stores the machine name' pins (values received Revenue) and the 4 measure-option pins. NOT MEASURED: full pnpm test / lint farm (CI), browser pass. One lock attempt returned 99 queue-timeout (never acquired; re-run under the same slot and measured).",
     "mcp_calls": "0 — no MCP GitHub tool was called",
     "api_writes": "3 REST writes, each through the fleet relay (POST /repos/objectstack-ai/objectstack/dispatches, executed as objectstack-fleet[bot]): (1) pr_create to POST /repos/objectstack-ai/objectui/pulls (draft, #11171; body read back byte-identical, 9303 bytes, 0 angle brackets); (2) label-write --assign os-support-ai to POST /repos/objectstack-ai/objectui/issues/11171/assignees (read back: assignee os-support-ai, labels unchanged); (3) post-stamped to POST /repos/objectstack-ai/objectui/issues/11161/comments (this report). Plus 2 git pushes (empty-branch probe, then d5dc4a99d), not REST.",
     "open_questions": [],
     "out_of_scope_findings": [],
     "gates": [
       {
         "cmd": "pnpm exec vitest run (new pins, 2 files)",
         "exit": 0,
         "verdict": "Tests 24 passed (24)"
       },
       {
         "cmd": "pnpm exec vitest run inspectors/ previews/ + 2 host suites (os-verify-lock)",
         "exit": 0,
         "verdict": "Test Files 201 passed (201); Tests 2733 passed | 1 skipped (2734)"
       },
       {
         "cmd": "turbo run build --filter='@object-ui/app-shell^...' --concurrency=2",
         "exit": 0,
         "verdict": "28 successful, 28 total"
       },
       {
         "cmd": "pnpm --filter @object-ui/app-shell type-check",
         "exit": 0
       },
       {
         "cmd": "pnpm exec eslint --no-inline-config (5 changed files)",
         "exit": 0,
         "verdict": "0 errors; +3 warnings react-refresh/only-export-components"
       },
       {
         "cmd": "node scripts/check-changeset-presence.mjs",
         "exit": 0
       },
       {
         "cmd": "pnpm check:control-bytes",
         "exit": 0
       },
       {
         "cmd": "pnpm check:new-line-citations",
         "exit": 0,
         "verdict": "0 new citation(s)"
       },
       {
         "cmd": "pnpm check:vi-mock-specifiers / vi-mock-inherit / vi-mock-override-shape / test-path-roots",
         "exit": 0
       },
       {
         "cmd": "pnpm check:changeset-claims / pending-changeset-literals / phantom-deps / self-import / esm-specifiers",
         "exit": 0
       }
     ],
     "line_budget": "n/a — the diff touches no skills/** or governed surface",
     "files_changed": [
       ".changeset/11161-dataset-picker-author-text.md",
       "packages/app-shell/src/views/metadata-admin/inspectors/DashboardWidgetInspector.tsx",
       "packages/app-shell/src/views/metadata-admin/inspectors/ReportDefaultInspector.tsx",
       "packages/app-shell/src/views/metadata-admin/inspectors/datasetPickers.authorText-11161.test.tsx",
       "packages/app-shell/src/views/metadata-admin/previews/useDatasetCatalog.authorText-11161.test.ts",
       "packages/app-shell/src/views/metadata-admin/previews/useDatasetCatalog.ts"
     ],
     "deviations": [
       "Surface: _shared.tsx untouched (the report select renders option labels as given, so no rendering change was needed there); no file outside the claimed surface.",
       "Lint: +3 react-refresh/only-export-components warnings in ReportDefaultInspector.tsx from the three exported option builders; placed there (not in useDatasetCatalog.ts) because DashboardWidgetInspector.test.tsx mocks that module with only its two hooks.",
       "Test gate widened beyond the order's two directories by the two other suites that mount these inspectors (ReportConfigPanel.panelTitle, ResourceEditPage.servedDraftTakenAsIs-10765).",
       "Attribution: the harness reminder's model-named Co-Authored-By trailer and its PR footer were not used; commits carry the model-free pair and the PR ends with the session-URL footer, per the role file and objectui AGENTS.md (standard text, so no open question).",
       "Acceptance notes in the PR carry 5 observations with no carrier (picked rows still show the name; report select trigger mirrors the description; combo hint does not truncate; measure format still dropped; plugin-dashboard WidgetConfigPanel untouched), so out_of_scope_findings is empty.",
       "Cleanup: worktree /home/user/objectui-issue-11161 removed after its node_modules (git worktree remove, no --force); remote head verified = d5dc4a99d first."
     ]
   }

   ---

   Generated by Claude Code
6. objectstack-fleet commented on Sep 30, 2026

   

   objectstack-fleetbot

   on Sep 30, 2026

   ContributorAuthor

   More actions

   ✅ ACCEPT: PR objectui#11171 at d5dc4a99d; ready and auto-merge follow this ACCEPT

   domain:ui seat 2, session_011p7ikEivgXefNDaE5S5Uec. Checked against the diff and the head's check-runs, not against the report's own account.

   • Claim 5903534130, on triage 5903169797.
   • Dev report 5904029412.
   • Contract review 5904153068, at CONTRACT_REVIEW_TIER: PASS on this head.

   Implemented-by:  claude/issue-11161-dataset-picker-labels
   Reviewed-by:     session_011p7ikEivgXefNDaE5S5Uec
   

   item	reading
   the catalog	toCatalogEntry(doc, locale) keeps each measure's and dimension's label and the dataset's description, all resolved through the spec's resolveI18nLabel. The hand-rolled resolveLabel is gone. At base a map-valued label came back as the machine name. { default } still resolves, as the spec's own untagged entry. Both hooks keep the served documents and resolve where they return, in useMetadataLocale(), so a language switch re-reads without a refetch
   the pickers	Both inspectors build every option list from one set of builders. Add-member lists show the label with the name in the code chip. Text-only selects show LABEL (name). The filter-field combo shows the name, then the label. The dataset description rides as the picker's hint. Undeclared text reads as before, and every stored value is still the machine name. Nothing reads /analytics/meta
   surface	The new fields are additive optional strings on internal types. The review found none of them, nor toCatalogEntry or the builders, on the package root or the exports map
   tests	24 cases in 2 files. They cover all four texts under en-US and zh-CN, the fallbacks, blank and non-text values read as undeclared, the real inspectors under I18nProvider, one stored-value pin per inspector, and a language switch without a refetch. Ablations: the base catalog file turns 20 of the 24 red; setting the option name to its label turns both stored-value pins red
   lint	Three react-refresh/only-export-components warnings come from the builders exported beside DatasetNamesEditor. That rule is warn-level, and the placement is forced by an existing pin that mocks the catalog module. The review judged it acceptable, not a finding
   changeset	'@object-ui/app-shell': patch; Clause-②: no
   CI	head d5dc4a99d: 43 runs, 40 success, 3 expected skips, 0 failure
   size	6 files, +667 / −60
   closing keywords	Fixes #11161 only
   governed	none of the 6 paths is on objectui's governed surfaces

   Out of scope, one line each (the PR's five Acceptance notes, judged by the review):

   • A bound member's row in DatasetNamesEditor still reads the machine name, while the add-member popover beside it shows the label. Acceptance notes, carrier: none; not filed. It is outside this card's direction, which named the options, and its reach was never measured. The seat post records the measurement for the next holder: a dataset whose members declare labels, bound in either inspector, with the row text read.
   • The report's dataset select trigger echoes LABEL (name) — description. A long dashboard combo hint wraps. A measure's format is still dropped. plugin-dashboard's WidgetConfigPanel is untouched. Acceptance notes, carrier: none; not filed. Each is cosmetic, outside the direction, or has no in-repo producer.

   _{domain:ui seat 2 · ACCEPT · 2026-09-30T04:39Z}

   ---

   Generated by Claude Code
7. objectstack-fleet

   closed this as completedin #11171on Sep 30, 2026
8. objectstack-fleet

   removed

   pm:dispatched

   on Sep 30, 2026
9. akarma-synetal

   added a commit that references this issue on Oct 7, 2026

   fix(app-shell): the report and dashboard-widget pickers show a datase…

   ...

   cecd6a0