Skip to content

fix(charts): refuse a cartesian chart that declared no series binding at all (#4695) - #10353

Merged
os-project-manager merged 2 commits into
mainfrom
claude/issue-4695-no-series-binding-refusal
Sep 24, 2026
Merged

os-project-manager merged 2 commits into
mainfrom
claude/issue-4695-no-series-binding-refusal

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #4695
Clause-②: yes

What changed

A bar / horizontal-bar / line / area / combo chart (and column, normalized to bar) handed data rows but no series binding at all (series === undefined) now refuses loudly instead of drawing axes, grid and legend around zero marks. This is maintainer ruling A on objectui#4695 (relayed in issue comment 5808476637).

  • hasNoPlottableSeries (packages/plugin-charts/src/AdvancedChartImpl.tsx) now returns a discriminant, 'empty' or 'undeclared' or null, read on the RAW props in the outer AdvancedChartImpl wrapper, before AdvancedChartImplInner's series = [] default erases the difference. Its docstring (which used to record the undefined omission as deliberate) is rewritten.
  • The objectui#4683 placeholder is reused: same ChartRefusal shell, same role="status", same data-chart-error="no-plottable-series" code. No second placeholder. Only the sentence differs:
    • computed and empty (objectui#4683): "This chart cannot plot any series: no measure or group reached its X axis."
    • never declared (objectui#4695): "This chart cannot plot any series: none was declared to draw against its X axis."
  • The console warning differs the same way: the undeclared arm names the row keys a series could bind and cites objectui#4695.
  • The sentence is a literal, as the objectui#4683 one is. No i18n pack key was added (packages/i18n/src/locales/* untouched).

The narrowed accept-set (for the contract review)

Now refuses (placeholder, no svg), only when data has at least one row and no category-axis refusal applies:

  • chartType in bar, horizontal-bar, line, area, combo, column, or omitted (the renderer's bar default), with series absent. Through ChartRenderer that is an authored chart with no series, no categories and no y-axis field (a malformed categories or a retired value key included, since the normalizer yields no series for them).

Still draws, unchanged:

  • any chart with a declared series (reverse control pinned: a bar with series: [{ dataKey: 'est_hours' }] draws 2 bars, no data-chart-error, no warning);
  • pie, donut, funnel, radar, scatter (and the other value-fallback families) with no series. They fall back to the value column, pinned for the undefined arm too;
  • any chart with zero rows (the chart's own empty state);
  • the category-axis refusal (missing-category-key) still wins when both apply.

Already refused before this PR, unchanged: series: [] on the same families (objectui#4683).

Callers measured (PM hypothesis 4)

ChartRenderer is the only importer of AdvancedChartImpl (lazy). It forwards spec.series ?? authored, so undefined reaches the renderer only when the schema declared none of series / categories / y-axis fields. ObjectChart forwards buildChartSeries output (always an array) on the dataset path and augmentedSeries (or nothing) otherwise; DashboardRenderer always builds a series array. In every one of those, an undefined series on a cartesian family already drew zero marks, because the cartesian tail and the combo tail render series.map(...) and nothing else. So no caller drawing marks today can start refusing: the change turns silent empty frames into an explained refusal, and nothing else. Annotations (reference lines) with no series behave exactly as they already did under series: [] since objectui#4683.

Pins

  • AdvancedChartImpl.unprojectedSeriesDimension.test.tsx: the pin leaves a caller that computed NO series binding at all untouched is rewritten (not deleted) to refuses a caller that computed NO series binding at all, in its own sentence (objectui#4695). It asserts the placeholder, role="status", no svg, one warning citing objectui#4695, and that its text differs from the computed-and-empty refusal's. A new describe block covers the undefined arm across the refusing families, the value-fallback families that keep drawing, the reverse control, and the no-rows case.
  • ChartRenderer.foreignDialectRetired-8650.test.tsx: two cases pinned a bar with no series as "mounts and plots nothing" (malformed categories, retired value). That contradicts the ruling, so both now wait for the no-plottable-series refusal. The positive reading is kept: re-adding the retired read would plot, no refusal would arrive, and the waitFor goes red. This file is outside the claimed file surface. It is a test-only change forced by the ruling's "leave no pin contradicting it". None of the 23 open PRs touches it (their file lists were read).

Verification (head 54f2e1d95)

  • pnpm exec vitest run --maxWorkers=2 packages/plugin-charts/: 66 files / 599 tests passed at 54f2e1d95.
  • Earlier wide run at d9dedb5cb (plugin-charts, plugin-dashboard, plugin-report, plugin-view, plus every other chart-referencing test file across app-shell, console, schema-catalog, list, runner and others): 3414 passed, 2 failed. Those 2 are exactly the objectui#8650 pins above. After re-pointing them, both files pass (23/23).
  • Ablation (committed state, fix arm replaced by a marker, marker count 1, anchor count 0; restored with git checkout HEAD --, git diff HEAD empty, blob hash matches HEAD): 4 red. They are the rewritten pin, the family loop, and both objectui#8650 cases. The other 19 in those files stay green.
  • plugin-charts type-check: exit 0, after building the dependency closure (--filter '@object-ui/plugin-charts^...' build). lint: exit 0, 0 errors.
  • check:new-line-citations (0 new), check:control-bytes, check:changeset-claims, check:pending-changeset-literals, check:vi-mock-specifiers, check:vi-mock-inherit, check:vi-mock-override-shape, check:test-path-roots, check-changeset-presence.mjs, check-changeset-no-major.mjs: all exit 0.

Acceptance notes

  • One data-chart-error code for both arms is deliberate. The ruling says to reuse the channel, and the two arms share the failure ("cannot plot a series"). A machine consumer that needs the arm reads the sentence or the warning. If a distinct code is wanted, that is a one-line follow-up.
  • Changeset: .changeset/4695-no-series-binding-refusal.md, @object-ui/plugin-charts: patch.

Generated by Claude Code

… at all

A bar / horizontal-bar / line / area / combo chart handed rows but no
`series` prop (`series === undefined`) drew axes, grid and legend around
zero marks and said nothing. It now renders the objectui#4683
`no-plottable-series` placeholder with its own sentence ("none was
declared") and a console warning naming the row keys. Pie, donut, funnel,
radar and scatter fall back to a `value` column and keep drawing.

The pin that recorded the old silence is rewritten to assert the refusal.

Refs objectui#4695

Co-Authored-By: Claude <noreply@anthropic.com>
…l; add changeset

Two objectui#8650 cases pinned a bar chart with no series binding as "mounts
and plots nothing". Under the objectui#4695 ruling that shape now refuses, so
both wait for the `no-plottable-series` placeholder instead; the positive
reading is kept (re-adding the retired read would plot and never refuse).

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 1 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/7546-chart-series-keys-declared.md

  • names AdvancedChartImpl.tsx → packages/plugin-charts/src/AdvancedChartImpl.tsx — edited by this change

    Every one of the six is read by normalizeSeries (@object-ui/plugin-charts, normalizeChartSchema.ts:242-255) and does real work in AdvancedChartImpl.tsx — label names the legend entry, variant === 'comparison' selects the muted overlay, opacity / dashArray set stroke and fill, stack becomes Recharts' stackId, yAxis binds the secondary axis. Any consumer of the parse output — objectui check / objectui validate via safeValidateSchema, a JSON schema derived from the mirror, or any pipeline that keeps parse()'s result — lost them outright.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 8c10f4f71 (merge-base with origin/main): 3 file(s) changed outside .changeset/, read against 1331 pending declaration(s) that publish a body (1904 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3041.8 KB 3104.5 KB
Main entry chunk (gzip) 148.3 KB 350 KB
Entry file index-D6mqU2S1.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.68KB 6.20KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 541.61KB 129.47KB
core (index.js) 8.94KB 3.59KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 222.47KB 61.83KB
fields (index.js) 253.70KB 64.09KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 34.99KB 11.45KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.15KB 11.05KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.08KB 3.95KB
plugin-calendar (index.js) 51.44KB 14.62KB
plugin-charts (index.js) 72.59KB 20.30KB
plugin-chatbot (index.js) 198.27KB 47.18KB
plugin-dashboard (index.js) 133.06KB 35.21KB
plugin-designer (index.js) 216.12KB 44.37KB
plugin-detail (index.js) 260.65KB 67.82KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 146.34KB 37.48KB
plugin-gantt (index.js) 168.31KB 41.45KB
plugin-grid (index.js) 215.46KB 58.88KB
plugin-kanban (index.js) 49.30KB 15.39KB
plugin-list (index.js) 114.13KB 28.14KB
plugin-map (index.js) 21.74KB 7.07KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.55KB 11.99KB
plugin-timeline (index.js) 30.68KB 8.95KB
plugin-tree (index.js) 10.56KB 3.71KB
plugin-view (index.js) 85.79KB 21.35KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 110.46KB 36.33KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.78KB 2.56KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: 66/66 CONTRACT_REVIEW_TIER
Head-sha: 54f2e1d956e5f977c6de21576a567814418bab50

Adopted from an isolated at-tier reviewer by domain:ui seat 3, 2026-09-24T20:04Z. Tier read off the reviewer's transcript: 66 of 66 stamped requests served at CONTRACT_REVIEW_TIER.

① Derived judgments

  • (a) Accept-set is exactly the ruling's. hasNoPlottableSeries (packages/plugin-charts/src/AdvancedChartImpl.tsx) returns null unless SERIES_ONLY_CHART_TYPES.has(chartType) && rows.length > 0, then 'undeclared' for series === undefined, 'empty' for Array.isArray(series) && series.length === 0, else null. SERIES_ONLY_CHART_TYPES is unchanged from main at 1f8ef0a: bar, horizontal-bar, line, area, combo. column is not a set member on main or at head; it reaches the set through the pre-existing props.chartType === 'column' ? 'bar' normalization, which the diff does not touch. The predicate is called in the outer AdvancedChartImpl wrapper on raw props, and AdvancedChartImplInner (series = [] default parameter at its signature) is only reached by the wrapper's final return <AdvancedChartImplInner {...props} />, so the distinction is taken before the default erases it. pie / donut / funnel / radar / scatter / treemap / sankey all read series[0]?.dataKey || 'value' in the inner component and are outside the set; the new test loop pins pie, donut, funnel, radar and scatter drawing an svg with no refusal and no warning. Zero rows returns null before either arm (pinned).
  • (a, order) missingCategoryKey ? null : hasNoPlottableSeries(props) keeps the missing-category-key refusal winning, as before.
  • (b) No drawable surface regresses. ChartRenderer.tsx is the only importer of AdvancedChartImpl (React.lazy(() => import('./AdvancedChartImpl')); repo-wide grep at head confirms). It forwards spec.series ?? authored, where normalizeChartSchema derives series from schema.series, else schema.categories, else the y-axis fields; undefined survives only when none of the three yields an entry. Every producer feeding ChartRenderer measured: DashboardRenderer.tsx and DashboardGridLayout.tsx always build series: [{ dataKey: yField }]; DatasetWidget.tsx and DatasetReportRenderer.tsx pass buildChartSeries output (always an array); ObjectView.tsx and ListView.tsx always pass an array (vals.map or [{ dataKey: valueField }]); DatasetPreview.tsx maps measureNames; ObjectChart.tsx forwards datasetChart.series or augmentedSeries or the author's own schema.series. Inside AdvancedChartImplInner the bar / horizontal-bar / line / area tail and the combo ComposedChart tail emit marks only from series.map(...); the only series-independent children are annotationEls, brushEl, axes, grid, tooltip and legend. No path derives a series from yAxisKey, value or categories for these families, so the dev's claim holds: every cartesian chart that reached the inner component with series === undefined drew zero marks. The two schema-catalog chart entries (advanced-line-chart.json, area-chart.json) declare series. Falsification attempt failed.
  • (c) One channel. Both arms render the same ChartRefusal component with code="no-plottable-series" and role="status"; no second placeholder component exists. Sentences: undeclared = "This chart cannot plot any series: none was declared to draw against its X axis."; empty = "This chart cannot plot any series: no measure or group reached its X axis." The rewritten pin asserts the two texts differ. The undeclared sentence is literally true for the shape that reaches it: series === undefined means the normalizer found no series, categories or y-axis field to declare one from. The console warning names the row keys and cites objectui#4695.
  • (d) Pins. AdvancedChartImpl.unprojectedSeriesDimension.test.tsx: the :205 pin is rewritten in place (title refuses a caller that computed NO series binding at all, in its own sentence (objectui#4695)), asserting placeholder, role="status", no svg, one warning citing objectui#4695, and a differing sentence from the series={[]} control; a new describe covers the six-family loop (including column), the value-fallback families, the reverse control (2 .recharts-rectangle, no data-chart-error, no warning) and the no-rows case. Repo-wide sweep of test files for "plots nothing" / "zero marks" / "bars: 0" / "no series" / "empty frame" found no remaining pin asserting a series-only chart drawing with no series; the other hits are comments about pre-fix pictures or unrelated click payloads. ChartRenderer.foreignDialectRetired-8650.test.tsx: the two cases that asserted { bars: 0, lines: 0 } on a bar with no series now waitFor the no-plottable-series refusal and assert no .recharts-surface; positive reading kept, since a re-added retired read would define a series, draw, and the waitFor would time out. The plotted / marks helpers remain used by three other cases, so nothing dangles. The edit is outside the claimed surface but is forced by the ruling's "leave no contradicting pin", is disclosed in the PR body and the dev report's deviations, and no open PR touches the file per the dev's read.
  • (f) Truth. PR body and changeset read sentence by sentence against the diff: the accept-set, the callers, the pins, the ablation, the single-code note and the "no i18n key" claim (packages/i18n untouched in the file list) are all consistent with what was measured. One PR-body sentence, "None of the 23 open PRs touches it", rests on the dev's read and was not re-derived here. Commit trailers on both commits are Co-Authored-By: Claude <noreply@anthropic.com>; a grep of both commit messages for model names returns nothing. Check-runs at head at review time: 28 success, 3 skipped (coverage shards, dependabot), 0 failure, 11 still in progress (Test shards 1-8, Type Check, Lint, Spec Main Shape Gate). Changeset Declaration, Changeset Bump Policy, Changeset Fixed Group Check, Changeset Claim Re-read, Changeset Overwrite Report, Line Citation Gate, Build & E2E, Test (dist pins) are all success.

② Semver level

  • .changeset/4695-no-series-binding-refusal.md declares '@object-ui/plugin-charts': patch. The repo's rule (AGENTS.md: patch for fixes, never major, objectui's own breaking changes as minor) and the direct precedent are consistent with patch: the objectui#4683 no-plottable-series refusal shipped under ### Patch Changes in packages/plugin-charts/CHANGELOG.md, and 8269 (category-axis groupBy) is patch. The only minor in this family is 8650, a key retirement, not a refusal. No type changed (series?: NormalizedSeries[] untouched), and the ruling frames the narrowing as a defect fix. Patch is correct; Changeset Bump Policy is green.

③ Boundary flags

  • PR API base sha is 8c10f4f71 (main moved), while the merge-base of head with origin/main is 1f8ef0a89, the base named in the task; the diff reviewed is head against 1f8ef0a89, four files, +202/-30.
  • One data-chart-error code for both arms, as the ruling's "reuse the channel" allows; a machine consumer cannot tell "empty" from "undeclared" without reading the sentence or warning. Disclosed in the PR body as a one-line follow-up if wanted.
  • Through ChartRenderer a literal authored series: [] lands on the "computed and empty" sentence, and a malformed categories: 'revenue' lands on "none was declared" (the normalizer yields no series). Both are the pre-existing forwarding semantics, not introduced here, and both refuse rather than draw.
  • A cartesian chart carrying only annotations (reference lines) and no series now refuses; it already refused with series: [] since objectui#4683, so no new class of chart is blanked, but it is a shape the accept-set closes.
  • series: null (excluded by the prop type) passes both arms and reaches the inner component's series.map unguarded; pre-existing, out of scope.
  • CI at head was still running (11 in progress, 0 failures) when this record was produced; the dev's local run reports 599/599 in packages/plugin-charts and 23/23 in the two re-pointed files.

Implemented-by: claude/issue-4695-no-series-binding-refusal
Reviewed-by: session_01D486C1axmXnrkJMNUfz2eb

VERDICT: PASS

Seat decision: ACCEPT on top of the PASS. The boundary flags are pre-existing forwarding semantics or disclosed choices, and none asks for a fix in this PR. Next: update-branch, then ready + auto-merge once CI is green on the new head.


Generated by Claude Code

@os-project-manager
os-project-manager marked this pull request as ready for review September 24, 2026 20:05
@os-project-manager
os-project-manager added this pull request to the merge queue Sep 24, 2026
Merged via the queue into main with commit f82f857 Sep 24, 2026
45 checks passed
@os-project-manager
os-project-manager deleted the claude/issue-4695-no-series-binding-refusal branch September 24, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

finding(plugin-charts): a cartesian chart handed NO series binding at all draws the same silent empty frame #4683 just closed for series: []

2 participants