Skip to content

fix(plugin-map, plugin-gantt): objectName is not a required registration input (objectui#7470) - #10390

Merged
os-project-manager merged 1 commit into
mainfrom
claude/issue-7470-designer-objectname-not-required
Sep 24, 2026
Merged

os-project-manager merged 1 commit into
mainfrom
claude/issue-7470-designer-objectname-not-required

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #7470
Clause-②: no

What changed

Ruling 5809231477 (letter align, maintainer 「同意」), executed as written:

  • objectName loses required: true on every map and gantt registration key, re-derived by symbol on origin/main 62bc8a250: object-map (namespace plugin-map), map (namespace view) and object-gantt (namespace plugin-gantt). The bare gantt key is already retired (objectui#8008), so gantt has one key today, not two.
  • Its description now states the rule: the record source is one of data, staticData and objectName, and the object-map / object-gantt schema refuses a block that declares none of them.
  • packages/plugin-gantt/README.md: the "objectName (required)" sentence is corrected.
  • No one-of vocabulary was added to the input declaration. The renderers' read order and the zod mirrors are unchanged.

Why the description is true (hypothesis 3)

requireRecordSource in packages/types/src/zod/objectql.zod.ts checks RECORD_SOURCE_KEYS (data, staticData, objectName) and adds an issue with params.code RECORD_SOURCE_REQUIRED when none is present. It is attached with superRefine(requireRecordSource('object-map')) on ObjectMapSchema and superRefine(requireRecordSource('object-gantt')) on ObjectGanttSchema. The new tests assert this directly, so the sentence in the description is checked by a test, not copied prose.

What the required flag did at runtime

sdui-parser's validateTree turns a required input into a missing-required-prop ERROR. A staticData-only map or gantt drew that error while the schema accepted the block and the renderer drew it. After this change it no longer does.

Hypothesis 2: pins and generated artefacts

No pin or generated artefact asserted required: true for these inputs. apps/console/public/manifest.json (public-tier manifest) carries no map or gantt entry. No test in plugin-map / plugin-gantt read the inputs' required. content/docs/plugins/plugin-map.mdx and plugin-gantt.mdx already say "At least one of data / staticData / objectName is required", which is correct, so they are not touched. packages/plugin-map/README.md makes no required claim.

Tests

New tests: packages/plugin-map/src/index.recordSourceInput-7470.test.tsx (both map keys) and packages/plugin-gantt/src/__tests__/recordSourceInput-7470.test.ts. For each key they check four things: objectName is declared (non-vacuity) and is not required; the description names the three sources; the named schema refuses a block with no source, with RECORD_SOURCE_REQUIRED; and, as a control, the same schema accepts a staticData-only block.

All runs are on head 2083a24f8:

  • pnpm exec vitest run packages/plugin-map/ packages/plugin-gantt/: Test Files 97 passed (97), Tests 705 passed (705).
  • Reverse verification, done after the fix was committed. The mutation was put back with ablation-replace.mjs, and each anchor was confirmed to hit once. required: true restored on object-gantt gave 1 failed / 9 passed. On object-map alone it gave × 'object-map' — objectName is declared and not required, and on map alone × 'view:map' — …. Each file was restored with git checkout HEAD, the restore was proved by matching the HEAD blob hash, and git diff HEAD was empty afterwards. The re-run was 10/10 green. The first map attempt was a no-op: the anchor was ambiguous (x2) and the tool refused it, so it was redone with per-key anchors.
  • type-check (tsc --noEmit && tsc -p tsconfig.test.json) for both packages: exit 0, after building the dependency closure. --listFiles confirms that both new test files are in the test program.

Acceptance notes

  • The map key has no zod arm. safeValidateSchema on a map node with staticData gives invalid_union ("Invalid input"), while object-map with the same content passes. So on the map key the description's sentence talks about the object-map schema, and a bare map node is refused whatever it carries. This is reported to the seat as a finding and not changed here.
  • data / staticData are still not declared inputs on map or gantt. validateTree therefore reports a staticData-only block as unknown-prop, which is a warning, not an error. The ruling did not order declaring them, so this is reported to the seat.
  • object-calendar / calendar have the same disagreement one plugin over: objectName is required: true while ObjectCalendarSchema carries requireRecordSource('object-calendar'). That is out of this card's ruling and reported to the seat.

Gates (local, targeted)

Exit 0: check:new-line-citations (VERDICT … 0 new citation(s)), check:control-bytes, check:element-data-source-declaration, check:component-surface-parity (report-only; its divergences are on the map / gantt config inputs and existed before this change), check:changeset-claims (it points at .changeset/6470-gantt-dependency-field-deprecated.md, which names the gantt README; I read that paragraph and it is still true), check:pending-changeset-literals, check:vi-mock-*, check:test-path-roots, check:registry-bare-names, check:phantom-deps, changeset presence, and check-governed-queue-guard --test (NOT GOVERNED).

NOT MEASURED, left to CI:

  • check:sdui-registration-pins exited 2 because the console build it reads was absent.
  • check:readme-exports exited 1 because only part of the packages were built, so its population collapsed below its floors.

ESLint over the 4 touched source and test files: 0 errors (warnings only, the same kinds as the file's existing ones). The config is not type-aware, so this diff cannot change verdicts on untouched files.

Session https://claude.ai/code/session_01D486C1axmXnrkJMNUfz2eb, domain:ui#3 seat.


Generated by Claude Code

…ion input

The registrations of object-map, map and object-gantt declared objectName
required while the renderers read data, staticData or objectName and the zod
schemas enforce one of the three via requireRecordSource. Drop required, state
the rule in the input description, and correct the plugin-gantt README.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation plugin tests labels Sep 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 1 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/6470-gantt-dependency-field-deprecated.md

  • names packages/plugin-gantt/README.md → packages/plugin-gantt/README.md — edited by this change

    packages/plugin-gantt/README.md's ObjectGanttSchema example authored the singular; it was the only in-repo site that did, and it now authors the plural with the alias named as legacy. No runtime code, fixture, example app or catalog schema authored it.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 170fcb6df (merge-base with origin/main): 5 file(s) changed outside .changeset/, read against 1355 pending declaration(s) that publish a body (1928 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3042.7 KB 3104.5 KB
Main entry chunk (gzip) 148.4 KB 350 KB
Entry file index-DiQGASW3.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.68KB 6.20KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 542.11KB 129.60KB
core (index.js) 8.94KB 3.59KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 224.12KB 62.26KB
fields (index.js) 254.86KB 64.50KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 34.99KB 11.45KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.28KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.44KB 14.62KB
plugin-charts (index.js) 72.58KB 20.29KB
plugin-chatbot (index.js) 198.27KB 47.18KB
plugin-dashboard (index.js) 133.19KB 35.25KB
plugin-designer (index.js) 216.12KB 44.37KB
plugin-detail (index.js) 260.94KB 67.93KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 146.34KB 37.47KB
plugin-gantt (index.js) 168.47KB 41.53KB
plugin-grid (index.js) 215.22KB 58.85KB
plugin-kanban (index.js) 49.30KB 15.39KB
plugin-list (index.js) 114.17KB 28.16KB
plugin-map (index.js) 22.05KB 7.14KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.55KB 11.99KB
plugin-timeline (index.js) 30.72KB 8.96KB
plugin-tree (index.js) 10.74KB 3.76KB
plugin-view (index.js) 85.86KB 21.38KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 114.58KB 37.60KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.78KB 2.56KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-project-manager
os-project-manager marked this pull request as ready for review September 24, 2026 21:49
@os-project-manager
os-project-manager added this pull request to the merge queue Sep 24, 2026
Merged via the queue into main with commit 3ef0b51 Sep 24, 2026
45 checks passed
@os-project-manager
os-project-manager deleted the claude/issue-7470-designer-objectname-not-required branch September 24, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation plugin tests

Projects

None yet

2 participants