Skip to content

fix(components): ui:calendar designer stops offering mode default (objectui#10377) - #10420

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-10377-calendar-mode-default
Sep 25, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-10377-calendar-mode-default

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #10377

Clause-②: conditional.
The branch taken is the first one: only the designer enum drops 'default'; CalendarSchema.mode (TS) and the UiCalendarSchema mirror are byte-unchanged.

What changed

  • packages/components/src/renderers/form/calendar.tsx: the ui:calendar registration inputs enum for mode is now ['single', 'multiple', 'range'], exactly what CalendarSchema.mode and UiCalendarSchema admit. 'default' is gone.
  • New pin packages/components/src/renderers/form/__tests__/calendar.designerModeEnum-10377.test.ts: every value in the ui:calendar designer mode enum passes UiCalendarSchema.safeParse (enum is a subset of the contract). The list of modes is not restated; the mirror is the judge. It also has a non-vacuity row and a control row showing the mirror still refuses default, so the pin can fail.
  • .changeset/10377-calendar-designer-mode-enum.md: patch for @object-ui/components.

Measurement (step 1, before any edit)

A throwaway probe rendered the real ui:calendar renderer (real ComponentRegistry, react-day-picker 10.0.1, clock frozen inside 2026-09) and compared mode omitted, mode: 'single' and mode: 'default', each with no value, with value and with defaultValue, then clicked two days:

case selected before after clicking the 20th after clicking the 22nd root data-mode
mode omitted none 2026-09-20 2026-09-22 single
mode: 'single' none 2026-09-20 2026-09-22 single (DOM byte-identical to omitted)
mode: 'default' none none none default
omitted + value: '2026-09-15' 2026-09-15 2026-09-20 2026-09-22 single
'default' + value: '2026-09-15' none none none default
'default' + defaultValue: '2026-09-15' none none none default

So 'default' is distinct from omitting mode, but it is not a meaningful mode. react-day-picker 10's Mode union is only single | multiple | range, and its useSelection switch sends any other string to the no-selection branch. isInteractive is mode !== undefined, so all 35 day cells still render as buttons, but clicking them does nothing, and the authored value / defaultValue is silently dropped. That is a value falling through an unrecognised string, not a designed mode. That is why this PR takes the drop-from-the-enum branch. A read-only calendar is a separate question, raised in the report as an open question for the PM rather than widened here.

The corpus check found no document authoring mode: 'default'. The only hit in the tree was the registration itself.

Ablation (after the fix commit)

The fix was committed first (3d90a1259). Then 'default' was put back into the enum on disk. The anchor count went from 0 to 1 for the old spelling and from 1 to 0 for the new one. The new pin went red: Tests 1 failed | 2 passed (3), and the diff showed + "default" as the refused value. The restore used git checkout HEAD --; git diff HEAD was empty and the disk hash matched the HEAD blob b9a6e73df. After the restore the pin was green: Tests 3 passed (3).

Checks, run on 3d90a1259

  • pnpm --filter @object-ui/components type-check (after turbo run build --filter='@object-ui/components^...', 7/7 tasks): exit 0. The --listFiles output of tsconfig.test.json includes the new test.
  • pnpm exec vitest run packages/components/: Test Files 295 passed | 1 skipped (296), Tests 2845 passed | 17 skipped (2862).
  • eslint on the two touched source files: 0 errors and 3 warnings, all pre-existing no-explicit-any on unchanged lines (the base file has the same 3). Type-aware linting is not enabled in eslint.config.js, so this diff cannot move the verdict of any untouched file.
  • check:designer-field-key-parity OK · check:control-bytes OK · check:new-line-citations 0 new · check:changeset-claims pass · check:pending-changeset-literals pass · check:component-surface-parity report-only, exit 0 (its ui:calendar rows are the pre-existing minDate/maxDate rows and are unchanged) · scripts/check-changeset-presence.mjs pass.
  • NOT MEASURED: check:sdui-registration-pins. Reason: it reads the console bundle and refuses to run without pnpm --filter @object-ui/console build. Left to CI.

Acceptance notes

  • I found no generic designer-enum-vs-objectui-mirror check to extend. apps/console/src/__tests__/registry-inputs-spec-parity.test.ts judges enum arms against @objectstack/spec ComponentPropsMap, which does not carry the objectui-own ui:calendar. The existing enum-vs-mirror pins are per-component (text-variant-align-6942, toast-sonner-button-variant-inputs-7316). So the pin is per-component too.

Generated by Claude Code

…objectui#10377)

The registration inputs enum offered 'default' beside single/multiple/range.
CalendarSchema.mode and the UiCalendarSchema mirror both refuse it, and
react-day-picker 10 has no such mode: measured, it drops the authored
selection and clicks select nothing. The enum now lists the contract's
modes, pinned enum-subset-of-mirror by a safeParse test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01877XiBYSaRCk2CU7cMSg3S
@github-actions

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 2 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/8499-node-slot-registered-arms.md

  • names renderers/form/calendar.tsx → packages/components/src/renderers/form/calendar.tsx — edited by this change

    • SemanticElementSchema (zod/layout.zod.ts) — the seven HTML sectioning tags renderers/layout/semantic.tsx registers: aside main header nav footer section article. - HtmlElementSchema (zod/layout.zod.ts) — the 37 safe flow/inline tags renderers/basic/html-elements.tsx registers (h1…h6, p, a, ul, img, …), plus the per-tag keys that module forwards to the DOM (href, target, rel, title, src, alt, width, height, dateTime, cite). - InputShorthandSchema (zod/form.zod.ts) — email / password, the two aliases renderers/form/input.tsx registers onto the input renderer with inputType pinned. inputType is deliberately NOT declared on this arm: the wrapper spreads its own value last, so an authored one is overwritten. - UiCalendarSchema (zod/form.zod.ts) — ui:calendar, the date-picker primitive renderers/form/calendar.tsx registers under exactly that key (skipFallback, because bare calendar belongs to the plugin-calendar view).

.changeset/9067-zod-barrel-named-arms.md

  • names renderers/form/calendar.tsx → packages/components/src/renderers/form/calendar.tsx — edited by this change

    • InputShorthandSchema (zod/form.zod.ts) — the email / password shorthand arm. - UiCalendarSchema (zod/form.zod.ts) — ui:calendar, the date-picker primitive renderers/form/calendar.tsx registers, a different component from the calendar plugin view that owns the bare literal.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 74fcda829 (merge-base with origin/main): 2 file(s) changed outside .changeset/, read against 1368 pending declaration(s) that publish a body (1943 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3043.7 KB 3104.5 KB
Main entry chunk (gzip) 148.4 KB 350 KB
Entry file index-CfVWQwsl.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.68KB 6.20KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 542.46KB 129.64KB
core (index.js) 8.94KB 3.59KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 224.12KB 62.26KB
fields (index.js) 255.56KB 64.73KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.28KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.44KB 14.62KB
plugin-charts (index.js) 72.54KB 20.26KB
plugin-chatbot (index.js) 198.27KB 47.18KB
plugin-dashboard (index.js) 133.45KB 35.33KB
plugin-designer (index.js) 216.12KB 44.37KB
plugin-detail (index.js) 260.94KB 67.93KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 146.34KB 37.47KB
plugin-gantt (index.js) 168.47KB 41.53KB
plugin-grid (index.js) 215.22KB 58.85KB
plugin-kanban (index.js) 49.30KB 15.39KB
plugin-list (index.js) 114.36KB 28.24KB
plugin-map (index.js) 22.05KB 7.14KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.55KB 11.99KB
plugin-timeline (index.js) 30.72KB 8.96KB
plugin-tree (index.js) 10.74KB 3.76KB
plugin-view (index.js) 85.86KB 21.38KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 114.58KB 37.60KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.78KB 2.56KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

PM ACCEPT — objectui#10420 (Closes #10377)

Head-sha: 3d90a12592490d45cf5f054121b4917f06136bde

Clause-②: no. The branch taken only drops 'default' from the ui:calendar registration inputs enum. CalendarSchema.mode (TS) and UiCalendarSchema are byte-unchanged, so no contract review is needed.

Measurement. The runtime measurement came before the edit, as the triage plan asked.

Pin. calendar.designerModeEnum-10377.test.ts checks that the enum is a subset of the contract, as judged by the mirror itself (no restated list). It has a non-vacuity row and a refusing control. The dev's ablation, re-adding 'default', turned it red: 1 failed / 2 passed.

Changeset. A patch for @object-ui/components.

Dev's open question: option A. No display-only mode for now. No document authors one, and adding it would widen CalendarSchema.mode, which needs its own card and a naming decision.

Ready and enqueued once CI is green.

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review September 25, 2026 00:22
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 6276478 Sep 25, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-10377-calendar-mode-default branch September 25, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

finding(components/types): the ui:calendar designer offers mode: 'default', which both authoring faces refuse

1 participant