Skip to content

fix(app-shell): the membership-tier and hook-object flags read in the designer's locale (objectui#10448) - #10551

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-10448-designer-flags-i18n
Sep 25, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-10448-designer-flags-i18n

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #10448

Clause-②: no — two designer display strings move onto the catalogue; no export, schema or accept set moves.

What changes

Two designer unknown-value flags were English template literals. Both now go through flagUnknownValue (the objectui#9652 device in inspectors/_shared.tsx), so the engine.form.flaggedValue template decides the order of value and flag and the gap between them.

site before new catalogue row (en / zh) locale channel
FlowReferenceField.tsx, ReferenceCombobox org-membership-level strict select, a stored tier outside the enum `${current} (invalid)` engine.form.invalid = (invalid) / (无效) useMetadataLocale() (the control has no locale prop)
HookDefaultInspector.tsx, object picker pickerOptions, a selected object the live catalog does not list `${n} (not published)` engine.form.notPublished = (not published) / (未发布) the locale prop the inspector already receives
  • The zh words are the catalogue's own: engine.list.invalid is 无效, engine.studio.unpublished is 未发布. Both zh flags open with a full-width bracket, as the comment above the zh flag rows requires.
  • en is byte-identical: {value} {flag} with the en flag rebuilds the pre-fix string exactly, and both en cases pin it as a literal.
  • pickerOptions re-derives on the locale primitive, not on the tr callback identity (AGENTS.md rule [WIP] Enhance every detail of the designer #10).
  • metadata-admin/i18n.ts: one EN hunk and one ZH hunk, each directly after that table's engine.form.deprecated row, inside the engine.form.* flag block. Both are hunk-disjoint from the open PRs objectui#10509 and objectui#10527, which also edit this file.
  • Changeset: .changeset/10448-designer-invalid-not-published-flags.md ('@object-ui/app-shell': patch).

Pins: red on base, green on head

New files, one beside each site: inspectors/FlowReferenceField.flag.i18n-10448.test.tsx and inspectors/HookDefaultInspector.flag.i18n-10448.test.tsx. Each has three cases:

  • a non-vacuity guard: the zh row is not the key, not the en row, and opens with a full-width bracket;
  • a zh case: the RENDERED text is the value followed directly by the catalogue's zh flag. FlowReferenceField mounts an I18nProvider in zh. HookDefaultInspector passes locale and waits for the object catalog to answer first;
  • an en control: the pre-fix literal, byte for byte.

Red on base 111fa4c94 (only the two new test files added): Tests 4 failed | 2 passed (6). The 2 passes are the en controls. The FlowReferenceField zh case failed with Received: "sales_manager (invalid)". The Hook zh case found no checkbox with the zh-flagged name; the checkbox on screen was named ghost_object (not published). Both guards were red (the key was echoed).

Green on head e337f8c1e: those two files, the objectui#9652 flag suite and the seven existing FlowReferenceField / HookDefaultInspector suites gave Test Files 10 passed (10) and Tests 75 passed (75).

Ablation on the committed head. The catalogue rows stayed; only the site went back to its English literal. It ran through ablation-replace.mjs, which reported: anchor 1 to 0, blob changed, restored blob equal to HEAD, git diff HEAD empty.

  • FlowReferenceField: Expected: "sales_manager(无效)", Received: "sales_manager (invalid)", Tests 1 failed | 2 passed (3).
  • HookDefaultInspector: no checkbox named ghost_object(未发布); the rendered name was ghost_object (not published). Tests 1 failed | 2 passed (3).

Local verification (head e337f8c1e)

  • pnpm --filter @object-ui/app-shell type-check (tsc --noEmit && tsc -p tsconfig.test.json), after building the @object-ui/app-shell^... closure: VERDICT command-exit 0. tsc -p tsconfig.test.json --listFiles lists both new test files.
  • Tests, narrowed and declared. The full packages/app-shell/ run did not finish inside the foreground cap (killed at 570 s, exit 124), so it is NOT MEASURED locally; CI runs it. The narrowed set had 117 files: the whole metadata-admin/inspectors/ directory; every test file outside it that names FlowReferenceField, HookDefaultInspector, FlowObjectListField, FlowNodeConfigField, ReferenceCombobox or default-inspector-registry; every test naming metadata-admin/i18n; the metadata-admin i18n suites; and the four scripts/__tests__/check-i18n-* suites. Result: Test Files 117 passed (117), Tests 1614 passed | 1 skipped (1615).
  • Gates, each exit 0: check-changeset-presence (5 source files of 1 released package, 1 changeset); check:new-line-citations (VERDICT new-cross-file-line-citations: 0 new citation(s)); check:control-bytes OK; check:i18n-keys; check:i18n-drift (0 en values changed, 2 keys added); check:i18n-designer-parity (every en row has a zh row with the same placeholders); check:i18n-dead-keys; check:vi-mock-specifiers / -inherit / -override-shape OK; check:test-path-roots OK; check:changeset-claims (report-only: 3 pending changesets name i18n.ts, and all three still hold); check:pending-changeset-literals; check-changeset-no-major; check:designer-field-key-parity; check-type-check-coverage; check:unreferenced-sources.
  • check:eager-locale-catalogues: PREREQUISITE NOT MET (it reads a built console bundle), so NOT MEASURED.
  • eslint on the five changed ts/tsx files (--no-inline-config, JSON output): 5 files, 0 errors, 10 warnings. All 10 are in FlowReferenceField.tsx and on lines this PR does not touch; the base blob of that file also gives 10. HookDefaultInspector.tsx gives 0 on base and on head. eslint.config.js sets no parserOptions, so linting is not type-aware and this diff cannot move the verdict on any untouched file.

Acceptance notes

  • Out of scope, handed to the seat, not changed here: HookDefaultInspector's object picker flags a selected object (not published) while the object catalog is still loading, and again after that load fails, with no failure notice. A probe of the real component with the metadata client's list pending, and then rejected, rendered a checkbox named account (not published) both times. This is the same class as objectui#8862 / objectui#9651 (the in-flight and failed roster for ViewColumnInspector). This PR's Hook pin waits for the catalog to answer, so it does not pin that behaviour in either direction.
  • Out of scope: both inspectors still render other hard-coded English under zh, for example All objects (*), Pick at least one object (or All objects)., Select at least one event. and the manager cell's Resolved automatically. A zh-CN probe confirmed all four.

Generated by Claude Code

… designer's locale

FlowReferenceField's org-membership-level select flagged a stored tier
outside its vocabulary with a hard-coded `(invalid)`, and
HookDefaultInspector's object picker flagged a selected object missing
from the live catalog with a hard-coded `(not published)`. Both now go
through `flagUnknownValue` with two new designer-catalogue rows,
`engine.form.invalid` and `engine.form.notPublished` (en and zh), beside
`engine.form.notFound` / `engine.form.deprecated`. en-US is unchanged.

ReferenceCombobox has no locale prop and reads `useMetadataLocale()`;
HookDefaultInspector uses the `locale` prop it already receives.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
@github-actions

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 3 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/6310-designer-formula-key-retired.md

  • names packages/app-shell/src/views/metadata-admin/i18n.ts → packages/app-shell/src/views/metadata-admin/i18n.ts — edited by this change

    Not touched: designer.field.formula ('Formula (CEL)') in packages/app-shell/src/views/metadata-admin/i18n.ts, a different and live key belonging to metadata-admin's ObjectFieldInspector — the surface that still authors formula expressions.

.changeset/7125-dashboard-empty-state-keys-retired.md

  • names packages/app-shell/src/views/metadata-admin/i18n.ts → packages/app-shell/src/views/metadata-admin/i18n.ts — edited by this change

    Not touched: table.noRows ('No rows to display') and engine.form.noRows (packages/app-shell/src/views/metadata-admin/i18n.ts, read at widgets.tsx) — two different, same-named keys in different namespaces. Nor the comments in WidgetEmptyState.tsx, DatasetWidget.tsx, ObjectDataTable.tsx and PivotTable.tsx that record WHY three widgets with three strings became one shared empty state; the packs' own comment keeps that rationale and now names the retirement instead of a row that is gone.

.changeset/8632-malformed-picklist-option-loud.md

  • names views/metadata-admin/i18n.ts → packages/app-shell/src/views/metadata-admin/i18n.ts — edited by this change

    Two new strings land in the designer's own en / zh tables — the metadata-admin console owns its strings in views/metadata-admin/i18n.ts and is deliberately outside the ten locale packs (packages/i18n/README.md, "Scope — the engine.* carve-out").

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 2ad36717b (merge-base with origin/main): 5 file(s) changed outside .changeset/, read against 1439 pending declaration(s) that publish a body (2021 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3046.3 KB 3104.5 KB
Main entry chunk (gzip) 147.8 KB 350 KB
Entry file index-Cw_-VrQO.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.68KB 6.20KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 545.50KB 130.49KB
core (index.js) 9.22KB 3.71KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 223.91KB 62.28KB
fields (index.js) 257.41KB 65.16KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.28KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.38KB 14.60KB
plugin-charts (index.js) 74.95KB 20.88KB
plugin-chatbot (index.js) 198.36KB 47.20KB
plugin-dashboard (index.js) 133.50KB 35.37KB
plugin-designer (index.js) 216.25KB 44.39KB
plugin-detail (index.js) 232.25KB 61.40KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 146.50KB 37.51KB
plugin-gantt (index.js) 169.64KB 41.92KB
plugin-grid (index.js) 215.37KB 58.92KB
plugin-kanban (index.js) 49.30KB 15.39KB
plugin-list (index.js) 114.55KB 28.29KB
plugin-map (index.js) 23.82KB 7.42KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.55KB 11.99KB
plugin-timeline (index.js) 30.64KB 8.94KB
plugin-tree (index.js) 10.52KB 3.69KB
plugin-view (index.js) 87.31KB 21.78KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 114.58KB 37.60KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.03KB 1.86KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.78KB 2.56KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: e337f8c1e1d7bee087edab81f60700f62ef4b334

Read: card #10448 body plus 3 comments (triage 5827608071, Claim 5828735025, os-dev-report 5829371758); PR #10551 body and 6-file list; precedent PR #10445 body and 8-file list; git diff 111fa4c94..e337f8c1e (6 files, +210/-4, one commit); git rev-parse refs/review/pr-10551 = head, confirmed. Checkout untouched (git status --porcelain = 0 lines throughout). No tests or gates re-run.

① Derived judgments

  • en byte-identical: yes, at both sites. flagUnknownValue (_shared.tsx:330) is tFormat('engine.form.flaggedValue', locale, { value, flag }); tFormat (i18n.ts:4707) substitutes {name} holes with a replacer function (no $ re-interpretation). EN template '{value} {flag}' (i18n.ts:1017) with (invalid) / (not published) yields exactly sales_manager (invalid) and ghost_object (not published), one ASCII space, matching the base literals at FlowReferenceField.tsx:703 and HookDefaultInspector.tsx:134 (both still present on current main). Both en pins are literals (toBe('sales_manager (invalid)'), getByRole('checkbox', { name: 'ghost_object (not published)' })).
  • zh rows follow the catalogue's block: yes. engine.form.invalid = (无效), engine.form.notPublished = (未发布): bare suffixes, full-width open bracket, no space (ZH template is '{value}{flag}' at i18n.ts:2997, so flaggedValue owns the gap). Words are the catalogue's own (engine.list.invalid = 无效 at :2230, engine.studio.unpublished = 未发布 at :3570). Placement: EN hunk at :1010 directly after engine.form.deprecated, before flaggedValue; ZH hunk at :2988 likewise. Parity: 2 EN rows, 2 ZH rows, same keys.
  • Locale sourcing: correct. ReferenceCombobox calls useMetadataLocale() at :620, unconditionally and before every early return (hook order safe); this mirrors FlowObjectListField.tsx:134 from fix(app-shell): the designer's unknown-value flags read in the designer's locale (objectui#9652) #10445. useMetadataLocale maps useObjectTranslation().language to 'zh-CN' | 'en-US'; with no provider language falls to 'en' (provider.tsx, context?.language || i18n.language || 'en'), so the existing provider-less en suites (FlowReferenceField.lookup, .membershipTier, which assert sales_manager (invalid)) keep rendering en. HookDefaultInspector uses its locale: SupportedLocale prop (required, default-inspector-registry.ts:59), the same source its tr callback already reads. pickerOptions deps are [objectOptions, objectNames, locale]: locale is a string primitive, tr is not in the list (AGENTS.md [WIP] Enhance every detail of the designer #10 satisfied). t() is a pure table lookup with no state, so no render loop. Note, pre-existing and not this PR's doing: objectNames is a fresh array from readObjects each render, so the memo re-derives every render anyway; harmless.
  • Pins: red on base for the right reason. Each file has a non-vacuity guard (zh not.toBe(key), not.toBe(en), startsWith('(')) plus a zh case reading the RENDERED text and an en literal control, the same shape as unknownValueFlag.i18n-9652.test.tsx:90-93. The dev's reported base run (4 failed | 2 passed, zh received sales_manager (invalid), Hook checkbox named ghost_object (not published), guards red on echoed key) is consistent with the base source and with the assertions; the per-site ablation results (1 failed | 2 passed each, expected zh vs received en) match what reverting only the site while keeping the rows would produce. Not re-run here.
  • Hunk-disjointness: holds, but the PR body's framing is stale. feat(app-shell): an assignment value can be written as a CEL expression envelope beside {token} text #10509 merged 07:43Z and feat(app-shell): valueDomain select for text fields in the Object Field inspector #10527 merged 07:56Z, both before this PR was created (08:26:54Z), so they are no longer "open PRs"; their i18n.ts hunks are now on main (EN :404 and :1486, ZH :2370 and :3460; git diff 111fa4c94..main -- i18n.ts = 12 insertions, 4 hunks) and are disjoint from this PR's EN :1010 / ZH :2988. Main has 13 commits since the merge-base; only i18n.ts moved among the four relevant files; GitHub reports mergeable: true, state behind. Current open list = 11 PRs; the other 10 (file lists via REST, and changeset-release/main chore: release packages #5400 via git diff, 1732 files) touch neither metadata-admin/i18n.ts, the two inspectors, nor _shared.tsx: 0 hits.

② Semver level

'@object-ui/app-shell': patch is right. Two display strings move onto the catalogue; no export, schema, prop or accept-set change (the only new identifiers are two catalogue keys; flagUnknownValue already existed). app-shell is in the single 40-package fixed group; AGENTS.md §9 requires a changeset for any src/ change in a released package and forbids major; Changeset Declaration, Changeset Bump Policy, Changeset Fixed Group Check and Changeset Claim Re-read all success. The changeset prose is true against the diff (rows beside notFound/deprecated, en unchanged, useMetadataLocale() for the tier select, existing locale for the Hook inspector).

③ Boundary flags

  • CI state (three reads, last one final): 42 check-runs on the head; 32 success, 3 skipped (coverage jobs, dependabot), 0 failures, 7 still in_progress: Test (shard 1/8), (2/8), (3/8), (5/8), (6/8), Type Check, Spec Main Shape Gate. Lint, Test (shard 4/8), (8/8), Test (dist pins), Build & E2E completed green. The full app-shell vitest run was declared NOT MEASURED locally (foreground cap), so the running shards are the only full-suite evidence; they must finish green before landing.
  • Out-of-scope finding 1 (roster in flight flags every object): real at source. useObjectOptions starts with options: [], loading: true, and its catch sets []; HookDefaultInspector discards loading and flags every selected name absent from the (empty) roster. Same family as the ViewColumnInspector.rosterPending / rosterFailure tests (finding(app-shell): a valid stored value is flagged "(not in object)" while its option roster is still loading — the primitive cannot tell an empty roster from an unanswered one #8862). Not made worse by this PR: the only change is which words the flag carries; the new Hook pin awaits the roster answer, so it pins neither direction of that behaviour.
  • Out-of-scope finding 2 (more hard-coded English): real at source on head: SectionHeader title="Basics", label="Label", placeholder="Human-readable name", No objects found — publish an object… in HookDefaultInspector.tsx; placeholder="Resolved automatically" and the manager/queue hint sentences in FlowReferenceField.tsx. Outside this card's flag-only scope.
  • PR assignee unset: confirmed (assignees: []); the dev's write was refused. The PR is also still a draft. Both are the seat's to finish.
  • Prose staleness, not a defect: the PR body and the Claim say "hunk-disjoint from the open PRs objectui#10509 and objectui#10527"; both had merged before the PR opened. The disjointness claim itself is true against main.
  • Nothing in the diff should stop landing.

Implemented-by: claude/issue-10448-designer-flags-i18n
Reviewed-by: session_014mXUNuFomfj24w7s1pZzhN

VERDICT: PASS


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review September 25, 2026 08:41
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit f94cfa5 Sep 25, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-10448-designer-flags-i18n branch September 25, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant