Skip to content

fix(plugin-form,components): master-detail edit lines and element:record_picker options re-read on the data-invalidation bus (objectui#10853) - #10873

Merged
objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/issue-10853-master-detail-picker-bus-readers
Sep 28, 2026
Merged

objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/issue-10853-master-detail-picker-bus-readers

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #10853
Clause-②: no — two readers subscribe to the existing invalidation bus; no declared key, export or accept set moves.

This is the fifth batch of bus readers under decision B on objectui#10519 ("readers first"). After PR objectui#10777 removes PageView's remount, these two blocks would otherwise keep showing data from before a page action. objectui#10519 remains open.

Dispatched by the domain:ui seat 4 PM (claim comment 5860833997, triage 5860720827). Session: https://claude.ai/code/session_01MCg3z5cGrV51xEddpGcxEY. In mode:subagent that id is also this run's. Branch claude/issue-10853-master-detail-picker-bus-readers was cut from origin/main a7fd877 (BASE). Head is a13048c, after one patch round on the contract review of ac526b1 (see Patch round below).

What changed

Each read now takes a nonce from the data-invalidation bus for the object it queries. This follows the objectui#10623 / objectui#10778 shape: the same bus, the same matcher (dataChangeMatches), no second channel and no remount.

  • packages/plugin-form/src/MasterDetailForm.tsx, edit mode. Each detail collection's find of its child object now re-reads when the bus reports a change to that child object, or '*'. The re-read happens in place, and the rows and the save baseline move together.

    • The collections are authored, so their number is not fixed, and one useDataInvalidation call per object cannot be made. A local useObjectsInvalidation(names) subscribes through subscribeDataChanges, the listener set useDataInvalidation itself uses. It tests each change with dataChangeMatches at object level and keys on the set's content.
    • Nothing new is exported. The claim's Clause-②: no holds.
    • The load now runs one collection at a time: a per-collection read number, plus a generation the load effect's teardown bumps. So the load on mount, a record change, a bus re-read and a replay each commit only if they are that collection's latest read.
    • A collection only re-reads for its own child object. The header re-reads through its own ObjectForm (objectui#10572), which is unchanged.
    • The row editor ("Open row") holds its collection's re-read while it is open (patch round).
  • packages/components/src/renderers/basic/record-picker.tsx. The option read's effect now names useDataInvalidation(object), subscribed only when the adapter reads and the object has resolved. A read of exactly the query whose options are already on screen (same adapter, object, filter, sort and limit) runs in place:

    • there is no setLoading(true), so the control stays enabled and shows no "Loading…";
    • the answer swaps the options when it lands and clears an earlier failure;
    • the bound page variable is never written.

    Any other read starts from "Loading…", as before. The placeholder input's description now says so ("while it reads a new set of options"). That is a text change only; the input's type is unchanged.

  • object-form with subforms routes to the same MasterDetailForm, so the same reader covers it. This is pinned. The spec refuses subforms on object-form, so this does not gate (triage note 5).

  • .changeset/10853-master-detail-picker-bus-readers.md: @object-ui/plugin-form patch and @object-ui/components patch.

  • .changeset/10778-dashboard-bus-readers.md: one appended dated note in the objectui#10533 form (triage note 4). It says the drillDown.report drawer does re-read since objectui#10814 (PR objectui#10836), and points at drillDownReport.invalidationRefetch-10814.test.tsx. The single-record drawer half of that sentence still holds. The frontmatter is byte-identical: md5 of lines 1-3 is d527064c725ab089f1c5e8f4c419e8cd before and after, and check-changeset-overwrite.mjs reports the declared bump unchanged (@object-ui/plugin-dashboard: patch).

Unsaved lines (B3): held, then replayed after a save or a revert

This is the objectui#10712 R3 / objectui#10572 rule, applied to each collection separately.

  • Unsaved means the edit save's row diff (buildMasterDetailEditBatch) finds something to write to that collection other than the parent link. A user's edit therefore reads as unsaved exactly when the save would send it, and a line changed back to its stored value reads as saved again.

    • The parent link is set aside on purpose, and it is the one place the two disagree. The save restates the link on every row it writes, as the parent id in string form. Against a backend that returns the link as a number or an expanded lookup, the save restates it on every row while the lines read as saved. That restatement is not user input, so it does not hold a re-read. sendBatch is unchanged.
  • An open row editor counts as unsaved for its collection (patch round). The editor keeps its draft in its own form, not in the rows, so the rows alone cannot show it.

  • A held bus re-read is replayed once, when the row editor is closed (Apply or Close) and either:

    • revert: the collection's lines read as saved again; or
    • save: this form's save has landed. sendBatch marks every collection the batch wrote, and the replay runs once the save guard releases.

    After Apply the applied line is unsaved, so the re-read stays held until that line is saved or changed back.

  • A line typed while a re-read is in flight is kept, in the grid or in the row editor.

    • The answer only commits over the same rows the read was issued over, and never while the row editor is open on that collection. That check sits both before and inside the setRowState updater.
    • Otherwise the re-read is held behind the edit.
    • Unlike LineItemsPanel, the grid is not disabled during a re-read, and the row editor is never reset, re-keyed or disabled by one. Only a save disables it, as before.
  • A failed re-read keeps the lines on screen and warns. A failed load still leaves the collection empty, as before.

    • A bus event during the FIRST load supersedes that load. If that re-read then fails, the warning now says "no lines have been read for it yet" instead of "the lines on screen are kept" (patch round, a one-line change).

The picker's bound value (B4)

  • A re-read never writes the page variable.
  • If the bound record is no longer among the re-read options, the variable keeps its value and the trigger shows no label. It shows neither the old label nor the placeholder: Radix draws the placeholder only for an empty value, and no offered item carries the value. This is the same thing the picker has always shown for a value outside its options, for example one beyond limit.
  • When a later read offers that record again, its label returns.

All of this is pinned.

Patch round (contract review of ac526b1: FAIL)

The review (comment 5861421338) found one defect, and it is verified: with the row editor open on a line, a bus event committed fresh row copies under it. expandedRow then changed, and the editor's inline initialData reset overwrote the draft.

  • Measured at ac526b1 with the new pins: the draft read 'first (server)' where the user had typed 'first (draft)'.
  • When the server dropped the line, the editor was reset to its neighbour ('second'), so a later Apply would have mapped onto that row.

What changed in the fix:

  • MasterDetailForm.tsx: the expanded state moves above the lines reader. A render-time rowEditorEntryRef (the same pattern as rowStateRef) names the collection the editor is open on, and three places read it:
    • the hold decision counts that collection as unsaved;
    • both in-flight commit sites hold instead of committing while it is open;
    • the replay effect skips it while it is open and runs again when expanded changes.
  • The failed re-read warning is now accurate for a collection that never loaded.
  • linesUnsaved's doc, the changeset and this body now claim only what holds about the parent link.
  • The changeset sentence about a line typed in flight now names both the grid and the row editor, and says an open editor is never reset by a re-read.
  • Two pending changesets re-read against this diff, per the changeset-claim-re-read bot. Both hold, and neither is edited:
    • .changeset/6726-find-envelope-records-arms.md: its row "element:record_picker options" still describes the picker, whose read is still res?.data ?? (Array.isArray(res) ? res : []). A { records } answer still reads as no rows, on a first read and on a re-read.
    • .changeset/6783-readprops-degenerate-config-bag.md: the picker still reads its bag through readProps, which this diff does not touch.

Mechanism assumptions, measured

  • B1 (templates). I read both merged diffs.

    • PR objectui#10836: LineItemsPanel holds edits and keeps the grid drawn with refreshing.
    • PR objectui#10837: DatasetWidget / DashboardRenderer, one reader per widget component.

    I reused the seam. The picker needed the in-place path because its re-read flipped loading. The master-detail lines needed no refreshing state: at BASE their edit-mode read had no loading branch, so a re-read never blanked them.

  • B2 (sites re-read 0 times at BASE). Confirmed with an uncommitted scratch probe on BASE a7fd877: the real SchemaRenderer, real registrations, one notifyDataChanged({ objectName: '*' }), and a bare useDataInvalidation reader as the lit control. Results, counted as reads on mount → reads after the event:

    site before → after
    detail lines (find of po_line) 2 → 2
    header (findOne) 1 → 2
    picker options 1 → 1
    control nonce 1

    Mount reads the lines twice because the load effect runs again once the resolved details are set. That is unchanged, and the pins count from rest.

  • B3 / B4. See the two sections above.

Pins and ablation

  • The pins. MasterDetailForm.busReread-10853.test.tsx (12 tests: 8, plus 4 for the row editor) and record-picker.busReread-10853.test.tsx (4 tests) render through the real SchemaRenderer and the packages' own registrations. The master-detail pins use the real line-item grid; the picker pins sit in a real PageVariablesProvider with a variable bound to the picker. A bare useDataInvalidation reader is the lit control, and reads can be held open to look at the block mid-flight.
  • What they cover.
    • '*' re-reads once in place: the same input node, no blanking. A save afterwards writes no line, so the baseline moved.
    • A child-object event re-reads; an unrelated object does not.
    • Two collections each answer only to their own object.
    • Held then revert; held then save (exactly one replay each).
    • A line typed in flight is kept.
    • Row editor, through the real form ("Open row", type into its fields):
      • a bus event rewrites the line: the draft is intact, Apply writes that line, the save sends update l1 { label, memo }, and the held re-read replays once after the save;
      • the server drops the line: the draft is intact, and Apply and the save target l1, not its neighbour;
      • Close without Apply replays the held re-read once;
      • a re-read already in flight when the editor opens does not commit under it, and replays once on close.
    • The subforms route re-reads.
    • Picker: in place with the value kept; its own object versus an unrelated one; the bound record gone and then back.
    • Controls: create mode and a picker with no object read nothing.
leg mutation (on-disk proof) result
head ee5c87d none Tests 12 passed (12)
A1, reverse both source files checked out at BASE under the committed pins (trap restore); blobs 157fa2762a / b5217ead2d == BASE; reader hits linesBusNonces 0, invalidationNonce 0 Tests 10 failed, 2 passed (12). Every red is a read-count miss (expected 2 to be 3, expected "vi.fn()" to be called 2 times, but got 1 times); the 2 green are the two controls. Restored with git checkout HEAD -- ABSOLUTE_PATH: blobs bc3724ddf8 / d11d0e1fcc == HEAD, git diff HEAD 0 bytes
A2, ablation ablation-replace.mjs (objectstack origin/main): if (unsavedLines(entry)) { → if (false) {, anchor 1 → 0, blob bc3724ddf8 → 9347b55e8e Tests 3 failed, 5 passed (8): exactly the three hold cases ("a bus re-read ran over unsaved lines" ×2, "re-read again over the unsaved line"). Restored by the tool: blob == HEAD, git diff HEAD empty
A3, ablation same tool: the picker's const inPlace = …signature; → const inPlace = false;, anchor 1 → 0, blob d11d0e1fcc → 4fb57ece38 Tests 1 failed, 3 passed (4): exactly "the re-read disabled the picker". Restored by the tool: blob == HEAD, git diff HEAD empty
A4, reverse (patch round) MasterDetailForm.tsx checked out at ac526b1 under the committed pins at ea52c79 (trap restore); blob c4a5fdc81c == ac526b1; rowEditorEntryRef hits 0 Tests 4 failed, 8 passed (12): all four editor cases, each on the draft (expected 'first (server)' to be 'first (draft)' ×3; expected 'second' to be 'first (draft)'). Restored: blob d147657e95 == HEAD, git diff HEAD 0 bytes
A5, ablation (head a13048c) same tool: rowEditorEntryRef.current === entry.id || → false || (the hold decision), anchor 1 → 0, blob 1a74a580d7 → b2dda3c6ba Tests 3 failed, 9 passed (12): the three editor cases, on "a bus re-read ran under an open row editor". The draft stays intact there because the commit guard still holds. Restored by the tool
A6, ablation (head a13048c) both in-flight commit sites at once, by a scripted replace with anchor counts 1/1 → 0/0 and a trap restore; blob 1a74a580d7 → 4fc16f6691 Tests 1 failed, 11 passed (12): exactly "the in-flight re-read reset the editor’s draft". Restored: blob == HEAD, git diff HEAD 0 bytes

Two ablation attempts in the patch round, reported as they happened:

  • The first A5 attempt, at ea52c79, crashed the worker (Worker exited unexpectedly) instead of failing. At that head the commit guard held by re-asking, and with the hold decision ablated the re-ask looped. The shipped code cannot loop, because both checks read the same ref, but a13048c makes the guard hold directly so the two checks no longer depend on each other. A5 was then re-run cleanly (above).
  • Ablating only the outer commit site stayed green (Tests 12 passed): the updater site alone covers it. That is why A6 mutates both sites.

No dist/ preflight applies: each pin imports its package's registration through a relative source path, and both mutated files are reached through it.

Gates

Pinned to head a13048c unless marked. packages/components is byte-identical since ee5c87d: git diff ee5c87d a13048c -- packages/components is empty, so its runs at ee5c87d stand.

  • turbo run build --concurrency=2 --filter=@object-ui/plugin-form^... (Tasks: 11 successful), then pnpm --filter @object-ui/plugin-form type-check: script echoed, VERDICT command-exit 0. --listFiles counts the pin in tsconfig.test.json: 1.
  • pnpm exec vitest run --maxWorkers=2 packages/plugin-form/ packages/components/src/renderers/basic/__tests__/record-picker.busReread-10853.test.tsx: Test Files 137 passed (137), Tests 1597 passed | 1 skipped (1598), VERDICT command-exit 0.
  • At ee5c87d:
    • pnpm --filter @object-ui/components type-check: exit 0.
    • packages/components/ in 3 shards, all VERDICT command-exit 0: 108 files / 1039 tests passed; 107 files / 1212 passed + 10 skipped; 106 files passed + 1 skipped / 887 passed + 7 skipped.
    • Importers that render these blocks (the 10 files listed in the first round): Tests 1166 passed (1166).
  • Lint, narrowed and measured, at a13048c:
    • eslint --format json over MasterDetailForm.tsx and its pin read 2 files: 0 errors / 23 warnings and 0 / 6. MasterDetailForm.tsx is 0 / 23 as at ac526b1 (BASE 0 / 25); with --no-inline-config it is 0 / 29 (exhaustive-deps 6, the file's existing disables).
    • record-picker.tsx is unchanged since ee5c87d (0 / 10 = BASE).
    • eslint.config.js is not type-aware, so this diff moves no verdict in an untouched file.
  • Script gates at a13048c, all exit 0:
    • check:new-line-citations: VERDICT … 0 new citation(s).
    • check:control-bytes: OK. A self-scan of the changed files found no control byte.
    • check:test-path-roots, check:vi-mock-specifiers, check:vi-mock-inherit, check:unreferenced-sources, check:element-data-source-declaration: OK.
    • check:phantom-deps, check:changeset-claims, check:pending-changeset-literals: ✅.
    • scripts/check-changeset-presence.mjs ✅, scripts/check-changeset-no-major.mjs ✅, scripts/check-changeset-fixed.mjs ✅, scripts/check-type-check-coverage.mjs ✅.
    • scripts/check-changeset-overwrite.mjs (report-only): 1 added, 1 modified; the 10778 note, case 2.
  • NOT MEASURED: check:sdui-registration-pins. Reason: it exits 2 without a console build. This diff changes no registration and no sideEffects array. CI builds the console.
  • CI owns the repo-wide lint and the full test run.

Serial

  • git merge-tree --write-tree HEAD at a13048c against a fresh origin/main (e32dae1, fetched into a private ref, since deleted): clean. No commit on main since BASE touches these three files.
  • PageView is not touched (PR objectui#10777, seat 2).

Acceptance notes

Not changed here. Each was read at source unless it says it was measured.

  • The lines subscribe to each collection's child object only. A write declared on the PARENT object, for example a record action that rewrites lines on the server and announces the parent, re-reads the header but not the lines. '*', which PageView will send, does both. This is the same boundary LineItemsPanel has.
  • Measured at BASE and unchanged: the edit-mode lines are read twice on mount. The load effect runs again when the resolved details are first set, even when nothing needed resolving, and the first read is superseded. Carrier: none.
  • Unchanged: a failed first load of a collection's lines still leaves it empty with no message. Only the new re-read path keeps the lines and warns. Carrier: none.
  • The picker's in-place re-read that fails shows "Failed to load" and disables the control, the same as a failed first load. The options it had stay in state and come back with the next read that lands.
  • With the console's mutation bridge mounted, the save's own batch echoes on the bus while its collections still read unsaved. By the ordering read at source, that echo is held and replayed once after the save, so there is one extra read per written collection, in place. The pins' adapter has no onMutation, so this is not pinned.
  • element:record_picker's emptyText input description cites a line address, :213 read at a7fd877, for the "No records" default. At a7fd877 that line is inside a comment block, not the default. This is a stale same-file line address in published registry text, outside this card's class, so it is not repaired here. Carrier: none.

Generated by Claude Code

…er options re-read on the data-invalidation bus (objectui#10853)

An edit-mode object-master-detail-form reads the bus for each detail
collection's child object and re-reads that collection's lines in place;
unsaved lines hold the re-read, replayed once after a revert or after the
save lands. element:record_picker's option read names the nonce for its
object; a re-read of the same query stays enabled over the options on screen
and never touches the bound page variable.

Also appends a dated note to the pending 10778 changeset: the drillDown.report
drawer does re-read since objectui#10814.

Claude-Session: https://claude.ai/code/session_01MCg3z5cGrV51xEddpGcxEY
Co-authored-by: Claude <noreply@anthropic.com>
…ting row and child-schema types (objectui#10853)

No behaviour change: the two annotations the reader added use `RowState['rows']`
and `ChildSchema` instead of `any`, and an unused lint directive is dropped.

Claude-Session: https://claude.ai/code/session_01MCg3z5cGrV51xEddpGcxEY
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 1 address(es) in this pull request's own prose name a tree it replaced

Each was read from a tree this change itself moves, so a reader who follows it lands somewhere else. ⛔ Nothing here blocks and nothing here says the sentence is false — the question asked is arithmetic: does this diff move the line that number points at?

  • in this body, record-picker.tsx:213 — this change moves packages/components/src/renderers/basic/record-picker.tsx:213 to :245

    • element:record_picker's emptyText input description cites record-picker.tsx:213 for the "No records" default.

⛔ The repair is not to correct the number. Changing :246 to :274 is true today and born false again on the next insertion — objectui#9509 states that before anything else. Bind the number to the tree it was read from (`:246` at `b8a006883d`, `:274` at this head), which cannot re-stale because each number names its own tree; or state a rule instead of a coordinate, the way objectui#9495 replaced a file count with "every file in git diff --name-only against the merge base".

⚠️ 2 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/6726-find-envelope-records-arms.md

  • names components/src/renderers/basic/record-picker.tsx → packages/components/src/renderers/basic/record-picker.tsx — edited by this change

    | module | what it does | | --- | --- | | components/src/hooks/related-count-store.ts | related-list tab badge count | | components/src/renderers/basic/data-list.tsx | element:repeater rows | | components/src/renderers/basic/elements.tsx | element:number client-side aggregate | | components/src/renderers/basic/record-picker.tsx | element:record_picker options | | plugin-detail/src/renderers/record-activity.tsx | record:activity self-fetch | | plugin-detail/src/renderers/record-history.tsx | record:history self-fetch | | plugin-view/src/ObjectView.tsx | non-grid (kanban / calendar / gallery / timeline) fetch |

.changeset/6783-readprops-degenerate-config-bag.md

  • names record-picker.tsx → packages/components/src/renderers/basic/record-picker.tsx — edited by this change

    Five modules under packages/components/src/renderers/basic/ — elements.tsx, data-list.tsx, text-input.tsx, record-picker.tsx, metadata-viewer.tsx — each carried a copy of the same reader, { ...(schema?.props ?? {}), ...(schema?.properties ?? {}) }. ?? only replaces null/undefined, so a non-object bag went into the object spread and came back out as indexed keys: for properties: 'not-a-bag', the config bag a renderer received was { '0': 'n', '1': 'o', … '8': 'g' } — nine keys nobody authored. The five copies are now one readProps (renderers/basic/readProps.ts) that asks isConfigBag, and a degenerate bag on either side contributes no keys.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with fab627ff9 (merge-base with origin/main): 4 file(s) changed outside .changeset/, read against 1643 pending declaration(s) that publish a body (2233 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3083.2 KB 3104.5 KB
Main entry chunk (gzip) 148.5 KB 350 KB
Entry file index-COyRhQrg.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.57KB 6.15KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.17KB 10.58KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 557.59KB 133.61KB
core (index.js) 9.93KB 3.94KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 225.01KB 62.50KB
fields (index.js) 261.26KB 66.37KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.28KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.73KB 14.72KB
plugin-charts (index.js) 83.99KB 22.86KB
plugin-chatbot (index.js) 197.67KB 46.90KB
plugin-dashboard (index.js) 136.82KB 36.44KB
plugin-designer (index.js) 216.42KB 44.47KB
plugin-detail (index.js) 233.48KB 61.79KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 160.95KB 41.33KB
plugin-gantt (index.js) 169.83KB 41.99KB
plugin-grid (index.js) 218.66KB 59.90KB
plugin-kanban (index.js) 48.43KB 15.11KB
plugin-list (index.js) 114.78KB 28.44KB
plugin-map (index.js) 22.90KB 7.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.17KB 12.20KB
plugin-timeline (index.js) 31.00KB 9.09KB
plugin-tree (index.js) 11.21KB 3.89KB
plugin-view (index.js) 87.86KB 22.02KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 119.16KB 39.05KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.03KB 1.86KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 7.50KB 3.05KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 6.16KB 2.71KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 3.52KB 1.36KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.26KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.27KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: 229/229 CONTRACT_REVIEW_TIER
Head-sha: ac526b1a299586395c3e4504b6f19328566f5cc5

Read: card objectui#10853 body and its three comments (triage 5860720827, claim 5860833997; the os-dev-report 5861273028 treated as claims only); the objectui#10519 decision 5830213285; merged PR objectui#10836 and objectui#10837 diffs (via the API); PR #10873 body, file list (6 files) and its diff against the merge-base a7fd877c (origin/main is fab627ff; the PR is 2 commits ee5c87d, ac526b1); at the head: packages/react/src/data-invalidation.ts, packages/plugin-form/src/MasterDetailForm.tsx (head and base), masterDetailTx.ts, sanitize.ts (changedFields, isSameStoredValue), ObjectForm.tsx (routesToMasterDetail, the record-fetch effect, useRecordInvalidation), initialRecord.ts, packages/components/src/renderers/form/form.tsx (the defaultValues layout-effect reset), packages/fields/src/widgets/GridField.tsx (ghost row, per-keystroke onChange), SelectField.tsx, renderers/form/select.tsx, record-picker.tsx (head and base line 213), plugin-dashboard DrillDownDrawer.tsx, ObjectDataTable.tsx, RecordDetailDrawer.tsx; both pin files; AGENTS.md §5 and §9; .changeset/config.json; .changeset/10778-dashboard-bus-readers.md at base and head; .changeset/10853-master-detail-picker-bus-readers.md; every pending changeset naming the touched files (grep for sentences about loading, in-flight input, baseline, slots); packages/components/package.json and packages/plugin-form/package.json (exports, files); the head's check-runs twice. Ran the two pin files once at the head in my own throwaway worktree under os-verify-lock.sh (slot review-10873): Test Files 2 passed (2), Tests 12 passed (12); the worktree was clean and is removed.

① Derived judgments

1. One bus, not a second channel — RIGHT. useObjectsInvalidation(names) subscribes through subscribeDataChanges, which adds to the same module-level listeners Set that useDataInvalidation subscribes through; it tests each change with dataChangeMatches(change, name) with no recordId, which is exactly what useDataInvalidation(name) does (its first line returns true for '*'; both compare change.objectName with strict equality, neither normalises names). It subscribes only when the set is non-empty, mirroring if (!objectName) return; the effect cleanup unsubscribes on unmount and on every namesKey change; it is one unconditional hook call with fixed inner hooks (useState, useEffect), keyed on the set's content (JSON.stringify of the sorted unique names), so a fresh array of the same names neither resubscribes nor resets a nonce, and a nonce survives a set change the way useDataInvalidation keeps its nonce across an objectName change. Nothing is exported. No divergence in substance; the only difference is that nonces for names no longer authored stay in the state object, which nothing reads. Reuse of useDataInvalidation was possible (one child component per detail collection, reporting its nonce up), but the triage's "no second channel" reads as no other event mechanism (a window event, a refreshKey, a relay), and this is a composition of the bus's own exported primitives.

2. Held dirty lines — WRONG on one path; the traced paths otherwise hold.

  • Traced and holding: a 'bus' read over a collection that linesUnsaved reads as dirty is added to heldLinesRereadRef and not issued; the replay effect (keyed on rowState, saving) replays a held entry once its lines read clean again (held.delete before readLines(e, 'replay'), so once), and after a save through linesSavedRef (marked in sendBatch after childRowsAfterSave; the replay effect returns before clearing that set while saving is true, so the mark survives until the guard releases). A line typed in the grid while a read is in flight changes rowState.rows identity (GridField's cells call onChange per keystroke), the commit is refused against rowsAtIssue both before and inside the setRowState updater, and the read is re-asked as 'bus', which holds it. One commit per collection: a per-collection seq plus a gen the load effect's teardown bumps supersede every older read. Every commit writes rows and original together, and the save's baseline advance (childRowsAfterSave) is unchanged, so I found no sequence that leaves a stale baseline or applies one answer twice. The pins cover hold-then-revert, hold-then-save, and typed-in-flight.
  • The defect: the row editor ("expand to full form", offered in grid mode whenever formFields outnumber columns, and always in inlineMode: 'form') holds the user's draft inside its nested ObjectForm's react-hook-form state, not in rowState, so linesUnsaved cannot see it and the collection reads clean. A bus event then commits fresh row copies (rows.map((r) → ({ ...r }))). expandedRow is rowState[entryId].rows[rowIdx], handed to the editor as an inline schema.initialData; ObjectForm's record-fetch effect lists schema.initialData in its deps and, with no recordId, calls setInitialData(resolveInitialRecord(schema)); the form renderer's defaultValues layout effect then runs form.reset(defaultValues) whenever the JSON of the defaults differs from the last one, carrying only fields absent from both the outgoing and incoming defaults. So: open the editor on a line, type, and let a page action that rewrites that line (or '*') land: the re-read commits under the open editor and the reset overwrites every drafted field the row names. If the server no longer returns the row, expandedRow becomes another row or undefined, the editor is reset to that, and a later "Apply" calls applyRowEdit(entryId, rowIdx, values), which maps by index onto whatever row now sits there, or onto nothing. The head itself treats the editor as an input surface that must be held: it wraps it in ‹fieldset disabled=saving› and the pending 10631 changeset says "An open row editor … is disabled too, 'Apply' included". The LineItemsPanel precedent has no row editor, so its refreshing grid-disable never had to cover one; this form does, and the PR's deviation (grid left enabled, identity guard on rows only) leaves that one surface unheld. Not pinned. The changeset's sentence "A line typed while a re-read is in flight is kept" is therefore true for grid cells and false for the editor's draft.
  • Initial load: the change from one Promise.all commit to one commit per collection alters the FIRST load only in that collections now render progressively (the first to answer draws before the others; base drew all at once), which nothing reads wrongly: sendBatch, sumRows and MasterDetailLines all read by the current entries' ids. Ordering is unchanged (the derive effect's setResolvedEntries still re-runs the load effect, the first run's reads now superseded by the gen bump where base cancelled them). Not pruning slots of entries no longer authored is unread by anything (all readers iterate entries). The unresolved early-return now commits an empty slot synchronously on the first run instead of inside the cancelled Promise.all; the grid shows no rows either way.

3. The picker — RIGHT. inPlace is true only when committedReadRef holds the same adapter and the same [object, filterKey, sortKey, limit] signature, and then setLoading(true) is skipped, so disabled={loading || !!error || !object} stays false and the SelectValue placeholder stays placeholder, not 'Loading…'; the ref is written only when a read commits, so a re-read after a failed first read still starts from "Loading…". binding.setValue is called only from handleChange; the effect never touches it (pinned: bound-value stays a1). Bound record gone: value is kept and Radix draws neither the old label nor the placeholder (pinned textContent ''), and the label returns when the record is offered again (pinned). Acceptable face: it is what the head's form:select renders for a value outside its authored options (Radix, no fallback), and what this picker already showed at base for a defaultValue beyond limit. The counter-example is SelectField in @object-ui/fields, which prunes a value no longer offered (isValueStillOffered → onChange(null)), but that is a cascade-clear of a record field, and triage note 2 requires the bound page variable to be kept. Registration metadata is published: packages/components/src/index.ts imports ./renderers at module scope (→ ./basic → ./record-picker), and the package's exports . points at ./dist/index.js with files: ['dist', …], so the inputs[].description string ships in the bundle. The new text is true at the head: the placeholder is replaced by 'Loading…' only when loading is set, which happens only for a read that is not in place (first read, or a changed adapter or query), and by 'Failed to load' on error, which a failed in-place re-read also sets.

4. Pins — RIGHT. MasterDetailForm.busReread-10853.test.tsx renders through the real SchemaRenderer inside SchemaRendererProvider, registers through import './index' (the package's own entry) and registerAllFields() (the real grid), fires the real notifyDataChanged, lights BusControl with useDataInvalidation('po_line'), and uses unrelated_object as the negative (plus po_note versus po_line across two collections). record-picker.busReread-10853.test.tsx renders through the real SchemaRenderer, registers through import '../../../renderers', supplies the adapter through AdapterCtx.Provider (the context useAdapter reads) inside a real PageVariablesProvider, lights a control on 'account', and uses unrelated_object as the negative. No timeout is raised anywhere (no testTimeout, no per-test timeout argument); nothing is skipped (no .skip, .only, .todo). Each re-read case asserts a read count one above rest (atRest + 1, toHaveBeenCalledTimes(2), toHaveBeenCalledTimes(3)), and the base effects carry no nonce (base picker deps [adapter, object, filterKey, sortKey, limit]; base form effect [isEdit, dataSource, schema.recordId, resolvedEntries]), so those cannot hold on base; the two controls pass on base by construction, as controls should. My single run at the head: 12 passed.

5. Prose and shape — RIGHT except the one sentence noted under 2. 10853-master-detail-picker-bus-readers.md: frontmatter patch for @object-ui/plugin-form and @object-ui/components, no major, both in the fixed group; every sentence checked at the head holds except "A line typed while a re-read is in flight is kept, and the re-read is held behind it" for the row editor's draft (item 2). One gloss is loose: "(lines the next save would write)" — linesUnsaved normalises the parent link on original, but sendBatch does not, so with a backend that returns the FK as a number or an expanded lookup the real save restates the FK on every row (base behaviour since objectui#10108) while linesUnsaved reads clean; no user input is affected by that difference. 10778-dashboard-bus-readers.md: the first 18 lines are byte-identical to base and the frontmatter md5 is d527064c725ab089f1c5e8f4c419e8cd both sides; the note's claims hold — DrillDownDrawer.tsx renders type: 'spec-report' through SchemaRenderer, PR objectui#10836's own changeset says "The spec-report a drill-down drawer opens for drillDown.report re-reads the same way", apps/console/src/__tests__/drillDownReport.invalidationRefetch-10814.test.tsx exists at the head, and the table row's single-record drawer (RecordDetailDrawer) performs no read and names no bus hook, so "still does not re-read" stands. PR body first line Fixes #10853; Clause-②: no holds (no export, index, spec key, registry input name or type moves; the picker change to registration is description text only). No pending changeset naming the touched files is made false (10564's baseline rule, 10631's in-flight guard, 10664's sort key and 6372's slot identity all still hold).

6. Out-of-scope notes — all three RIGHT. (a) Read twice on mount: at base the load effect keys on resolvedEntries, which the derive effect sets even when nothing needs deriving (if (!needsDerive) { setResolvedEntries(baseEntries); return; }), so the effect runs at mount and again on that set, the first run cancelled; unchanged at the head (superseded by the gen bump). (b) A failed first load: the head's 'load' catch sets rows = [] and warns nothing, as base's catch { return [e.id, { rows: [], original: [] }] } did; only 'bus'/'replay' warn and keep the lines. (c) emptyText's description cites record-picker.tsx:213: at base that line is inside the toText comment block and the default ?? 'No records' sits later (head line 274); a same-file address, so under the AGENTS.md #11 carve-out and not a gate finding, but stale.

② Semver level

patch for @object-ui/plugin-form and @object-ui/components is right: two renderers gain a bus subscription and an in-place re-read; no export, type, spec key or registry input shape changes; the registry description is text. No major (AGENTS.md §9 version policy).

③ Boundary flags

  • Row-editor draft (item 2): the fix shape is the seat's call — count an open editor for an entry as unsaved in unsavedLines, or hold that entry's re-read while expanded.entryId names it and disable the editor's fieldset during an in-flight re-read the way saving does — and a pin should open the editor, type, land a changed row on the bus, and assert the draft and the target row.
  • Narrow race, not a defect on its own: a bus event during the FIRST load supersedes the 'load' read (per-collection seq); if that 'bus' read then fails, its warning says the lines on screen are kept while the collection has none yet.
  • The FK-restatement gloss in the 10853 changeset and the PR body's "cannot disagree" (item 5); user input is unaffected.
  • The picker's "no label" face is base behaviour for any value outside the options; SelectField in @object-ui/fields takes the opposite policy (prune) for record fields.
  • With the console's mutation bridge, a save's own echo is held and replayed once per written collection (one extra in-place read per save), as the PR says; not pinned (the pins' adapter has no onMutation).
  • CI as read: poll 1 at 2026-09-28T00:32:40Z — 42 check-runs, 29 success, 3 skipped, 10 in progress (Lint, Skill Example Check, Spec Main Shape Gate, Test shards 1/8 to 8/8, Type Check). Poll 2 at 2026-09-28T00:45:36Z — 43 check-runs, 40 success, 3 skipped (Test (coverage shard …/4), Test (coverage), dependabot), 0 failures, 0 in progress; among the successes: Lint, Type Check, Test shards 1/8 to 8/8, Test (dist pins), Build & E2E, Changeset Declaration, Changeset Bump Policy, Changeset Fixed Group Check, Changeset Claim Re-read, Changeset Overwrite Report, Line Citation Gate, Control Byte Scan, Governed Surface Queue Guard, Spec Main Shape Gate, Bundle Analysis, Build Docs.
  • Nothing in the PR touches PageView (PR objectui#10777's file); the branch merges cleanly by the API's mergeable: true (mergeable_state: behind).

Implemented-by: claude/issue-10853-master-detail-picker-bus-readers
Reviewed-by: session_01MCg3z5cGrV51xEddpGcxEY

VERDICT: FAIL

…on's bus re-read (objectui#10853)

Contract review of ac526b1: the row editor ("Open row") keeps its draft in its
own form, not in the collection's rows, so a bus re-read committed fresh rows
under it and the editor's reset overwrote the draft (or re-pointed it at a
neighbouring row when the server dropped the line). While the editor is open on
a collection, that collection counts as unsaved for the re-read decision, a read
already in flight does not commit under it, and the held re-read replays through
the same path once the editor closes. The editor is not reset, re-keyed or
disabled by a re-read.

The failed-re-read warning names a collection that has not loaded yet
accurately, and the changeset and linesUnsaved doc claim only what holds about
the parent link.

Claude-Session: https://claude.ai/code/session_01MCg3z5cGrV51xEddpGcxEY
Co-authored-by: Claude <noreply@anthropic.com>
…w editor is held directly (objectui#10853)

The in-flight commit guard held the read by asking again, which relied on the
open editor also counting as unsaved; it now adds the collection to the held set
itself, so the two checks do not depend on each other.

Claude-Session: https://claude.ai/code/session_01MCg3z5cGrV51xEddpGcxEY
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3083.2 KB 3104.5 KB
Main entry chunk (gzip) 148.4 KB 350 KB
Entry file index-YI2Fkfxl.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.57KB 6.15KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.17KB 10.58KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 557.59KB 133.61KB
core (index.js) 9.93KB 3.94KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 225.01KB 62.50KB
fields (index.js) 261.26KB 66.37KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.28KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.73KB 14.72KB
plugin-charts (index.js) 83.99KB 22.86KB
plugin-chatbot (index.js) 197.67KB 46.90KB
plugin-dashboard (index.js) 136.82KB 36.44KB
plugin-designer (index.js) 216.42KB 44.47KB
plugin-detail (index.js) 233.48KB 61.79KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 161.16KB 41.40KB
plugin-gantt (index.js) 169.83KB 41.99KB
plugin-grid (index.js) 218.66KB 59.90KB
plugin-kanban (index.js) 48.43KB 15.11KB
plugin-list (index.js) 114.78KB 28.44KB
plugin-map (index.js) 22.90KB 7.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.17KB 12.20KB
plugin-timeline (index.js) 31.00KB 9.09KB
plugin-tree (index.js) 11.21KB 3.89KB
plugin-view (index.js) 87.86KB 22.02KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 119.16KB 39.05KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.03KB 1.86KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 7.50KB 3.05KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 6.16KB 2.71KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 3.52KB 1.36KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.26KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.27KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3083.2 KB 3104.5 KB
Main entry chunk (gzip) 148.4 KB 350 KB
Entry file index-DI7c78sK.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.57KB 6.15KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.17KB 10.58KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 557.59KB 133.61KB
core (index.js) 9.93KB 3.94KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 225.01KB 62.50KB
fields (index.js) 261.26KB 66.37KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.28KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.73KB 14.72KB
plugin-charts (index.js) 83.99KB 22.86KB
plugin-chatbot (index.js) 197.67KB 46.90KB
plugin-dashboard (index.js) 136.82KB 36.44KB
plugin-designer (index.js) 216.42KB 44.47KB
plugin-detail (index.js) 233.48KB 61.79KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 161.21KB 41.41KB
plugin-gantt (index.js) 169.83KB 41.99KB
plugin-grid (index.js) 218.66KB 59.90KB
plugin-kanban (index.js) 48.43KB 15.11KB
plugin-list (index.js) 114.78KB 28.44KB
plugin-map (index.js) 22.90KB 7.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.17KB 12.20KB
plugin-timeline (index.js) 31.00KB 9.09KB
plugin-tree (index.js) 11.21KB 3.89KB
plugin-view (index.js) 87.86KB 22.02KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 119.16KB 39.05KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.03KB 1.86KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 7.50KB 3.05KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 6.16KB 2.71KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 3.52KB 1.36KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.26KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.27KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: 82/82 CONTRACT_REVIEW_TIER
Head-sha: a13048ce95eacfac6f7ef7d33210e7520bf075cc

Read: the previous record (review/record.md, VERDICT FAIL on item 2); the card thread (triage 5860720827, claim 5860833997, the os-dev-report 5861273028 treated as claims only); the PR body at a13048c and its file list (6 files; 4 commits; mergeable: true, mergeable_state: clean; merge-base with origin/main e32dae16 is a7fd877c); the fetched ref refs/review/pr-10873-re2 and the delta ac526b1..a13048c (two commits ea52c79, a13048c; 3 files: MasterDetailForm.tsx, its pin, the 10853 changeset); the blob ids of all 6 PR files at both heads; at the head: packages/plugin-form/src/MasterDetailForm.tsx in full (useObjectsInvalidation, linesUnsaved, MasterDetailLines, the reader block, the replay effect, applyRowEdit, addRowViaForm, cancelRowEdit, sendBatch, the row-editor Card), ObjectForm.tsx (the inline-fields effect, readsRecord, the record-fetch effect), initialRecord.ts, recordInvalidation.ts (the readsRecord gate), packages/components/src/renderers/form/form.tsx (the defaultValues layout-effect reset), packages/fields/src/widgets/GridField.tsx (emit, applyPatch, the "Open row" button, every emit call site), masterDetailTx.ts (buildMasterDetailEditBatch, diffRows, childRowsAfterSave), sanitize.ts (isSameStoredValue, changedFields), record-picker.tsx (the 6726 arm and readProps); both pin files at the head and the pin's delta; AGENTS.md §5, §9 测试纪律 and 版本号策略; .changeset/10853-master-detail-picker-bus-readers.md at both heads, .changeset/10778-dashboard-bus-readers.md (blob and diff against a7fd877), 6726-find-envelope-records-arms.md, 6783-readprops-degenerate-config-bag.md, 10631-master-detail-save-in-flight.md; the head's check-runs twice. Ran the two pin files once at the head in a throwaway worktree under os-verify-lock.sh (slot review-10873-re2, acquired after 0 s, held 14 s): Test Files 2 passed (2), Tests 16 passed (16); the worktree had no change outside node_modules and is removed; /home/user/objectui is untouched (clean, on its own branch).

① Derived judgments

1. The row-editor defect is fixed — RIGHT.

  • The hold decision: unsavedLines is now rowEditorEntryRef.current === entry.id || linesUnsaved(…), and readLines(entry, 'bus') consults it before issuing anything, adding the id to heldLinesRereadRef and returning. So editor open, draft typed, a bus event that rewrites the line (or drops it, or '*'): no read is issued at all, rowState does not move, expandedRow keeps its identity, the editor's inline initialData serialises to the same key, and the form renderer's lastDefaultsKey layout effect does not reset. Pins 1 to 3 assert both halves (reads equals atRest; label/memo still the draft).
  • Both in-flight commit sites: after isCurrent(), if (inPlace && rowEditorEntryRef.current === entry.id) adds to the held set and returns, placed before the rowsAtIssue re-ask; and inside the setRowState updater the guard is prev[entry.id]?.rows !== rowsAtIssue || rowEditorEntryRef.current === entry.id, returning prev. The outer site holds directly instead of re-asking, so it no longer depends on the hold decision; that is what closes the loop the dev reports at ea52c79 with the hold decision ablated. Pin 4 (read issued, then the editor opened, then the answer): draft intact, grid still ['first', 'second'], reads stays at atRest + 1.
  • Never reset, re-keyed or disabled by a re-read: the editor's key is row-${entryId}-${rowIdx} from expanded alone, its fieldset is disabled by saving alone, and neither is touched by the delta; a held or uncommitted read leaves rowState as it was. The editor's nested ObjectForm has no recordId, so readsRecord is false and it holds no bus subscription of its own.
  • After Close: cancelRowEdit sets expanded null; the render writes the ref null; the replay effect, whose deps now include expanded, runs: the id is held, the ref is null, linesSavedRef is empty, unsavedLines(e) is false (no grid edit) → held.delete(e.id) then readLines(e, 'replay'), once. Pin 3 asserts atRest + 1 and that it stays there after a pause; pin 4 asserts atRest + 2.
  • After Apply: onSuccess runs applyRowEdit (the row at rowIdx becomes { ...r, ...values }) and setExpanded(null); the replay effect finds the ref null, linesSavedRef empty, and linesUnsaved true because buildMasterDetailEditBatch → changedFields(writable, before) finds label/memo moved → it stays held (pin 1: atRest after Apply). Save → sendBatch adds the entry to linesSavedRef and advances original through childRowsAfterSave; the replay effect returns before clearing while saving; releaseSave → the effect replays once → atRest + 1 (pins 1 and 2, and pin 1 asserts it does not replay again). An Apply whose values equal the stored row yields an empty changedFields, no op, so it reads as saved and replays at once, which is the right reading.
  • Apply targets the intended row in every one of those sequences: while the editor is open the collection's rows array is never replaced by the bus path (the read is either never issued or never committed), so expanded.rowIdx still addresses the row it was opened on. Pin 1's op is update l1 { label, memo }; pin 2's update ids are ['l1'] after the server dropped l1 and the grid shows ['first (draft)', 'second'].
  • Sequences the pins do not cover, traced at the head: (i) the editor switches from a row of collection A to a row of collection B while A is held: the ref becomes B, the replay effect runs on the expanded change and replays A once if its lines read saved; B's own events are then held while open; nothing is stranded. The outgoing editor's draft is discarded by the key change, which is what "Open row" on another row did at base. (ii) Switching rows within A: the ref stays A, the hold stays, Close replays. (iii) The collection removed from the authored details while its editor is open: the derive effect sets resolvedEntries, the load effect clears heldLinesRereadRef and linesSavedRef, bumps gen and issues 'load' reads for the surviving entries; expandedDetail is undefined so the editor is not rendered; the replay effect iterates entries, so a dead id is neither replayed nor waited on. expanded keeps the dead id until the next open; nothing reads it. (iv) Unmount with a held re-read: the load effect's cleanup bumps gen, useObjectsInvalidation unsubscribes, a late answer fails isCurrent(), the held set is a ref and dies with the component; no state write after unmount, no timer. (v) Save clicked with the editor open (the action bar is not gated on expanded): the replay effect after the save skips the editor's entry and then clears linesSavedRef; on Close the replay still fires because childRowsAfterSave advanced original to what was written and linesUnsaved reads false. One replay, none lost. (vi) A bus event during a save with the editor open: held at issue (the hold decision does not consult saving), replayed on Close. (vii) inlineMode: 'form' Add: addRowViaForm appends {} and opens with isNew; Cancel removes the blank row and closes → the rows are the original set again → replay; Apply on the new row is a create → held until the save → the created row takes its id, the baseline advances → replay. (viii) Loop: the only re-ask left is the rowsAtIssue mismatch (a grid edit during the flight), one read per identity change; GridField's emit is reached only from user actions (applyPatch, addRow, remove, duplicate, reorder; no effect emits on a prop change), so identity cannot churn on its own. I found no sequence that loses a draft, double-applies an answer, loops, or leaves a held re-read never replayed.

2. No regression on the paths the previous record judged RIGHT — RIGHT.

  • The grid-cell hold: the rowsAtIssue guard stands at both sites (outer: re-ask as 'bus'; updater: hold), and pin 6 (typed in flight kept, atRest + 1) still passes.
  • seq/gen: the seq increment, isCurrent, and the load effect's teardown bump are byte-identical to ac526b1.
  • linesSavedRef after a save: sendBatch's marking is unchanged, and the replay effect still returns before linesSavedRef.current.clear() while saving is true.
  • The first load: both new checks are gated on inPlace, so a 'load' read commits exactly as at ac526b1.
  • expanded moved above the reader: a useState declared earlier in the same component; the hook order is fixed across renders; expandedRow, expandedDetail, applyRowEdit, addRowViaForm and cancelRowEdit are unchanged.
  • The render-time ref: rowEditorEntryRef.current = expanded?.entryId ?? null is assigned in render, the pattern rowStateRef.current = rowState already uses in this component. Every reader is either an effect of this component, which runs after the commit that wrote the ref and so never sees an older expanded, or the async continuation in readLines, which reads the value of the latest committed render. The two gaps are both safe: between setExpanded(open) and its render an answer sees "closed" and commits, but no editor is mounted yet, so no draft exists, and the editor then opens on the committed row; between setExpanded(null) and its render (including the async onSuccess path) an answer sees "open" and holds, and the replay effect of that very render, keyed on expanded, replays it once. StrictMode's double render writes the same value. No stale read.

3. The narrow-race wording — RIGHT. The inPlace catch now interpolates rowsAtIssue === undefined ? 'no lines have been read for it yet' : 'the lines on screen are kept'. rowsAtIssue is rowStateRef.current[entry.id]?.rows read at issue, undefined only when no commit has ever written the slot, which is exactly the race (a 'bus' read supersedes the first 'load', then fails). A failed 'load' commits rows = [], so a later failed re-read says "kept", which is also true. The else branch yields the byte-identical message of ac526b1 (…after a data change; the lines on screen are kept.), and the 'load' branch (rows = [], no warning) is unchanged.

4. Prose — RIGHT.

  • The 10853 changeset: frontmatter (lines 1 to 4) md5 329d544f777da815044a51592f11206d at both heads. Each changed sentence holds at the head: "lines the user has changed since they were last read or saved (compared the way the save compares rows, with the link to the parent set aside)" is linesUnsaved running buildMasterDetailEditBatch over rows and original with the FK normalised on original, and original is written at every commit and by childRowsAfterSave; "or while the row editor ("Open row") is open on it, its re-read is held" is the hold decision, and "Open row" is the aria-label of the one expand control GridField renders; "It runs once, when the row editor is closed and either the lines have been changed back or this form's save has landed" is the replay effect's three conditions; "A line typed while a re-read is in flight, in the grid or in the row editor, is kept, and the re-read is held behind it; an open row editor is never reset by a re-read" is the two in-flight sites, pinned by tests 4 and 6. The rest of the file is byte-identical. The linesUnsaved doc now says the save restates the parent link while the lines read as saved and that the restatement does not hold a re-read, which is true (sendBatch unchanged; withFk restates on every row).
  • The 10778 note: blob 6da9d731… identical at ac526b1 and a13048c; against a7fd877 the file differs by the 9 appended lines only.
  • PR body: first line Fixes #10853. Clause-②: no holds: the delta adds or moves no export or import, no spec key, no registry input. The line address is bound to its tree: ":213 read at a7fd877… At a7fd877 that line is inside a comment block". The 6726 claim is true: record-picker.tsx at the head still reads const data: any[] = res?.data ?? (Array.isArray(res) ? res : []), with records named only in the comment above it, so a { records } answer reads as no rows on a first read and on a re-read alike. The 6783 claim is true: import { readProps } from './readProps' and const props = readProps… are in place and the file is untouched by the delta. The Patch-round section's measurements match the source (see 5).

5. Pins — RIGHT. The four new tests sit in the same file, rendered through SchemaRendererProvider and SchemaRenderer, registered through import './index' (the package entry) and registerAllFields() (the real grid). EDITOR_DETAIL carries two formFields over one column, so the real grid offers onRowExpand; openRow clicks getAllByLabelText('Open row'), GridField's own button; the editor is found by data-testid="md-row-form" (the Card in MasterDetailForm) and its fields by input[name=…] inside it, that is the nested real ObjectForm (key row-…, submitText: 'Apply'); editorButton('Apply') submits through that form's own submit into submitHandler then onSuccess then applyRowEdit; editorButton('Close') is the CardHeader button wired to cancelRowEdit. The inputsOf helper now excludes inputs inside md-row-form, which changes nothing for tests 1 to 8 (no editor is open there). No timeout is raised (the only setTimeouts are 20 ms and 30 ms settles), nothing is skipped (no .skip, .only, .todo), no vi.mock, no fake timers. Each can fail on ac526b1's MasterDetailForm.tsx: there unsavedLines had no editor term and neither commit site had an editor check, so in tests 1 to 3 the bus read is issued (reads becomes atRest + 1, failing the first count assertion) and, had it not, the commit under the editor would reset the draft to first (server) (tests 1 and 3) or to its neighbour second (test 2, l1 dropped); in test 4 the in-flight answer commits and resets to first (server). That is the dev's A4 result ('first (server)' ×3, 'second' ×1). A5 (the hold term ablated to false ||): the read is issued, so tests 1 to 3 fail at "a bus re-read ran under an open row editor", the commit sites still hold so the draft survives, and test 4 (its read was issued before the editor opened anyway) passes: 3 failed, 9 passed, consistent. A6 (both commit sites ablated): tests 1 to 3 are still held at issue and pass; test 4's answer commits and resets: 1 failed, consistent; "the outer site alone stays green" is consistent because the updater's check holds by itself. My run at the head: 16 passed (12 in the master-detail file, 4 in the picker's).

6. Carry-forward — RIGHT. packages/components/src/renderers/basic/record-picker.tsx (blob d11d0e1fcc…), its pin record-picker.busReread-10853.test.tsx (4efdf9671c…) and .changeset/10778-dashboard-bus-readers.md (6da9d731a0…) are byte-identical between ac526b1 and a13048c; the previous record's judgments 3 (the picker), 4 (the picker pin), 5 (the 10778 half) and 6 carry forward. The useObjectsInvalidation hook and the 'load' path (judgment 1 and the first-load half of 2) are also untouched by the delta.

② Semver level

patch for @object-ui/plugin-form and @object-ui/components is right and the frontmatter is unchanged: the delta adds a render-time ref and three checks inside one component, exports nothing, and moves no type, spec key or registry input. No major (AGENTS.md §9 版本号策略).

③ Boundary flags

  • Pre-existing, not this card's class: a grid action on the editor's own collection while the editor is open (Remove row, Duplicate row, a cell edit under a sort_field, which maps every row to a new object) changes expandedRow and shifts rowIdx, so the editor resets and Apply maps by the new index. That is setRows from the grid, identical at base; the bus path no longer does it.
  • A 'load' (a record change, an adapter change, or a details re-author through resolvedEntries) still commits under an open editor and resets it, as at base; the changeset's "never reset by a re-read" is about the bus re-read, which is what the card is about.
  • After a save made with the editor open, the linesSavedRef mark is cleared without a replay; the replay on Close rests on the baseline advance making linesUnsaved false. It holds today; were childRowsAfterSave ever to skip the advance (its original !== diffedAgainst identity check), the held re-read would wait for the next save or revert rather than be lost.
  • expanded keeps a removed collection's id after a details re-author; nothing reads it.
  • The parent-link restatement is now stated truthfully in the doc, the changeset and the body; user input is unaffected.
  • Carried from the previous record: the picker's "no label" face is base behaviour for a value outside its options; with the console's mutation bridge a save's own echo is held and replayed once per written collection, not pinned.
  • CI as read: poll 1 at 2026-09-28T01:23:09Z — 43 check-runs, 40 success, 3 skipped (Test (coverage), Test (coverage shard …/4), dependabot), 0 failures, 0 in progress. Poll 2 at 2026-09-28T01:30:02Z — identical. Successes: Test, Test (shard 1/8) to (shard 8/8), Test (dist pins), Type Check, Lint, Build & E2E, Live E2E (informational), Build Docs, Bundle Analysis, Changeset Declaration, Changeset Bump Policy, Changeset Fixed Group Check, Changeset Claim Re-read, Changeset Overwrite Report, Line Citation Gate, Control Byte Scan, Governed Surface Queue Guard, Spec Main Shape Gate, Skill Example Check, Skill Guide Path Check, Skill Eval Token Check, README Export Check, Doc Snippet Type Check, Doc Fence Language Check, Doc Example Id Check, Doc Component Type Check, Internal Docs Link Check, Docs Route Eager Closure Check, Shell Escape Residue Scan, Action Ref Convention, Inert vi.mock Specifier Check, Pre-Install Import Graph Check, label. No annotations to read: no failure.
  • The pin run's seconds are shared-box figures (the lock excludes other locked runs only).

Implemented-by: claude/issue-10853-master-detail-picker-bus-readers
Reviewed-by: session_01MCg3z5cGrV51xEddpGcxEY

VERDICT: PASS

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review September 28, 2026 01:37
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit de1b879 Sep 28, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-10853-master-detail-picker-bus-readers branch September 28, 2026 01:53
akarma-synetal pushed a commit to akarma-synetal/objectui that referenced this pull request Sep 28, 2026
…ts name 32 objectui issues that answer 404 (objectui#10803, batch 3) (objectstack-ai#10869)

Part of objectstack-ai#10803
Clause-②: no

Dispatched implementation of the `domain:ui` seat objectstack-ai#2 claim (comment
`5860873556`) on objectui#10803, batch 3, session
`https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN`; patch round 1
applies the seat ruling `5861129870` on the round's two open questions,
and patch round 2 applies contract review `5861306588` (two wording
fixes and one optional nit) and the ruling's amendment `5861311219`.
Citations only: no sentence's claim moves, and every edited pending
changeset's frontmatter is byte-identical. The runtime text that moves
loses its dead pointer and nothing else: four ADR-0049 tombstone
guidance strings and two zod `.describe()` strings in
`@object-ui/types`, and the Studio CEL authoring advisory in
`@object-ui/app-shell`. The six tests that pin the tombstone text, the
two changesets and two `content/docs` pages that quote it follow the
changed string, and nothing else in them moves.

## Why `Part of`, not a closing line

The card stays open for the other 83 numbers of the family remainder
(seat amendment `5860244997`, Q2 = A).

## The seat ruling `5861129870` and its amendment `5861311219`, as
applied

- **Q1, the tombstone guidance class: a seat variant of option A, as
amended.** Each of the four runtime tombstone strings keeps the house
`RETIRED (REF) —` shape with `ADR-0049` as the reference, in place of
the dead card. The ruling first conditioned `ADR-0049` on the key's
TypeScript twin comment naming it: the twins of `TreeViewSchema.data`
and `ChartDataSeriesSchema.data` (`data-display.ts`) and of
`TextSchema.value` (`layout.ts`) each read "RETIRED (SHA, ADR-0049
enforce-or-remove)", while the twin of `DashboardConfigSchema.aria` is a
deletion note on `DashboardConfig` in `designer.ts` that names no ADR,
so round 1 shipped `RETIRED —` there. The amendment `5861311219`
corrects that proxy: the `aria` retirement is itself ADR-0049 (the
comment above `DashboardConfigSchema` in `complex.zod.ts`, its landing
commit `e7957ab87`, and the pending
`dashboard-config-aria-retired-5852.md` all say so), so `aria`'s error
and describe strings also open `RETIRED (ADR-0049) —`. All four now read
alike. Everything after the dash is unchanged. No sha enters runtime
text.
- **Q2, the CEL advisory: A.** The pointer drop in `rowCanonAdvisory`
stands, as shipped in round 1.
- **Folded (triage item 3):** the bare PR numbers objectstack-ai#5505 and objectstack-ai#5758, see
**Mapping** and **Special cases** 4 and 2.
- **Review `5861306588`, taken in full:** the objectstack-ai#5738 stand-down 3 sites
name the card by role behind the sha (**Special cases** 2); the
runtime-strings changeset's second sentence no longer says every pointer
is dropped; and, the optional nit, the sweep changeset names the
role-named case.
- **`main`:** `main` (`fab627ff9`) was merged in during round 1 by a
merge commit (`2cb9b253f`), no rebase and no force-push. The branch is 0
commits behind it, so round 2 merged nothing. Every reading below is on
the head `dd37e35d2`.

## Premise, re-measured

- REST `GET /repos/objectstack-ai/objectui/issues/N` for each of the 32:
all 32 answer 404, and a second read of each answers 404 again (32 of
32). `GET .../pulls/N` answers 404 for all 32 too. Lit controls:
objectui#10533 and objectui#7714 answer 200. No number was dropped from
the batch.
- The two folded bare PR numbers, objectstack-ai#5505 and objectstack-ai#5758, answer 404 on both
`issues/N` and `pulls/N`.
- The same 32 in objectstack all answer 200. Their subjects are
unrelated to the objectui sentences (for example objectstack#5425 is the
U+0000 finding about `useDatasetFields.ts`, objectstack#5418 the
language-menu card). The only objectstack-qualified sites these numbers
have in the in-scope classes already spell `objectstack#`
(`objectstack#5425` in `useDatasetFields.ts`, `objectstack#5418` twice
in `i18n`'s `provider.tsx`, and `objectstack#5505` twice in
`components`): live sister citations, untouched. Every other site names
an objectui card, confirmed by its landing commit below, so no site is
re-qualified.
- Every edited changeset is pending: it is present in `.changeset/` on
`main`.
- Branch point: `a60539b07`. Not a shallow checkout.

## Census (the enumeration pin for this batch)

The instrument PR objectui#10854 printed, with this batch's 32 numbers
and the two folded ones substituted (REF = a commit):

```
git grep -nE '(objectui#|#|issues/)(3499|3559|4784|5197|5221|5286|5309|5399|5401|5413|5414|5416|5417|5418|5425|5505|5518|5533|5709|5738|5741|5758|5852|5859|6296|6464|6661|6740|6757|6854|6859|6864|6896|6951)([^0-9]|$)' REF -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | grep -v 'objectstack#' | wc -l
```

- REF = `a60539b07` (branch point): **217** lines (216 for the 32 alone:
56 changeset lines in 47 files and 160 src-nontest lines in 77 files;
the folded objectstack-ai#5758 adds one line, and objectstack-ai#5505 sits on two lines objectstack-ai#5401
already counts). REF = `fab627ff9` (current `main`): 217.
- REF = `dd37e35d2` (this head, `main` merged in): **0**.
- This head merged with a fresh `main` (`fab627ff9`, `git merge-tree
--write-tree`, clean): **0**.
- The instrument's blind spot, measured: its `grep -v 'objectstack#'`
drops a whole line that ALSO names an objectstack number. One in-scope
line was hidden that way, `ActionRunner`'s `onSuccess` block
("objectui#5221, the console half of objectstack#9566/objectstack-ai#9474"); it is
re-pointed here too. Without the filter the instrument reads 5 at this
head, all live `objectstack#` lines (the three above and
`objectstack#5505` twice).
- Lit control, the same printed instrument over live objectui#7714 at
this head: 17 lines. Hex-colour false positives (a number followed by a
hex letter) at the branch point: 0.
- Out of scope, as it stands (the card's instrument with the 34 numbers,
unfiltered, whole tree at this head): 283 test lines in 121 files, 4
scripts lines in 2 files, 0 `.github`, 0 governed, and 24 other lines in
20 files (published `CHANGELOG.md` history, `content/docs`, two package
READMEs, and `apps/console`; see **Acceptance notes** 3). The test count
includes the `@ts-expect-error` comments named in **Acceptance notes**
5.

## Citation form

- The 9-character backticked sha of the commit on `main` that landed the
change the sentence rests on, as in PRs objectui#10707 / objectstack-ai#10766 / objectstack-ai#10797
/ objectstack-ai#10854. All 32 distinct shas below (the two folded numbers reuse two
of them) are ancestors of `main` (`git merge-base --is-ancestor`, exit 0
each; control leg: the head of PR objectui#10714 answers exit 1, and a
known ancestor `5f789538d` answers exit 0 in the same checkout), and
`git rev-parse --short=9` returns the same 9 characters for each.
- A changeset's pointer to its OWN card is dropped, not replaced:
`@changesets/changelog-git` prefixes each released entry with the hash
of the commit that added the file, which is that landing. Where dropping
the pointer left a dangling word, the clause was minimally repaired
(listed in **Special cases**).
- Where the sentence cites a RULING and no single commit is the ruling,
the ruling is cited by its date: "the 2026-08-23 ruling" (the dashboard
widget-options ruling, option B, recorded in `8d58f46b4`'s message),
"the maintainer ruling of 2026-08-31" (the chart `categories` ruling,
recorded in `b0d308da9`'s).
- Runtime text carries no sha. Inside a zod `.describe()` string and in
the author-facing CEL advisory the dead pointer is dropped (amendment
`5860244997`, Q1 = A; ruling `5861129870`, Q2 = A). A tombstone guidance
string keeps its `RETIRED (REF) —` shape with `ADR-0049` as the
reference (ruling `5861129870`, Q1, as amended by `5861311219`).
- Where nothing answers, the pointer is dropped and the sentence names
the card by role (objectstack-ai#5518 only).

## Mapping (number to resolution)

Lines and files are the branch-point census for that number. "Method" is
how the landing was found.

| dead number | resolution | method | lines / files | evidence |
|:--|:--|:--|:--|:--|
| objectstack-ai#3499 | `48132f7e6` | `git log --grep` | 1 / 1 | the rc.5 bump; its
message lists "`HttpMethodSchema` -> spec's `HttpMethodSubsetSchema`
(objectstack#5832, objectui#3499)" |
| objectstack-ai#3559 | `fbc23e094` | `git log --grep` | 7 / 3 | "keep a field's own
option keys when an action param inherits them (objectstack-ai#3559)"; it added
`ActionParamOption` and the `normaliseOptions` preservation |
| objectstack-ai#4784 | `833c90047` | `git log --grep` | 1 / 1 | "a 400 FLOW_FAILED or
404 on the flow route is terminal, not retryable"; its body names objectstack-ai#4784
as the card it settles |
| objectstack-ai#5197 | `9c60144b5` | `git log --grep` | 4 / 3 | "retire the
unreachable id-keyed nav label resolvers (objectstack-ai#5197)" |
| objectstack-ai#5221 | `053fdc8f9` | `git log --grep` | 4 / 3 | "read
ActionSchema.onSuccess for post-success navigation", "Part of objectstack-ai#5221"; it
added `5221-onsuccess-navigation.md` and the console `openIn: 'self'`
half |
| objectstack-ai#5286 | `38ba3ddf3` | `git log --grep` | 1 / 1 | "API Discovery
Storage group reads the canonical `storage` slot first (objectstack-ai#5286)": the
alias table the changeset's sentence describes |
| objectstack-ai#5309 | `c7a74c80d` | `git log -G` (the only commit adding the
citation) | 3 / 2 | "approver membership-tier picker reads the
server-published enum; delegated_admin stops rendering (invalid)" |
| objectstack-ai#5399 | `5a07e67d9` | `git log --grep` + changeset's adding commit | 2
/ 2 | "stop the sparse-predicate warning blaming `hidden: true` (objectstack-ai#5399)"
|
| objectstack-ai#5401 | `c86185eb5` | `git log --grep` | 3 / 3 | the PR objectstack-ai#5505 squash
("Bind `record` into node-level `visibleWhen`"); its body "flip[s] the
objectstack-ai#5401 defect pins" and implements the live successor objectui#5454 |
| objectstack-ai#5413 | `688cb93ad` | `git log --grep` | 1 / 1 | "resolve four
react-pages.md contradictions toward the framework's sources (objectstack-ai#5413)" |
| objectstack-ai#5414 | `77f846a8b` | changeset's adding commit | 11 / 5 | "name the
pending approver, not a truncated raw id"; its body names objectstack-ai#5414 as the
card it settles and states the confirmed-empty-seat surfacing |
| objectstack-ai#5416 | `add10d8f9` | `git log --grep` + changeset's adding commit | 9
/ 5 | "Studio metadata forms: no errors before input, translated help
text, and a publish button clear of the toast" |
| objectstack-ai#5417 | `c40f3b8ca` | `git log --grep` + changeset's adding commit | 4
/ 3 | "surface a screen flow's resume result, on both outcomes (objectstack-ai#5417)"
|
| objectstack-ai#5418 | `7a90afdf9` | changeset's adding commit + `git log -G` | 20 /
16 | "Studio's 新建对象 asks for the record-sharing baseline, and an
unauthored one is reported before Publish instead of by it"; it added
the ten locale keys and `securityPostureLint.ts` |
| objectstack-ai#5425 | `56f4e34c0` | `git log --grep` + changeset's adding commit | 5
/ 4 | "one header spelling across the table widget family", "Part of
objectstack-ai#5425" |
| objectstack-ai#5505 (bare PR number, folded) | `c86185eb5` | the PR's own squash
(subject ends "(objectstack-ai#5505)") | 2 / 2 | sits beside `c86185eb5` already, so
the pair collapses to the sha. See **Special cases** 4 |
| objectstack-ai#5518 | nothing answers | `git log --grep`, `git log -S` on the
fallback read | 1 / 1 | the `node.objectName ?? node.object` fallback it
asks about is still on `main`; no commit lands it. See **Special cases**
1 |
| objectstack-ai#5533 | `2573ff434` | `git log --grep` + changeset's adding commit |
12 / 6 | "Marketplace package detail page states the marketplace is off,
instead of red-erroring (objectstack-ai#5533)" |
| objectstack-ai#5709 | `8d58f46b4`; "the 2026-08-23 ruling" | `git log --grep` +
changeset's adding commit | 8 / 6 | "warn on dashboard widget options
keys no renderer consumes (objectstack-ai#5709)"; its body records "Maintainer ruling
2026-08-23 (option B)" |
| objectstack-ai#5738 | stand-down 3: the card named by role, behind `702c48a62`; the
recipe: `702c48a62` | `git log --grep` | 4 / 3 | `702c48a62` ("write the
requiredWhen example in the row-predicate canon (objectstack-ai#5738)") is the Phase-0
corpus-sweep landing and carries the `detectNonCanonicalRowSpelling`
recipe, but not the stand-down 3 finding, which was recorded only on the
dead card. See **Special cases** 2 |
| objectstack-ai#5741 | `83fe6e741` | `git log --grep` + changeset's adding commit |
25 / 13 | "row predicates on runtime record surfaces bind record.* only
(objectui#5741)"; "executed as ruled on objectui#5741 (2026-09-02,
amended 2026-09-05)" |
| objectstack-ai#5758 (bare PR number, folded) | `702c48a62` | the PR's own squash
(subject ends "(objectstack-ai#5758)") | 1 / 1 | "PR objectstack-ai#5758's recipe" beside
`702c48a62` collapses to the sha. See **Special cases** 2 |
| objectstack-ai#5852 | `e7957ab87`; runtime text `RETIRED (ADR-0049) —` | `git log
--grep` + changeset's adding commit | 5 / 4 | "retire the
designer-surface dashboard aria pair (objectstack-ai#5852)"; it wrote the hand-spelled
`z.never({ error })` tombstone |
| objectstack-ai#5859 | `41df89320` | changeset's adding commit | 1 / 1 | "retire the
orphaned ObjectTrigger and ObjectRelationship exports"; own-card pointer
only |
| objectstack-ai#6296 | `88b15fddc` | `git log --grep` + changeset's adding commit | 8
/ 3 | "caller-supplied subject vocabulary for ConditionBuilder", "Part
of objectstack-ai#6296"; it added `subjects` and the per-row quote character |
| objectstack-ai#6464 | `830ed5803` | changeset's adding commit | 8 / 6 | "offer
approval recall to the submitter only" |
| objectstack-ai#6661 | `969ba84f4` | changeset's adding commit | 5 / 5 | "console
renderers for `app:launcher` and `nav:menu`" |
| objectstack-ai#6740 | `7c9b044f4` | changeset's adding commit | 5 / 5 | "flex
declares the containment it renders" |
| objectstack-ai#6757 | `f99932a42` | `git log --grep` + changeset's adding commit |
11 / 10 | "render `global:search` and `global:notifications` instead of
the placeholder"; its body names objectstack-ai#6757 as the card it settles |
| objectstack-ai#6854 | `adb2a86db` | changeset's adding commit | 4 / 3 | "render
AppAction.items from its declared type, without the two `as any` reads";
it added the pin `LayoutRenderer.appActionItems-6854.test.tsx` and ran
the app-document census the Chinese changeset refers to |
| objectstack-ai#6859 | `64d937c53` | `git log --grep` + changeset's adding commit | 5
/ 2 | "correct the injected-editor commit justification, and pin what
actually happens (objectstack-ai#6859)" |
| objectstack-ai#6864 | `503cd8b89` | changeset's adding commit | 5 / 4 |
"aggregate()'s spec-shape branch refuses the analytics branch's `filter`
/ `field` / `function`" |
| objectstack-ai#6896 | `b0d308da9`; "the maintainer ruling of 2026-08-31"; runtime
text `RETIRED (ADR-0049) —` | `git log --grep` + changeset's adding
commit | 18 / 10 | "retire ChartDataSeries.data, correct categories'
prose (objectstack-ai#6896)" |
| objectstack-ai#6951, ruling A1 (`TextSchema.value`) | `5ad86ddee`; runtime text
`RETIRED (ADR-0049) —` | `git log --grep` + changeset's adding commit |
part of 16 / 7 | "retire TextSchema.value as an ADR-0049 tombstone
(objectui#6951 A1 / objectui#7016)" |
| objectstack-ai#6951, ruling B1 (`TreeViewSchema.data`) | `16a725f96`; runtime text
`RETIRED (ADR-0049) —` | `git log --grep` + changeset's adding commit |
part of 16 / 7 | "retire TreeViewSchema.data as an ADR-0049 tombstone
(objectui#6951 B1)" |

## Special cases (the judgement calls)

1. **objectstack-ai#5518, `StudioDesignSurface`'s nav inspector.** "is objectui#5518,
deliberately left out of objectstack-ai#4881's scope" becomes "is a follow-up card's
question, deliberately left out of objectstack-ai#4881's scope". Nothing lands it (the
fallback read is still there) and no successor is recorded in history,
so the card is named by role.
2. **objectstack-ai#5738 "stand-down 3", and objectstack-ai#5758.** The finding (RLS and flow
conditions are not row surfaces) was recorded on the dead Phase-0
corpus-sweep card, not in a commit. `702c48a62` is that sweep's landing
and the squash of PR objectstack-ai#5758, but it is a one-line `plugin-form/README.md`
edit that says nothing about a stand-down, so it cannot carry the
finding (review `5861306588`). The card is therefore named by role, with
the sha only to locate it: "(objectui#5738 stand-down 3)" becomes
"(stand-down 3 on the corpus-sweep card behind `702c48a62`)" in the
`conditionScope.ts` file docblock and in
`7727-conditional-formatting-record-scope.md`, and the `sharing_rule`
doc of `CONDITION_SCOPE_BY_METADATA_TYPE` reads "a stand-down 3 surface
of the corpus-sweep card behind `702c48a62`". `rowPredicateCanon.ts` is
different: "(the objectui#5738 corpus sweep, PR objectstack-ai#5758's recipe)" becomes
"(the `702c48a62` corpus sweep's recipe)", and that commit's message
does carry the recipe (the `detectNonCanonicalRowSpelling` oracle); the
review found it correct.
3. **objectstack-ai#5221, `consoleServerAction.ts`.** "precedence — objectui#5221
escalates it" becomes "precedence — the card behind `053fdc8f9`
escalates it": the escalation lived on the card, and no later ruling on
that precedence is in history.
4. **objectstack-ai#5401 and objectstack-ai#5505.** In `visibilityDiagnostic.ts`, "(objectui#5401 →
objectstack-ai#5454)" becomes "(objectui#5454)": the dead predecessor goes, the live
successor the sentence already named stays. In `data-table.tsx` and
`5926-empty-action-visible-when.md`, "objectui#5401 / objectstack-ai#5505 closed for
`record:alert`" becomes "`c86185eb5` closed for `record:alert`":
`c86185eb5` is the squash of PR objectstack-ai#5505, so the card / PR pair is one
landing.
5. **"that card" after a re-point.** Where the next words leaned on the
dead card, they were repaired minimally: "on the flag that card was not
about" becomes "that change was not about"
(`MarketplacePackagePage.tsx`,
`gate-listlocalinstalls-marketplace-5620.md`); "The card's complaint
was" becomes "The complaint it answered was"
(`StudioDesignSurface.tsx`); "is that card's to declare, not this one's
to guess" becomes ", the caller's to declare, not this list's to guess"
(`ConditionBuilder.tsx`'s `REFERENCE_ROOTS`); "belongs to objectui#6296"
becomes ", which `88b15fddc` added"
(`6293-conditionbuilder-reference-value.md`); "the unstaffed state
objectui#5414 asks to surface" becomes "the unstaffed state `77f846a8b`
surfaces"; "is not what objectui#5414 reports" becomes "is not what
`77f846a8b` fixes".
6. **Rulings by date.** "(objectui#5709 ruling)" becomes "(maintainer
ruling 2026-08-23)" in the objectstack-ai#5709 changeset (own card) and "(the
2026-08-23 ruling; ...)" in `validate.ts`; "whose objectui#5709 ruling
states the constraint" becomes "whose 2026-08-23 ruling states" in
`kanban-quick-add.ts`; "ruled LIVE by objectui#6896 (maintainer ruling
2026-08-31, prose follows machine)" becomes "ruled LIVE by the
maintainer ruling of 2026-08-31 (prose follows machine)" in
`ChartRenderer.tsx`, and `8650-chart-foreign-dialect-retired.md`'s
"ruled live by objectui#6896" becomes "ruled live by the maintainer
ruling of 2026-08-31".
7. **"Phase 2" wording.** "the warning objectui#5741 deleted" becomes
"the warning Phase 2 (`83fe6e741`) deleted" in `celAuthoring.ts`, so the
next sentence's "That ruling" keeps its antecedent; "objectui#5741 Phase
2 retired" becomes "Phase 2 (`83fe6e741`) retired" in
`ConditionBuilder.tsx` and `8167-conditionbuilder-mount-scope.md`;
`layout.ts`'s "objectui#6951 (maintainer ruling A1, 2026-09-04) decided
it" becomes "maintainer ruling A1 (2026-09-04, `5ad86ddee`) decided it".
8. **Own-card pointers that needed a word.**
`dashboard-table-header-one-spelling-5425.md`: "the defect class
objectui#5425 rules out" becomes "the defect class this change rules
out". `6757-global-search-notifications-renderers.md` and the two objectstack-ai#6951
changesets: the parenthesis opened on its own card, so the line break
moved with it ("page blocks.", "is RETIRED" then "(maintainer ruling
...)"). `6854-layout-renderer-retired-onclick.md`: "(objectui#6854,
maintainer ruling ...)" becomes "(the maintainer ruling ...)".
9. **The runtime strings.** Only the listed text moves in each (RECORD
below stands for the interpolated canonical root).

| file | member | before | after |
|:--|:--|:--|:--|
| `types/src/zod/complex.zod.ts` | `DashboardConfigSchema.aria`, `error`
| "RETIRED (objectui#5852) — `aria` is no longer part of
DashboardConfig; ..." | "RETIRED (ADR-0049) — `aria` is no longer part
of DashboardConfig; ..." |
| `types/src/zod/complex.zod.ts` | `DashboardConfigSchema.aria`,
`.describe()` | "RETIRED (objectui#5852) — the `{ label, description }`
spellings ..." | "RETIRED (ADR-0049) — the `{ label, description }`
spellings ..." |
| `types/src/zod/data-display.zod.ts` | `TreeViewSchema.data`
(tombstone) | "RETIRED (objectui#6951) — `data` is no longer part of
TreeViewSchema; ..." | "RETIRED (ADR-0049) — `data` is no longer part of
TreeViewSchema; ..." |
| `types/src/zod/data-display.zod.ts` | `ChartDataSeriesSchema.data`
(tombstone) | "RETIRED (objectui#6896) — `ChartDataSeries.data` was
never read: ..." | "RETIRED (ADR-0049) — `ChartDataSeries.data` was
never read: ..." |
| `types/src/zod/layout.zod.ts` | `TextSchema.value` (tombstone) |
"RETIRED (objectui#6951) — `value` is no longer part of TextSchema; ..."
| "RETIRED (ADR-0049) — `value` is no longer part of TextSchema; ..." |
| `types/src/zod/data-display.zod.ts` | `TreeViewSchema.nodes` | "... no
presence rule exists — objectui#6951 B1). ... the `data` fallback
spelling was retired by objectui#6951 (the registration's ..." | "... no
presence rule exists). ... the `data` fallback spelling was retired (the
registration's ..." |
| `types/src/zod/layout.zod.ts` | `TextSchema.content` | "... its
`value` fallback spelling was retired by objectui#6951)" | "... its
`value` fallback spelling was retired)" |
| `app-shell/src/views/metadata-admin/celAuthoring.ts` | the
`metadata-layer-root` advisory in `rowCanonAdvisory` | "... binds the
record as RECORD and nothing else (objectui#5741). The CEL scope ..." |
"... binds the record as RECORD and nothing else. The CEL scope ..." |

10. **What follows the tombstone strings, and nothing else in it.** The
literal anchors on the old text in the six pinning tests:
`dashboard-config.test.ts` (`/RETIRED \(objectui#5852\)/` becomes
`/^RETIRED \(ADR-0049\) — /`; the "delete the key" remedy anchor stays),
`tree-view-data-retired-6951.test.ts` and
`text-value-retired-6951.test.ts` (the full `GUIDANCE` literal's opening
and the `describeOf` anchor; `PRESCRIPTIVE` stays),
`chart-inline-data-retired.test.ts` (three anchors; the `xAxisKey` and
chart-level `data` remedy anchors stay), `chart-data-model-7113.test.ts`
and `chart-series-keys-7546.test.ts` (one anchor each). The two
changeset quotes (`6951-text-value-retired.md`,
`6951-tree-view-data-retired.md`, frontmatter byte-identical) and the
two `content/docs` quotes (`text.mdx`, `tree-view.mdx`) open `RETIRED
(ADR-0049) —`. Per the ruling these follow the changed string; they do
not widen the card's classes. No test, doc or changeset quotes either
`aria` string (whole-tree search after the amendment: the source line is
the only hit).

## Held

**By the serial rule: nothing.** The open-PR list was read at the start
(11 open) and re-read for each round; at round 2 there are 9 open
besides this one and the release PR: objectui#10873, objectstack-ai#10871, objectstack-ai#10870,
objectstack-ai#10852, objectstack-ai#10821, objectstack-ai#10780, objectstack-ai#10777, objectstack-ai#10714 and objectstack-ai#10278. In round 1, two of
them touched files this PR edits: objectui#10821
(`types/src/objectql.ts`, `types/src/zod/objectql.zod.ts`) and
objectui#10714 (`types/src/data-display.ts`, `types/src/layout.ts`,
`types/src/zod/data-display.zod.ts`, `types/src/zod/layout.zod.ts`).
Each one's hunks (3 lines of context) were mapped onto the head through
a line alignment of the PR's merge-base file: **none of the 22 lines
this PR changes in those files lies inside, or beside, any hunk.**
objectui#10871 (new since) touches `celAuthoring.ts` and
`metadata-admin/i18n.ts` in disjoint hunks (review `5861306588`), and no
open PR touches a file round 2 edits. Trial merges of each open PR head
with this head (`git merge-tree --write-tree`): clean for objectstack-ai#10873,
objectstack-ai#10871, objectstack-ai#10870, objectstack-ai#10852, objectstack-ai#10780, objectstack-ai#10777 and objectstack-ai#10714; objectstack-ai#10821 (`24bcb0035`)
and objectstack-ai#10278 (`eab4c8e52`) conflict, but each conflicts identically
against `main` alone, so the conflicts are not this PR's. PR objectstack-ai#5400
(Version Packages) regenerates and is not a hold.

## Changesets

- `.changeset/10803-dead-citation-sweep-third-batch.md`, EMPTY
frontmatter: the comment-only edits in 12 released packages; no
published behaviour changes through them. Its list of citation forms now
ends "or a live successor, and where nothing answers they name the card
by role" (the review's optional nit), and it points at the second file
for the runtime text.
- `.changeset/10803-third-batch-runtime-strings.md`,
`'@object-ui/types': patch` and `'@object-ui/app-shell': patch`. Its
second sentence now reads "so no dead pointer becomes a commit:
tombstones cite `ADR-0049` in its place, and every other pointer is
simply dropped" (review `5861306588` fix 2, in the amendment's all-four
wording). It names the four tombstones, all now opening `RETIRED
(ADR-0049) —` (`TreeViewSchema.data`, `TextSchema.value`,
`ChartDataSeriesSchema.data`, and `DashboardConfigSchema.aria`'s error
and describe text), with no process clause about a TypeScript twin; then
the two describe strings and the advisory. Nothing after a tombstone's
dash moves, and no key, path, issue code, accept set, refusal or
severity moves.

## Proof of prose-only (C4), against `main` `fab627ff9`

- **Source.** Each of the 77 touched non-test `.ts` / `.tsx` files was
parsed at `fab627ff9` (the `main` merged in, so the diff is exactly this
PR's) and at this head with TypeScript 6.0.3's `createSourceFile` and
re-printed by `createPrinter({ removeComments: true })`: 73 of 77 prints
are identical, and the other 4 (`celAuthoring.ts`, `complex.zod.ts`,
`data-display.zod.ts`, `layout.zod.ts`) are equal after exactly the 9
listed string substitutions are applied to the `main` print (each
matched once): the 4 tombstone strings in 5 literals, the 3
describe-string deletions and the advisory's. 0 parse diagnostics. Lit
controls on the same instrument: dropping "(ADR-0049)" from the
`TextSchema.value` string moves the print; re-spacing a comment does
not.
- **Changesets.** The frontmatter block of every one of the 47 edited
changesets is byte-identical at `fab627ff9` and this head (47 of 47);
the overwrite gate below agrees.
- **Scope of the diff against `main`:** 134 files, +287 / −237: 47
edited and 2 new changesets, 77 non-test source files, the 6 pinning
tests and the 2 `content/docs` pages.

## Gates, on this head `dd37e35d2`

Each line is the gate's own verdict and exit code, captured by
redirect-then-`$?`.

- `node scripts/check-changeset-presence.mjs`, exit 0: "83 source
file(s) of 12 released package(s) changed, and this change declares 2
changeset(s): .changeset/10803-dead-citation-sweep-third-batch.md,
.changeset/10803-third-batch-runtime-strings.md." (83 = the 77 sources
and the 6 tests under `packages/types/src`).
- `pnpm changeset:check`, exit 0: "All workspace packages are in the
changeset fixed group." / "No changeset declares a `major` bump."
- `node scripts/check-changeset-overwrite.mjs` (report-only), exit 0: "2
changeset(s) added, 47 modified, 0 deleted"; `declared at base` equals
`declares now` for 47 of 47.
- `pnpm check:changeset-claims` (report-only), exit 0: born-false "Every
one of those 9 address(es) either names the tree it was read from, or
points at a line this change does not move"; self-contradiction "Every
package declared across those 45 body(ies) is either not negated ...";
and the standing notice "92 pending changeset(s) describe a file this
change touches". Read against the diff: a pending changeset quoting a
replaced pointer would itself carry the dead number and so sit in the
census; the only pending quotes of the four tombstone strings are the
two edited here; and none of the words repaired beyond a pointer
(**Special cases** 1, 3 and 5) occurs in any pending changeset.
- `pnpm check:control-bytes`, exit 0: "check-control-bytes: OK (scanned
9113 tracked text file(s); skipped 85 binary)." Self-scan of the 134
changed files for C0 / DEL bytes: 0.
- Also run: `pnpm check:new-line-citations`, "VERDICT
new-cross-file-line-citations: 0 new citation(s), enforcement
report-only -> exit 0"; governed-surface predicate over the 134 paths,
exit 0, "NOT GOVERNED — 134 path(s) checked against 5 governed
surface(s); none matched." (lit control `AGENTS.md`: exit 3).

**Tests**, through the shared verify lock (`VERDICT command-exit 0`).
Round 2, on this head: the six pinning files (`dashboard-config`,
`tree-view-data-retired-6951`, `text-value-retired-6951`,
`chart-inline-data-retired`, `chart-data-model-7113`,
`chart-series-keys-7546`) and `tombstone-discriminator-agreement-9684`:
`Test Files 7 passed (7)`, `Tests 144 passed (144)`. Round 1, on
`e4bce25b8` (round 2 changed no other tested string): those seven plus
`tree-view-data-optional-6939`, `undeclared-but-consumed-keys-6150`,
`zod-mirror-parity`, `layout-default-jsdoc-7361` in `packages/types`,
and `celAuthoring.fieldRuleVerdict-9318`, `recordScopeDataRoot-8166`,
`ConditionalFormattingEditor` in `packages/app-shell`: `Test Files 14
passed (14)`, `Tests 393 passed (393)`.

**Whole-tree search for other verbatim quotes of the four old strings**
(tests, docs, examples, skills, apps): every hit is one of the source
strings, the six anchors, the two changeset quotes or the two docs
quotes, all updated. Remaining mentions of the old prefix are six
`@ts-expect-error` comments in `text-value-retired-6951.test.ts` and
`tree-view-data-retired-6951.test.ts` that describe the TypeScript face,
not the runtime string; left as they are (see **Acceptance notes** 5).

**Declared narrowing (per the dispatch: the named checks, not wider
sweeps).** NOT MEASURED locally: the full suites and type-check of the
12 touched packages, and eslint. Reason: the comment-stripped syntax
tree of 73 of the 77 touched source files is identical to `main` and the
other 4 differ only by the listed string-literal edits; every test that
quotes a changed string was found by search and run above. CI runs the
full farm.

## Acceptance notes

1. **The remainder rides this card, unchanged (seat amendment
`5860244997`, Q2 = A).** Of the 115 numbers PR objectui#10854's
Acceptance notes item 1 lists, this PR carries the first 30 in ascending
order plus objectstack-ai#6896 and objectstack-ai#6951, which that PR's release named. The other
**83** are: objectstack-ai#6872 objectstack-ai#6879 objectstack-ai#6882 objectstack-ai#6887 objectstack-ai#6888 objectstack-ai#6889 objectstack-ai#6892 objectstack-ai#6905 objectstack-ai#6907 objectstack-ai#6921
objectstack-ai#6923 objectstack-ai#6924 objectstack-ai#6931 objectstack-ai#6940 objectstack-ai#6942 objectstack-ai#6958 objectstack-ai#6959 objectstack-ai#6962 objectstack-ai#6965 objectstack-ai#7004 objectstack-ai#7008 objectstack-ai#7023
objectstack-ai#7025 objectstack-ai#7036 objectstack-ai#7068 objectstack-ai#7069 objectstack-ai#7077 objectstack-ai#7079 objectstack-ai#7087 objectstack-ai#7088 objectstack-ai#7091 objectstack-ai#7097 objectstack-ai#7108 objectstack-ai#7177
objectstack-ai#7612 objectstack-ai#7620 objectstack-ai#7623 objectstack-ai#7658 objectstack-ai#7666 objectstack-ai#7667 objectstack-ai#7669 objectstack-ai#7678 objectstack-ai#7681 objectstack-ai#7682 objectstack-ai#7703 objectstack-ai#7704
objectstack-ai#7708 objectstack-ai#7804 objectstack-ai#7844 objectstack-ai#7853 objectstack-ai#7869 objectstack-ai#7874 objectstack-ai#7877 objectstack-ai#7926 objectstack-ai#7959 objectstack-ai#7967 objectstack-ai#7979 objectstack-ai#7980
objectstack-ai#8058 objectstack-ai#8060 objectstack-ai#8072 objectstack-ai#8127 objectstack-ai#8137 objectstack-ai#8204 objectstack-ai#8229 objectstack-ai#8248 objectstack-ai#8307 objectstack-ai#8408 objectstack-ai#9231 objectstack-ai#9241
objectstack-ai#9244 objectstack-ai#9365 objectstack-ai#9373 objectstack-ai#9375 objectstack-ai#9542 objectstack-ai#9553 objectstack-ai#9585 objectstack-ai#10117 objectstack-ai#10119 objectstack-ai#10120 objectstack-ai#10129
objectstack-ai#10132 #14026. None of them was touched here.
2. **The census instrument is blind to bare PR numbers, and so is the
family list.** PR objectui#10854's census enumerated `objectui#N` and
objectui URLs only, so a bare `#N` that answers 404 never entered the
115: this batch found two by reading its own sentences, objectstack-ai#5505 and objectstack-ai#5758,
both the PRs whose squashes the sentence already cited, and folded them
in (ruling `5861129870`, triage item 3). The printed instrument above
counts a bare number only when the batch names it. ⇒ The next batch's
census should first enumerate every distinct bare `#N` in the two
in-scope classes, read each by REST (`issues/N` and `pulls/N`), and add
the 404s to its number list before it counts. Until that is done the
family pin is incomplete for bare numbers, and nothing here re-derives
how many there are.
3. **Published text outside the two in-scope classes still names some of
these numbers**, untouched by scope (another class, which the triage
split did not scope here): `apps/console`'s `useApiDiscovery.ts`
(non-test source of `@object-ui/console`, bare objectstack-ai#5286, not under
`packages/*/src`), the `@object-ui/data-objectstack` README (objectstack-ai#6864) and
the `@object-ui/plugin-detail` README (objectstack-ai#6464), `content/docs` (objectstack-ai#6896,
and the `text.mdx` / `tree-view.mdx` "Retired" notes that name objectstack-ai#6951;
only their verbatim message quotes moved here), and published
`CHANGELOG.md` history (never re-addressed). Carrier: none.
4. **Filenames are not citations.** Pending changeset FILENAMES carry
several of these numbers; they stay, as in PRs objectui#10707, objectstack-ai#10797
and objectstack-ai#10854.
5. **Test comments left as they are.** `text-value-retired-6951.test.ts`
and `tree-view-data-retired-6951.test.ts` each keep three
`@ts-expect-error` comments reading "RETIRED (objectui#6951)"; they
describe the `?: never` TypeScript face, quote no runtime string, and
tests are otherwise out of this card's classes.

---
_Generated by [Claude
Code](https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
akarma-synetal pushed a commit to akarma-synetal/objectui that referenced this pull request Sep 28, 2026
…ts name 30 objectui issues that answer 404 (objectui#10803, batch 4) (objectstack-ai#10875)

Part of objectstack-ai#10803
Clause-②: no

Dispatched implementation of the `domain:ui` seat 2 claim (comment
`5861571015`) on objectui#10803, batch 4, session
`https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN`. Citations
only: no sentence's claim moves, and every edited pending changeset's
frontmatter is byte-identical. The runtime text that moves loses its
dead pointer and nothing else: the legacy `ActionSchema` `onSuccess` /
`onFailure` tombstone guidance strings open `RETIRED (ADR-0049) —`
(ruling `5861129870` as amended by `5861311219`), and two
`DataTableSchema` zod `.describe()` strings drop their pointer
(amendment `5860244997`, Q1 = A), all in `@object-ui/types`. The one
test that pins the tombstone strings verbatim follows them, and nothing
else in it moves.

**Patch round 1** answers contract review `5861897723` (FAIL on
`d21aeb0f6`) under seat ruling `5861900779` (route a: tests that pin
changed comment text follow it, anchor only). `Test (shard 6/8)` was red
on `layout-default-jsdoc-7361`, whose `TextSchema.variant` pin anchored
on `6942`. The round does four things:
- Three comment-text anchors follow the re-pointed text: the one in
`layout-default-jsdoc-7361` and two in `cellClassNameCensusProse-6921`.
- The `MarkdownSchema` docblock stops crediting `8063bcbdc` with
retirements it never touched (**Special cases** 9).
- The `7004-cli-root-path-line.md` remnant "(the mechanical half)" goes.
- `main` (`de1b879a6`) is merged in by a merge commit (`ae0b81089`),
with no rebase and no force-push.

The round's anchor sweep (**Special cases** 10) shows those three pins
are the only anchors on changed text.

## Why `Part of`, not a closing line

The card stays open for the other 53 numbers of the family remainder
(seat amendment `5860244997`, Q2 = A), listed in **Acceptance notes** 1,
and for the bare-number 404s the C0 census below found.

## Premise, re-measured

- REST `GET /repos/objectstack-ai/objectui/issues/N` for each of the 30:
all 30 answer 404, and a second read of each answers 404 again (30 of
30). `GET .../pulls/N` answers 404 for all 30 too. Lit controls:
objectui#10533 and objectui#7714 answer 200. No number was dropped from
the batch.
- The same 30 in objectstack all answer 200, with subjects unrelated to
the objectui sentences (for example objectstack#6882 is an
`examples/app-todo` trigger finding, while the objectui sentences are
about `DataTableSchema.renderCellEditor`). Two exceptions were read, not
guessed:
- `objectstack#6888` already appears on 5 in-scope lines (`i18n.ts`,
`ActionDefaultInspector.tsx`, `ActionPreview.tsx`, `block-config.ts`,
`action-bar.tsx`), each about the `global_nav` retirement, which is
objectstack#6888's own subject. They are live sister citations,
untouched.
- `UnpublishedAppBar.tsx` wrote "framework PR objectstack-ai#6942" bare.
objectstack#6942 is the pull request "the ADR-0045 publish gate gets its
own machine-managed key — `app.hidden` goes back to meaning navigation",
exactly the `_unpublished` / `hidden` split that heading describes. It
is re-qualified to `objectstack#6942` (Zone 1 item 5).
- Every other site names an objectui card or pull request, confirmed by
its landing commit below.
- Every edited changeset is pending: it is present in `.changeset/` on
`main`.
- Branch point: `e32dae160`. `main` was merged in at `de1b879a6` in
patch round 1 (merge commit `ae0b81089`). Not a shallow checkout.

## C0: the bare-number census (measurement only; PR objectui#10869
Acceptance note 2)

The instrument, over the two in-scope classes at the branch point (a `#`
not preceded by a word character, `#`, `&`, `/`, `.` or `-`, so
`objectui#N`, `objectstack#N`, `cloud#N`, `hotcrm#N` and every other
`word#N` are excluded, as is a `#N` inside a URL):

```
git grep -hoP '(?:^|(?<=[^\w#&/.\-]))#\d+(?![0-9A-Za-z_])' e32dae1 -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | sort -u | wc -l
```

- **1002 distinct bare numbers.** That is over 600, so by the order's
budget only the **980** at or below 10900 were read (replace the final
`wc -l` with `tr -d '#' | awk '$1+0 <= 10900' | wc -l` to reproduce
980). The 22 above 10900 were NOT read.
- Each of the 980 was read once with REST `GET .../issues/N`: **955
answer 200 and 25 answer 404.** Each of the 25 was read a second time
and answered 404 again (25 of 25), and `GET .../pulls/N` answers 404 for
all 25.
- Lit control on the same instrument: objectstack-ai#5026, objectstack-ai#6905 and objectstack-ai#3720 are all in
its output at the branch point. At this head none of the eight batch
numbers it found bare remains.
- The 25, with site counts (lines / files, at the branch point):
- **This batch's own numbers (8), all fixed here:** objectstack-ai#6882 (5 / 2), objectstack-ai#6905
(7 / 2), objectstack-ai#6907 (5 / 1), objectstack-ai#6942 (1 / 1, the objectstack pull request
above, re-qualified), objectstack-ai#6959 (1 / 1), objectstack-ai#6962 (1 / 1), objectstack-ai#7036 (8 / 1), objectstack-ai#7087
(2 / 2). The printed census below already counts a bare `#N` for these.
- **Already on the family list (3), for their own batches:** objectstack-ai#7620 (2 /
2), objectstack-ai#7678 (3 / 3), objectstack-ai#7853 (1 / 1).
- **New to the family (11), for later batches:** objectstack-ai#3720 (5 / 3), objectstack-ai#5420 (1
/ 1), objectstack-ai#5503 (1 / 1), objectstack-ai#5506 (1 / 1), objectstack-ai#5737 (4 / 4), objectstack-ai#6467 (1 / 1), objectstack-ai#6936
(1 / 1), objectstack-ai#6945 (1 / 1), objectstack-ai#7622 (1 / 1), objectstack-ai#7662 (1 / 1), objectstack-ai#7684 (2 / 2).
- **Not citations (3):** `#0` (257 / 187, the `#0` of "AGENTS.md #0.1"),
`#000` (2 / 2) and `#000000` (10 / 6), which are CSS colours.
- **Folded here: none.** No C0 404 outside this batch's 30 sits in a
sentence this batch edits: none of the 11 new numbers, nor any of the
other 53 family numbers, occurs in any hunk of this diff (3 lines of
context).
- The 200 set is not a citation census: many bare numbers are
decision-batch, summons or commandment numbers, or React error codes,
that happen to name a live issue.

## Census (the enumeration pin for this batch)

The instrument PR objectui#10854 printed and PR objectui#10869 reused,
with this batch's 30 numbers substituted (REF = a commit or tree):

```
git grep -nE '(objectui#|#|issues/)(6872|6879|6882|6887|6888|6889|6892|6905|6907|6921|6923|6924|6931|6940|6942|6958|6959|6962|6965|7004|7008|7023|7025|7036|7068|7069|7077|7079|7087|7088)([^0-9]|$)' REF -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | grep -v 'objectstack#' | wc -l
```

- REF = `e32dae160` (branch point): **170** lines, 48 changeset lines in
38 files and 122 src lines in 45 files. REF = `de1b879a6` (the `main`
merged in): 170. REF = `c6678b1bd` (`main` at the round's final read):
170.
- REF = `ae0b81089` (this head, `de1b879a6` merged in): **0**. Round 0's
head `d21aeb0f6` also read 0.
- This head merged with a fresh `main` (`c6678b1bd`, `git merge-tree
--write-tree`, clean, tree `e109a3bd0`): **0**.
- **The instrument's blind spot, as batch 3 measured it.** Its `grep -v
'objectstack#'` drops a whole line that also names an objectstack
number. Three in-scope lines were hidden that way, each naming
objectui#6965 beside objectstack#9343: in
`10039-publish-drafts-advisories.md`, `6965-batch-publish-advisories.md`
and `render-publish-advisory-findings-5026.md`. They are re-pointed here
too, so the batch's true base population is 173 lines (51 changeset
lines in 40 files, 122 src lines in 45 files). Without the filter the
instrument reads 178 at the branch point and **7** at this head, all
live: the five `objectstack#6888` lines, `objectstack#6942` in
`UnpublishedAppBar.tsx`, and the same spelling in the new sweep
changeset.
- Other spellings at this head: a search for the 30 numbers with no `#`
finds only filenames (`action-callback-retired-7068.test.ts`,
`data-table-declared-keys-6882.test.ts` and the like) and two SVG path
coordinates. Hex-colour false positives (a number followed by a hex
letter) at the branch point: 0.
- Lit control, the same printed instrument over live objectui#7714 at
this head: 17 lines.
- **Out of scope, as it stands** (the instrument with the 30 numbers,
unfiltered, whole tree at this head): 226 test lines in 96 files
(`scripts/__tests__` included), 22 scripts lines in 5 files, 0
`.github`, 0 governed, and 18 other lines in 10 files: published
`CHANGELOG.md` history, three `content/docs` lines, and four lines of
the private `@object-ui/test-support` README. See **Acceptance notes**
3.

## Citation form

- The 9-character backticked sha of the commit on `main` that landed the
change the sentence rests on, as in PRs objectui#10707 / objectstack-ai#10766 / objectstack-ai#10797
/ objectstack-ai#10854 / objectstack-ai#10869. All 24 distinct shas below are ancestors of `main`:
`git merge-base --is-ancestor`, exit 0 each. Control leg in the same
checkout: the head of PR objectui#10714 (`d2afdb6bf`) answers exit 1,
and a known ancestor, `5f789538d`, answers exit 0. `git rev-parse
--short=9` returns the same 9 characters for each.
- A changeset's pointer to its OWN card is dropped, not replaced:
`@changesets/changelog-git` prefixes each released entry with the hash
of the commit that added the file, which is that landing. Where dropping
the pointer left a dangling word, the clause was minimally repaired
(**Special cases** 5).
- Where the sentence rests on a RULING, the ruling is cited by its date,
next to the sha that carried it out where one exists (**Special cases**
4).
- Where a dead card sits beside a live pull request that IS its landing,
the dead card is dropped and the live pointer stays (**Special cases**
1), as batch 3 dropped the dead predecessor in "(objectui#5401 →
objectstack-ai#5454)".
- Where the claim lived only on the dead card (a finding, a triage, a
deferral, a quoted ruling), the sha only locates the card: "the card
behind SHA" (**Special cases** 3). This is review `5861306588`'s lesson:
a sha must carry what the sentence cites it for.
- Where nothing answers, the pointer is dropped and the sentence names
the card by role (objectstack-ai#7023 only).
- Runtime text carries no sha: see **Special cases** 7.

## Mapping (number to resolution)

Lines / files are the branch-point census for that number (a line naming
two batch numbers counts for each, and the three hidden objectstack-ai#6965 lines are
included). "Method" is how the landing was found. The last column is why
that commit carries what the sentence cites it for.

| dead number | resolution | method | lines / files | why the commit
carries it |
|:--|:--|:--|:--|:--|
| objectstack-ai#6872 | own-card pointer dropped (landing `d9a0490b7`) | changeset's
adding commit | 1 / 1 | the only site is the objectstack-ai#6872 changeset's own
pointer |
| objectstack-ai#6879 | `3619792bf` | changeset's adding commit, `git log --grep` | 1
/ 1 | it curates `box` into `PUBLIC_BLOCKS`, the list the comment sits
in |
| objectstack-ai#6882 | `bf97b98c8` | changeset's adding commit | 20 / 7 | it declares
`renderCellEditor` and schema-level `cellClassName` on
`DataTableSchema`, adds the `Equal` exact-shape pin, and corrects
`cellClassName`'s reach to the three utility cells |
| objectstack-ai#6887 | `5c09cca27` | changeset's adding commit | 1 / 1 | it derives
metadata-viewer's option shape from the spec's `SelectOption` with the
`Omit` the comment names |
| objectstack-ai#6888 | `320374d2a` | changeset's adding commit | 9 / 7 | it keys
`LocationField`'s residue refusal and the two coordinate nouns into the
locale packs |
| objectstack-ai#6889 | `f75810e7c` | changeset's adding commit, `git log -S` | 8 / 1
| it parses a dropped-fields entry's `fields` and `object` instead of
asserting them, the gate the comments describe |
| objectstack-ai#6892 | own-card pointers dropped (landings `8d40c18a7`, `951fa8e0d`)
| changesets' adding commits | 2 / 2 | both sites are slice changesets'
pointers to their own card |
| objectstack-ai#6905 (a pull request) | `85f6a6097` | `git log --grep`: its squash
subject ends "(objectstack-ai#6905)" | 8 / 2 | it judges gantt dates by TYPE before
`new Date`, the "objectstack-ai#6781 type rule" the sentences name |
| objectstack-ai#6907 | `7fc5c3c12` | changeset's adding commit, `git log -S` | 7 / 2
| it spells a refused gantt date by a rule, and its changeset records
the measured throwing-getter crash |
| objectstack-ai#6921 | `4eb665bcf` | changeset's adding commit, `git log --grep` | 2
/ 2 | it pins, in the rendered DOM, which body cells schema-level
`cellClassName` reaches |
| objectstack-ai#6923 | `d3bf4fa6f`; "the 2026-08-31 ruling" | changeset's adding
commit, `git log --grep` | 5 / 4 | it gives the wrapper-key list its
build-free JSON home "per the 2026-08-31 ruling on objectui#6923" |
| objectstack-ai#6924 | `78e98bf44`; PR objectstack-ai#7024 kept | changeset's adding commit, `git
log --grep` | 5 / 3 | it adds the one enum-options walk for the
top-level reader family |
| objectstack-ai#6931 | `8063bcbdc` | changeset's adding commit, `git log -S` | 8 / 5
| it converts the remaining eleven tombstones, `confirm` and the menu
divider `type` included, to `retirementTombstone()`. At the
`MarkdownSchema` site, which `8063bcbdc` never touched (`446d93d4e`
retired those keys), it is cited only as the commit that made that
spelling uniform: see **Special cases** 9 |
| objectstack-ai#6940 | pointers dropped (landing `0c386dd7f`) | changeset's adding
commit | 2 / 2 | the only sites are its own changeset's pointer and a
`.describe()` string |
| objectstack-ai#6942 | `57f9b077b`; one site re-qualified to objectstack#6942 | `git
log --grep`; REST for the sister PR | 6 / 4 | it makes `ui:text` honour
the published `variant` enum, with a node that omits the key left
without a typography class |
| objectstack-ai#6958 | `6a449fc49` | changeset's adding commit | 6 / 5 | it clears a
field its own `visibleWhen` hides |
| objectstack-ai#6959 | `c0c436db8` | changeset's adding commit | 2 / 1 | it keeps the
find-call gate and adds a second one, and records the trap that a mock
call is one resolution ahead of its value |
| objectstack-ai#6962 | `7b433197d` | changeset's adding commit | 3 / 2 | it removes
`publishDraft`'s envelope unwrap after measuring the route at the
producer |
| objectstack-ai#6965 | `ce986aafc`; PR objectui#10038 kept at three sites |
changeset's adding commit, `git log --grep`; its body names the card it
settles | 21 / 9 | it routes "publish whole app" through the advisory
seam, adds `publishPackageDrafts`, and writes the "Corrected before
release" note |
| objectstack-ai#7004 | `85b495795` (root Path line); `a5d55472b` (arm selection) |
both changesets' adding commits | 7 / 4 | the first gives a root-level
issue a Path line; the second prints the arm the document selected, per
the 2026-09-02 ruling |
| objectstack-ai#7008 | `f08bcd9af` | changeset's adding commit | 15 / 11 | it makes
`FieldEditWidget` deliver the declared NON-DOM block through
`toHostProps`, and corrects `RequiredFieldsDialog` |
| objectstack-ai#7023 | nothing answers: the card named by role | `git log --grep`
finds only `d88e20f55`, the objectstack-ai#4895 retirement it dissolved into | 1 / 1 |
see **Special cases** 3 |
| objectstack-ai#7025 | own-card pointer dropped (landing `14884620e`) | changeset's
adding commit | 1 / 1 | the only site is its own changeset's pointer |
| objectstack-ai#7036 | `869b876c8` | `git log -S` on the timeline renderer | 11 / 1 |
it scopes the speller's totality claim, and refuses a `catch` because it
would substitute `an object` for a failure |
| objectstack-ai#7068 | `6bca0e4e8`; runtime text `RETIRED (ADR-0049) —` | changeset's
adding commit | 8 / 3 | it retires the callback pair as ADR-0049
tombstones and deletes `ActionCallback` / `ActionCallbackSchema` |
| objectstack-ai#7069 | `2760075ff` | changeset's adding commit | 3 / 3 | it adds the
fifth parity ledger that watches the mirror-wider-than-declared
direction |
| objectstack-ai#7077 | own-card pointer dropped (landing `00d3f09c5`) | changeset's
adding commit | 1 / 1 | the only site is its own changeset's pointer |
| objectstack-ai#7079 | own-card pointer dropped (landing `ab7dc31ce`) | changeset's
adding commit | 1 / 1 | the only site is its own changeset's pointer |
| objectstack-ai#7087 | `c93b4d5f3` | changeset's adding commit | 8 / 6 | it drops the
18 `disabled?: boolean` narrowings, adds the twin-symmetry pin, and
keeps the six independent `boolean` declarations |
| objectstack-ai#7088 | `c1fe272ad` | changeset's adding commit | 4 / 3 | it corrects
`BaseSchema.hidden`'s JSDoc to the single hide path and records the
synonymy |

## Special cases (the judgement calls)

1. **A dead card beside its own live landing.**
- "objectui#6965 / PR objectui#10038" (`AiChatPage.tsx`,
`PendingDraftsBar.tsx`, `StudioDesignSurface.tsx`) becomes "PR
objectui#10038". PR objectui#10038 answers 200 and is the landing of
`ce986aafc`, so the dead half goes and the live half stays.
- `7025-nonoptional-enum-cast.md`: "the same walk objectui#6924
converged the optional-cast family onto in PR objectstack-ai#7024" becomes "the same
walk PR objectstack-ai#7024 converged the optional-cast family onto". PR objectstack-ai#7024 answers
200 and is `78e98bf44`'s pull request.
2. **The sister-repo number.** In `UnpublishedAppBar.tsx`,
"(objectstack#4829 A1, framework PR objectstack-ai#6942)" becomes "(objectstack#4829
A1, framework PR objectstack#6942)". See **Premise**.
3. **The card named by role.**
- **objectstack-ai#7023**, in `4895-retire-block-schema-family.md`: "and objectui#7023
— the narrower validator-only fix — dissolves into this retirement"
becomes "and the separate card for the narrower validator-only fix
dissolves into this retirement". That card never landed on its own.
- **"The card behind SHA"**, where the sentence rests on something that
lived only on the card:
- `6755-field-diagnostics-i18n.md`: "objectui#6888 carries it" becomes
"The card behind `320374d2a` carries it". Carrying a pending item is the
card's act.
- `data-objectstack` `index.ts`: "Unlike objectui#6889's exotic case"
becomes "Unlike the exotic case on the card behind `f75810e7c`". The
exotic case is not in the commit.
- `toHostProps.ts`: "the specific mistake objectui#7008's ruling fences
off" becomes "the specific mistake the ruling on the card behind
`f08bcd9af` fences off". The quoted ruling text is the card's, not the
commit's.
- `zod-wrapper-keys.ts`: "the wall objectui#6923 was filed to get a
ruling on" becomes "the wall the card behind `d3bf4fa6f` was filed to
get a ruling on".
- `base.zod.ts`: "objectui#7069 called this repo's systematic producer"
becomes "the card behind `2760075ff` called this repo's systematic
producer". The commit's own diff attributes that phrase to the card.
- The timeline renderer names objectstack-ai#7036's deferral, triage and "1 of 6"
trade. These become "the file surface the card behind `869b876c8`
deferred", "the triage of the card behind `869b876c8`" and "the card
behind `869b876c8` was stopped from making". None of the three is in the
commit.
4. **Rulings by date.**
- `union-arm-diagnostics.ts`: "the 2026-09-02 ruling on objectui#7004
asks for" becomes "the 2026-09-02 ruling `a5d55472b` implements asks
for".
- `validate.ts`: "The ARM-SELECTION half of objectui#7004 landed on the
2026-09-02 maintainer ruling" becomes "The ARM-SELECTION half
(`a5d55472b`) landed on the 2026-09-02 maintainer ruling".
- `7201-schema-slot-census-gate.md`: "across objectui#6882, the ruling
that expired both holds" becomes "across the 2026-08-30 ruling that
expired both holds (`bf97b98c8`)".
- `7687-combobox-option-disabled.md`: "by the objectui#7087
twin-symmetry ruling" becomes "by the 2026-09-01 twin-symmetry ruling,
`c93b4d5f3`".
- `defaults-table-scan.ts`: "the one objectui#6923 already ruled for
exactly that wall" becomes "the one the 2026-08-31 ruling (`d3bf4fa6f`)
already set for exactly that wall".
5. **Own-card pointers that needed a word.**
- `6931-tombstone-guidance-remainder.md` and
`6888-location-residue-refusal-keyed.md`: the pointer sat on its own
line, so the period moved up with it.
- `7087-disabled-twin-symmetry.md`: the parenthesis opened on the dead
card, so the line break moved with it.
- `7004-cli-root-path-line.md`: "(objectui#7004, mechanical half)" is
dropped, so the sentence ends "sits at the document root." (patch round
1 took the review's nit), and "left open on objectui#7004 for a
maintainer ruling" becomes "left open for a maintainer ruling".
- `shared-zod-wrapper-keys-6923.md`: "objectui#6923: the Zod wrapper-key
list" becomes "The Zod wrapper-key list".
- `vi-mock-inherit-slice2.md` and `slice3.md`: "(objectui#6892 slice 2)"
becomes "(slice 2)", and likewise for slice 3.
6. **The totality sequence in the timeline renderer.** "(objectstack-ai#6759 -> objectstack-ai#6905
-> objectstack-ai#6907 -> objectstack-ai#7027)" becomes "(objectstack-ai#6759 -> `85f6a6097` -> `7fc5c3c12` ->
objectstack-ai#7027)", and likewise with "-> objectstack-ai#7036" as `869b876c8`. objectstack-ai#6759 and objectstack-ai#7027
answer 200 and stay. objectstack-ai#6905 was the pull request whose squash is
`85f6a6097`. "⚠️ objectui#7036 — READ THE TWO PARAGRAPHS" becomes "⚠️
`869b876c8` — READ…", and the "see the objectui#7036 note below" that
points at it follows.
7. **The runtime strings.** Only the listed text moves in each.

| file | member | before | after |
|:--|:--|:--|:--|
| `types/src/zod/crud.zod.ts` | `ActionSchema.onSuccess` (tombstone) |
"RETIRED (objectui#7068) — `onSuccess` is no longer part of this legacy
ActionSchema; ..." | "RETIRED (ADR-0049) — `onSuccess` is no longer part
of this legacy ActionSchema; ..." |
| `types/src/zod/crud.zod.ts` | `ActionSchema.onFailure` (tombstone) |
"RETIRED (objectui#7068) — `onFailure` is no longer part of this legacy
ActionSchema; ..." | "RETIRED (ADR-0049) — `onFailure` is no longer part
of this legacy ActionSchema; ..." |
| `types/src/zod/data-display.zod.ts` | `DataTableSchema.rowActions`
`.describe()` | "... mirrors the boolean the renderer truthiness-tests
(objectui#6940)" | "... mirrors the boolean the renderer
truthiness-tests" |
| `types/src/zod/data-display.zod.ts` | `DataTableSchema.cellClassName`
`.describe()` | "... so row density has to be set on both
(objectui#6882)" | "... so row density has to be set on both" |

**The ADR-0049 condition, measured from the retirement itself** (Zone 1
item 4):
- the zod comment above the two keys opens "ADR-0049 RETIREMENT
TOMBSTONES";
- its landing commit `6bca0e4e8` writes them as tombstones, not
deletions, and adds the pending `action-callback-retired-7068.md`, which
says "ADR-0049 enforce-or-remove";
- each string already ends "Retired under ADR-0049 enforce-or-remove".

Both open `RETIRED (ADR-0049) —`. Their TypeScript twins in `crud.ts`
read "RETIRED (`6bca0e4e8`, ADR-0049 enforce-or-remove)", the batch 3
twin form.
8. **What follows the strings, and nothing else in it.**
`action-callback-retired-7068.test.ts` pins both guidance strings as
full literals (`ON_SUCCESS_GUIDANCE`, `ON_FAILURE_GUIDANCE`), and their
openings follow. Its test names and four `@ts-expect-error` comments
still read "RETIRED (objectui#7068)". They describe the `?: never`
TypeScript face, quote no runtime string, and are out of the card's
classes (**Acceptance notes** 3). No test, doc or changeset quotes
either `.describe()` string: a whole-tree search for each old string
returns only the source line.
- Patch round 1: three pins quoted re-pointed COMMENT text, and they
follow it, anchor only (ruling `5861900779`, route a).
- `layout-default-jsdoc-7361.test.ts`: `toContain('6942')` becomes
`toContain('57f9b077b')` (the `TextSchema.variant` docblock).
- `cellClassNameCensusProse-6921.test.ts`:
`toMatch(/objectui#6882|objectstack-ai#6882/)` becomes `toMatch(/bf97b98c8/)` (the
`cellClassName` census entry).
- The same file: `toMatch(/REDUNDANT since objectui#6882/)` becomes a
match on "REDUNDANT since `bf97b98c8`" (the holds-member docblock).
     - Their titles, messages and comments stay as they are.
9. **The `MarkdownSchema` docblock (patch round 1, review
`5861897723`).** Round 0 wrote "Both refuse BY NAME through
`retirementTombstone()` (`8063bcbdc`), with the remedy in the message".
`8063bcbdc` never touched `MarkdownSchema`; `446d93d4e` retired
`sanitize` / `components`. So the sha did not carry what it was cited
for, the objectstack-ai#5738 class. It now reads "through `retirementTombstone()`, the
spelling `8063bcbdc` made uniform, with the remedy in the message". That
commit's own subject says the remaining tombstones carry their
remediation text. The edit is a comment, and the file's C4 print is
unchanged by it.
10. **The anchor sweep that closes the gap (patch round 1).**
- **Instrument:** every string, template, numeric and regex literal in
all 3814 test and script files under `packages/` and `scripts/`,
enumerated with `git ls-tree` at this head and parsed with TypeScript.
- **Test applied to each literal:** does its occurrence count DROP
between `main` and this head in any of the 90 files this PR changes? Raw
text and a comment-flattened form are both checked.
- **Specific anchors found** (a batch number, a changed phrase, or a
pattern keyed to them), after reading every hit against the file it sits
in:
     - the three pins above;
- `tombstone-discriminator-agreement-9684`'s /RETIRED \(objectui#/ note
search, which reads only `mobile.ts` and is untouched by this PR.
- **Everything else:** generic tokens (whitespace, punctuation,
`objectui#` spellings in ledger checks over the tests' own data, digit
and letter classes), none of them an assertion over text this PR
changed.
- **Round 0's quote search** covered runtime strings only. That is the
gap this sweep closes.

## Held

**By the serial rule: nothing.** Round 0's list: objectui#10873, objectstack-ai#10871,
objectstack-ai#10870, objectstack-ai#10852, objectstack-ai#10821, objectstack-ai#10780, objectstack-ai#10777, objectstack-ai#10714, objectstack-ai#10278 and objectstack-ai#5400. Since
then objectstack-ai#10873, objectstack-ai#10871, objectstack-ai#10870 and objectstack-ai#10821 have merged. objectstack-ai#10870 touched
`base.zod.ts` in a region apart from this PR's line, and the merge with
it is clean.
- Re-read before the round-1 push: 11 open. Besides this PR they are
objectui#10880, objectstack-ai#10879, objectstack-ai#10878, objectstack-ai#10876, objectstack-ai#10852, objectstack-ai#10780, objectstack-ai#10777, objectstack-ai#10714,
objectstack-ai#10278 and the release PR objectstack-ai#5400.
- Four of them hold files this PR edits:
  - objectui#10879: `types/src/zod/data-display.zod.ts`;
- objectui#10878: `data-objectstack/src/index.ts` and
`plugin-grid/src/ObjectGrid.tsx`;
- objectui#10714: `types/src/data-display.ts`, `types/src/layout.ts` and
`types/src/zod/data-display.zod.ts`;
  - objectui#10278: `plugin-grid/src/ObjectGrid.tsx`.
- Each one's hunks were read against its merge-base, with 3 lines of
context. **None of the 29 lines this PR changes in those files appears
inside or beside any of their hunks.**
- Trial merges of each open PR head with this head (`git merge-tree
--write-tree`) are clean for objectstack-ai#10880, objectstack-ai#10879, objectstack-ai#10878, objectstack-ai#10876, objectstack-ai#10852,
objectstack-ai#10780, objectstack-ai#10777 and objectstack-ai#10714.
- objectstack-ai#10278 (`eab4c8e52`) conflicts in `ObjectGrid.tsx`, but it conflicts
identically against `main` alone: one conflict hunk in its own page-size
region either way.
- PR objectstack-ai#5400 (Version Packages) regenerates and is not a hold.

## Changesets

- `.changeset/10803-dead-citation-sweep-fourth-batch.md`, EMPTY
frontmatter: the comment-only edits in 12 released packages and the
private `@object-ui/test-support`. No published behaviour changes
through them. It points at the second file for the runtime text.
- `.changeset/10803-fourth-batch-runtime-strings.md`,
`'@object-ui/types': patch`: the two tombstones open `RETIRED (ADR-0049)
—` with everything after the dash unchanged, and the two describe
strings lose their pointer. No key, path, issue code, accept set,
refusal or severity moves.

## Proof of prose-only (C4), against the merged `main` `de1b879a6`

- **Source.** Each of the 48 touched `.ts` / `.tsx` files was parsed at
`de1b879a6` and at this head with TypeScript 6.0.3's `createSourceFile`
and re-printed by `createPrinter({ removeComments: true })`. The 48 are
the 45 non-test sources and three tests: the one pinning the strings,
and the two whose comment-text anchors follow.
- 43 of 48 prints are identical. That includes all 45 non-test sources
except `crud.zod.ts` and `data-display.zod.ts`, whose `MarkdownSchema`
comment edit moves nothing.
- The other 5 are equal once exactly the 9 listed substitutions are
applied to the `main` print, each matched once:
    - `crud.zod.ts`: the two tombstone strings;
    - `data-display.zod.ts`: the two describe-string deletions;
- `action-callback-retired-7068.test.ts`: the same two tombstone
strings;
    - `layout-default-jsdoc-7361.test.ts`: the one anchor;
    - `cellClassNameCensusProse-6921.test.ts`: the two anchors.
  - 0 parse diagnostics.
- Lit controls on the same instrument: dropping "(ADR-0049)" from the
`onSuccess` string moves the print; re-spacing the "ADR-0049 RETIREMENT
TOMBSTONES" comment does not.
- **Changesets.** The frontmatter block of every one of the 40 edited
changesets is byte-identical at `de1b879a6` and this head (40 of 40, by
md5). The overwrite gate below agrees.
- **Scope of the diff against the merged `main`:** 90 files, +227 /
−184: 40 edited and 2 new changesets, 45 non-test source files, and 3
tests.

## Gates, on this head `ae0b81089`

Each line is the gate's own verdict and exit code, captured by
redirect-then-`$?`.

- `node scripts/check-changeset-presence.mjs`, exit 0: "44 source
file(s) of 12 released package(s) changed, and this change declares 2
changeset(s): .changeset/10803-dead-citation-sweep-fourth-batch.md,
.changeset/10803-fourth-batch-runtime-strings.md." (44 = the 41 released
sources and the 3 tests under released packages' `src/`; the four
`test-support` files sit under a package changesets ignores.)
- `pnpm changeset:check`, exit 0: "All workspace packages are in the
changeset fixed group." / "No changeset declares a `major` bump."
- `node scripts/check-changeset-overwrite.mjs` (report-only), exit 0: "2
changeset(s) added, 40 modified, 0 deleted". `declared at base` equals
`declares now` for 40 of 40.
- `pnpm check:changeset-claims` (report-only), exit 0:
- born-false: "Every one of those 1 address(es) either names the tree it
was read from, or points at a line this change does not move";
- self-contradiction: "Every package declared across those 30 body(ies)
is either not negated in its own prose, or negated only in an ASPECT of
it that may legitimately hold still";
- the standing notice "83 pending changeset(s) describe a file this
change touches".
- Read against the diff: a pending changeset quoting a replaced pointer
would itself carry the dead number and so sit in the census. No pending
changeset quotes either tombstone string or either describe string; the
one textual hit, "truthiness-tests" in
`6940-rowactions-boolean-mirror.md`, is prose, not a quote.
- `pnpm check:control-bytes`, exit 0: "check-control-bytes: OK (scanned
9125 tracked text file(s); skipped 85 binary)."
- `pnpm check:new-line-citations`, exit 0: "VERDICT
new-cross-file-line-citations: 0 new citation(s), enforcement
report-only -> exit 0".
- Also run: the governed-surface predicate over the 90 paths, exit 0:
"NOT GOVERNED — 90 path(s) checked against 5 governed surface(s); none
matched." (lit control `AGENTS.md`: exit 3).

**Tests**, through the shared verify lock.
- **Red, reproduced first.**
- `layout-default-jsdoc-7361` on `d21aeb0f6` itself gives `VERDICT
command-exit 1`, `Tests 1 failed | 74 passed (75)`: "expected '/**\n *
Text variant/style. …' to contain '6942'".
- `cellClassNameCensusProse-6921`: its `d21aeb0f6` copy was checked out
over this tree and run. `ObjectGrid.tsx` and the census changesets it
reads are identical at `d21aeb0f6` and here. Result: `Tests 2 failed | 3
passed (5)`, on `/objectui#6882|objectstack-ai#6882/` and `/REDUNDANT since
objectui#6882/`. The file was then restored with `git checkout HEAD --`,
checked by blob hash against `HEAD`, and `git diff HEAD` came back
empty.
- **Green, on this head `ae0b81089`:** `layout-default-jsdoc-7361`,
`cellClassNameCensusProse-6921`, `action-callback-retired-7068`,
`data-table-declared-keys-6882`,
`tombstone-discriminator-agreement-9684` and `zod-mirror-parity` give
`Test Files 6 passed (6)`, `Tests 181 passed (181)`.
- The run was the last part of the locked batch, so its exit is the one
the lock's `VERDICT batch-last-exit 0` reports.

**Declared narrowing (per the dispatch: the named checks, not wider
sweeps).** NOT MEASURED locally: the full suites and type-check of the
12 touched packages, and eslint. Reason: the comment-stripped syntax
tree of 43 of the 48 touched files is identical to `main`, and the other
5 differ only by the listed literal edits. Every test that anchors on a
changed string or comment was found by the anchor sweep (**Special
cases** 10) and run above. CI runs the full farm.

## Acceptance notes

1. **The remainder rides this card, unchanged (seat amendment
`5860244997`, Q2 = A).** Of the 83 numbers PR objectui#10869's
Acceptance notes item 1 lists, this PR carries the first 30 in ascending
order. The other **53** are: objectstack-ai#7091 objectstack-ai#7097 objectstack-ai#7108 objectstack-ai#7177 objectstack-ai#7612 objectstack-ai#7620 objectstack-ai#7623
objectstack-ai#7658 objectstack-ai#7666 objectstack-ai#7667 objectstack-ai#7669 objectstack-ai#7678 objectstack-ai#7681 objectstack-ai#7682 objectstack-ai#7703 objectstack-ai#7704 objectstack-ai#7708 objectstack-ai#7804 objectstack-ai#7844
objectstack-ai#7853 objectstack-ai#7869 objectstack-ai#7874 objectstack-ai#7877 objectstack-ai#7926 objectstack-ai#7959 objectstack-ai#7967 objectstack-ai#7979 objectstack-ai#7980 objectstack-ai#8058 objectstack-ai#8060 objectstack-ai#8072
objectstack-ai#8127 objectstack-ai#8137 objectstack-ai#8204 objectstack-ai#8229 objectstack-ai#8248 objectstack-ai#8307 objectstack-ai#8408 objectstack-ai#9231 objectstack-ai#9241 objectstack-ai#9244 objectstack-ai#9365 objectstack-ai#9373
objectstack-ai#9375 objectstack-ai#9542 objectstack-ai#9553 objectstack-ai#9585 objectstack-ai#10117 objectstack-ai#10119 objectstack-ai#10120 objectstack-ai#10129 objectstack-ai#10132 #14026. None
of them occurs in any hunk of this diff.
2. **The C0 bare-number 404s, for later batches** (sites at `e32dae160`,
lines / files):
- **New to the family:** objectstack-ai#3720 (5 / 3), objectstack-ai#5420 (1 / 1), objectstack-ai#5503 (1 / 1),
objectstack-ai#5506 (1 / 1), objectstack-ai#5737 (4 / 4), objectstack-ai#6467 (1 / 1), objectstack-ai#6936 (1 / 1), objectstack-ai#6945 (1 /
1), objectstack-ai#7622 (1 / 1), objectstack-ai#7662 (1 / 1), objectstack-ai#7684 (2 / 2).
- objectstack-ai#5737, objectstack-ai#6945, objectstack-ai#7622, objectstack-ai#7662 and objectstack-ai#7684 are written "PR #N". A later
batch can look for each one's squash commit, as batch 3 did for objectstack-ai#5505
and objectstack-ai#5758.
- The objectstack-ai#3720 sites are in `ObjectGrid.tsx`, `rowCrudAffordances.ts` and
`ListView.tsx`. `ObjectGrid.tsx` is also held by open PR objectui#10278.
- **Already on the family list:** objectstack-ai#7620, objectstack-ai#7678 and objectstack-ai#7853. They have bare
sites too, which the printed instrument counts.
- **Not read:** the 22 distinct bare numbers above 10900 (budget).
Nothing here re-derives whether any of them is dead.
3. **Published or shipped text outside the two in-scope classes still
names some of these numbers.** It is untouched by scope, as another
class the triage split did not scope here:
- `content/docs`: `enhanced-actions.mdx` and `schema-overview.md` say
the callbacks were "RETIRED (objectui#7068)" in prose, not as verbatim
quotes of the runtime string; `plugin-form.mdx` names objectui#6958.
- The private `@object-ui/test-support` README names objectui#6923 and
objectstack-ai#6924.
- Published `CHANGELOG.md` history, which is never re-addressed. It
includes a bare "framework PR objectstack-ai#6942" in `@object-ui/app-shell`'s.
- In tests: `action-callback-retired-7068.test.ts`'s test names and four
`@ts-expect-error` comments reading "RETIRED (objectui#7068)";
`layout-default-jsdoc-7361.test.ts`'s header-table comment naming
objectui#6942; and the test names and comments in
`cellClassNameCensusProse-6921.test.ts` that name objectstack-ai#6882. Only anchors
moved (ruling `5861900779`).
   - Carrier: none.
4. **Filenames are not citations.** Pending changeset and test FILENAMES
carry several of these numbers. They stay, as in PRs objectui#10707,
objectstack-ai#10797, objectstack-ai#10854 and objectstack-ai#10869.

---
_Generated by [Claude
Code](https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment