Skip to content

fix(plugin-form): the top-level fields descriptions and the unresolved-member warning stop teaching { name } as tolerated (objectui#11550) - #11566

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-11550-tolerated-descriptions
Oct 3, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-11550-tolerated-descriptions

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #11550

Clause-②: no

The patch round of objectui#11550: the seat's decision A (comment 5970513384) under triage ruling 5969880008 item 1, "the authoring faces stop teaching it". The card stays open after this merges: its governed guide PR objectui#11561 is still in flight, and the seat ends the card when both are in.

What changes

  • packages/plugin-form/src/index.tsx: the fields input description of object-form, view:form and embeddable-form drops "; { name } is tolerated" from "Bare field names to show, in order (each looked up in the object schema; …)". The object-master-detail-form one drops "({ name } tolerated)" after "Members are bare field names". Every other sentence is unchanged.
  • packages/plugin-form/src/sectionFields.ts: the warnUnresolvedTopLevelField message drops "({ name } is tolerated)". It still says "Top-level fields takes bare field-name strings", still names sections[].fields and FormFieldSchema, and still tells the author to use a bare field-name string or a sections[].fields entry. Its docblock now says the top level takes only bare field-name strings, and that a STORED { name } entry still reads but is no authoring spelling.
  • .changeset/11550-fields-tolerated-teaching-dropped.md: @object-ui/plugin-form patch, because the text ships (measured in dist/ below).
  • Not touched: the stored read (SimpleObjectForm's fieldsToShow loop in ObjectForm.tsx, buildFlatFields in flatFields.ts), the section shape-3 entry, and ObjectFormSchema.

Premise check, on main 072b7e8

  • Re-grep of is tolerated and tolerated) over packages/plugin-form/src: 6 hits, exactly the claimed sites (three identical descriptions, the master-detail one, the warning, its docblock). After this change: 0 hits.
  • Repo-wide, no test, snapshot, README or docs page quotes either the description sentence or the warning sentence. The claim's lead "any test that pins that exact text" found none. The three warning pins (objectFormFieldsMembers-8071, topLevelFieldsWarnCoverage-8847, flatFields.test.ts) assert the substrings { field: 'note' }, sections[].fields, FormFieldSchema and "top-level fields", and all four are kept.

Verification, head 701ada6

  • Build closure, pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-form^...' build: 11 packages built, exit 0.
  • pnpm exec vitest run --maxWorkers=2 packages/plugin-form/ (repo-root form): Test Files 163 passed (163), Tests 1889 passed, 1 skipped (1890).
  • pnpm --filter @object-ui/plugin-form type-check: exit 0, with the script name echoed.
  • eslint . in packages/plugin-form (the package's own lint script), JSON output: 203 files, 0 errors. The two edited files carry 22 and 10 warnings, the same counts as their 072b7e8 copies linted through stdin. The root config extends tseslint.configs.recommended and enables no type-aware linting, so this diff cannot move an untouched file's verdict. Repo-wide pnpm lint is CI's.
  • Shipped text: after pnpm --filter @object-ui/plugin-form build, no file in dist/ contains is tolerated. The new warning sentence is in dist/index.js and dist/index.umd.cjs, and the new description sentence appears 3 times in dist/index.js.
  • Gates, all exit 0: check:control-bytes OK; check:new-line-citations 0 new; check:pending-changeset-literals OK; check-changeset-presence (2 source files of 1 released package, 1 changeset); check-changeset-no-major; check-changeset-overwrite (0 modified); check-changeset-fixed; check:element-data-source-declaration; check-governed-queue-guard --test answers NOT GOVERNED.
  • check:changeset-claims (report-only) asked for three pending paragraphs that name sectionFields.ts to be re-read. 9884-master-detail-fields-intersection.md and console-formpage-visible-predicates-5594.md stay true. 8738-fields-warn-route1.md stays true of the read but still says "{ name } tolerated": see the first acceptance note.

Acceptance notes

  • .changeset/8738-fields-warn-route1.md is still pending, so it publishes into the same CHANGELOG release as this patch. It says "Top-level fields reads only bare field-name strings ({ name } tolerated)". That is still true of the runtime read, but it is the one remaining shipped text that calls { name } tolerated. It is not edited here. It is a changeset this change does not own (check-changeset-overwrite reports exactly that kind of edit), and it is outside the claimed file surface. The seat decides.
  • FlatFieldsContext.fields' docblock in flatFields.ts still says "objects carrying one ({ name })". It describes the kept read and is not exported; the seat already recorded it in 5970513384. Not touched.
  • The console ledger row object-form.fields in registry-inputs-spec-parity.test.ts still calls the { name } spelling "the read site's tolerance rather than a second contract". That is test prose about the pinned stored read, not an authoring face. Not touched.

Left to CI

Repo-wide pnpm lint, the pnpm test shards (the console suites included; registry-inputs-spec-parity only asserts each description is non-empty), e2e and the performance budget.

Session: https://claude.ai/code/session_01FjqrwXPfSMkSfkKYDSRkN2


Generated by Claude Code

…ved-member warning stop teaching `{ name }` as tolerated (objectui#11550)

The four top-level `fields` input descriptions (`object-form`, `view:form`,
`embeddable-form`, `object-master-detail-form`) and the
`warnUnresolvedTopLevelField` text no longer say a `{ name }` object member
"is tolerated". They still say the members are bare field names, and the
warning still names the right spelling. The stored `{ name }` read in
`ObjectForm.tsx` and `flatFields.ts` is unchanged, per the triage ruling that
a stored entry may stay readable.

Patch changeset for `@object-ui/plugin-form`, because the text ships.

Claude-Session: https://claude.ai/code/session_01FjqrwXPfSMkSfkKYDSRkN2
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the plugin label Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 3 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/8738-fields-warn-route1.md

  • names sectionFields.ts → packages/plugin-form/src/sectionFields.ts — edited by this change

    Top-level fields reads only bare field-name strings ({ name } tolerated) — a different vocabulary from sections[].fields, which also accepts the spec FormFieldSchema object (identity key field, e.g. { field: 'note', colSpan: 2 }). Moving one of those objects into a top-level fields array resolves to no name and used to vanish without a word; it is now reported once per distinct offender via console.warn, naming the skipped shape and the vocabulary difference, modelled on sectionFields.ts's existing warnOnMixedVocabulary.

.changeset/9884-master-detail-fields-intersection.md

  • names sectionFields.ts → packages/plugin-form/src/sectionFields.ts — edited by this change

    So the rendered outcome is unchanged and the intersection stands: the parent field pool is built from fields first, and each section resolves its members against that pool. What changed is that the loss is audible. warnSectionMemberExcludedByFields (sectionFields.ts, beside the two warnings objectui#8738 and objectui#3090 added) names the section, the member and the two keys that collided, once per distinct pair, whenever a member the object really declares is dropped for the sole reason that fields omits it — including the expensive case where it was the section's last surviving member and the section disappears with its heading. A member the object never declares at all is deliberately NOT recruited into this warning: it resolves to nothing whether or not fields is authored, which is a different silence with a different remedy.

.changeset/console-formpage-visible-predicates-5594.md

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with b0bf413ca (merge-base with origin/main): 2 file(s) changed outside .changeset/, read against 2088 pending declaration(s) that publish a body (2723 pending in total). · run

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 330 chunks) 3309.4 KB 3330.4 KB
Main entry chunk (gzip) 150.4 KB 350 KB
Entry file index-DNpnn7eD.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.88KB 6.25KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.17KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.70KB 10.94KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 572.97KB 137.34KB
core (index.js) 10.00KB 3.96KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 232.57KB 64.51KB
fields (index.js) 261.62KB 66.20KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 35.66KB 9.49KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 39.47KB 11.25KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.86KB 5.00KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.52KB 2.26KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 53.17KB 15.46KB
plugin-charts (index.js) 83.60KB 22.89KB
plugin-chatbot (index.js) 198.22KB 46.97KB
plugin-dashboard (index.js) 142.26KB 38.44KB
plugin-designer (index.js) 231.28KB 48.76KB
plugin-detail (index.js) 245.59KB 64.56KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 175.44KB 45.28KB
plugin-gantt (index.js) 179.16KB 45.06KB
plugin-grid (index.js) 235.02KB 64.63KB
plugin-kanban (index.js) 49.59KB 15.58KB
plugin-list (index.js) 116.46KB 28.93KB
plugin-map (index.js) 25.60KB 8.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 38.80KB 11.71KB
plugin-tree (index.js) 14.51KB 5.15KB
plugin-view (index.js) 90.23KB 22.73KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 6.06KB 2.68KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 21.42KB 7.05KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.16KB 1.96KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.07KB 2.39KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.25KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 3, 2026 16:56
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 3, 2026 16:56
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 3, 2026
Merged via the queue into main with commit dbd1081 Oct 3, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-11550-tolerated-descriptions branch October 3, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant