Skip to content

feat(plugin-form): derive the inline grid default columns through the spec rule deriveInlineGridColumns (objectui#11345) - #11623

Merged
objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/issue-11345-derive-inline-grid-columns
Oct 4, 2026
Merged

objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/issue-11345-derive-inline-grid-columns

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #11345

Clause-②: no

What this PR is

deriveColumns, the default columns of a master-detail inline grid whose author listed none, now takes which columns it draws, their order and their defaultHidden flag from @objectstack/spec's deriveInlineGridColumns, and its visible budget from the spec's DEFAULT_MAX_INLINE_GRID_COLUMNS. objectui's own per-column builder stays over the returned names (extracted as deriveColumn), so each column's label, cell type, options, lookup target, conditional rules and computed expression are built exactly as before, including the plain text column for a falsy field definition.

Deleted from packages/plugin-form/src/deriveMasterDetail.ts: curateColumns, NAME_LIKE_FIELDS, TYPE_FILL_PRIORITY, fillPriority, NON_EDITABLE_TYPES, and the module-level DEFAULT_MAX_INLINE_COLUMNS = 6, which the package entry never re-exported. SYSTEM_FIELDS and SORT_FIELD_NAMES stay, because deriveFormFields and the sort-field pick in deriveDetail still read them.

The direction is triage's first grade (comment 5926478449): names and defaultHidden from the spec, objectui's builder over the names, the budget imported as DEFAULT_MAX_INLINE_GRID_COLUMNS, no second 6.

The fence

  • deriveColumns keeps its signature, and its output is unchanged on every input the evidence below reached.
  • No export, prop, type member or i18n key is added to any @object-ui/* package. The one declaration-file change is the module-level DEFAULT_MAX_INLINE_COLUMNS leaving dist/deriveMasterDetail.d.ts. The package entry src/index.tsx never re-exported it, and the package exports map exposes only ..

Landing site, and one addition to the claimed file surface

The landing site is the dispatched one: packages/plugin-form/src/deriveMasterDetail.ts and a test beside it.

⚠️ Outside the claim's declared surface: packages/plugin-form/package.json (@objectstack/spec goes from ^17.0.0 to ^17.6.0) and the one matching specifier line in pnpm-lock.yaml. The resolved version stays 17.6.0. They are in commit 399fc03, kept separate so it can be judged on its own. The reason: the published dist/index.js now imports deriveInlineGridColumns and DEFAULT_MAX_INLINE_GRID_COLUMNS from @objectstack/spec/data. The old floor admitted 17.0.0 to 17.5.x, which carry neither name, so a consumer that resolves one of those versions could not link the entry. PR #11552 and PR #11555 raised floors the same way, with the lockfile specifier.

Evidence (head fe06e31, after merging main c096f03)

The pin. deriveMasterDetail.inlineGridColumns-11345.test.ts holds one 14-entry corpus to two answers:

  1. the names, order and defaultHidden equal (toStrictEqual) the spec's deriveInlineGridColumns answer;
  2. the full output equals (toStrictEqual) the arrays the replaced implementation returned. These were generated from deriveColumns at 6e9090c.

The corpus covers both sides of the budget edge, maxColumns 3, 0 and -1, exclude with and without a relationship field, the filters, more required columns than the budget, a computed required column, falsy definitions, and four shapes with no field map. One more test checks that an omitted maxColumns leaves exactly DEFAULT_MAX_INLINE_GRID_COLUMNS columns visible.

Ablations on committed code (b879c7c). Each ran through objectstack's scripts/ablation-replace.mjs. In each, the anchor went from 1 hit to 0, the blob changed, and the restore was proven (blob equals HEAD, git diff HEAD empty).

  • A: drop the spec's defaultHidden carry. Predicted 13 red. Observed Tests 13 failed | 16 passed (29).
  • B: a falsy definition answers a bare { name }, the hydrate route the card warns about. Predicted 1 red (pin 2, falsy entry). Observed Tests 1 failed | 28 passed (29).
  • One earlier spelling of B is not counted. The tool refused it before any test ran, because its replacement contained the anchor.

One-off differential. Not committed; a historical reading at fe06e31. It compares deriveColumns at BASE (6e9090c) with this branch over 80,014 cases: the 14 corpus entries, 50,000 random cases and 30,000 budget-heavy ones.

  • Inputs: system, sort, name-like and prototype-named field keys; random types and flags; falsy and primitive definitions; random relationshipField, exclude and maxColumns, including NaN and Infinity.
  • Comparison: the util.inspect rendering (so key order and undefined-valued keys count) plus deep equality.
  • Result: 0 mismatches.
  • Control leg: the rejected route, the spec's names through hydrateColumns, gives 68,522 mismatches on the same cases, so the instrument can fire.

Floor. This is objectui's scripts/check-spec-range-floors.mjs verdict (its analyze()), scoped to @object-ui/plugin-form over its built dist:

  • at ^17.0.0: red, floor-too-low on exactly DEFAULT_MAX_INLINE_GRID_COLUMNS and deriveInlineGridColumns;
  • at ^17.5.0 (in memory): red, on the same two names;
  • at ^17.6.0: green.
Run (from the repo root) Exit
pnpm exec vitest run packages/plugin-form/ 0: Test Files 164 passed (164), Tests 1918 passed / 1 skipped (1919)
pnpm --filter @object-ui/plugin-form type-check, after turbo run build --filter=@object-ui/plugin-form. Both tsc legs ran, and --listFiles shows the test program reads the new pin 0
pnpm --filter @object-ui/plugin-form lint 0, with 0 errors
check:spec-symbols, check:phantom-deps, check:unused-deps, check:lockfile-integrity, check:lockfile-dedupe, check:new-line-citations, check:control-bytes, check:test-path-roots, check:unreferenced-sources, check:installed-pin-claims, check:pending-changeset-literals, check:changeset-claims, check:esm-specifiers, check:self-import, check:vi-mock-specifiers 0 each
scripts/check-changeset-presence.mjs, scripts/check-changeset-no-major.mjs 0 each
scripts/check-governed-queue-guard.mjs --test over the five changed paths NOT GOVERNED

NOT MEASURED locally. These need every published package built, and CI or the release path runs them:

  • the full check:spec-floors (the scoped verdict above stands in);
  • check:readme-exports (refused here with 24 packages unbuilt; this diff touches no README and no export);
  • check:dist-completeness, check:node-esm-load and check:published-dist;
  • the root pnpm lint and pnpm test.

Measured answers to the dispatch's open points

Acceptance notes

  • SYSTEM_FIELDS and SORT_FIELD_NAMES (used by the row form and the sort-field pick) hold the same names as the spec's module-private INLINE_GRID_SYSTEM_FIELDS and INLINE_GRID_SORT_FIELDS, which @objectstack/spec/data does not export. This is an observation only: the row-form rule is not spec-owned, and nothing here judges it. Carrier: none.

Changeset

.changeset/11345-inline-grid-columns-spec-rule.md declares @object-ui/plugin-form patch and includes the floor sentence.

Session: https://claude.ai/code/session_015W8GBu6sBiqus2L2xjMsAL (os-dev, dispatched by the domain:ui seat 1).


Generated by Claude Code

claude added 4 commits October 4, 2026 17:12
…he spec's deriveInlineGridColumns (objectui#11345)

`deriveColumns` now takes which columns an inline master-detail grid draws,
their order and their `defaultHidden` flag from `@objectstack/spec`'s
`deriveInlineGridColumns`, and builds each column from its child field with
the per-column builder it already had (extracted as `deriveColumn`). The local
budget (`curateColumns`, `NAME_LIKE_FIELDS`, `TYPE_FILL_PRIORITY`), the local
column filter (`NON_EDITABLE_TYPES`) and the module's own
`DEFAULT_MAX_INLINE_COLUMNS = 6` are deleted; the budget is the spec's
`DEFAULT_MAX_INLINE_GRID_COLUMNS`.

Signature and output of the public `deriveColumns` are unchanged. A new pin
holds a corpus to both answers: the spec's names / order / defaultHidden, and
the full output the replaced implementation returned.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015W8GBu6sBiqus2L2xjMsAL
`@object-ui/plugin-form`'s published `dist/index.js` now imports
`deriveInlineGridColumns` and `DEFAULT_MAX_INLINE_GRID_COLUMNS` from
`@objectstack/spec/data`, which the spec first exports in 17.6.0. The declared
`^17.0.0` admitted 17.0.0 to 17.5.x, none of which carries either name.
`pnpm-lock.yaml` follows the specifier; the resolved version (17.6.0) does not
move.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015W8GBu6sBiqus2L2xjMsAL
…columns (objectui#11345)

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015W8GBu6sBiqus2L2xjMsAL
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 331 chunks) 3313.9 KB 3330.4 KB
Main entry chunk (gzip) 151.6 KB 350 KB
Entry file index-DDXytEbZ.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 17.22KB 6.37KB
app-shell (runtime-config.js) 22.52KB 7.86KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.17KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.70KB 10.94KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 573.73KB 137.60KB
core (index.js) 10.00KB 3.96KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 232.57KB 64.51KB
fields (index.js) 262.75KB 66.62KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 35.66KB 9.49KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 39.47KB 11.25KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.86KB 5.00KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.52KB 2.26KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 53.17KB 15.46KB
plugin-charts (index.js) 84.26KB 23.05KB
plugin-chatbot (index.js) 198.22KB 46.97KB
plugin-dashboard (index.js) 143.54KB 38.79KB
plugin-designer (index.js) 231.41KB 48.84KB
plugin-detail (index.js) 245.74KB 64.59KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 175.71KB 45.38KB
plugin-gantt (index.js) 179.16KB 45.06KB
plugin-grid (index.js) 235.92KB 64.87KB
plugin-kanban (index.js) 50.06KB 15.74KB
plugin-list (index.js) 116.72KB 29.10KB
plugin-map (index.js) 25.60KB 8.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 38.80KB 11.71KB
plugin-tree (index.js) 14.51KB 5.15KB
plugin-view (index.js) 90.23KB 22.73KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 6.06KB 2.68KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 21.42KB 7.05KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.36KB 2.51KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.25KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 4, 2026 18:22
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 4, 2026 18:22
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 4, 2026
Merged via the queue into main with commit 15f6702 Oct 4, 2026
47 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-11345-derive-inline-grid-columns branch October 4, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants