Skip to content

fix(console): the approvals drawer's record summary shows the record page's labels and value faces (objectui#11677) - #11702

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-11677-approvals-summary-faces
Oct 6, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-11677-approvals-summary-faces

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #11677

Clause-②: no

What changed

The approvals inbox's request drawer now shows its record summary the way the record page shows the record. The only code that changed is the console page apps/console/src/pages/system/ApprovalsInboxPage.tsx. No published package export, registry input or locale key changes.

  • The card reads the request object's field declarations. It calls the same getObjectSchema(object_name) that useHiddenFieldsByObject already makes for this object. That read lands on the adapter's MetadataCache, which de-duplicates in-flight reads, so no network request is added. The new hook is useRequestFieldDefs.
  • Labels. A declared field takes its declared label through useSafeFieldLabel().fieldLabel, the translator the record page uses. The card no longer uses payload_labels or prettifyKey for it.
  • Values. A declared field's value is drawn by RecordFieldFace. It passes the declaration and the stored value to resolveCellRendererType and then getCellRenderer from @object-ui/fields, the chain DetailSection renders a field through, and translates the options as DetailSection does. This is the existing helper, imported. ⛔ There is no second formatter. A server-resolved payload_display value (a lookup's title) still wins.
  • Rows. When the metadata is known, a snapshot key the object does not declare gets no row, and neither does a reference with no resolved title. When the metadata is unknown (not answered yet, failed, or a schema with no fields), the card falls back to the snapshot rendering it had before. The fallback direction is the same as the hidden trim's.
  • The lead amount (the figure at the top of the card) follows the same rules. Its candidate selection also skips undeclared keys when the drawer has the declarations. The queue rows do not pass declarations, so their choice is unchanged.
  • Two rows never share a label. The page's private six-name system-key list is replaced by @object-ui/types' isSystemManagedField, the classifier the default list columns, record pickers and related lists already use. It also drops the injected owner_id column. A label two remaining rows still share is qualified with the field key (withDistinctLabels).
  • The duplicate React key. The summary grid rows are keyed by field key. They were keyed by label.

The measurement, and three premises it corrected

The real stack was booted: a showcase backend from objectstack 01e0f71a (objectstack dev --seed-admin --fresh) and this branch's console on its own port, driven with Playwright. The same shapes were then rendered through the page in jsdom.

Before (merge base 57d82cb), Invoice Dual Sign-off: Owner: Dev Admin, Invoice Number, Owner: linus@example.com, Region: amer, Status: sent, Issued On: 2026-04-19, lead Subtotal: 0. React logged "Encountered two children with the same key" twice per drawer open, live and in jsdom. In jsdom the key argument reads Owner. High-Value Expense: Approved: 0, lead Total: 8,900.

After (this branch, same live stack): Invoice: Invoice Number: INV-1012, Owner: linus@example.com, Region: AMER, Status: Sent, Issued On: Apr 19, Tax Rate (%): 8, lead Total: 0. These are the record page's faces for the same record: AMER and Sent badges, Apr 19, TOTAL 0. Expense: Status: Submitted, Submitted On: Yesterday, Approved: 0, Reimbursable: 8900, lead Total: 8900. No duplicate-key warning on open, and none after approving the invoice from the drawer.

Corrected premises:

  1. The duplicate key was in none of the three candidate lists. It was the summary grid itself. Its rows were keyed by their label, and two rows were labelled Owner.
  2. owner_id is a declared field. The registry injects it on every business object as a system: true lookup labelled "Owner". The live metadata read and payload_labels both say so. The showcase invoice also declares its own text owner (its row-level-security anchor) with the same label, so the collision is between two declarations, not between a declaration and a stray key. Dropping owner_id as bookkeeping is what the platform's other default surfaces already do. The label qualifier is the backstop for any other pair of fields with one label.
  3. Approved 0 is not a boolean. showcase_expense_report declares no boolean field. "Approved" is the label of approved_amount, a summary roll-up, and its value for the demo report is 0. Its record-page face is the summary cell, which prints the stored number. The invoice's "Subtotal" is a summary too.

Tests

New pin file ApprovalsInboxPage.summaryFaces-11677.test.tsx, 8 tests. Its fixtures follow the live shapes: the snapshot key order, the nulls, the hydrated account, payload_display with owner_id only, both Owner labels in payload_labels, and the metadata read's Total against the snapshot's Subtotal. Each value is compared with the record page's own dispatch rendered standalone, next to literal anchors (EMEA, Sent, raw strings absent). The file covers: both measured requests, one Owner, no duplicate-key warning, the lead's label and face, undeclared keys, two declared fields sharing a label, and the fail-open path.

Fixtures updated beside it:

  • hiddenFieldTrim declares every snapshot key it expects on the card. Under the new rule an undeclared key takes no row once metadata has answered. The trim and the promotion it pins are unchanged.
  • characterizationPins moves its _id-trim fixture from owner_id to vendor_id, because owner_id is now dropped as bookkeeping and never reaches prettifyKey.
  • rawPayloadGate: a header comment now names the classifier instead of the removed private list.

Reverse verification, committed fix first, then each leg restored and proven (blob equal to HEAD, git diff HEAD empty):

  • the page at the merge base: 8 of 8 red;
  • the private six-name list put back in place of isSystemManagedField: 3 red (the two Owner tests and the fail-open test);
  • withDistinctLabels removed: 1 red (two declared fields sharing a label);
  • HEAD: 8 of 8 green.

The duplicate-key assertions sit after the label assertions in each test, so on a defective tree the label assertion goes red first. Their red direction is the merge-base measurement above, not those assertion lines themselves.

Gates, local, at the head this body names:

All at head e4b9a61. Exit codes were captured before any pipe.

command exit verdict line
pnpm exec vitest run apps/console/ (the console project) 0 Test Files 151 passed (151), Tests 1783 passed (1783)
pnpm exec vitest run apps/console/src/pages/system/ApprovalsInboxPage.summaryFaces-11677.test.tsx 0 Tests 8 passed (8)
pnpm --filter @object-ui/console type-check (after turbo run build --filter='@object-ui/console^...') 0 tsc --noEmit && tsc -b tsconfig.node.json --force clean; --listFiles includes the new test file
pnpm --filter @object-ui/console lint 0 0 errors; this page has the same warnings as the merge base, none new
pnpm check:new-line-citations 0 0 new citation(s)
pnpm check:control-bytes 0 OK
pnpm check:changeset-claims 0 No pending changeset names a file this change touches
pnpm check:pending-changeset-literals 0 No test source names a pending changeset
pnpm check:handler-key-reads 0 OK
node scripts/check-changeset-no-major.mjs 0 No changeset declares a major bump
node scripts/check-changeset-presence.mjs 0 5 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)
node scripts/check-changeset-fixed.mjs 0 All workspace packages are in the changeset fixed group
node scripts/check-changeset-overwrite.mjs 0 No pre-existing changeset was modified or deleted
pnpm check:vi-mock-override-shape 0 OK
pnpm check:test-path-roots 0 OK
pnpm check:phantom-deps 0 Every in-scope import is declared by the package that publishes it
pnpm check:self-import 0 No package names itself inside its own src/
pnpm check:i18n-keys 0 every in-scope call-site key resolves

Not run locally, declared to CI: the repository-wide pnpm lint / pnpm test / pnpm type-check farm. The local runs are the console package's own lint, type-check and test project. turbo affected-set reasoning was not used.

Acceptance notes

  • Summary roll-ups print ungrouped. The two measured leads are summary fields. Through the record page's summary cell (FormulaCellRenderer) they print the stored number in mono, without digit grouping or currency: 8900 where the old card printed 8,900. The record page draws them the same way. The gap belongs to that cell in @object-ui/fields and is outside this card's file surface. Carrier: none.
  • Two label sources disagree in the showcase. The showcase translation bundle labels showcase_invoice.total "Total" and the object declares "Subtotal". The metadata read serves the bundle's label, which the record page shows and this card now shows. payload_labels carries the object's own label. The spec documents payload_labels as localized only for a single-locale project. Observation only.
  • objectui#2763 (parked for v18) plans to rebuild this surface. This change does not start that rebuild.

Generated by Claude Code

…d faces

The request drawer's record summary read labels from the snapshot
(`payload_labels` or a title-cased key) and printed values through a
type-blind formatter, so option values, dates and currency showed as
stored. It now reads the request object's field declarations and draws
each declared field through the record page's own cell dispatch
(`resolveCellRendererType` and `getCellRenderer`), under the declared
label. Undeclared snapshot keys and unresolved references take no row.
Without metadata the card falls back to the snapshot rendering.

The injected `owner_id` column is now dropped as bookkeeping via
`isSystemManagedField`, which replaces the page's private six-name list,
so an object with its own `owner` field no longer shows two "Owner"
rows. Rows are keyed by field key instead of label, which removes React's
duplicate-key warning, and any label two rows still share is qualified
with the field key.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FngvPpdrnhHMdHHq6vwwju
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 331 chunks) 3322.5 KB 3330.4 KB
Main entry chunk (gzip) 152.7 KB 350 KB
Entry file index-DFyyuz6a.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 17.22KB 6.37KB
app-shell (runtime-config.js) 22.52KB 7.86KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.70KB 10.94KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 574.72KB 137.94KB
core (index.js) 10.00KB 3.96KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 232.57KB 64.51KB
fields (index.js) 262.75KB 66.62KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 35.66KB 9.49KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.18KB 11.71KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.86KB 5.00KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.52KB 2.26KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 53.17KB 15.46KB
plugin-charts (index.js) 84.26KB 23.05KB
plugin-chatbot (index.js) 198.81KB 47.14KB
plugin-dashboard (index.js) 143.75KB 38.87KB
plugin-designer (index.js) 231.41KB 48.84KB
plugin-detail (index.js) 247.23KB 65.04KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 177.09KB 45.89KB
plugin-gantt (index.js) 179.16KB 45.06KB
plugin-grid (index.js) 238.48KB 65.51KB
plugin-kanban (index.js) 52.17KB 16.37KB
plugin-list (index.js) 116.72KB 29.10KB
plugin-map (index.js) 25.60KB 8.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 38.80KB 11.71KB
plugin-tree (index.js) 14.51KB 5.15KB
plugin-view (index.js) 90.23KB 22.73KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.25KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 6, 2026 07:36
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 6, 2026 07:36
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 3409fe8 Oct 6, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-11677-approvals-summary-faces branch October 6, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

approvals inbox: the request drawer's record summary renders raw stored values, labels two fields "Owner", and logs duplicate React keys

1 participant