Repository navigation
revert(app-shell): re-land Studio's validation presets (objectui#11931) and the Interfaces page-create (objectui#11932) - #11967
Merged
Conversation
…ting the rollback 3c888c6 This reverts commit 3c888c6 (objectui#11956), which rolled back Studio's validation presets (objectui#11931, part of objectui#11861) and the Interfaces page-create (objectui#11932, objectui#11823 step 3) to bring the console's eager closure back under its ceiling. The re-land lands against the +5,120 B allowance of objectui#11949 (ruling 6056819248 step 2). It restores both changes byte for byte to their f3a0488 blobs and removes the rollback's changeset, which this re-land supersedes. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land Brings in objectui#11949's +5,120 B eager-closure allowance (ruling 6056819248 step 2) and the three app-shell/plugin-list changes that landed after 3c888c6. No conflicts: none of them touches a file this re-land restores. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land Brings in objectui#11955 (object-grid's resizableColumns retired). No conflicts: it touches no file this re-land restores. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land Brings in objectui#11945 (objectui#11923, the validation Runs on row), objectui#11954 and objectui#11957. One conflict, the import block of ObjectValidationsPanel.tsx: this side imports validationPresets.js, main imports ScriptValidationSchema and ScriptValidationParsed from @objectstack/spec/data. Both imports are kept. i18n.ts (main removes the engine.studio.rules.event.delete row, en and zh) and the newRuleWaits-11820 pin (main asserts no Delete box) merge without conflict; both intents are kept in all three files. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land Brings in objectui#11959 (objectui#11933, Studio's page previews draw the page's own kind) and objectui#11934. No conflicts: neither touches a file this re-land restores. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land Brings in objectui#11935 (objectui#11894, typed is-empty operators in the condition builder) and objectui#11953. Two conflicting hunks, both in ObjectValidationsPanel.tsx, both because each side added the same FieldOpt member, type: (1) the FieldOpt interface keeps one type member, the presets' system flag and main's multiple flag, with one doc comment naming both readers; (2) the field mapping keeps one type line, main's multiple line and its comment, and the presets' system line. i18n.ts merges without conflict; main's ten added lines and this side's rows are both kept. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11861
Re-lands objectui#11823 step 3: objectui#11932, the Studio Interfaces page-create (seat
domain:ui#3). That card stays open.Clause-②: no
Held as a draft until objectui#11949 (the +5,120 B allowance, ruling
6056819248step 2) lands.When this PR was opened, objectui#11949 was already on
mainas1c51e973b, and this branch has merged it.What this is
A plain
git revert 3c888c6, followed by merges ofmain.3c888c6is the rollback PR objectui#11956, a single-parent squash, so-m 1does not apply. It brings back:Claim
6057967120on objectui#11861 · review6057399892on objectui#11937 · ruling6056819248on objectui#11942.Tree proof
7eeffd29bhas the tree off3a0488(011fe521e), sogit diff f3a0488 7eeffd29b --statprints nothing..changeset/11937-eager-budget-rollback.mdwas added by3c888c6and never existed atf3a0488. Its removal therefore shows against3c888c6, not againstf3a0488.main, the branch changes the 15 paths3c888c6changed, and no other path.f3a0488blob byte for byte. The other three were also changed onmainafter3c888c6, and they carry both intents (next section).Merges of main, and the conflicts
The branch merged
mainfive times: at1c51e973b,d73d98770,70e3d7721,ccc2824cfand247f50349. Only two of the PRs these brought in touch a restored file.objectui#11945 (objectui#11923, the Runs on row), merged at
70e3d7721.ObjectValidationsPanel.tsx. This side importsvalidationPresets.js;mainimportsScriptValidationSchema/ScriptValidationParsedfrom@objectstack/spec/data. Both lines are kept.metadata-admin/i18n.ts:mainremoves theengine.studio.rules.event.deleterow, en and zh. It stays removed.newRuleWaits-11820pin:mainasserts there is no Delete box. That assertion stays.mainequal the re-land's own changed lines (3c888c6..f3a0488). The changed lines of the merge against this branch's previous head equal objectui#11945's own diff. Both comparisons were identical for all three files.objectui#11935 (objectui#11894, typed is-empty operators), merged at
247f50349.ObjectValidationsPanel.tsx. Each side added the sameFieldOptmember,type.type,main'smultipleand the presets'system. One doc comment names both readers oftype.typeline,main'smultipleline with its comment, and the presets'systemline.i18n.tsmerged without conflict, and both sides' rows are kept.typemember and the merged comments as residual lines.mainmoved on after247f50349(objectui#11961, #11962, #11944). None of those touches any of the 15 paths, so they are not merged here.Changesets
.changeset/11861-validation-presets.mdand.changeset/11823-page-create.md, both@object-ui/app-shell: patch..changeset/11937-eager-budget-rollback.md(@object-ui/app-shell: patch). This re-land supersedes it.check-changeset-overwriteis report-only and exits 0. It reports one pre-existing changeset deleted, with@object-ui/app-shell"GONE from the declaration" of that file.Gates, on head
fb0c91d45(every merge above included)Tests use the repo-root
pnpm exec vitest runand run under the shared verify lock.ObjectValidationsPanel*suites, including objectui#11945'srunsOn-11923and objectui#11935'stypedEmptyOps-11894;interfaceCreateorStudioDesignSurface;column-identity.ratchet.test.ts;mainpins next to the conflicts:ConditionBuilder.typedEmptyOps-11894,PagePreview.pageKind-11933andSourcePageEditor.pageKind-11933.validationPresets,ObjectValidationsPanelor the designer string tablemetadata-admin/i18n.ts.pnpm --filter @object-ui/app-shell type-checkpasses, after a turbo build of the app-shell dependency closure (28 of 28 tasks).check:i18n-keys,check:i18n-designer-parity,check:i18n-drift;check-changeset-presence,check-changeset-fixed,check-changeset-no-major,check:changeset-claims,check:pending-changeset-literals,check-changeset-overwrite(report-only, see above);check:unreferenced-sources.--max-warnings. The warnings are the ones already in these files atf3a0488, and the merge adds none.check-governed-queue-guard --testreports NOT GOVERNED: none of the 15 paths is on a governed surface.Bundle Analysismeasures the first-load bytes against the ceiling that objectui#11949 raised.scripts/check-eager-closure-budget.mjsis not touched.f3a0488(the tree this re-land restores) had 66 check runs succeed, 6 skipped and 1 fail,Bundle Analysis. That is 73 of 73 runs read.Generated by Claude Code