Skip to content

revert(app-shell): re-land Studio's validation presets (objectui#11931) and the Interfaces page-create (objectui#11932) - #11967

Merged
objectstack-fleet[bot] merged 6 commits into
mainfrom
claude/issue-11861-reland-presets
Oct 8, 2026
Merged

objectstack-fleet[bot] merged 6 commits into
mainfrom
claude/issue-11861-reland-presets

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #11861
Re-lands objectui#11823 step 3: objectui#11932, the Studio Interfaces page-create (seat domain:ui#3). That card stays open.
Clause-②: no
Held as a draft until objectui#11949 (the +5,120 B allowance, ruling 6056819248 step 2) lands.
When this PR was opened, objectui#11949 was already on main as 1c51e973b, and this branch has merged it.

What this is

A plain git revert 3c888c6, followed by merges of main. 3c888c6 is the rollback PR objectui#11956, a single-parent squash, so -m 1 does not apply. It brings back:

  • objectui#11931: Studio's validation "New" menu opens on common rules, with the rule types under "Advanced". This is the validation-rule entry of objectui#11861.
  • objectui#11932: objectui#11823 step 3. The Interfaces pillar creates a page and opens it on its source beside a live preview.

Claim 6057967120 on objectui#11861 · review 6057399892 on objectui#11937 · ruling 6056819248 on objectui#11942.

Tree proof

  • The revert commit 7eeffd29b has the tree of f3a0488 (011fe521e), so git diff f3a0488 7eeffd29b --stat prints nothing.
  • .changeset/11937-eager-budget-rollback.md was added by 3c888c6 and never existed at f3a0488. Its removal therefore shows against 3c888c6, not against f3a0488.
  • Against main, the branch changes the 15 paths 3c888c6 changed, and no other path.
  • Twelve of the 15 hold their f3a0488 blob byte for byte. The other three were also changed on main after 3c888c6, and they carry both intents (next section).

Merges of main, and the conflicts

The branch merged main five times: at 1c51e973b, d73d98770, 70e3d7721, ccc2824cf and 247f50349. Only two of the PRs these brought in touch a restored file.

objectui#11945 (objectui#11923, the Runs on row), merged at 70e3d7721.

  • One conflicting hunk, in the import block of ObjectValidationsPanel.tsx. This side imports validationPresets.js; main imports ScriptValidationSchema / ScriptValidationParsed from @objectstack/spec/data. Both lines are kept.
  • Two files merged without conflict:
    • metadata-admin/i18n.ts: main removes the engine.studio.rules.event.delete row, en and zh. It stays removed.
    • the newRuleWaits-11820 pin: main asserts there is no Delete box. That assertion stays.
  • Check, per file: the changed lines of the merge against main equal the re-land's own changed lines (3c888c6..f3a0488). The changed lines of the merge against this branch's previous head equal objectui#11945's own diff. Both comparisons were identical for all three files.

objectui#11935 (objectui#11894, typed is-empty operators), merged at 247f50349.

  • Two conflicting hunks, both in ObjectValidationsPanel.tsx. Each side added the same FieldOpt member, type.
    • The interface keeps one type, main's multiple and the presets' system. One doc comment names both readers of type.
    • The field mapping keeps one type line, main's multiple line with its comment, and the presets' system line.
  • i18n.ts merged without conflict, and both sides' rows are kept.
  • The same check, run on this merge, leaves only the shared type member and the merged comments as residual lines.

main moved on after 247f50349 (objectui#11961, #11962, #11944). None of those touches any of the 15 paths, so they are not merged here.

Changesets

  • Restored: .changeset/11861-validation-presets.md and .changeset/11823-page-create.md, both @object-ui/app-shell: patch.
  • Removed: .changeset/11937-eager-budget-rollback.md (@object-ui/app-shell: patch). This re-land supersedes it.
  • check-changeset-overwrite is report-only and exits 0. It reports one pre-existing changeset deleted, with @object-ui/app-shell "GONE from the declaration" of that file.
    • The package still bumps, because both restored changesets declare it. This is the gate's case 3: a changeset superseded by a replacement in the same change.

Gates, on head fb0c91d45 (every merge above included)

Tests use the repo-root pnpm exec vitest run and run under the shared verify lock.

  • Named set: 98 files and 631 tests, all passed. It covers:
    • all eight ObjectValidationsPanel* suites, including objectui#11945's runsOn-11923 and objectui#11935's typedEmptyOps-11894;
    • every test file that imports interfaceCreate or StudioDesignSurface;
    • column-identity.ratchet.test.ts;
    • the main pins next to the conflicts: ConditionBuilder.typedEmptyOps-11894, PagePreview.pageKind-11933 and SourcePageEditor.pageKind-11933.
  • Widened set: 87 files and 1,103 tests, all passed. It covers every other test that imports validationPresets, ObjectValidationsPanel or the designer string table metadata-admin/i18n.ts.
  • pnpm --filter @object-ui/app-shell type-check passes, after a turbo build of the app-shell dependency closure (28 of 28 tasks).
  • Each of these gates exits 0:
    • check:i18n-keys, check:i18n-designer-parity, check:i18n-drift;
    • check-changeset-presence, check-changeset-fixed, check-changeset-no-major, check:changeset-claims, check:pending-changeset-literals, check-changeset-overwrite (report-only, see above);
    • check:unreferenced-sources.
  • eslint on the 11 touched source and test files reports 0 errors and 22 warnings. The repo sets no --max-warnings. The warnings are the ones already in these files at f3a0488, and the merge adds none.
  • check-governed-queue-guard --test reports NOT GOVERNED: none of the 15 paths is on a governed surface.
  • Not run: the console build. CI's Bundle Analysis measures the first-load bytes against the ceiling that objectui#11949 raised. scripts/check-eager-closure-budget.mjs is not touched.
  • Reference point: on its push run, f3a0488 (the tree this re-land restores) had 66 check runs succeed, 6 skipped and 1 fail, Bundle Analysis. That is 73 of 73 runs read.

Generated by Claude Code

claude added 6 commits October 8, 2026 10:35
…ting the rollback 3c888c6

This reverts commit 3c888c6 (objectui#11956),
which rolled back Studio's validation presets (objectui#11931, part of
objectui#11861) and the Interfaces page-create (objectui#11932, objectui#11823
step 3) to bring the console's eager closure back under its ceiling.

The re-land lands against the +5,120 B allowance of objectui#11949 (ruling
6056819248 step 2). It restores both changes byte for byte to their f3a0488
blobs and removes the rollback's changeset, which this re-land supersedes.

Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU
Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land

Brings in objectui#11949's +5,120 B eager-closure allowance (ruling
6056819248 step 2) and the three app-shell/plugin-list changes that landed
after 3c888c6. No conflicts: none of them touches a file this re-land restores.

Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU
Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land

Brings in objectui#11955 (object-grid's resizableColumns retired). No conflicts: it touches no file this re-land restores.

Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU
Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land

Brings in objectui#11945 (objectui#11923, the validation Runs on row), objectui#11954 and objectui#11957. One conflict, the import block of ObjectValidationsPanel.tsx: this side imports validationPresets.js, main imports ScriptValidationSchema and ScriptValidationParsed from @objectstack/spec/data. Both imports are kept. i18n.ts (main removes the engine.studio.rules.event.delete row, en and zh) and the newRuleWaits-11820 pin (main asserts no Delete box) merge without conflict; both intents are kept in all three files.

Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU
Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land

Brings in objectui#11959 (objectui#11933, Studio's page previews draw the page's own kind) and objectui#11934. No conflicts: neither touches a file this re-land restores.

Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU
Co-authored-by: Claude <noreply@anthropic.com>
…2 re-land

Brings in objectui#11935 (objectui#11894, typed is-empty operators in the condition builder) and objectui#11953. Two conflicting hunks, both in ObjectValidationsPanel.tsx, both because each side added the same FieldOpt member, type: (1) the FieldOpt interface keeps one type member, the presets' system flag and main's multiple flag, with one doc comment naming both readers; (2) the field mapping keeps one type line, main's multiple line and its comment, and the presets' system line. i18n.ts merges without conflict; main's ten added lines and this side's rows are both kept.

Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation tests package: app-shell labels Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 337 chunks) 3309.2 KB 3312.0 KB
Main entry chunk (gzip) 71.4 KB 350 KB
Entry file index-PYiyELaQ.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 17.82KB 6.58KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 587.49KB 141.58KB
core (index.js) 10.00KB 3.96KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 240.39KB 67.09KB
fields (index.js) 266.92KB 67.47KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.50KB 11.82KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.86KB 5.00KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.52KB 2.26KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 53.39KB 15.52KB
plugin-charts (index.js) 84.71KB 23.25KB
plugin-chatbot (index.js) 199.63KB 47.46KB
plugin-dashboard (index.js) 144.20KB 38.95KB
plugin-designer (index.js) 231.46KB 48.87KB
plugin-detail (index.js) 248.57KB 65.47KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 177.11KB 45.88KB
plugin-gantt (index.js) 179.17KB 45.07KB
plugin-grid (index.js) 248.06KB 68.79KB
plugin-kanban (index.js) 52.17KB 16.37KB
plugin-list (index.js) 117.68KB 29.40KB
plugin-map (index.js) 27.24KB 9.03KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 39.10KB 11.81KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 91.07KB 22.93KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.25KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 8, 2026 12:56
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 8, 2026
Merged via the queue into main with commit 7546570 Oct 8, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-11861-reland-presets branch October 8, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation package: app-shell tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants