Repository navigation
refactor(app-shell): Studio's object settings panel picks with the shared Select (objectui#11865) - #11995
Merged
objectstack-fleet[bot] merged 1 commit intoOct 8, 2026
Conversation
…ared Select (objectui#11865) The object Settings tab's five browser-native select elements (internal and external sharing model, name field, lifecycle field, and the highlight fields' "add field") become the shared Radix Select, through one module-private SettingsPicker modelled on the validation editor's RulePicker: items carry their option's index, so the options whose value is '' need no empty SelectItem, and a stored value none of the options carries gets an item of its own. Each caller maps the picked value to the same patch as before. Pinned in ObjectSettingsPanel.sharedSelect-11865.test.tsx against literals read once on the pre-conversion panel. ObjectSettingsPanel.test.tsx and StudioDesignSurface.servedDraftTakenAsIs-10765.test.tsx now read the trigger, whose button value is '' whatever the dial holds. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
objectstack-fleet
Bot
deleted the
claude/issue-11865-object-settings-select
branch
October 8, 2026 17:59
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Oct 9, 2026
…ed Select (objectstack-ai#12012) Part of objectstack-ai#11865 Clause-②: no Slice h of claim `6069665700`, the console's own pages: four browser-native select elements on three pages become the shared Radix `Select` (`packages/components/src/ui/select`, used, not edited), following objectui#11976, objectstack-ai#11990, objectstack-ai#11995, objectstack-ai#12000 and objectstack-ai#12005. This PR converts these files and no others: - `apps/console/src/pages/developer/PublicFormsPage.tsx`: "FormView" in *Publish a FormView* and "After submit" in the edit dialog, through one module-private `FormsPicker`. - `apps/console/src/pages/developer/FlowRunsPage.tsx`: the flow picker, through a module-private `FlowPicker`. - `apps/console/src/pages/system/ProfilePage.tsx`: "Preferred language", through a module-private `LanguagePicker`. Each picker follows the card's earlier pickers. Items carry their option's index, so the two options whose value is the empty string ("— Select a FormView —", "Use the deployment default") need no empty `SelectItem`. A value no option carries gets an item of its own and is shown as itself. No picker is exported, and no listing logic on Public Forms moved (objectui#11545 is untouched). ## Hypotheses, measured - **H1, value parity: holds.** A scratch probe (not committed) on base `902fbe190`, with the native selects and the same fixtures as the pins, read what every option led to. The pins compare against those readings as JSON text: - Public Forms, publish: each view writes the same `meta.saveItem` call (`["view","lead.intake",{…,"sharing":{"enabled":true,"allowAnonymous":true,"publicLink":"/forms/contact-us"}}]`, and the same for the view with no label or object). "— Select a FormView —" leaves Publish disabled with no call. - Public Forms, "After submit": 12 rows (stored behaviour unset, `redirect` with `/done`, or `continue`, by each of the four options), each the same full `saveItem` call, `submitBehavior` included. - Flow Runs: each flow, picked, is the one Run Flow executes (`[["nightly_sync",{"params":{}}]]`) and whose runs are listed (`[["nightly_sync",{"limit":20}]]`), and the same for `reassign_wizard`. - Profile: 13 rows (stored tag none, `ja` or `pt-BR`, by each option), each the same `adapter.update` call; "Use the deployment default" still saves `{"locale":null}`. Re-picking the current option leaves Save disabled, as before. - **H2, names, keyboard and read-only: holds.** - Names, read on base through `getByRole('combobox', { name })`: "FormView", "After submit" and "Preferred language" come from each field's Label htmlFor. Each trigger now carries that `id`, and the name pins are green on base and head by design. - The flow picker had no label, `id` or `aria-label`, so its name was empty. It is still empty, and is pinned so (see Acceptance notes). - Keyboard: Enter opens and Enter on an option selects, pinned once per page. - Read-only: only the Profile card has such a state. Its trigger is the primitive's disabled trigger (objectui#11781), pinned by `ProfilePage.language`'s "degrades to read-only" case. Public Forms' two dialogs open only from the page's own buttons, and Flow Runs has no such state. - **H3, a value no option carries: holds.** On base the native control showed its first option in each case. Head shows the value itself, pinned three times: - Flow Runs, a picked flow that a Refresh no longer lists: base showed "Reassign (reassign_wizard)" while the page held `nightly_sync` and showed no runner. - "After submit" with a stored kind none of the four names: base showed "Show a thank-you panel" with no thank-you fields. - Profile, a pick the offered list has since dropped: base showed "Use the deployment default" while Save wrote `zh`. - **H4, first-load bytes: neutral.** - Measured before the first edit, on base: the three pages ship in lazy chunks (`PublicFormsPage-*`, `FlowRunsPage-*` and `ProfilePage-*`), none among the 336 members of `dist/eager-closure.json`. The positive controls were the entry chunk and `ui-components`, both eager. - On head: eager gzip 3,391,326 B on base and 3,391,327 B on head, and eager raw 11,496,190 B on both, so the delta is +1 B gzip and 0 B raw. - The one eager member that changed is the entry chunk. It names the three lazy chunks, whose hashes moved. `ui-components` keeps its file name, so the shared `Select` was already in it. ## Tests New pins (one per page): `PublicFormsPage.sharedSelect-11865.test.tsx`, `FlowRunsPage.sharedSelect-11865.test.tsx`, `ProfilePage.sharedSelect-11865.test.tsx`. Suites that drove or mount these pages, changed only in their harness: - `PublicFormsPage.redirect`: the editor helper picks "Redirect to a URL" through the primitive. - `ProfilePage.language`: picks through the primitive. Its adapter mock is now one object, as the app's provider hands out. A fresh one per render re-read the row and reset the pick before Save could be reached. The native control's synchronous change event used to win that race. - `developerMetadataEnvelope.contractEnvelope-6917` and `consoleFaces.displayLocale-9909`: `getClient()` now returns one client, as the real adapter's does. With a fresh client per call, Flow Runs re-ran its loads on every render. Measured with that harness shape: 251 `meta.getItems` calls in 600 ms on the base page and 73 on this branch, against 2 with one client. The native option text was readable between reloads; the shared trigger's value never settled, so their Flow Runs cases went red. Reverse leg, from the committed head `699224076`: - The three page files were put back on their base blobs (hash-checked on disk) and the new pins run: `Tests 42 failed | 3 passed (45)`. The three passing are the name pins, green on both sides by design. - Restored with `git checkout HEAD`. The blobs on disk equal HEAD's, and `git diff HEAD` is empty. A trap restored on EXIT, INT and TERM. ## Gates (head `f0ec3325f`, worktree clean) - Repo-root `pnpm exec vitest run` over the 3 new pins, the 8 suites that mount these pages, `submitRedirect.test.ts`, `column-identity.ratchet.test.ts` and `one-authority-per-exported-name-6273.test.ts`: `Test Files 14 passed (14)`, `Tests 180 passed (180)`. - `pnpm --filter @object-ui/console type-check`, after `turbo run build --filter='@object-ui/console^...'` (`Tasks: 34 successful, 34 total`): exit 0. `tsc --listFilesOnly` lists every touched file. - `pnpm exec eslint` on the 10 touched ts/tsx files: 0 errors and 32 warnings, all pre-existing rule kinds. The base blobs carry 33, and `PublicFormsPage` loses one `no-explicit-any`. - `pnpm check:eager-closure` on the head build: "Console eager closure is 3311.8 KB gzipped across 336 of 2458 chunks (budget: 3312.0 KB, headroom: 0.2 KB)." - Each exit 0: - `node scripts/check-changeset-presence.mjs`: "10 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)". - `node scripts/check-changeset-no-major.mjs`. - `pnpm check:new-line-citations`: "0 new citation(s)". - `pnpm check:control-bytes`. - Derived from the touched paths: `check:vi-mock-specifiers`, `check:vi-mock-inherit`, `check:vi-mock-override-shape`, `check:test-path-roots`, `check:i18n-keys`, `check:changeset-claims`, `check:pending-changeset-literals`, `check:phantom-deps`, `check:metadata-write-doors`, `check:unreferenced-sources` and `check:handler-key-reads`. Changeset: `.changeset/11865-h-console-pages-shared-select.md`, `'@object-ui/console': patch`. Docs: no guide or README describes these controls. A `git grep` of `content/docs` and the console README for the page names and labels finds only `public-forms.md`, which documents the route and the redirect contract, not the dialog's controls. So no doc change. ## Acceptance notes None of these is filed. Each is noted with no carrier. - The flow picker has no accessible name, before and after: no label, `id` or `aria-label` is associated with it. Kept for parity, as the claim asks. Naming it is a separate change. - Picking a flow reloads the flow list, because `loadFlows` depends on the picked name. The picker unmounts while the list loads, so focus does not come back to it after a pick. Read in jsdom, the same before and after. - Flow Runs keys its flow and run loads on the identity of `getClient()`. The real adapter returns one client, so this is dormant in the app; only a harness that builds a fresh client loops. `FlowRunsPage.test.tsx` still builds one per call and passes. - A stored `submitBehavior.kind` outside the spec's four is saved away: Save writes the view without `submitBehavior`, before and after. The spec refuses such a kind, so reaching this needs an off-spec stored view. - The FormView option for a view with no object keeps the trailing space the native option had. Session: `https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU`. --- _Generated by [Claude Code](https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11865
Clause-②: no
The object settings slice of objectui#11865 (claim 6064876007): the five browser-native select elements on Studio's object Settings tab become the shared Radix
Select. The card stays open for the other native selects. The earlier slices are objectui#11934 (the Group panel), objectui#11976 (the validation editor) and objectui#11990 (Explain access).What changed
packages/app-shell/src/views/studio-design/ObjectSettingsPanel.tsx: one module-privateSettingsPicker, drawn with the sharedSelectfrom@object-ui/components, renders all five pickers: the internal sharing model, the external sharing model, the name field, the lifecycle field, and the highlight fields' "+ Add field…". It follows the validation editor'sRulePicker. Items carry their option's index, so the options whose value is''("not set", "auto-derived", "auto-detect", "+ Add field…") need no emptySelectItem. A stored value that none of the options carries gets an item of its own. Each caller turns the picked value into the same patch as before: the mapping expressions are the nativeonChangebodies, with the event's value replaced by the picked value.owd-internal-select,owd-external-select); the other three gainname-field-select,stage-field-selectandhighlight-add-select.engine.*keys is identical to the base's (diffed).ObjectSettingsPanel.sharedSelect-11865.test.tsx(new), 35 tests.ObjectSettingsPanel.test.tsx: the five OWD-dial cases that drove the native control (option list, pick, clear, external default, external clear) now open and pick through the trigger, and check the same things.StudioDesignSurface.servedDraftTakenAsIs-10765.test.tsx: its Data pillar case read the dial'svalue. The trigger is a button, whosevalueis''whatever the dial holds, so that assertion would have passed vacuously. It now reads the trigger's text: the unset label is shown and the publishedprivatelabel is not..changeset/11865-object-settings-shared-select.md:@object-ui/app-shell: patch.Hypotheses
H1, value parity: held. A scratch probe (uncommitted, deleted) fired a
changeevent on every option of each native select on base0bbb67b9aand recorded the patch. The new suite's 24-row table pins every option of every picker against those literals, compared as JSON text, with the keys that holdundefinednamed:undefined;stageField: false;A table-coverage test pins each picker's listed options in order. Caveat: the probe's
changeevent fired for the current option too, so the re-pick rows (no write) pin the primitive, not a browser reading of the native control.H2, labels, keyboard and read-only: held. The probe read each native select's accessible name on base. On head each trigger computes the same name: the four label texts, and
''for the "+ Add field…" picker on both. Enter opens a picker, and Enter on an option selects it. The panel has a read-only state:disabled, whichStudioDesignSurfacepasses from its read-only flag. In it, the four triggers are disabled, wear the primitive's owndisabled:classes, and do not open. The "+ Add field…" picker is not drawn, as on base.H3, a stored value outside the options: held. Each of these is shown in the trigger: a name field naming a missing field, a lifecycle field naming a field that is not a select field, and sharing models neither dial offers (
full,read_write). The native control showed its first option there. The missing name field is listed first, and re-picking it writes nothing.H4, first-load bytes: byte-neutral locally. On
e02c4c116:apps/consolevite buildplusnode scripts/check-eager-closure-budget.mjs, on head and on the same tree with the panel at its base blob (landing and restore proven by hash).Console eager closure is 3311.2 KB gzipped across 337 of 2459 chunks (budget: 3312.0 KB, headroom: 0.8 KB).eagerGzipBytesis 3390714 on both legs, andeagerRawBytesis equal. The only eager entry that differs is the entry chunk's file-name hash; its bytes are identical.studioBuilderchunk on both legs.The budget bot's reading on this PR is the authority.
Reverse leg
With the implementation committed, the panel was written from its base blob (its hash equals the base blob: 5 native select elements, 0
SettingsPicker). Then the new suite,ObjectSettingsPanel.test.tsxand the served-draft suite ran:Tests 41 failed | 11 passed (52).ObjectSettingsPanel.test.tsxand the served-draft suite's three other cases.That is the direction the suite header predicts. The restore,
git checkout HEAD --under a trap, is proven: the hash equals the HEAD blob, andgit diff HEADis 0 bytes.Gates (on
e02c4c116)pnpm exec vitest run:Test Files 7 passed (7),Tests 61 passed (61).DataPillar.hiddenSystemFields-11780.test.tsxstubs the panel and is not among them.column-identity.ratchetandone-authority-per-exported-name-6273:Test Files 2 passed (2),Tests 18 passed (18).pnpm --filter @object-ui/app-shell type-check, after the app-shell dependency closure build: exit 0. By--listFilesOnly, the panel is in the main program, and the panel and the three touched suites are in the test program.pnpm exec eslinton the four touched.tsxfiles: exit 0, 0 errors, 0 warnings.check-changeset-presence,check-changeset-no-major,check:new-line-citations(0 new) andcheck:control-bytes: exit 0.pending-changeset-literals,test-path-roots, the three vi-mock gates,phantom-deps,unreferenced-sources,i18n-keys,i18n-designer-parity,i18n-drift,metadata-write-doors,esm-specifiers,self-import, lint coverage, type-check coverage,handler-key-readsanddesigner-field-key-parity.component-surface-parityandi18n-dead-keysalso exit 0; both are report-only.pnpm testfarm and repo-widepnpm lint.Acceptance notes
Select, as the claim directs and as the earlier slices measured.Selectjumps to an option by its typed leading letters.Generated by Claude Code