Skip to content

feat(app-shell): New automation opens on starting points, the trigger form under Advanced (objectui#11861) - #12018

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-11861-flow-presets
Oct 9, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-11861-flow-presets

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #11861

Clause-②: no

The automations entry, the last of the three entries triage named on the card (comment 6051947408). The validation-rule entry landed through objectui#11931 / objectui#11967 and the actions entry through objectui#11977, so this PR closes the card. Claim: comment 6071664220 (seat domain:ui#3).

What changes

New automation used to ask for a name and then offer the Start node's whole trigger list, with "Choose later on the Start node" first (objectui#11788). It now asks When it runs, with four plain-language starting points from a module-private table, flowPresets.ts, the first one chosen:

Preset Writes on the Start node Waits for
When a record is created triggerType: 'record-after-create' + objectName the object
When a record is updated triggerType: 'record-after-update' + objectName the object
When a record is deleted triggerType: 'record-after-delete' + objectName the object
When a button or another automation starts it triggerType: 'manual' nothing
  • Each preset is one of the Start node's own trigger choices, sent through the unchanged doCreateFlow and withStartTrigger. A preset flow is therefore byte for byte the flow Advanced writes for the same trigger: a Start node and an End node, type: 'autolaunched', born status: 'obsolete' (objectui#11779).
  • A record preset shows the Start node's own Object field right under it. With no object named, Create sends nothing and the dialog says "Choose the object it watches." Which presets wait is not a second list: the Start node's Object field decides it through its showWhen, the same reading the Advanced form uses.
  • Advanced is the fifth choice. Choosing it shows the objectui#11788 trigger form, unchanged in markup and in what it writes. Left on "Choose later", it writes the blank flow byte for byte (pinned as the control).
  • No preset adds a step, and no preset writes a script.

Files: StudioDesignSurface.tsx (the dialog's extra and onSubmit, its two new state values, the New button's reset, one import), the new flowPresets.ts, 6 new rows en + zh under engine.studio.auto.* in metadata-admin/i18n.ts (the Advanced word reuses engine.studio.rules.advanced, as the Actions menu does), the new pin, a helper-only change to two existing pins (the objectui#11788 pin and the objectui#11779 create case now choose Advanced first; no assertion changed), and .changeset/11861-flow-presets.md (@object-ui/app-shell: patch). All inside the claim's file surface. CreateItemDialog.tsx is not touched, so the hold is a refusal inside onSubmit shown through the dialog's existing error slot, not a disabled Create button.

Measured before choosing (dispatch zone 2, hypothesis 2)

FlowSchema from the installed @objectstack/spec 17.7.0 accepts every candidate start-to-end flow, including the ones that cannot work as created: a record trigger with no object, triggerType: 'schedule' with a cron, triggerType: 'api' with no secret. So the schema is not the hold criterion here; the runtime is. Read in objectstack source (not run against a live backend):

  • A record trigger with no object. The record-change trigger registers its hook with object: binding.object; ObjectQL's registerHook treats an absent object as a global hook, run for every object's records. So a record preset waits for its object.
  • Schedule and time-relative sweep: not offered. resolveScheduledWorkEnabled answers false unless the deployment switches OS_AUTOMATION_SCHEDULED_WORK_ENABLED on, and both schedule triggers refuse to bind while it is off. Under the isolated posture a bound one also needs config.organization. Such a flow is "Not running here" on a default deployment, so it is not a working preset.
  • Webhook / API: not offered. The engine refuses to register an api flow whose Start node carries no secret, and this dialog does not ask for one.
  • Screen flow: not offered. It needs a screen step, and every step names something only the author knows.

All of these stay one choice away, under Advanced.

Pins

New: StudioDesignSurface.flowPresets-11861.test.tsx, 8 tests, driven through the real AutomationsPillar and CreateItemDialog with a recording metadata client:

  1. the dialog opens on 3 to 5 presets, the first checked, with the trigger form absent until Advanced is chosen;
  2. every preset's trigger is one of the Start node's options, and exactly the record ones are in the Object field's showWhen (the pure flowPresetTrigger read both ways);
  3. to 6. per preset: the saved flow parses with FlowSchema, resolveFlowTriggerKind answers record_change or none (never a schedule, sweep or hook), the nodes are exactly start and end, and the flow equals the one Advanced writes for the same trigger and object;
  4. the hold: a record preset with no object sends nothing and shows the line, then saves once the object is named;
  5. the control: Advanced left on "Choose later" writes the objectui#11788 blank flow, compared as a fully spelled-out literal.

Reverse verification, through objectstack scripts/ablation-replace.mjs WRAP mode on 650b0d03b (each anchor x1 to x0, blob changed; each restore proven: blob equal to HEAD and git diff HEAD empty). Control: 8 of 8 pass.

  • A1, a preset routed through the blank path (doCreateFlow(label, name, trigger) to null): 5 failed, 3 passed (the four preset cases and the hold).
  • A2, the hold removed (flowPresetTrigger returns the trigger without an object): 2 failed, 6 passed (the pure read and the hold).
  • A3, Advanced routed through the preset path: 5 failed, 3 passed (the four preset-equals-Advanced cases and the control).

Evidence, at HEAD 658db0b82 (after merging main at 70f1b2755, objectui#11795)

  • pnpm --workspace-concurrency=2 --filter '@object-ui/app-shell^...' build, then pnpm --filter @object-ui/app-shell type-check (it echoes tsc --noEmit && tsc -p tsconfig.test.json; the test project includes src/**/*.test.tsx): exit 0.
  • The whole studio-design directory, in two locked runs: 156 files, 1108 tests, all passed.
  • Every other test that imports the designer table, reads its source, or names AutomationsPillar or flowPresets, in two locked runs: 95 files, 1421 tests, all passed.
  • eslint (root eslint.config.js, files: ['**/*.{ts,tsx}'], no type-aware linting, so this diff cannot move a verdict on an untouched file) on the 6 touched TS files: 0 errors, 13 warnings, all in StudioDesignSurface.tsx. That file carries the same 13 on main 70f1b2755.
  • check:i18n-keys, check:i18n-drift ("No en value changed in this range."; designer table: 6 keys added, 0 en values changed), check:i18n-dead-keys, check:i18n-designer-parity, check:control-bytes, check:test-path-roots, check:changeset-claims, check:pending-changeset-literals, check:new-line-citations, check:unreferenced-sources, check:esm-specifiers, check:vi-mock-* (3), check:spec-symbols, check:handler-key-reads, check:metadata-write-doors, and scripts/check-changeset-{presence,no-major,fixed,overwrite}.mjs: all exit 0. check-governed-queue-guard --test on the 7 paths: NOT GOVERNED.
  • NOT MEASURED: check:readme-exports (prerequisite not met: app-shell dist/index.d.ts not built here; no export changed). A real-browser pass (no objectstack backend serving Studio in this container; behaviour pinned in happy-dom). The console build and first-load bytes, which belong to CI's Bundle Analysis; its reading goes in the os-dev report on the card.

Acceptance notes

  • Docs. Neither content/docs/guide/console.md nor packages/app-shell/README.md describes the New automation dialog, so nothing there is stale and both are outside the claim. A sentence the seat may add to the console guide: "New automation asks when it runs: when a record is created, updated or deleted (on the object named right under the choice), or when a button or another automation starts it. The full trigger list is under Advanced."
  • Not filed (read-only, no carrier): packages/app-shell/README.md's flow designer section says a start node "deliberately stores no triggerType" and lists Entry condition as criteria. The Start node's trigger select writes config.triggerType (objectui#11788 relies on it), and the inspector writes condition. Docs drift, untouched here.
  • Not filed (boundary, no carrier): the Advanced form still lets an author save a record trigger with no object, which the runtime runs as a global hook. That is today's behaviour, kept byte for byte as ordered.

Generated by Claude Code

claude added 2 commits October 9, 2026 00:41
… form under Advanced (objectui#11861)

The New automation dialog now asks "When it runs" with four plain-language
presets from a module-private table (flowPresets.ts): when a record is
created, updated or deleted, and when a button or another automation starts
it. Each preset is one of the Start node's own trigger choices, written by the
same create path, so it writes exactly the flow the trigger form writes for
that trigger. A record preset waits for its object: Create sends nothing until
one is named. The objectui#11788 trigger form is the Advanced choice,
unchanged.

Claude-Session: https://claude.ai/code/session_01CGZy1BGCjdN5cXqL9cnvB8
Co-authored-by: Claude <noreply@anthropic.com>
…ow-presets

objectui#11795 edits StudioDesignSurface.tsx's fold decision and properties
aside and adds rows to metadata-admin/i18n.ts; this branch edits the New
automation dialog and adds automations rows. Auto-merged, no conflict.

Claude-Session: https://claude.ai/code/session_01CGZy1BGCjdN5cXqL9cnvB8
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 289 chunks) 3160.7 KB 3204.6 KB
Main entry chunk (gzip) 71.6 KB 350 KB
Entry file index-M_rNoTg2.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 19.52KB 7.19KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 587.83KB 141.44KB
core (index.js) 10.00KB 3.96KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 240.39KB 67.09KB
fields (index.js) 268.74KB 68.04KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.50KB 11.82KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.86KB 5.00KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.52KB 2.26KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 53.43KB 15.54KB
plugin-charts (index.js) 84.71KB 23.25KB
plugin-chatbot (index.js) 201.12KB 47.86KB
plugin-dashboard (index.js) 144.20KB 38.95KB
plugin-designer (index.js) 233.53KB 49.80KB
plugin-detail (index.js) 248.57KB 65.47KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 177.11KB 45.88KB
plugin-gantt (index.js) 179.17KB 45.07KB
plugin-grid (index.js) 249.56KB 69.16KB
plugin-kanban (index.js) 52.22KB 16.38KB
plugin-list (index.js) 118.51KB 29.60KB
plugin-map (index.js) 27.24KB 9.03KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 39.10KB 11.81KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 91.16KB 22.97KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.25KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 9, 2026 01:49
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 9, 2026 01:49
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit f0268ad Oct 9, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-11861-flow-presets branch October 9, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

studio: every "New" entry opens on a blank technical form — offer 3–5 presets or templates first, with the full form under Advanced

2 participants