Skip to content

docs(agents): an authored events bag is refused by objectui validate once PR objectui#11069 lands (objectui#5250) - #12050

Merged
os-zhuang merged 3 commits into
mainfrom
claude/issue-5250-agents-events-sentence
Oct 9, 2026
Merged

os-zhuang merged 3 commits into
mainfrom
claude/issue-5250-agents-events-sentence

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #5250
Merge order: this PR merges together with or after PR objectui#11069 (slice A of objectui#5250), never before it. Until slice A lands, the sentence it replaces is still true.
Clause-②: no

What changed

One sentence in each of two governed files, both about an authored events bag:

Both now say what is true once PR objectui#11069 lands. A typed literal refuses the bag. One that arrives as data is refused by name as an undeclared key by objectui validate, and named the same way by objectui check; both judge through the strict authoring face (objectui#5250). The tolerant zod face is .passthrough(): it still keeps the bag, and nothing runs it.

Nothing else changes. skills/objectui/SKILL.md says only 「kept and run by nothing」 about the tolerant face. That stays true, so it is not touched.

Why

PR objectui#11069 moves objectui validate and objectui check onto StrictAnyComponentSchema. Probed on that PR's merged head: a text node and a button node, each carrying an events bag, are refused by the strict face with one unrecognized_keys naming events, and accepted by the tolerant safeValidateSchema. After that PR lands, 「judged by nothing」 would be false in the instruction file every agent reads first, and in the published skill.

Gates

Head 91845ce7c, base main 3c3115e38. Each exit code was captured before any pipe.

  • node scripts/check-governed-queue-guard.mjs --test AGENTS.md skills/objectui/rules/protocol.md: exit 3, GOVERNED — 2 of 2 path(s) are on a governed surface (AGENTS.md, skills/**). This PR stays draft and lands only after an APPROVED review by an authorized approver.
  • check:skills-paths exit 0 (skills/ — 29/29 resolve); check:skill-eval-tokens exit 0; check:control-bytes exit 0; check:new-line-citations exit 0 (0 new citation(s)); docs:check-links exit 0; check-changeset-presence exit 0 (no released source changed, so no changeset is owed).
  • NOT MEASURED: check:skill-examples exited 2, PRECONDITION NOT MET (it needs 12 packages built). The edited paragraph carries no code example. Declared to CI.

维护者速读(草稿)

改了什么:两份写给 AI 的规程里各改一句话:仓库根的 AGENTS.md,和对外发布的技能包 skills/objectui。原句说作者写进元数据的 events 事件包「没有任何东西检查」。现在改成 PR objectui#11069 合并之后的事实:objectui validate 会按名字拒绝它,objectui check 也会点名它。

为什么改:PR objectui#11069 让命令行校验改用严格模式,events 这种没有渲染器读取的键会被直接拒绝。规程里如果还留着「没人检查」,AI 会以为写了也无害,或者不把校验报错当回事。

风险与代价(含回滚):只改两句文字,不动代码,也不发版。唯一的风险是合并顺序:如果先于 PR objectui#11069 合并,这两句话会提前变成假话,所以必须和它一起合并,或在它之后合并。回滚就是撤销本 PR,只涉及两处文字。

席位意见:

你要做的:在 PR objectui#11069 合并的同时或之后,审阅这两句话并批准本 PR。


Generated by Claude Code

…te` and named by `objectui check` (objectui#5250)

AGENTS.md section 5 #4 and skills/objectui/rules/protocol.md said an `events`
bag that arrives as data is "kept, judged by nothing and run by nothing".
Once PR objectui#11069 (objectui#5250 slice A) lands, `objectui validate`
and `objectui check` judge a document through the strict authoring face,
which refuses `events` as an undeclared key. The two sentences now say
that; the tolerant face still keeps the bag, and nothing runs it.

Must merge together with or after PR objectui#11069, never before.

Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU
Co-authored-by: Claude <noreply@anthropic.com>
…ssion (objectui#5250)

skills/objectui/guides/project-setup.md said `objectui check` exits
non-zero on unreadable JSON only. Since objectui#4795 a `${…}` refused on
a text key its node never evaluates fails the run too. One sentence in the
CLI table.

Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

This PR now also corrects skills/objectui/guides/project-setup.md

Seat domain:ui#2 · os-bill · session_01MgfduSkFrfM3eorB3UGfAU, under the take-over claim 6077901503 on objectui#5250. The relay cannot edit a PR body, so this comment records the change in scope.

The second commit (d4737568d) changes one sentence in the guide's CLI table.

The objectui check row said the command 「exits non-zero on unreadable JSON only」. It now says the command exits non-zero on unreadable JSON and on a ${…} refused on a text key its node never evaluates (objectui#4795).

Why it is here: the sentence has been false since objectui#4795, which made a refused expression fail the run. It lives in the governed skills/** tree, so it rides this governed PR instead of the ungoverned door-prose sweep. It does not depend on PR objectui#11069: it is true on main today, and stays true once PR objectui#11069 lands. The merge-order line in the body still governs the PR as a whole.

Gates on d4737568d:

  • check:control-bytes exit 0;
  • check:skills-paths exit 0 (skills/ — 29/29 resolve);
  • node scripts/check-governed-queue-guard.mjs --test over the three paths: exit 3, GOVERNED — 3 of 3 path(s) (AGENTS.md, skills/** x2). Still Tier H, still draft.

The 维护者速读 draft in the body is unchanged.


Generated by Claude Code

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

维护者速读(终稿)

PR objectui#12050 · objectui#5250 的受管面配套 · domain:ui 席位 2 · 2026-10-09T11:13Z

**改了什么:**两份写给 AI 的规程里,改正三句话:

  • 仓库根 AGENTS.md 与对外发布的技能包 skills/objectui/rules/protocol.md:原句说作者写进元数据的 events 事件包「没有任何东西检查」。改为:objectui validate 按名字拒绝它,objectui check 也会点名它。
  • skills/objectui/guides/project-setup.md:原句说 objectui check「只在 JSON 读不出来时才失败」。objectui#4795 之后,遇到被拒绝的 ${…} 表达式它也会失败。这句话早已过时,顺带改正。

**为什么改:**PR objectui#11069 让命令行校验改用严格模式,没有渲染器读取的键会被直接拒绝。规程如果还写着「没人检查」,AI 会以为写了也无害,或者不把校验报错当回事。

**风险与代价(含回滚):**只改三句文字,不动代码,也不发版。

  • 风险在合并顺序:events 那两句必须和 PR objectui#11069 一起合并,或在它之后合并;先合并会让这两句提前变成假话。
  • 回滚就是撤销本 PR。

**席位意见:**同意合并。措辞已对照 PR objectui#11069 的实际行为核对:validate 是拒绝,check 只点名不失败。PR objectui#11069 的合同级复审已通过(6079721513),正在走合并队列。

**你要做的:**PR objectui#11069 合并后(或同时),以授权账户批准本 PR。批准后由席位放行进合并队列。


Generated by Claude Code

@os-zhuang
os-zhuang marked this pull request as ready for review October 9, 2026 11:16
@os-zhuang
os-zhuang enabled auto-merge October 9, 2026 11:16
@os-zhuang
os-zhuang added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit 972e566 Oct 9, 2026
40 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-5250-agents-events-sentence branch October 9, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants