Repository navigation
docs: name the door objectui validate / objectui check run as the strict face (objectui#5250) - #12054
Merged
Merged
Conversation
… strict face (objectui#5250) Un-park step 2 of objectui#5250, the door prose slice A makes false. Each edited sentence said `objectui validate` or `objectui check` runs `safeValidateSchema`, `AnyComponentSchema` or the tolerant face; since slice A both commands run `StrictAnyComponentSchema` through validateAuthoredDocument. Only the false sentence or test name changes; no assertion changes. Where a sentence named both faces, the attribution moves to the strict one; where it named only the tolerant face, it says "the tolerant face"; past-tense history stays as history. A sentence is left as it is where the door it names is still true on the strict face (the `list-view` record-source rule, the dashboard global filter options, the form-field widget namespace: each refused by both faces, probed on the merged tree). Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
…on (objectui#5250)
Two test comments said unreadable JSON is the only thing that fails an
`objectui check` run. Since objectui#4795 a `${…}` refused on a text key its
node never evaluates fails it too. Comment-only.
Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU
Co-authored-by: Claude <noreply@anthropic.com>
… patch (objectui#5250) check-changeset-presence requires a changeset: the sweep edits published `src/` files in 8 released packages, among them `@object-ui/types` source docblocks. Comments and test names only. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
github-actions
Bot
added
documentation
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5250
Merge order: this PR merges together with or after PR objectui#11069 (slice A of objectui#5250), never before it. Until slice A lands,
objectui validateandobjectui checkstill run the tolerant face, and the sentences this PR replaces are still true.Clause-②: no
What this is
The door-prose sweep split out of PR objectui#11069 by the seat (objectui#5250, un-park step 2; the split was the seat's call because step 2 counted 65 files). PR objectui#11069 makes
objectui validateandobjectui checkjudge through the strict authoring face,StrictAnyComponentSchema. Across the tree, comments, doc sentences and test names still say those commands runsafeValidateSchema,AnyComponentSchemaor the tolerant face. This PR corrects them.⛔ No behaviour, schema, export or assertion changes. The only non-comment lines touched are test names and face labels inside string literals: 23 line pairs in 19 test files. A
git diff -U0scan confirms that each pair differs only inside one single-quoted string, and that no non-test source file has a non-comment change.It also corrects two CLI test comments that have been stale since objectui#4795. Both said unreadable JSON is the only thing that fails an
objectui checkrun; a refused${…}fails it too.The rule, re-derived on the merged tree
Changed: every sentence or test name that says
objectui validateorobjectui checkruns, calls, takes or readssafeValidateSchema,AnyComponentSchemaor the tolerant face, in the present tense. This includes:objectui validateruns」 and 「the doorobjectui validate/objectui checkrun」;objectui validate)」 and 「the union the CLI applies」;objectui validatemakes」.How each was changed:
Left as written, on purpose:
safeValidateSchema, andobjectui validatewith it, refused every document naming it」): it describes what the door was.content/docs/guide/dashboard-filters.md's sentence that objectui's own validator (@object-ui/types, whichobjectui validateruns) refuses bare-string filter options. The strict face refuses them too.packages/plugin-list's comment on thelist-viewrecord-source ruleobjectui validateruns. The strict face keeps that rule: alist-viewwith no record source is refused with the samecustomissue on both faces.packages/cli'scheck-validity-recognisercomment thatsafeValidateSchemarefusesplugin-dashboard:metric-cardattype. That is a recorded measurement, not a claim about which doorcheckruns.eventsbag, and theobjectui checkrow inskills/objectui/guides/project-setup.md, are in the governed companion, PR objectui#12050.strict-authoring-face.ts,zod/index.zod.tsand the objectui#6318 corpus pin are in PR objectui#11069 itself.objectui validateruns and supersedes them at release.Renamed tests: 17 test names in 13 files named themselves as the CLI door while asserting only
safeValidateSchema. Their names now say the tolerant face. By the seat's decision they stay tolerant-face tests: no assertion changes on this card. The door itself is pinned inpackages/cli.Changeset
check-changeset-presencerequires one: the sweep edits publishedsrc/files in 8 released packages, including the@object-ui/typessource docblocks. So.changeset/5250-door-prose-sweep.mddeclares'@object-ui/types': patch, worded as comments and test names only.Files: 65, grouped by package
.changeset(1)5250-door-prose-sweep.mdapps/console(1)src/__tests__/drillDownReport.nameRetired-11517.test.tsxcontent/docs(2)guide/data-source.mdplugins/plugin-dashboard.mdxexamples/schema-catalog(2)test/sidebar-node-docs-10859.test.tsxtest/slotted-pages-header-example-11165.test.tspackages/cli(2)src/__tests__/check-first-issue-11007.test.tssrc/__tests__/cli-bin.test.tspackages/components(3)src/__tests__/layout-spacing-sets-11474.test.tsxsrc/renderers/__tests__/sidebar-node-provider-10859.test.tsxsrc/renderers/basic/__tests__/element-text-published-variants-7450.test.tsxpackages/plugin-dashboard(3)src/__tests__/ObjectMetricWidget.ruleFilterSpecShape-11526.test.tsxsrc/__tests__/metricCardLabelRefusedTitleHeading-4425.test.tsxsrc/__tests__/readme-dashboard-examples-spec-valid.test.tspackages/plugin-form(1)src/__tests__/objectFormLayout-11168.test.tsxpackages/plugin-timeline(1)src/__tests__/objectTimelineInputs-11168.test.tsxpackages/plugin-tree(1)src/__tests__/objectTreeInputs-11168.test.tsxpackages/types(48)src/__tests__/app-actions-retired-7469.test.tssrc/__tests__/app-mobile-nav-mode-refusal-11363.test.tssrc/__tests__/bare-kanban-node-key-retired-8802.test.tssrc/__tests__/chart-type-doc-row-11521.test.tssrc/__tests__/container-padding-set-11424.test.tssrc/__tests__/dashboard-widget-slot-component-arm-7952.test.tssrc/__tests__/drill-down-per-block-10685.test.tssrc/__tests__/drill-down-report-dataset-bound-11506.test.tssrc/__tests__/drill-down-report-name-retired-11517.test.tssrc/__tests__/element-data-source-objectname-waiver-11117.test.tssrc/__tests__/element-number-arm-10872.test.tssrc/__tests__/filter-builder-mirror-6939.test.tssrc/__tests__/filter-builder-nested-group-retired-9306.test.tssrc/__tests__/filter-ui-operator-retired-10611.test.tssrc/__tests__/flat-props-refusal-10872.test.tssrc/__tests__/form-field-widget-namespace.test.tssrc/__tests__/grid-columns-set-11491.test.tssrc/__tests__/grid-field-keys-camelcase-11610.test.tssrc/__tests__/grid-flat-columns-retired-11505.test.tssrc/__tests__/grouping-field-padded-refused-7347.test.tssrc/__tests__/held-public-block-arms-10872.test.tssrc/__tests__/layout-gap-sets-11474.test.tssrc/__tests__/list-bind-only-11405.test.tssrc/__tests__/named-view-kanban-stray-group-by-10321.test.tssrc/__tests__/nav-label-locale-map-11299.test.tssrc/__tests__/navigation-spec-parity.test.tssrc/__tests__/nested-page-children-11223.test.tssrc/__tests__/object-chart-axis-config-10518.test.tssrc/__tests__/object-chart-legacy-axis-keys-retired-10608.test.tssrc/__tests__/object-chart-react-tier-node-10770.test.tssrc/__tests__/object-form-subforms-columns-11266.test.tssrc/__tests__/object-kanban-allow-collapse-retired-8801.test.tssrc/__tests__/object-kanban-on-quick-add-retired-11234.test.tssrc/__tests__/object-kanban-quick-add-retired-8285.test.tssrc/__tests__/object-master-detail-form-details-entry-11396.test.tssrc/__tests__/page-nav-misc-spec-parity.test.tssrc/__tests__/page-width-padding-refusal-11318.test.tssrc/__tests__/passing-keys-arms-11440.test.tssrc/__tests__/public-block-doc-examples-bag-11321.test.tssrc/__tests__/record-alert-flat-body-remedy-10872.test.tssrc/__tests__/record-line-items-arm-10872.test.tssrc/__tests__/schema-registry-chatbot-keys-7704.test.tssrc/__tests__/timeline-items-bar-shape-7365.test.tssrc/__tests__/timeline-readme-schema-example-10824.test.tssrc/complex.tssrc/form.tssrc/zod/form.zod.tssrc/zod/nested-component-walk.tsGates
Head
408047981, basemain3c3115e38. Each exit code was captured before any pipe; each tool's own verdict line is quoted.@object-ui/cliclosure build:Test Files 58 passed (58)·Tests 1900 passed (1900),VERDICT command-exit 0.pnpm --filter @object-ui/types type-check(tsc --noEmit && tsc -p tsconfig.examples.json && tsc -p tsconfig.test.json): exit 0.docs:check-linksexit 0 (Links are valid across 17 scan roots);check:new-line-citationsexit 0 (0 new citation(s));check:control-bytesexit 0.check-changeset-presenceexit 0 (60 source file(s) of 8 released package(s) changed, and this change declares 1 changeset(s));check-changeset-no-majorexit 0;check-changeset-overwriteexit 0;check-changeset-claimsexit 0 (No pending changeset names a file this change touches).NOT GOVERNED.git diff -U0scan above).Generated by Claude Code