Skip to content

fix(plugin-grid): a list column's inline locale-map label heads the column (objectui#12358) - #12377

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-12358-grid-column-label-map
Oct 14, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-12358-grid-column-label-map

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12358
Clause-②: no

What

ListColumnSchema.label is the spec's I18nLabel: a plain string or an inline locale map ({ en: 'MAPEN Est', 'zh-CN': 'MAPZH 预计' }). The spec documents the map as resolved by the renderer. In plugin-grid, resolveColumnLabel kept only a plain string and returned undefined for a map. The header then fell back to the field label in every locale.

resolveColumnLabel now takes the viewer's UI language. It passes a plain string through unchanged and resolves a map through pickLocalized from @object-ui/i18n. That is the same resolver the navigation and Studio label-map fixes use, so there is no second locale-pick implementation. The fallback when the viewer's locale is absent is pickLocalized's own rule: exact tag, base language, a regional sibling, default, en, then the first entry. A map with no usable entry still returns undefined, so the existing field-label fallback applies as before.

The locale source is uiLanguage, which is useObjectTranslation().language through the grid's useGridTranslation. That is the text-language channel the pickLocalized call sites across the plugins use. generateColumns now lists uiLanguage as a dependency.

Readers checked (mechanism assumption A1)

  • resolveColumnLabel in ObjectGrid.tsx is the only place in plugin-grid where a column's label is read. Its call site in generateColumns is the one changed.
  • Every downstream reader uses the resolved header produced there, so this fix covers them too: the column header, the client CSV export header row (generateColumns().map(c => c.header)), the inline-edit conflict dialog's field label (columnHeaderOf), the summary footer (col.header), and the cell face's fieldMeta.label.
  • The other label reads in plugin-grid are object field labels. FieldSchema.label is a z.string() in the spec, so those reads are a different key and are out of scope. The column picker and settings panel are not in plugin-grid.

Tests

packages/plugin-grid/src/__tests__/ObjectGrid.columnLabelMap-12358.test.tsx mounts the grid under a real I18nProvider whose bundle translates every field. A header that fell back to the field label would therefore show the bundle's text and fail.

  • en shows the map's en entry and not the field label.
  • zh shows the zh-CN entry, not the en entry and not the field label. The map lists en first, so falling back to en or to the first entry would fail this case.
  • fr, which the map does not carry, shows pickLocalized's fallback, the en entry.
  • Control: a plain-string label renders unchanged in both en and zh.
  • Control: a column with no label still shows the translated field label.

Ablation (one-off; the fix was committed first): ablation-replace.mjs swapped return pickLocalized(label, language) || undefined; for return undefined;, which is the old behaviour.

  • The anchor count went from 1 to 0 and the blob changed. The three map cases failed and the two controls passed (Tests 3 failed | 2 passed (5)).
  • After the restore, the blob matches HEAD and git diff HEAD is empty.

Gates and test runs on head bacf601:

  • Dependency closure build (pnpm --filter '@object-ui/plugin-grid^...' build) and type-check (tsc --noEmit plus the test tsconfig): both exit 0.
  • Targeted vitest (this file, the authoredColumnLabel-12110 file and the cellFaceLabel-11689 file): 14 of 14 passed.
  • Full plugin-grid suite (pnpm exec vitest run packages/plugin-grid/): Test Files 213 passed (213), Tests 1929 passed (1929).
  • Lint narrowed to the 2 changed files: eslint run as the package's lint script runs it, 0 errors. All warnings are on lines outside this diff.
  • The pre-tsc battery (phantom-deps, self-import, unreferenced-sources, doc-example-readers, handler-key-reads, side-effects-array, element-data-source-declaration, spec-symbols, action-forward-parity, designer-field-key-parity, icon-record-names, i18n-keys, i18n-drift, i18n-designer-parity), plus control-bytes, new-line-citations, check-changeset-fixed and check-changeset-presence: all exit 0.
  • check:spec-floors exits 1 on main for an unrelated reason: "The scan collapsed: 0 package(s) declare @objectstack/spec". This PR does not fix it.

Acceptance notes

  • Observation, not filed: several other I18nLabel reads in ObjectGrid.tsx resolve against displayLocale (useDisplayLocale: tenant regional locale first, then UI language), not the UI language. These are the view label in the export filename, the caption, the detail label, the description and the empty state. With a tenant regional locale such as en-US and a zh UI, those would pick the en entry while this column header picks zh-CN. This is a read-only inference and was not reproduced.

Changeset

.changeset/12358-grid-column-label-map.md: @object-ui/plugin-grid patch.

Implemented by session https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB.


Generated by Claude Code

…jectui#12358)

resolveColumnLabel kept only a plain-string label, so a ListColumnSchema
label written as an inline locale map (the spec's I18nLabel) was dropped and
the header fell back to the field label. The map now goes through
pickLocalized against the UI language; a plain string passes through.

Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

No CI run exists on this PR's head bacf601 · domain:ui seat 2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-14T15:43Z

The PR was opened at 15:00:53Z. objectui ran no workflow at all between 14:56Z and 15:24Z, scheduled runs included, and this PR's pull_request (opened) event never produced a run. check-runs on bacf601 reads total_count: 0, and the workflow runs for the branch read 0.

ci.yml's pull_request trigger takes only the default activity types, so marking the PR ready would not start a run. A close-and-reopen or an empty commit is not used.

Plan: once main moves past df05784 (PR #12374 is next to land), the original dev merges main into this branch and pushes. That is a real commit, and its synchronize event starts CI. The ACCEPT is held until CI is green on that head.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 69 chunks) 3052.4 KB 3119.4 KB
Main entry chunk (gzip) 73.8 KB 350 KB
Entry file index-B6_guGTm.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 20.90KB 7.67KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 591.65KB 142.68KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.41KB 69.48KB
fields (index.js) 283.00KB 72.12KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.26KB 11.71KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.72KB 23.27KB
plugin-chatbot (index.js) 201.72KB 48.07KB
plugin-dashboard (index.js) 143.63KB 38.79KB
plugin-designer (index.js) 233.77KB 50.02KB
plugin-detail (index.js) 259.78KB 68.65KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 178.88KB 46.47KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 259.06KB 72.25KB
plugin-kanban (index.js) 53.23KB 16.71KB
plugin-list (index.js) 123.35KB 31.60KB
plugin-map (index.js) 27.14KB 8.99KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 91.99KB 23.23KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Test (shard 2/12) cancelled at the job timeout on head abb4c59; not this PR's, one re-run · domain:ui seat 2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-14T16:48Z

  • What failed: Test (shard 2/12), job 115970222544 in run 38598179761, ended cancelled at the job's 20-minute limit (16:27:13Z → 16:47:35Z). The aggregate Test check is red because of it.
  • Why it is not this PR's:
    • No test failed. The log's last minutes show ✓ lines arriving every few seconds, for unrelated packages (app-shell, plugin-detail, plugin-timeline, layout, schema-catalog), right up to "The operation was canceled".
    • The other 11 shards on this head finished in 8–12 minutes, all success.
    • This PR changes one module-private function in ObjectGrid.tsx and adds a 5-case pin. Nothing in it can slow a shard of unrelated files.
    • This is a slow runner hitting the timeout, the same shape as the shard 8/10 timeouts on PR feat(app-shell): register record:approval_decision, armed in @object-ui/types (objectui#12342) #12362 earlier today.
  • No fix to port: no change exists that would make this shard faster.
  • Action: one re-run of the failed jobs on this head (abb4c59). A second timeout or a real failure is treated as this PR's.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants