fix(plugin-detail): record page inline date / datetime edit draws the platform picker and keeps the time (objectui#12759) by objectstack-fleet[bot] · Pull Request #12786 · objectstack-ai/objectui

objectstack-fleet · 2026-10-16T20:32:38Z

Fixes #12759
Clause-②: no

An inline edit of a datetime field on the record page keeps its time. The details section and the header highlights now draw the platform date picker for date and datetime, the same picker the grid cell, the forms, the dialogs and the kanban dialog draw since #12756.

What was wrong (measured live before the fix)

InlineFieldInput routed date and datetime to DateField, the native date input, which can only hold a day. For a datetime it wrote local midnight of the picked day.

On origin/main, with a Chromium browser in Asia/Taipei, the record showcase_field_zoo held f_datetime = 2026-06-17T14:30:00.000Z (22:30 local). An inline edit of the day to the 20th sent {"f_datetime":"2026-06-19T16:00:00.000Z"} and stored it. The time was lost, and the box then repainted the previous day, 06/19.

What changed

packages/plugin-detail/src/InlineFieldInput.tsx
- date and datetime are no longer excluded from the FieldEditWidget delegation tail, and the DateField branch is removed.
- FieldEditWidget already draws the lazy DatePickerField / DateTimePickerField (the fields-date-picker chunk). No second picker and no static import were added.
- date and datetime left INLINE_ROUTED_FIELD_TYPES, an internal set that is not exported from the package entry.
The value written
- A datetime is read as the local wall clock. A calendar pick keeps the time, typed text carries the time typed, and the write is an ISO instant.
- A date field still writes the plain YYYY-MM-DD (console: inline-editing a date-only field in record highlights saves the day before east of UTC — it sends local midnight as a UTC instant (the Edit form sends the plain date) #12206).
The impossible-stored-day notice (finding(plugin-detail): the inline date editor (InlineFieldInput) silently blanks an impossible stored day — the third editor of the objectui#10567 class #10625 / finding(fields): the date-only editor blanks an impossible stored day silently — input type=date sanitises 2026-02-30 to empty, and DateField / the grid's date cell show no marker #10567) is the picker's own: an empty aria-invalid box, described by a notice that names the stored string.
Typed text and Save. The picker reads typed text on blur and on Enter. Save takes focus first, so the typed value is saved. Ctrl/Cmd+Enter was also measured live: it saves the typed value.
Docs
- The pending changesets 12622, 12642 and 12664 said the detail inline editor keeps the native input. That sentence is corrected.
- DatePickerField.tsx's "where the native input stays" comment is corrected (comment only).

Live reading

Published backend @objectstack/*@18.0.0-next.2 (showcase app), this branch's console, Chromium in Asia/Taipei. PNGs and the table are on claude/issue-12759-evidence under evidence/12759/.

Run	PATCH body	Stored
before, native input, day 20	`{"f_datetime":"2026-06-19T16:00:00.000Z"}`	local midnight, time lost
after, calendar day 20	`{"f_datetime":"2026-06-20T14:30:00.000Z"}`	22:30 kept
after, typed `06/20/2026, 09:05 PM` + Save	`{"f_datetime":"2026-06-20T13:05:00.000Z"}`	as typed
after, the same typed + Ctrl+Enter	`{"f_datetime":"2026-06-20T13:05:00.000Z"}`	as typed
control, `date` field, day 20	`{"f_date":"2026-06-20"}`	plain day

The picker shows 06/17/2026, 10:30 PM with the placeholder MM/DD/YYYY, HH:mm AM/PM (console locale).

Tests

New: InlineFieldInput.datetimePicker-12759.test.tsx. It drives the whole record-page write: highlights strip, then save bar, then dataSource.update.

the picker is drawn, not the native date input, and it shows the date and the time;
a record at 14:30 moved to the 16th in the calendar saves 2026-10-16T14:30:00.000Z;
a typed date and time saves that instant;
CONTROL: a date field saves { due_date: '2026-10-16' };
zone cases at UTC+8 and UTC-5 (14:30 local is kept). These are registered in date-only-zone-pins-10183.test.ts and run in its forks child.

Ported to the picker (the assertions keep their intent): InlineFieldInput.test.tsx, InlineFieldInput.delegation.test.tsx, InlineFieldInput.impossibleDay-10625.test.tsx, InlineFieldInput.dateOnlyWriteZone-12206.test.tsx, inlineEditTypeCoverage.test.tsx (date/datetime move from routed to delegated).

Ablation. Through src: vitest aliases the packages to src. Each leg checked the anchor count and the blob on disk, and each restore matched the HEAD blob with an empty git diff HEAD.

the base editor restored: 4/4 suite pins red;
a local-midnight re-emit for datetime: both time pins red, CONTROL green;
the picker's date write turned into an instant: CONTROL red only;
the picker's notice removed: both finding(plugin-detail): the inline date editor (InlineFieldInput) silently blanks an impossible stored day — the third editor of the objectui#10567 class #10625 notice cases red.

Runs

at a286306: zone driver 29/29;
targeted sets 36 files / 872 passed, 81 files / 1459 passed, 13 files / 477 passed;
new pin re-run at merged head 6fdbc5d: 4 passed.

NOT MEASURED: the whole-package packages/plugin-detail run hit the foreground time cap (exit 124). CI runs the full farm.

Gates (local)

closure build @object-ui/plugin-detail^...: 0
type-check plugin-detail 0, fields 0
check:i18n-keys / -drift / -dead-keys 0
check:changeset-claims 0
changeset:check 0
check:test-path-roots 0
check:spec-symbols 0
check:new-line-citations 0
check-changeset-presence.mjs 0
check:control-bytes 0
eslint on the changed files: 0 errors

Acceptance notes

Clause-②: no. No prop, export, type member or language-pack key is added or removed. INLINE_ROUTED_FIELD_TYPES is not exported from the package entry.
Under jsdom, Ctrl+Enter right after typing does not save the typed value, because synthetic dispatch runs no microtask checkpoint between listeners. Real Chromium saves it (table above), so no jsdom pin was added for it.

Provenance: built by the cloud session session_01K55FPCr5QJXCL9M28p3vvZ (claim 6223418940) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat replaced the dev's footer line with this line and changed nothing else.

Generated by Claude Code

…platform picker and keep the time (objectui#12759) InlineFieldInput routed date and datetime to the native date input, a day-only control; a datetime edit re-emitted local midnight and dropped the stored time. Both now delegate to FieldEditWidget, which draws the platform date picker the grid cell, forms and dialogs draw. A date field still writes YYYY-MM-DD, and the impossible-stored-day notice is the picker's own. Co-Authored-By: Claude <noreply@anthropic.com>

…line-datetime

github-actions · 2026-10-16T20:36:16Z

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 74 chunks)	3127.2 KB	3744.1 KB
Main entry chunk (gzip)	75.6 KB	350 KB
Entry file	`index-DHDNIDIr.js`	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	21.42KB	7.85KB
app-shell (runtime-config.js)	22.59KB	7.89KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.11KB	3.87KB
auth (ActiveOrganizationStorage.js)	27.95KB	10.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	41.15KB	10.86KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	20.67KB	6.12KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.72KB	2.24KB
auth (SocialSignInButtons.js)	9.74KB	3.94KB
auth (UserMenu.js)	3.39KB	1.21KB
auth (auth-gate-events.js)	1.62KB	0.83KB
auth (authStyles.js)	5.27KB	1.86KB
auth (createAuthClient.js)	41.19KB	11.12KB
auth (createAuthenticatedFetch.js)	8.54KB	3.46KB
auth (index.js)	3.63KB	1.64KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	11.08KB	4.58KB
collaboration (CommentThread.js)	27.26KB	8.03KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.28KB	2.60KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (commentAuthorship.js)	1.39KB	0.78KB
collaboration (index.js)	1.93KB	0.85KB
collaboration (useCollaborationTranslation.js)	6.50KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	600.51KB	145.04KB
core (index.js)	10.18KB	4.04KB
create-plugin (index.js)	27.94KB	9.51KB
data-objectstack (index.js)	248.96KB	69.45KB
fields (index.js)	291.36KB	74.46KB
i18n (LocalizationContext.js)	2.92KB	1.42KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	2.59KB	1.22KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	8.87KB	3.64KB
i18n (index.js)	5.52KB	2.39KB
i18n (pickLocalized.js)	9.86KB	3.95KB
i18n (provider.js)	39.35KB	12.88KB
i18n (translateFn.js)	0.20KB	0.18KB
i18n (useDisplayLocale.js)	3.52KB	1.76KB
i18n (useObjectLabel.js)	36.87KB	9.88KB
i18n (useSafeTranslation.js)	7.14KB	2.92KB
layout (index.js)	40.67KB	11.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	6.62KB	2.45KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	5.52KB	2.10KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	15.35KB	5.51KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.82KB	2.38KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	8.33KB	3.07KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	16.04KB	3.92KB
plugin-calendar (index.js)	54.94KB	16.05KB
plugin-charts (index.js)	84.97KB	23.36KB
plugin-chatbot (index.js)	201.89KB	48.13KB
plugin-dashboard (index.js)	146.23KB	39.59KB
plugin-designer (index.js)	233.95KB	50.08KB
plugin-detail (index.js)	263.56KB	69.68KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	180.28KB	46.60KB
plugin-gantt (index.js)	178.36KB	45.08KB
plugin-grid (index.js)	270.84KB	75.07KB
plugin-kanban (index.js)	59.42KB	18.48KB
plugin-list (index.js)	132.61KB	34.08KB
plugin-map (index.js)	27.07KB	8.96KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	46.66KB	13.13KB
plugin-timeline (index.js)	39.21KB	11.85KB
plugin-tree (index.js)	15.07KB	5.33KB
plugin-view (index.js)	93.43KB	23.94KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	12.07KB	3.68KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	120.23KB	39.46KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.50KB	2.06KB
react (schema-input.js)	4.31KB	2.07KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (body-dialect.js)	4.50KB	1.99KB
sdui-parser (codegen.js)	9.45KB	3.76KB
sdui-parser (dashboard-widget-options.js)	3.07KB	1.30KB
sdui-parser (index.js)	7.30KB	3.12KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	25.28KB	7.81KB
sdui-parser (provenance.js)	3.84KB	1.90KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	23.87KB	7.83KB
types (ai.js)	4.39KB	2.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	4.12KB	1.61KB
types (authoring-nodes.js)	0.20KB	0.19KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (cloud.js)	0.20KB	0.18KB
types (complex.js)	4.44KB	2.07KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (dashboard-widget-layout.js)	2.06KB	0.96KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	1.13KB	0.65KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	5.78KB	2.70KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	5.00KB	2.39KB
types (navigation.js)	0.20KB	0.18KB
types (node-slots.js)	7.18KB	2.34KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	2.52KB	1.31KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-approval-decision.js)	0.20KB	0.20KB
types (record-components.js)	0.20KB	0.19KB
types (record-panels.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	4.99KB	1.96KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (strict-authoring-face.js)	19.93KB	7.26KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.48KB	3.50KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

objectstack-fleet · 2026-10-16T20:46:01Z

席位核对 · ACCEPT · `domain:ui` seat 1 · `session_011K9g23W67dy2zwnyzaoB6o` · 2026-10-16T20:45Z

What was reviewed:

Head 6fdbc5d, against objectui#12759.
The claim 6223418940, and the dev's report with the seat's answers on the card.
Tier: TIER_DEFAULT, the seat's own review. Clause-②: no is on line 2 of the body and in the changeset. INLINE_ROUTED_FIELD_TYPES is not exported from @object-ui/plugin-detail's entry, and no prop, export, type member or key changes.

Shape.
- Fixes #12759 is the first line and the only closing keyword. The assignee is os-tesla.
- 13 files, NOT governed (check-governed-merges --pr on this file list, 419 changed lines): InlineFieldInput.tsx, a comment in DatePickerField.tsx, one new and five ported tests, one zone-driver PINS line, the new changeset (@object-ui/plugin-detail and @object-ui/fields patch) and one corrected sentence in each of the pending changesets 12622, 12642 and 12664.
The change.
- The date / datetime exclusion and the DateField branch are removed from InlineFieldInput, so both take the existing FieldEditWidget tail and draw the lazy platform picker the grid, forms, dialogs and kanban already draw (PR fix(fields,components): grid inline date / datetime editors draw the platform picker, and the cell seam commits what was typed #12756). No second picker and no static import.
- A datetime keeps its time: a calendar pick keeps the wall clock and typed text carries the time typed. The local-midnight re-emit (new Date(v + 'T00:00:00').toISOString()) is gone.
- A date field still writes YYYY-MM-DD (objectui#12206). The impossible-stored-day notice (objectui#10625) is the picker's own and stays pinned.
- The three pending changesets each said the detail inline editor keeps the native input; this change makes that false, so the correction is owed.
Tests and evidence.
- The new pin drives the whole record-page write (highlights strip, save bar, dataSource.update): picker drawn with date and time, a 14:30 record moved to another day saves 14:30, typed date and time saved, CONTROL date writes the plain day, and zone cases at UTC+8 and UTC−5 in the forks driver (29/29).
- Four ablations, each red as reported (the base editor, a local-midnight re-emit, the date write as an instant, the notice removed); each restored blob equals HEAD.
- Targeted sets: 36 files / 872, 81 files / 1459 and 13 files / 477 passed. The whole-package local run hit the time cap (NOT MEASURED); CI's 16 shards below are the reading.
- Live in Chromium at Asia/Taipei against a published 18.0.0-next.2 backend: before, a day edit stored 2026-06-19T16:00:00.000Z (time lost); after, calendar 2026-06-20T14:30:00.000Z, typed + Save and typed + Ctrl+Enter 2026-06-20T13:05:00.000Z; control f_date 2026-06-20. The PNGs are at 3675425 on claude/issue-12759-evidence.
Gates (check-runs pinned to this head).
- 33 success and 3 skipped (coverage and dependabot, skipped by design), including Lint, Type Check, Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Repo Gates, Governed Surface Queue Guard and every changeset check.
Recorded, not changed: under jsdom, Ctrl+Enter right after typing does not save the typed value (no microtask checkpoint between synthetic listeners); real Chromium saves it, as measured. No card.
Landing.
- Ready, then auto-merge into the merge queue.
- After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_01K55FPCr5QJXCL9M28p3vvZ.

Generated by Claude Code

claude added 2 commits October 16, 2026 20:12

Merge remote-tracking branch 'origin/main' into claude/issue-12759-in…

6fdbc5d

…line-datetime

objectstack-fleet Bot assigned os-tesla Oct 16, 2026

github-actions Bot added plugin tests package: fields labels Oct 16, 2026

objectstack-fleet Bot mentioned this pull request Oct 16, 2026

Record page inline edit of a datetime field drops its time: InlineFieldInput edits it through a date-only control and saves local midnight (the last inline editor still on the native date input) #12759

Closed

objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 20:46

objectstack-fleet Bot enabled auto-merge October 16, 2026 20:46

objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026

Merged via the queue into main with commit 020d178 Oct 16, 2026
37 checks passed

objectstack-fleet Bot deleted the claude/issue-12759-inline-datetime branch October 16, 2026 20:58

Navigation Menu

Repository navigation

fix(plugin-detail): record page inline date / datetime edit draws the platform picker and keeps the time (objectui#12759) - #12786

fix(plugin-detail): record page inline date / datetime edit draws the platform picker and keeps the time (objectui#12759)#12786
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-12759-inline-datetime

objectstack-fleet Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

objectstack-fleet Bot commented Oct 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

objectstack-fleet Bot commented Oct 16, 2026

What was wrong (measured live before the fix)

What changed

Live reading

Tests

Gates (local)

Acceptance notes

Uh oh!

github-actions Bot commented Oct 16, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

objectstack-fleet Bot commented Oct 16, 2026

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-16T20:45Z

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

席位核对 · ACCEPT · `domain:ui` seat 1 · `session_011K9g23W67dy2zwnyzaoB6o` · 2026-10-16T20:45Z