Skip to content

test(console): pin record:quick_actions member shapes (objectui#8071 slice 4) - #8860

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-8071-member-pins-slice-4
Sep 9, 2026
Merged

os-warren merged 1 commit into
mainfrom
claude/issue-8071-member-pins-slice-4

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Refs #8071

Fourth slice of objectui#8071's transition: both remaining record:quick_actions keys converted from member-pin exemption to member pin, and MEMBER_PIN_EXEMPTION_CEILING moved down with the list in the same commit.

Re-derived on this branch's base (origin/main 42df92809)

Copied slice 3's instrument rather than a brace-depth counter: ts.createSourceFile + a visitor over VariableDeclaration nodes, counting each object literal's own PropertyAssignment children. Controlled at two commits:

reading at origin/main (42df92809, this branch's base) after this PR
MEMBER_PINS 40 42
MEMBER_PIN_EXEMPTIONS 50 48
MEMBER_PIN_EXEMPTION_CEILING 50 48
population (array/object-armed inputs on covered blocks) 90 90

The 50/40 base reading matches the card's claim comment (5604086894) and slice 3's landing note (5603836330) — the ledger has not moved since. Population does not move; a pin and an exemption are the two halves of one partition.

⚠️ A correction to the dispatch's "BOTH assertions" quote. The dispatch's blockquote — "BOTH assertions below carry the ceiling and BOTH must move together, the toBe is EXACT in both directions" — is a real sentence in this file, but it is not about MEMBER_PIN_EXEMPTION_CEILING. It sits in the different the objectui#8176 backlog has a ceiling test (UNPUBLISHED_EXEMPTIONS / LAZY_REGISTERED_BLOCKS, only object-calendar/object-kanban), which does carry two literal assertions (toBeLessThanOrEqual(1) and toBe(1)). MEMBER_PIN_EXEMPTION_CEILING has exactly one assertion (toBeLessThanOrEqual, :3945), driven symbolically off the constant — confirmed against slice 3's own merged diff (9e9a4b6da), which touched only the const MEMBER_PIN_EXEMPTION_CEILING = 54 line and no assertion. This slice moves the one constant; no second assertion needed editing.

Which keys, and why these

record:quick_actions — actionNames, requiredPermissions. This is the entire remaining exemption list for the block (both of its two array-armed keys) — a coherent whole-block closure, the shape slice 3 set with element:record_picker. Neither key needed NO_READ_SITE_TO_PIN: both have a real read site in renderers/record-quick-actions.tsx.

Per key — where the renderer reads it, and the shape found

key read site shape the renderer actually reads
actionNames resolveDeclaredActionIds → useMetadataItem('object', objectName) Action-id STRINGS resolved against the object's own actions; with none declared (and no host actions) the metadata layer is never queried and the empty placeholder renders — a fallback the registered description used to promise but the code never took (objectui#4663).
requiredPermissions required.every((p) => perms.can(objectName, p)), evaluated before any action is drawn A BLOCK-LEVEL gate — distinct from an ActionDef's own per-action requiredPermissions field, a different mechanism the gated fixture in declared-action-ids-7182.test.tsx already exercises. The whole array must be held (.every, not just element 0); with none declared the gate never asks the permission system at all.

One promoted pre-existing file, one new

recordQuickActionsInputs.actionNamesFallback.test.tsx (actionNames) was read end to end before being credited — it was written for objectui#4663 (the registered description over-promised a fallback), not for this direction, but its second case already drives the exact useMetadataItem read this key needs pinned.

requiredPermissions had no candidate anywhere in the repo: the only prior reference to that name on this renderer's surface is an ActionDef's own per-action field (a different mechanism, exercised in declared-action-ids-7182.test.tsx), never the block-level schema.requiredPermissions gate. New file: record-quick-actions.requiredPermissions-gate.test.tsx — a CONTROL row (no key declared → renders regardless of the grant set, perms.can never called), a positive read (one permission, granted → renders; denied → whole bar hidden), and the discriminating row: a partial grant on a two-entry array still gates the bar (.every over the whole array, not element 0), with the all-granted case as that row's own positive control.

Ablation — both mutations proven on disk before being read, restored via git checkout HEAD -- ABS_PATH from a trap … EXIT INT TERM, restoration proven by blob-hash equality against HEAD (not exit code) plus an empty git diff HEAD

# target mutation on-disk proof result
1 the gate's own ledger re-add 'record:quick_actions.actionNames': AWAITING_A_PIN to MEMBER_PIN_EXEMPTIONS without raising MEMBER_PIN_EXEMPTION_CEILING anchor 0→1, blob 2f106ed→2df9d65 3 failed / 195 passed (198 total) — the non-vacuity census, carries no stale member-pin exemption, and the member-pin exemption list only ratchets DOWN (49 > 48) all catch it, same three rows slice 3's ablation named
2 record-quick-actions.tsx (the RENDERER, not the test) required forced to [] regardless of schema.requiredPermissions — the read severed at its source anchor (live read) 1→0, blob ea73102→d665dc4 3 failed / 11 passed across the new pin file + its two reachability neighbours — every row that depends on the gate actually firing reds (deny, partial-grant, objectName-check); the CONTROL/positive-render rows in the same file and both neighbouring files correctly stay green

Non-vacuity: vitest run apps/console/.../registry-inputs-spec-parity.test.ts is exit 0 at rest both before ablation 1 and after its restoration (198/198 both times). The three-file group for ablation 2 is exit 0 / 14 passed both before and after.

Base → origin/main window check

Non-empty both times it was taken. First: 42df92809(base)..561abefd7 — one commit, touching only packages/core/src/adapters/**, packages/fields/src/widgets/FilterConditionField.tsx and their tests/changeset — disjoint from every file this slice reads or edits. Re-checked immediately before opening this PR: 561abefd7..8a388ee76 — one more commit, content/docs/utilities/data-objectstack.mdx only — again disjoint. Neither window touches the gate file, record-quick-actions.tsx, or any file in the record:quick_actions test family.

Collision check against the two other branches named live right now

git diff --name-only against both: zero files in common. claude/kanban-gantt-family-retirement's live (uncommitted) edits are apps/console/src/register-plugins.ts and packages/plugin-gantt/src/index.tsx; claude/issue-8738-fields-warn-route1's are four files under packages/plugin-form/src/. Neither touches the gate file's record:quick_actions section, record-quick-actions.tsx, or any file this PR adds. (A third, later-noticed branch — claude/issue-8738-fields-warn-route1 / draft PR #8859 — touches ONE line of this same gate file: the prose inside the pre-existing MEMBER_PINS['object-form.fields'] entry, ~60 lines above my nearest hunk (:2212 vs my closest hunk starting :2271). No semantic or textual overlap; flagged here in case #8859 lands first and this PR needs a routine merge.)

Ledger-hazard check (scripts/check-doc-example-types.mjs UNGATED_EXAMPLES)

This diff shifts line numbers inside registry-inputs-spec-parity.test.ts (net +54 lines) and adds a new file. Neither is a ledger key: grep -c "registry-inputs-spec-parity" scripts/check-doc-example-types.mjs → 0, same for record-quick-actions.requiredPermissions-gate → 0. Firing control: the identical grep against a path that is a key (AuthGuard.tsx) → 1. No re-keying owed.

Gates

gate exit note
vitest run apps/console/src/__tests__/registry-inputs-spec-parity.test.ts (the gate itself) 0 198 tests, exit captured before any pipe
vitest run the new requiredPermissions pin file alone 0 6/6
vitest run the promoted actionNames file alone 0 3/3
pnpm --filter '@object-ui/console^...' build, '@object-ui/plugin-detail^...' build 0 dependency closures, needed before type-check
pnpm --filter @object-ui/console run type-check 0 tsc --noEmit && tsc -b tsconfig.node.json --force
pnpm --filter @object-ui/plugin-detail run type-check 0 tsc --noEmit && tsc -p tsconfig.test.json
pnpm --filter @object-ui/console run test (full package) 0 98 files / 1132 tests
pnpm --filter @object-ui/plugin-detail run test (full package) 0 155 files / 1415 tests
final sweep: all 8 record:quick_actions-family test files together 0 34/34
node scripts/check-changeset-presence.mjs 0 empty-frontmatter changeset: test-only, releases nothing
node scripts/check-vi-mock-specifiers.mjs / check-vi-mock-inherit.mjs 0 / 0 new file's @object-ui/permissions mock inherits real exports via ...actual
eslint (narrowed to the 2 changed/new files, --no-inline-config) 0 0 errors, 2 no-explicit-any warnings, matching the neighbouring suites' house style (verified: sibling files in the same family carry the identical warning)

Every vitest run above printed RUN v4.1.10 /home/user/objectui-issue-8071-slice4 — this worktree's own root, not a sibling's. Exit codes captured before any pipe (cmd > log 2>&1; EXIT=$?). Repo-wide pnpm lint and CI's own full-farm check:* sweep were not taken locally (CI-owned).

Out-of-scope findings

None filed. No trap-shaped near-miss files were found this slice — the one promoted file pins exactly the key it is credited for, and the new file was written fresh rather than adapted from a near-miss.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Jmxdo7bmeqCQHLSfmLVX9w


Generated by Claude Code

…slice 4)

Converts both remaining `record:quick_actions` MEMBER_PIN_EXEMPTIONS entries
(actionNames, requiredPermissions) into real per-block member pins and
lowers MEMBER_PIN_EXEMPTION_CEILING 50 -> 48 in the same commit.

`actionNames` promotes a pre-existing file
(recordQuickActionsInputs.actionNamesFallback.test.tsx, written for
objectui#4663 but already driving the exact read this key needs) after
reading it end to end; `requiredPermissions` had no existing candidate — the
only prior reference to that name in this renderer's tests is an ActionDef's
own per-action field, a different mechanism from the block-level gate this
key declares — so it is a new file
(record-quick-actions.requiredPermissions-gate.test.tsx).

Refs #8071

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jmxdo7bmeqCQHLSfmLVX9w
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 50 chunks) 3486.0 KB 3512.7 KB
Main entry chunk (gzip) 144.1 KB 350 KB
Entry file index-DysqhgIT.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.69KB 6.21KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 500.00KB 114.54KB
core (index.js) 7.48KB 2.96KB
create-plugin (index.js) 26.68KB 8.94KB
data-objectstack (index.js) 198.39KB 55.29KB
fields (index.js) 246.94KB 62.28KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 6.57KB 2.76KB
i18n (index.js) 3.65KB 1.47KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 26.89KB 9.04KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.84KB 10.94KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 14.81KB 3.63KB
plugin-calendar (index.js) 49.03KB 13.93KB
plugin-charts (index.js) 71.39KB 19.92KB
plugin-chatbot (index.js) 194.54KB 46.34KB
plugin-dashboard (index.js) 131.43KB 34.44KB
plugin-designer (index.js) 215.51KB 44.29KB
plugin-detail (index.js) 252.45KB 65.33KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 134.69KB 33.72KB
plugin-gantt (index.js) 167.16KB 40.99KB
plugin-grid (index.js) 210.86KB 57.28KB
plugin-kanban (index.js) 57.03KB 16.26KB
plugin-list (index.js) 112.73KB 27.69KB
plugin-map (index.js) 20.49KB 6.83KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.42KB 11.92KB
plugin-timeline (index.js) 30.10KB 8.74KB
plugin-tree (index.js) 9.55KB 3.32KB
plugin-view (index.js) 84.54KB 20.84KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 81.07KB 26.86KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 2.32KB 1.24KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.55KB 2.45KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 20.57KB 5.88KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 13.64KB 4.59KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 14.27KB 5.47KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-warren
os-warren marked this pull request as ready for review September 9, 2026 16:26
@os-warren
os-warren added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit 42ddd7f Sep 9, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-8071-member-pins-slice-4 branch September 9, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants