Repository navigation
feat(hr): route time-off approver, add leave types & document expiry banding - #39
Merged
Merged
Conversation
…banding - The "My Pending Approvals" surfaces filter on `approver`, but nothing ever set it on submit (the hook comment claimed it did; the code didn't). Set the approver = employee's manager inside time_off_submitted.flow, which already loads the manager to notify — so approval routing is real without a new flow or an unsafe cross-object hook read. Hook docstring corrected. - Add the statutory leave types real People-Ops teams need: `parental` and `bereavement` (en + zh-CN). - Add an `expiry_status` formula on hr_document (none / expired / expiring_30d / expiring_60d / valid) so the document list can sort and colour-band by a single severity instead of two booleans. - CHARTER: correct the field-sensitivity claim — salary is HR-Admin-only; the "visible to self" half is a documented fork, not shipped. typecheck + objectstack build + format:check clean (4 Objects, 2 Flows). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
approver, but nothing set it on submit (the hook comment claimed it did; the code didn't) — so the tile was always empty.parental/bereavementwere missing.What changed (within caps — 4 objects, 2 flows, 1 approval, 1 sharing)
approver = employee.managerintime_off_submitted.flow(which already resolves the manager to notify) — real routing, no new flow, no unsafe cross-object hook read. Hook docstring corrected.parental+bereavement(en + zh-CN).expiry_statusformula onhr_document(none / expired / expiring_30d / expiring_60d / valid).Verification
typecheck+objectstack build+ repoformat:checkclean. Build: 4 Objects / 2 Flows.🤖 Generated with Claude Code