Repository navigation
feat(expense): reimbursable flag, amount-tiered approval, fix rollup docstrings - #40
Merged
Merged
Conversation
…docstrings - Add `expense_line.reimbursable` (default true) so personal / non-reimbursable items can be flagged and excluded from what finance pays back — the single most consequential gap in a reimbursement tool. - Amount-tiered approval (the charter's headline): manager signs off first; claims ≥ $1,000 escalate to a new `expense_director` second sign-off before final approval; smaller claims approve on the manager alone. Adds the `expense_director` role to the hierarchy. - Add the two most common missing SMB categories — Mileage and Telecom/Phone. - Honesty fix: the report/line docstrings and `total_amount` description claimed a line rollup hook that does not exist and would crash the QuickJS sandbox. Reworded to match the charter (stored header field, client/seed maintained) so forkers don't build the crashing pattern. en + zh-CN updated. typecheck + objectstack build + format:check clean (3 Objects, 4 Roles, 4 Flows). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
total_amountrollup hook that doesn't exist and would crash the QuickJS sandbox — actively misleading forkers.What changed (within the 3-object cap, no nested-write hooks)
expense_line.reimbursable(default true) — flag personal items so the reimbursable total excludes them.expense_directorrole.total_amountdescription now say "stored header field, client/seed-maintained" instead of a nonexistent rollup hook.en + zh-CN updated.
Verification
typecheck+objectstack build+ repoformat:checkclean. Build: 3 Objects / 4 Roles / 4 Flows.🤖 Generated with Claude Code