Repository navigation
i18n(dashboards): complete zh-CN dashboard titles & descriptions - #66
Merged
Merged
Conversation
Dashboard widget strings are keyed by widget id in the per-template translation bundles; en.ts is the source of truth. Several widgets were missing from the bundles entirely (so they fell back to the def's hardcoded English title), and many zh-CN metric cards had a translated title but no translated description — rendering half-Chinese-half-English under a zh-CN UI. Filled every gap so en.ts and zh-CN.ts mirror each dashboard def exactly: - compliance: chart `assessments_by_month` + 4 metric descriptions - content: chart `published_by_month` - contracts: charts `signed_by_month`, `exposure_by_counterparty` - hr: `expired_docs` + charts `headcount_by_dept`, `hires_by_month` - procurement: 6 metric/table descriptions + charts `po_value_by_month`, `top_vendors_by_spend` - project: both dashboards (pmo_overview, pm_workbench) had NO dashboards translation block at all — added complete en + zh-CN blocks (13 widgets, labels, descriptions, the create_project action) - todo: chart `throughput_by_week` Verified: a script cross-checking every dashboard def's widget ids against both bundles now reports zero missing keys. Browser-verified the compliance and PMO dashboards render fully in Chinese (titles, descriptions, chart titles) where they previously showed English. Note: KPI unit captions (Controls / Projects / Total Value) are dataset measure labels, not dashboard widget titles, and are localized through a separate mechanism — out of scope here. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard widget strings are keyed by widget id in the per-template translation bundles (
en.tsis the source of truth). Several widgets were missing from the bundles entirely — so they fell back to the def's hardcoded English title even under the zh-CN UI — and many zh-CN metric cards had a translated title but no translated description, rendering half-Chinese-half-English.Filled every gap so
en.tsandzh-CN.tsmirror each dashboard def exactly. 14 files, +96 lines.assessments_by_month+ 4 metric descriptionspublished_by_monthsigned_by_month,exposure_by_counterpartyexpired_docs+ chartsheadcount_by_dept,hires_by_monthpo_value_by_month,top_vendors_by_spenddashboardsblock at all — added complete en + zh-CN (13 widgets, labels, descriptions,create_projectaction)throughput_by_weekVerification
pnpm typecheck/build/format:checkclean.admin@objectos.ai):Out of scope
KPI unit captions (
Controls/Projects/Total Value) are dataset measure labels, not dashboard widget titles, and are localized through a separate mechanism.🤖 Generated with Claude Code