Fixed order of inserting to multidatabase entity - #79
Open
Hlavos wants to merge 1 commit into
Open
Conversation
Hlavos
changed the title
ZZromanZZ
reviewed
Jun 7, 2018
| ); | ||
| } | ||
|
|
||
|
|
| ); | ||
| } | ||
|
|
||
|
|
Hlavos
changed the title
Hlavos
force-pushed
the
fixInsertToMultiDatabaseEntity
branch
from
June 7, 2018 06:20
219a8e2 to
45df258
Compare
ZZromanZZ
approved these changes
Jun 7, 2018
hAdamm
reviewed
Jun 8, 2018
| $selectedEntity = $this->selectEntity(static::BUSINESS_CONTACTS_REPOSITORY, $entity->primaryPropertyValue()); | ||
| Assert::true($selectedEntity !== FALSE, "Contact entity with ID " . $entity->primaryPropertyValue() . "should be inserted in database"); | ||
|
|
||
|
|
hAdamm
reviewed
Jun 8, 2018
| protected function createBusinessContactEntity($save = true) { | ||
| $entity = Assets\Entities\Contact\BusinessManager::entityFromArray(static::$businessContactData); | ||
|
|
||
| if ($save) { |
Hlavos
force-pushed
the
fixInsertToMultiDatabaseEntity
branch
2 times, most recently
from
June 18, 2018 11:08
c46df5e to
b0ead98
Compare
Contributor
Author
|
edited |
Hlavos
force-pushed
the
fixInsertToMultiDatabaseEntity
branch
from
June 18, 2018 11:11
b0ead98 to
a180b6c
Compare
hAdamm
reviewed
Jun 22, 2018
| } | ||
|
|
||
| $convertedData = []; | ||
| $propertyRepositoryNameOfPrimaryProperty = $entityInformation->informationForPropertyWithName($entityInformation->primaryPropertyName)->repositoryName ?: $entityInformation->repositoryName; |
Collaborator
There was a problem hiding this comment.
maybe better(in naming convention) name for variable would be "PrimaryPropertyRepositoryName" and "PrimaryPropertyStorageName" below
Hlavos
force-pushed
the
fixInsertToMultiDatabaseEntity
branch
from
June 28, 2018 05:32
a180b6c to
c126483
Compare
hAdamm
approved these changes
Jun 28, 2018
Hlavos
force-pushed
the
fixInsertToMultiDatabaseEntity
branch
from
June 28, 2018 06:46
c126483 to
f468b1c
Compare
Hlavos
force-pushed
the
fixInsertToMultiDatabaseEntity
branch
from
June 28, 2018 06:46
f468b1c to
d13d443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.