Skip to content

fix: update filestorage mount#369

Open
obs-gh-alexlew wants to merge 1 commit intomainfrom
alew/update-filestorage-mount-path
Open

fix: update filestorage mount#369
obs-gh-alexlew wants to merge 1 commit intomainfrom
alew/update-filestorage-mount-path

Conversation

@obs-gh-alexlew
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 14, 2025

The following chart updates are necessary:

diff --git a/charts/agent/Chart.yaml b/charts/agent/Chart.yaml
index beb24e4..b398b11 100644
--- a/charts/agent/Chart.yaml
+++ b/charts/agent/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: agent
 description: Chart to install K8s collection stack based on Observe Agent
 type: application
-version: 0.56.0
+version: 0.55.1
 appVersion: "2.3.0"
 dependencies:
   - name: opentelemetry-collector

@obs-gh-alexlew
Copy link
Copy Markdown
Contributor Author

So this one is weird, it seems to work right now anyways? and if I go into the container and ls i get

/ # ls /var/lib
docker         misc           observe-agent  otelcol

but filestorage is only defined in observe-agent.

It almost seems like this shouldn't actually work so I'm kind of confused why the current state is working. The agent also expects the path to be /var/lib/observe-agent/filestorage

@obs-gh-alexlew obs-gh-alexlew force-pushed the alew/update-filestorage-mount-path branch from 7d4b436 to e850297 Compare May 14, 2025 19:06
@obs-gh-mattcotter
Copy link
Copy Markdown
Collaborator

So this one is weird, it seems to work right now anyways? and if I go into the container and ls i get

/ # ls /var/lib
docker         misc           observe-agent  otelcol

but filestorage is only defined in observe-agent.

It almost seems like this shouldn't actually work so I'm kind of confused why the current state is working. The agent also expects the path to be /var/lib/observe-agent/filestorage

How did you end up running into this? Instead of changing the mounts, can we override the dir in the extension configuration:

{{- define "config.extensions.file_storage" -}}
file_storage:
create_directory: true
{{- end -}}

I think that would better preserve backwards compatibility.

@obs-gh-alexlew
Copy link
Copy Markdown
Contributor Author

just forwarded you the customer email

@obs-gh-mattcotter
Copy link
Copy Markdown
Collaborator

I still think changing the bundled config instead of the mount is better for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants