Skip to content

checks: Properly handle lack of OBS version #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RytoEX merged 1 commit into from
Jan 7, 2026
Merged

checks: Properly handle lack of OBS version #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions checks/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ def getOBSVersionLine(lines):
for line in versionLines:
if versionPattern.search(line):
return line
return versionLines[-1]


def getOBSVersionString(lines):
versionLine = getOBSVersionLine(lines)
versionString = versionLine[versionLine.find("OBS"):]
return versionString.split()[1]
if versionLine:
versionString = versionLine[versionLine.find("OBS"):]
return versionString.split()[1]


def checkObsVersion(lines):
Expand Down
2 changes: 1 addition & 1 deletion checks/utils/obsversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class ObsVersion():
None: 3}

def __init__(self, version_string):
self.string = version_string
self.string = str(version_string)
self.parsed = False
self.version = self._VersionNum(self._nan, self._nan, self._nan, 3, 0)
# NaN for false comparisons
Expand Down