added member_force and assoc_force#199
Closed
Humam-Alhusaini wants to merge 1 commit intoocaml-community:masterfrom
Closed
added member_force and assoc_force#199Humam-Alhusaini wants to merge 1 commit intoocaml-community:masterfrom
Humam-Alhusaini wants to merge 1 commit intoocaml-community:masterfrom
Conversation
Member
|
Thanks for the PR. However, I don't think this is the right approach, for a number of reasons:
|
Author
|
You're right. I propose we add |
Member
|
My issue with it is that |
Member
|
(In any case I'll close this PR for now, the discussion on what would be the most reasonable thing to do should go into #198) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the solution to #198. I made a alternative to the member function that raises an error
Missing_Memberif it can't find a member.