Fix FSEvents kind and action decoding#14725
Merged
Merged
Conversation
rgrinberg
force-pushed
the
push-zxoxswmqpsxz
branch
9 times, most recently
from
546228a to
c829c47
Compare
The kind decoder only treated MustScanSubDirs as Dir_and_descendants when ItemIsDir was also set, so subtree invalidations without ItemIsDir were reported as File. The action decoder tested action bits in priority order, so events with multiple action bits set, such as Created+Modified or Removed+Renamed, were reported as a single action instead of Unknown. Decode these cases in the C stubs using the SDK flag constants, and cover the decoder with an inline library test using C-provided flag examples. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-zxoxswmqpsxz
branch
from
c829c47 to
e2cd1ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind decoder only treated MustScanSubDirs as Dir_and_descendants when ItemIsDir was also set, so subtree invalidations without ItemIsDir were reported as File.
The action decoder tested action bits in priority order, so events with multiple action bits set, such as Created+Modified or Removed+Renamed, were reported as a single action instead of Unknown.
Decode these cases in the C stubs using the SDK flag constants, and cover the decoder with an inline library test using C-provided flag examples.