unable_to_parse from libpython_from_pkg_config should be caught in find_library_path#100
Open
Zeta611 wants to merge 1 commit intoocamllibs:mainfrom
Open
unable_to_parse from libpython_from_pkg_config should be caught in find_library_path#100Zeta611 wants to merge 1 commit intoocamllibs:mainfrom
unable_to_parse from libpython_from_pkg_config should be caught in find_library_path#100Zeta611 wants to merge 1 commit intoocamllibs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an issue of not being able to initialize pyml with a trace:
Not really sure why that cannot be parsed, but I believe exns raised by
unable_to_parseinlibpython_from_pkg_configshould be caught infind_library_path, as it is just one of multiple heuristics failing. Moreover, the mapping function already expects something optional withOption.value ~default:[].