Skip to content

Avoid stack overflow on deep mutual recursion under --effects=double-translation #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hhugo wants to merge 2 commits into
base: master
Choose a base branch
from
+447 −123
Draft

Avoid stack overflow on deep mutual recursion under --effects=double-translation #2243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b05de45
Add regression test for stackoverflow with --effects=double-translation
hhugo May 21, 2026
cc4aa71
Compiler: avoid stack overflow on deep mutual recursion under --effec…
hhugo May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
whole-program builds emit reversed `Filename.concat` operands and
silently broke `Filename.temp_file`
* Runtime/wasm: fix string conversion from JS to OCaml (#2230)
* Compiler: avoid JS stack overflow on deep mutually recursive
direct-style calls under `--effects=double-translation`; the trampoline
pass now applies the same `caml_stack_check_depth` / trampoline pattern
used for CPS calls to the direct half of cps_needed mutually recursive
closures


# 6.3.2 (2026-02-15) - Lille
Expand Down
5 changes: 2 additions & 3 deletions compiler/lib/driver.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,9 +718,8 @@ let optimize ~shapes ~profile ~keep_flow_data p =
+> effects_and_exact_calls ~keep_flow_data ~deadcode_sentinel ~shapes profile
+> map_fst5
(match Config.target (), Config.effects () with
| `JavaScript, `Disabled -> Generate_closure.f
| `JavaScript, (`Cps | `Double_translation) | `Wasm, (`Disabled | `Jspi | `Cps)
-> Fun.id
| `JavaScript, (`Disabled | `Double_translation) -> Generate_closure.f
| `JavaScript, `Cps | `Wasm, (`Disabled | `Jspi | `Cps) -> Fun.id
| `JavaScript, `Jspi | `Wasm, `Double_translation -> assert false)
+> map_fst5 deadcode'
in
Expand Down
Loading