Fix deprecated use of posts#66
Open
randycoulman wants to merge 2 commits into
Open
Conversation
The `merged_file_read_opts` method is in the `Jekyll::Utils` module and takes a `site` argument. Note that this is the same fix as in octopress#65; I just wanted to have a functional version of ink for Jekyll 3.
|
I reckon this should be a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the latest version of Ink with Jekyll 3.x, several deprecation warnings are shown. This fixes the deprecation warnings by following the instructions given.
This fix will break compatibility with Jekyll 2. It looks like some of the other gems in the Octopress family are doing that, but if it is necessary to remain compatible with both Jekyll 2 and 3, this fix will need to be re-worked somehow. I'm not sure of the best way to do that, so suggestions are most welcome.
There might be a similar issue in octopress-multilingual, but I haven't used that gem, so can't say for sure.
Fixes #64.