Light curve OGIP read/write#8
Open
ferrigno wants to merge 15 commits into
Open
Conversation
ferrigno
marked this pull request as draft
August 9, 2024 16:32
ferrigno
changed the title
Open
volodymyrss
reviewed
Aug 16, 2024
volodymyrss
reviewed
Aug 16, 2024
| def from_file_name_normal(fn): | ||
|
|
||
| f = fits.open(fn) | ||
| if 'RATE' in f['SPECTRUM'].data.names: |
Member
There was a problem hiding this comment.
Could you please put this change in a different PR so it can be assessed separately?
volodymyrss
reviewed
Aug 16, 2024
volodymyrss
requested changes
Aug 16, 2024
volodymyrss
left a comment
volodymyrss
left a comment
Member
There was a problem hiding this comment.
Thanks, it's a good start!
Co-authored-by: Volodymyr <volodymyrss@users.noreply.github.com>
Correct to_long_string some style
ferrigno
marked this pull request as ready for review
August 20, 2024 16:12
volodymyrss
reviewed
Aug 20, 2024
| lc = ogip.lc.Rate(fn) | ||
| k = fn.rfind('.') | ||
| new_fn = fn[0:k] + '_ogip.' + fn[k + 1:] | ||
| lc.to_fits(new_fn) |
Member
There was a problem hiding this comment.
could you check something basic about the content, at least that it's non-zero, there is total sum, etc?
Member
It may also be Anyway, the interface will have to be unified later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created the module lc.py that reads and writes a light curve in OGIP format.
There is an example of usage in tools.ipynb and in test_lc.py (this one not yet tested)
As I needed to access class properties while reading, I found it more natural to build the object from the filename, rather than from a staticmethod as in spectrum.py
TODO: