docs(api): fix electronics drift in ProductCategory enum - #104
Closed
LKSNDRTMLKV wants to merge 1 commit into
Closed
docs(api): fix electronics drift in ProductCategory enum#104LKSNDRTMLKV wants to merge 1 commit into
LKSNDRTMLKV wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
9 tasks
Member
Author
|
Superseded by #108, which removes the This PR's own note said the field was slated for removal once the pinned core version picked up core's removal of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProductCategoryin the OpenAPI spec is a hand-maintained, cross-sector enum onPassportResponse.productCategory. Its electronics values had drifted: it carriedlaptopandchargerbut was missingtablet,monitor,tv,server, andearphone— incomplete even against what's actually pinned today.dpp-domaincatalog.dpp-domain::Passport.product_category, which the core library has already removed upstream (zero production readers there) — every write path here already sets it tonull, so the field is dead in practice regardless of its listed values, and it's slated for removal from this spec once the pinned core version picks up that change. Not removing it now since that's bundled with the core-pin bump, a separate piece of work.Scoped to the electronics values only — the battery-related entries (
ev_battery/industrial_battery/lmt_battery) weren't part of what was checked this pass and are left untouched.Test plan
just openapi-check(Redocly lint) green