feat(landing,docs): i18n foundation, content de-dup, and de/it/fr/es - #11
Draft
LKSNDRTMLKV wants to merge 5 commits into
Draft
feat(landing,docs): i18n foundation, content de-dup, and de/it/fr/es#11LKSNDRTMLKV wants to merge 5 commits into
LKSNDRTMLKV wants to merge 5 commits into
Conversation
Deploying odal-node-docs with
|
| Latest commit: |
2feb335
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95017244.odal-node-docs.pages.dev |
| Branch Preview URL: | https://feat-landing-i18n-foundation.odal-node-docs.pages.dev |
Deploying odal-node-landing with
|
| Latest commit: |
2feb335
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://690d6b61.odal-node-landing.pages.dev |
| Branch Preview URL: | https://feat-landing-i18n-foundation.odal-node-landing.pages.dev |
LKSNDRTMLKV
changed the title
LKSNDRTMLKV
changed the title
LKSNDRTMLKV
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i18n foundation (routing + typed dictionary, landing)
src/i18n/config.ts) that fails the build if a locale is referenced without matching translations.src/i18n/ui.ts) driving the shared shell (Nav,Footer,Hero's status badge).Base.astrois locale-aware:<html lang>,og:locale(+ alternates),hreflang/x-default.src/i18n/plural.ts— anIntl.PluralRuleshelper, not consumed yet.Content de-duplication (new:
packages/shared-content)dpp-landing+dpp-docs: the data-boundary table and the 5-step signing mechanism were independently retyped in 4+ places and had already drifted (a table header disagreed; the step count disagreed 4 vs 5).summaryfor landing,detailfor docs).index.astroand the docs' "What Odal can and cannot see" page both render from it./trust(previously an unrouted draft) is now live — shrunk to a short statement + link to the canonical docs breakdown instead of a second full copy.de/it/fr/es activated — both sites
fallback+fallbackType: "rewrite". UI chrome dictionary (~20 strings) translated into all 4 new locales. NewLanguageSwitcher.astro(plain links, no JS) in desktop + mobile nav, preserving the current page across a language switch.localesconfig,rootfor English. Starlight ships built-in translated UI strings for German/Italian/French/Spanish (skip-link, search, TOC, etc.) — zero translation work needed for that chrome. Starlight auto-generates its own language-select dropdown in the header, correctly preserving the current page per locale — no custom component needed here.Known gaps (flagged, not blocking)
@astrojs/sitemap'si18nconfig is wired but the generated sitemap only lists the 4 default-locale URLs, not the fallback-generated locale pages. Docs' sitemap does not have this problem — Starlight registers locale routes explicitly, so all 80 locale-prefixed URLs appear correctly. Worth reconciling before real launch.Test plan
pnpm --filter dpp-landing build/check— green, 0 errors;de/it/fr/esfallback pages generated for every routepnpm --filter dpp-docs build/check— green, 0 errors; 102 pages (up from 22), Pagefind indexed 5 languages<html lang>, translated chrome, unchanged English prose on fallback pageshreflang+og:localeon landing;hreflangon docsLanguageSwitcherand Starlight's built-in language-select both preserve the current page path across a locale switch (root →/de/trust→it→/it/trust, not/it/)