Remove unused csv-parse dependency - #867
Merged
Merged
Conversation
The CSV import was removed in efebc46 along with src/util/parseCsv.ts and src/util/importCsv.ts, but the dependency stayed behind. Nothing imports it anymore, and npm ls shows no other package depends on it. Also drops the now-orphaned Jest moduleNameMapper entry that rewrote the browser ESM build to the Node one; no module requests that specifier any longer. The csv-stringify mapping stays, since src/util/writeCsv.ts still uses it for the CSV report export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSV import was removed in efebc46 ("Remove unused user import (server sync endpoint and CSV import)") along with
src/util/parseCsv.tsandsrc/util/importCsv.ts, but the dependency itself stayed behind.Changes
package.json— dropcsv-parse. Nothing in the repo imports it, andnpm ls csv-parseshowed it as a top-level dependency with no other package depending on it.jest.config.js— drop the now-orphanedmoduleNameMapperentry'^csv-parse/browser/esm/sync$': 'csv-parse/sync'. It existed only so Jest (running in Node) could resolve the browser ESM subpath the source used to import. No module requests that specifier anymore, so the mapping never fires.package-lock.json— regenerated; the only change is removal of thecsv-parseentry.csv-stringifyis untouched and stays:src/util/writeCsv.tsstill uses it for the CSV report export, as does its Jest mapping.Verification
npm run typecheck— cleannpm test— 2492/2500 pass. The 8 failures are styled-components snapshot mismatches (sc-*class hashes only, identical DOM structure) in LabeledBox, ImageButton, LabeledComponent, ModalDialog and OptionalLink. They reproduce identically on a clean checkout ofdevelop, so they are pre-existing and unrelated to this change.npm run build --project=lszt— succeeds, confirming no dynamic import that a source grep would missAs a side effect this clears the
csv-parseentry from the outdated-dependency list; it needed a major bump to 7.0.2, which is now moot.