Upgrade jest-dom and webpack-dev-server to next major - #868
Merged
Conversation
Both are dev/test-only and do not ship in the bundle. @testing-library/jest-dom 6 -> 7. Used only by test/testSetup.js and global.d.ts; no deprecated matchers were in use, so no source changes were needed. webpack-dev-server 5 -> 6. webpack.config.js has no devServer block, so there was no configuration to migrate. @firebase/rules-unit-testing is deliberately left on 3.x. It is used only by test/rules/movementWrite.rules.js, which runs via npm run test:rules and is not part of CI, so that upgrade cannot be verified here and is better done separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First batch of the remaining major upgrades, scoped to packages that are dev/test-only and do not ship in the bundle.
Changes
test/testSetup.jsandglobal.d.ts. No deprecated matchers were in use, so no source changes were needed.webpack.config.jshas nodevServerblock, so there was no configuration surface to migrate.Only
package.jsonandpackage-lock.jsonchange.Verification
Against a clean tree, in the same order the CI
buildjob runs:npm run typecheck— cleannpm run build— succeedsnpm run test:app— 2057/2057 pass, 176/176 suites, 9/9 snapshotsFor webpack-dev-server, which none of the above exercises, I booted it directly (
npm start --project=cypress-testing): it compiles, listens on 8080, servesindex.htmlwith the expected cypress-testing title, and serves the emitted bundle (HTTP 200, 12.7 MB). That is the same path CI'scy:testdrives viastart-server-and-test.npm run cy:testitself was not run locally — the Cypress binary download is blocked in my environment — but CI covers it.Deliberately not included
@firebase/rules-unit-testing3 → 5, though it is also dev-only. It is used solely bytest/rules/movementWrite.rules.js, which runs throughnpm run test:rulesand is not part of CI (buildandbuild_functionsare the only checks). Verifying it needs the Firebase emulator, and the Firebase CLI is neither installed nor a project dependency here. Upgrading it in this PR would mean landing it with neither CI nor local coverage, so it should go in its own change where someone can runnpm run test:rulesonce locally.