Update OdinDataController to send configuration directly in put#448
Open
LuisFSegalla wants to merge 3 commits into
Open
Update OdinDataController to send configuration directly in put#448LuisFSegalla wants to merge 3 commits into
LuisFSegalla wants to merge 3 commits into
Conversation
Contributor
|
We need to check if changing the acquisition ID loses the previously set values, or if they get copied over to the new ID. If not, there could be special handling of this like the meta adapter does, until acquisitions are overhauled. |
Contributor
Author
|
When I tested the changes changing the acquisition ID does not cause the previously set values to change. I could keep the same chunk configuration through different acquisition IDs. |
LuisFSegalla
force-pushed
the
update-put-method
branch
from
March 27, 2026 10:58
2a3f90e to
236ba1d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 32.43% 32.53% +0.09%
==========================================
Files 94 94
Lines 7568 7546 -22
Branches 667 667
==========================================
Hits 2455 2455
+ Misses 4939 4917 -22
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LuisFSegalla
force-pushed
the
update-put-method
branch
from
March 27, 2026 12:16
e5079f1 to
831b75a
Compare
This is only for local development and will be removed once a new release fixes the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
putmethod inodin_data_controller.pyto stop arrays from being split into individual value put and tried simplifying logic by executing commands andconfigrequest in the same method