Skip to content

Update OdinDataController to send configuration directly in put#448

Open
LuisFSegalla wants to merge 3 commits into
masterfrom
update-put-method
Open

Update OdinDataController to send configuration directly in put#448
LuisFSegalla wants to merge 3 commits into
masterfrom
update-put-method

Conversation

@LuisFSegalla

Copy link
Copy Markdown
Contributor

Updated put method in odin_data_controller.py to stop arrays from being split into individual value put and tried simplifying logic by executing commands and config request in the same method

@GDYendell GDYendell changed the title Change put method to allow for sending arrays Update OdinDataController to send configuration directly in put Mar 6, 2026
@GDYendell

GDYendell commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

We need to check if changing the acquisition ID loses the previously set values, or if they get copied over to the new ID. If not, there could be special handling of this like the meta adapter does, until acquisitions are overhauled.

@LuisFSegalla

Copy link
Copy Markdown
Contributor Author

When I tested the changes changing the acquisition ID does not cause the previously set values to change. I could keep the same chunk configuration through different acquisition IDs.

@codecov

codecov Bot commented Mar 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.53%. Comparing base (90d80bc) to head (3a24b19).

Files with missing lines Patch % Lines
...thon/src/odin_data/control/odin_data_controller.py 0.00% 18 Missing ⚠️
cpp/frameProcessor/src/FileWriterPlugin.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   32.43%   32.53%   +0.09%     
==========================================
  Files          94       94              
  Lines        7568     7546      -22     
  Branches      667      667              
==========================================
  Hits         2455     2455              
+ Misses       4939     4917      -22     
  Partials      174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Ohisemega and others added 2 commits March 28, 2026 12:20
This is only for local development and will be removed once a new
release fixes the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update OdinDataAdapter to send config requests to clients without caching

3 participants