Added python tests to improve coverage.

[ajgdls]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.44%. Comparing base (9a92832) to head (4c4e964).

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #480       +/-   ##
===========================================
+ Coverage   33.66%   47.44%   +13.77%     
===========================================
  Files          95       95               
  Lines        7690     7685        -5     
  Branches      672      672               
===========================================
+ Hits         2589     3646     +1057     
+ Misses       4907     3845     -1062     
  Partials      194      194               

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ajgdls]

Coverage for Python tests pushed above 80%

[JamesOHeaDLS]

Thanks Alan, this all looks good and runs nicely.

I have made comments for 2 very minor points.

A discussion point for another time - at the moment we seem to have a fairly even mix of unittest.TestCase style tests and pytest style tests. This is most apparent with the assertEqual(a, b) vs assert a == b lines. I think it would make sense to use a consistent approach across all tests. pytest would be my preference. I can raise this at the next core developers meeting.

[ajgdls]

Thanks Alan, this all looks good and runs nicely.

I have made comments for 2 very minor points.

A discussion point for another time - at the moment we seem to have a fairly even mix of unittest.TestCase style tests and pytest style tests. This is most apparent with the assertEqual(a, b) vs assert a == b lines. I think it would make sense to use a consistent approach across all tests. pytest would be my preference. I can raise this at the next core developers meeting.

Thanks @JamesOHeaDLS yeah I did debate a bit around this and changed a couple already. I could convert to pytest pretty easily for some of them, so I'll see if it's easy to just switch them all over.

[JamesOHeaDLS]

Thanks @ajgdls - looks good and all tests run succesfully

I've just two suggestions for fixture tweaks

[JamesOHeaDLS]

Thanks Alan - looks good and all tests run and pass