Fix FrameReceiverController "Stop Reactor" Bug#525
Open
Ohisemega wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #525 +/- ##
=======================================
Coverage 33.66% 33.67%
=======================================
Files 95 95
Lines 7690 7689 -1
Branches 672 672
=======================================
Hits 2589 2589
+ Misses 4907 4906 -1
Partials 194 194 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Delete duplicate reactor_.stop() command in FrameReceiverController::handle_frame_release_channel(). Change procedure for stopping reactor_ in FrameReceiverController to utilize an IpcReactorTimmer. Fix #524
timcnicholls
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reactor_.stop()command inFrameReceiverController::handle_frame_release_channel().reactor_inFrameReceiverControllerto utilise anIpcReactorTimer.Fixes reactor of FrameReceiverController called twice when expected frame received and released #524