Replace Metadata Hash With a 'Latest Version Timestamp'#529
Open
Ohisemega wants to merge 10 commits into
Open
Conversation
Ohisemega
added
enhancement
Ohisemega
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
===========================================
+ Coverage 33.66% 47.84% +14.17%
===========================================
Files 95 95
Lines 7690 7673 -17
Branches 672 670 -2
===========================================
+ Hits 2589 3671 +1082
+ Misses 4907 3810 -1097
+ Partials 194 192 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Implement time-stamping feature in plugins. Update time-stamp at locations of structural change to the plugin. Report the latest time-stamp in requestConfiguration(). Remove 'key-hashing' related implementation and tests. Fixes #526
Ohisemega
changed the title
Ohisemega
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Call the update_*_metadata_ts() methods from the parent class - FrameProcessorPlugin's constructor. Add public methods to return the raw timestamp value of the plugin. Remove redundant set_param() calls and extra loops.
ajgdls
requested changes
Jul 14, 2026
Add unit test to validate that the metadata timestamp for FileWriter and ParameterAdjustment are updated When the triggering configuration is passed to it.
ajgdls
requested changes
Jul 15, 2026
ajgdls
approved these changes
Jul 16, 2026
ajgdls
requested changes
Jul 16, 2026
Ohisemega
force-pushed
the
Implement_timestamped_metadata
branch
from
July 16, 2026 15:22
58cc67f to
7b93502
Compare
ajgdls
reviewed
Jul 16, 2026
timcnicholls
approved these changes
Jul 17, 2026
Add seperate keys for the timestamp of status and config. Rename local variables.
JamesOHeaDLS
approved these changes
Jul 17, 2026
JamesOHeaDLS
left a comment
JamesOHeaDLS
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks @Ohisemega
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a time-stamping feature in plugins.
requestConfiguration()andprovideStatus().Fixes #526