Add pre-commit Hook to reject commits that fail the clang-format check!#534
Add pre-commit Hook to reject commits that fail the clang-format check!#534Ohisemega wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #534 +/- ##
===========================================
+ Coverage 33.66% 47.46% +13.80%
===========================================
Files 95 95
Lines 7690 7685 -5
Branches 672 672
===========================================
+ Hits 2589 3648 +1059
+ Misses 4907 3843 -1064
Partials 194 194 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Andrew Duller created a script to ensure Git hooks were setup correctly. It is mentioned in README.git-hooks but it is not obvious to new developers that this should be read before working with the repo. I propose that instead of adding to postStartCommand we update the main README with instructions for initial developer setup cc: @Ohisemega @ajgdls |
2de94b0 to
434ba9e
Compare
I have added the script Andy wrote as a |
Update the readme with developer instructions.
|
Hi @JamesOHeaDLS, could this PR please be reviewed for approval once more? Given it's a minor tooling improvement. |
JamesOHeaDLS
left a comment
There was a problem hiding this comment.
Thanks @Ohisemega I can confirm that the config gets set on rebuild of the devcontainer
Add 'postStartCommand' to copy the pre-commit script to ./git/hooks directory at container startup.
Fixes #533