Skip to content

[FIX] charts: pass onDataSetHover to chart config#8801

Open
hokolomopo wants to merge 1 commit into
saas-19.3from
saas-19.3-chart-dataset-hover-fix-adrm
Open

[FIX] charts: pass onDataSetHover to chart config#8801
hokolomopo wants to merge 1 commit into
saas-19.3from
saas-19.3-chart-dataset-hover-fix-adrm

Conversation

@hokolomopo
Copy link
Copy Markdown
Contributor

Description

The handler onDataSetHover of the chart data source was never actually passed to the chartJS config.

Also the event handlers were not correctly typed.

Task: 6233312

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

The handler `onDataSetHover` of the chart data source was never
actually passed to the chartJS config.

Also the event handlers were not correctly typed.

Task: 6233312
@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 28, 2026

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants