[IMP] carousel: pick chart type when adding chart to carousel#8826
Open
hokolomopo wants to merge 2 commits into
Open
[IMP] carousel: pick chart type when adding chart to carousel#8826hokolomopo wants to merge 2 commits into
hokolomopo wants to merge 2 commits into
Conversation
Collaborator
|
|
This commit extracts the chart type picker popover to a separate component so it can be re-used separately from the `select`. Task: 6263706
The button "Add chart" in the carousel panel would always create a bar chart. It'd be better to allow the user which chart they want to create, and to directly open the chart side panel. Task: 6263706
hokolomopo
force-pushed
the
master-carousel-chart-insertion-adrm
branch
from
db85c01 to
a6a92bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
[IMP] carousel: pick chart type when adding chart to carousel
The button "Add chart" in the carousel panel would always create a
bar chart. It'd be better to allow the user which chart they want to
create, and to directly open the chart side panel.
[REF] chart: extract chart type picker popover
This commit extracts the chart type picker popover to a separate
component so it can be re-used separately from the
select.Task: 6263706
review checklist