[IMP] Model: plugins only see the grid selection#8835
Open
rrahir wants to merge 2 commits into
Open
Conversation
When the grid selection is inactive, whether through the composer or a selectionInput, the user intension is to modify a specific definition or cell content but not to alter an object present in the grid. They act as a sort of "modal" that allows to select ranges in the grid and nothing else. As such, the table resizer should not be active when the grid selection isn't eiter. Task: 6268168
Collaborator
|
|
Except from the grid selection, the other actors of the SelectionProcessor only live in the stores, the plugins don't know about them. Since the plugins sometimes call the processor, it means they always assume that they will impact the grid selection. With this revision, every call to the selection processor coming from the plugins will ensure that the grid selection is active. Task: 6268168
rrahir
force-pushed
the
master-grid-selection-features-rar
branch
from
e9358d6 to
732fd9f
Compare
Collaborator
Author
|
robodoo rebase-ff |
Collaborator
|
Merge method set to rebase and fast-forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Except from the grid selection, the other actors of the
SelectionProcessor only live in the stores, the plugins don't know about
them.
Since the plugins sometimes call the processor, it means they always
assume that they will impact the grid selection.
With this revision, every call to the selection processor coming from
the plugins will ensure that the grid selection is active.
Task: 6268168
review checklist