[FIX] pivot: prevent drag & drop in pivot side panel#8842
Open
hokolomopo wants to merge 1 commit into
Open
Conversation
In the pivot side panel, a pointerdown event on a button/input/select of an dimension should not trigger the drag & drop of the dimension. The way we were handling that was all over the place. Some elements in the children had a `pointerdown.stop`, the `<select>` were handled directly before starting a drag & drop, and some elements didn't prevent a d&d where they should have. We will now handle everything in the layout configurator. Before starting the d&d, we check that the event target is not an input/select, or has a class that indicates that it is interactive and should not trigger a d&d. The solution is not the greatest, as we might forget some classes, but it beats having the children having to stop pointer events because of their parents. Task: 6268403
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
In the pivot side panel, a pointerdown event on a button/input/select of an dimension should not trigger the drag & drop of the dimension.
The way we were handling that was all over the place. Some elements in the children had a
pointerdown.stop, the<select>were handled directly before starting a drag & drop, and some elements didn't prevent a d&d where they should have.We will now handle everything in the layout configurator. Before starting the d&d, we check that the event target is not an input/select, or has a class that indicates that it is interactive and should not trigger a d&d.
The solution is not the greatest, as we might forget some classes, but it beats having the children having to stop pointer events because of their parents.
Task: 6268403
review checklist