[IMP] runbot: update test tags version bounds on manual parse#1399
Open
d-fence wants to merge 1 commit into
Open
[IMP] runbot: update test tags version bounds on manual parse#1399d-fence wants to merge 1 commit into
d-fence wants to merge 1 commit into
Conversation
Xavier-Do
reviewed
May 8, 2026
| if build_error_content.error_id and build_error_content.error_id.test_tags: | ||
| errors_to_update |= build_error_content.error_id | ||
| for error in errors_to_update: | ||
| error._onchange_test_tags() |
Contributor
There was a problem hiding this comment.
The onchange is not safe in this case, because it could actually make the range of covered version slower.
Lets imagine I scan in 19.0, the disable from 18.0 to master
If I have a n error in master and scan it, it will change the min from 18 to 19, renabling the test in 18.0.
Note that the same problem could occur when modifying a test tag
It would be safer to either have a custom logic there, or take the current tags_min_version_id and tags_max_version_id in the onchange.
When parsing build errors, it may happen that the error appears in a version lower or higher than the current test tags bounds. With this commit, when a build error log is manually parsed (via the web interface or the server action), the min and max version bounds of the test tags are updated accordingly to include the new builds versions.
d-fence
force-pushed
the
19.0-autotags-update-moc
branch
from
7ea8a8f to
eee5c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing build errors, it may happen that the error appears in a version lower or higher than the current test tags bounds.
With this commit, when a build error log is manually parsed (via the web interface or the server action), the min and max version bounds of the test tags are updated accordingly to include the new builds versions.