training-tupan

[TudorCalinCS]

No description provided.

[robodoo]

[plha-odoo]

Good job for the general quality and readability of the code !
A few comments :

• We try to always leave an empty line at the end of every file.
  If you are using vscode there is an option to automatically do it which is called Insert Final Newline.
• for the commit message and title we try to always follow these guidelines https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html
• a few styling modifications for which I made local reviews (spaces arround an '=' except when used to define a parameter, spaces after but not before a ':', etc)

[plha-odoo]

Good job for these chapters, for the applying the correct styling almost everywhere and for udpating the code after the first review.
Just a few comments :

• don't forget to use the proper git commit title convention event if it's an udpate, in which case your title should start with [FIX]
• two styling for which I did local reviews

[TudorCalinCS]

Performed a rebase to align commit history with git guidelines.

[plha-odoo]

good job on applying the previous reviews and on adapting the previous git commit titles !
I left a few reviews in the code but mostly nitpicking

[plha-odoo]

good job on applying the previous reviews and on adapting the previous git commit titles !
I left a few reviews in the code but mostly nitpicking

[plha-odoo]

good job ! just a single styling improvement but it's nitpicking

[plha-odoo]

your last line contains a space so it's not considered as an extra line by the runbot

Suggested change

[plha-odoo]

Suggested change

	self.env["account.move"].create(
	[
	{
	"partner_id": record.buyer_id.id,
	"move_type": "out_invoice",
	"invoice_line_ids": [
	Command.create(
	{"name": record.name, "quantity": 1, "price_unit": record.selling_price * 0.06}
	),
	Command.create({"name": "Administrative fees", "quantity": 1, "price_unit": 100}),
	],
	}
	]
	)
	self.env["account.move"].create({
	"partner_id": record.buyer_id.id,
	"move_type": "out_invoice",
	"invoice_line_ids": [
	Command.create(
	{"name": record.name, "quantity": 1, "price_unit": record.selling_price * 0.06}
	),
	Command.create({"name": "Administrative fees", "quantity": 1, "price_unit": 100}),
	],
	})