[ADD] Design an Estate module

[THDES-odoo]

No description provided.

[robodoo]

[artn-odoo]

Nice job so far !
All comments are small styling nitpicks but your code won't pass the styling tests if they are not fixed.
We also try to always add an empty line at the end of every file. If using vscode, the Insert Final Newline option can be activated to do it automatically every time you save your file.

[artn-odoo]

Nice one, as usual just a few nitpicks

[artn-odoo]

If the line is split because it's too long, every parameter should be on it's own line

Suggested change

	date_availability = fields.Date('Availability Date', copy=False,
	default=fields.Date.add(fields.Date.today(), months=3))
	date_availability = fields.Date(
	'Availability Date',
	copy=False,
	default=fields.Date.add(fields.Date.today(), months=3)
	)

And the closing bracket's indentation should match the opening one

[artn-odoo]

Try to match the opening bracket's indentation

Suggested change

	garden_orientation = fields.Selection(
	string='Garden Orientation',
	selection=[
	('north', 'North'), ('south', 'South'),
	('east', 'East'), ('west', 'West')
	])
	garden_orientation = fields.Selection(
	string='Garden Orientation',
	selection=[
	('north', 'North'),
	('south', 'South'),
	('east', 'East'),
	('west', 'West')
	]
	)

Also, it would be better to have each selection proposition on it's own line

[artn-odoo]

Same as above

Suggested change

	selection=[
	('new', 'New'), ('offer_received', 'Offer Received'),
	('offer_accepted', 'Offer Accepted'),
	('sold', 'Sold'), ('cancelled', 'Cancelled') ],
	default='new',
	required=True
	)
	selection=[
	('new', 'New'),
	('offer_received', 'Offer Received'),
	('offer_accepted', 'Offer Accepted'),
	('sold', 'Sold'),
	('cancelled', 'Cancelled')
	],
	default='new',
	required=True
	)

[artn-odoo]

Looks almost good to me !

[artn-odoo]

The newlines seem kind of random, you could just remove them IMO

Suggested change

	date_availability = fields.Date(
	'Availability Date',
	copy=False,
	default=fields.Date.add(fields.Date.today(), months=3)
	)
	expected_price = fields.Float('Expected Price', required=True)
	selling_price = fields.Float('Selling Price', readonly=True, copy=False)
	date_availability = fields.Date(
	'Availability Date',
	copy=False,
	default=fields.Date.add(fields.Date.today(), months=3)
	)
	expected_price = fields.Float('Expected Price', required=True)
	selling_price = fields.Float('Selling Price', readonly=True, copy=False)

[artn-odoo]

In this case, I feel like this is a bit overkill, it could be done in one line in the constrains, or you could break the line before the and if it gets too long

Suggested change

	@api.constrains('state', 'expected_price', 'selling_price')
	def _check_prices(self):
	for record in self:
	if record.state == 'offer_accepted' and self._offer_too_low():
	raise ValidationError('The selling price must be at least 90% of the selling price')
	def _offer_too_low(self):
	self.ensure_one()
	return float_compare(
	self.selling_price,
	self.expected_price * 0.9,
	precision_digits=2
	) == -1
	@api.constrains('state', 'expected_price', 'selling_price')
	def _check_prices(self):
	for record in self:
	if record.state == 'offer_accepted' and float_compare(self.selling_price, self.expected_price * 0.9, precision_digits=2) == -1:
	raise ValidationError('The selling price must be at least 90% of the selling price')

That was a nice try though, and it could have been the right solution had the use case been a bit different !

[artn-odoo]

Same here the newlines seem kind of random

Suggested change

	validity = fields.Integer(string='Validity (days)', default=7)
	date_deadline = fields.Date(
	string='Deadline',
	compute='_compute_deadline',
	inverse="_compute_validity"
	)
	property_id = fields.Many2one('estate.property', string='Property', required=True)
	partner_id = fields.Many2one('res.partner', string='Partner', required=True)
	validity = fields.Integer(string='Validity (days)', default=7)
	date_deadline = fields.Date(
	string='Deadline',
	compute='_compute_deadline',
	inverse="_compute_validity"
	)
	property_id = fields.Many2one('estate.property', string='Property', required=True)
	partner_id = fields.Many2one('res.partner', string='Partner', required=True)

[artn-odoo]

Looking good !

[artn-odoo]

Looks kinda weird IMO, removing the lines should be fine

Suggested change

	record.state = 'sold'
	record.state = 'sold'

[artn-odoo]

Same here

Suggested change

	record.state = 'canceled'
	record.state = 'canceled'

[artn-odoo]

Suggested change

	self.state = 'accepted'
	self.state = 'accepted'

Lots of unneeded newlines, won't point them all out but I feel like this is a bit much